From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96D8C433E2 for ; Thu, 17 Sep 2020 14:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DD8C206DC for ; Thu, 17 Sep 2020 14:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbgIQO5e convert rfc822-to-8bit (ORCPT ); Thu, 17 Sep 2020 10:57:34 -0400 Received: from mailout09.rmx.de ([94.199.88.74]:42461 "EHLO mailout09.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727387AbgIQOv2 (ORCPT ); Thu, 17 Sep 2020 10:51:28 -0400 Received: from kdin01.retarus.com (kdin01.dmz1.retloc [172.19.17.48]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout09.rmx.de (Postfix) with ESMTPS id 4Bsf9R3fS6zbhsy; Thu, 17 Sep 2020 16:14:35 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin01.retarus.com (Postfix) with ESMTPS id 4Bsf925k8gz2xcC; Thu, 17 Sep 2020 16:14:14 +0200 (CEST) Received: from n95hx1g2.localnet (192.168.54.36) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Sep 2020 16:13:51 +0200 From: Christian Eggers To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= CC: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , , , NXP Linux Team , Pengutronix Kernel Team , , Subject: Re: [PATCH 1/3] i2c: imx: Fix reset of I2SR_IAL flag Date: Thu, 17 Sep 2020 16:13:50 +0200 Message-ID: <16013235.tl8pWZfNaG@n95hx1g2> Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG In-Reply-To: <20200917140235.igfq2hq63f4qqhrr@pengutronix.de> References: <20200917122029.11121-1-ceggers@arri.de> <20200917122029.11121-2-ceggers@arri.de> <20200917140235.igfq2hq63f4qqhrr@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Originating-IP: [192.168.54.36] X-RMX-ID: 20200917-161416-4Bsf925k8gz2xcC-0@kdin01 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Uwe, On Thursday, 17 September 2020, 16:02:35 CEST, Uwe Kleine-König wrote: > Hello, > > On Thu, Sep 17, 2020 at 02:20:27PM +0200, Christian Eggers wrote: > ... > > /* check for arbitration lost */ > > if (temp & I2SR_IAL) { > > temp &= ~I2SR_IAL; > > + temp |= (i2c_imx->hwdata->i2sr_clr_opcode & I2SR_IAL); > > imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2SR); > > return -EAGAIN; > ... > This looks strange. First the flag is cleared and then it is (in some > cases) set again. i.MX controllers require writing a 0 to clear these bits. Vybrid controllers need writing a 1 for the same. > If I2SR_IIF is set in temp you ack this irq without handling it. (Which > might happen if atomic is set and irqs are off?!) This patch is only about using the correct processor specific value for acknowledging an IRQ... But I think that returning EAGAIN (which aborts the transfer) should be handling enough. At the next transfer, the controller will be set back to master mode. > I see this idiom is used in a few more places in the driver already, I > didn't check but these might have the same problem maybe? Best regards Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D96C433E2 for ; Thu, 17 Sep 2020 14:16:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBA1720838 for ; Thu, 17 Sep 2020 14:16:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hc9i9ANj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBA1720838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arri.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bLjzDSplJhk5UiqSQtiuQQ7AtC1wF29RimEnnU0Guck=; b=Hc9i9ANjBCb/KRKpz69/1Ne+u yJsKuPlMpHcwJePfm6Y40ALA9nCzJb+MqN9H4mwt7jy3Qsju7qcRGIiLUBsBbAx90rae2kDc6yfDP zCzMWLCk1M+h2spDWXzdpp5yXIbJ1eEdJ8m4qtiP9P9ofTlvTB8JxIy7YNGW1sVIQ5BIt0o8d/k33 U4+3qgXmS2OJduvRqOoM9OA6VW5odi3DhSJOu0rriH9esH65Zu/5wmcsmzzp1wB5k/nkqOCq1aTJt WOlJzIifhjm88+s4JLKMByi8cpKDdR9peOm4ceJOJ5Ox+8UTQZHSHP2xNS7CH5ANS9kl2Ir/gexBP jaB4oz4Ng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIugO-0001Ky-Lg; Thu, 17 Sep 2020 14:14:44 +0000 Received: from mailout09.rmx.de ([94.199.88.74]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIugJ-0001Jg-Dd for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 14:14:43 +0000 Received: from kdin01.retarus.com (kdin01.dmz1.retloc [172.19.17.48]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout09.rmx.de (Postfix) with ESMTPS id 4Bsf9R3fS6zbhsy; Thu, 17 Sep 2020 16:14:35 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin01.retarus.com (Postfix) with ESMTPS id 4Bsf925k8gz2xcC; Thu, 17 Sep 2020 16:14:14 +0200 (CEST) Received: from n95hx1g2.localnet (192.168.54.36) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 17 Sep 2020 16:13:51 +0200 From: Christian Eggers To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Subject: Re: [PATCH 1/3] i2c: imx: Fix reset of I2SR_IAL flag Date: Thu, 17 Sep 2020 16:13:50 +0200 Message-ID: <16013235.tl8pWZfNaG@n95hx1g2> Organization: Arnold & Richter Cine Technik GmbH & Co. Betriebs KG In-Reply-To: <20200917140235.igfq2hq63f4qqhrr@pengutronix.de> References: <20200917122029.11121-1-ceggers@arri.de> <20200917122029.11121-2-ceggers@arri.de> <20200917140235.igfq2hq63f4qqhrr@pengutronix.de> MIME-Version: 1.0 X-Originating-IP: [192.168.54.36] X-RMX-ID: 20200917-161416-4Bsf925k8gz2xcC-0@kdin01 X-RMX-SOURCE: 217.111.95.66 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_101439_576772_9F78C023 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksij Rempel , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Uwe, On Thursday, 17 September 2020, 16:02:35 CEST, Uwe Kleine-K=F6nig wrote: > Hello, > = > On Thu, Sep 17, 2020 at 02:20:27PM +0200, Christian Eggers wrote: > ... > > /* check for arbitration lost */ > > if (temp & I2SR_IAL) { > > temp &=3D ~I2SR_IAL; > > + temp |=3D (i2c_imx->hwdata->i2sr_clr_opcode & I2SR_IAL); > > imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2SR); > > return -EAGAIN; > ... > This looks strange. First the flag is cleared and then it is (in some > cases) set again. i.MX controllers require writing a 0 to clear these bits. Vybrid controllers need writing a 1 for the same. > If I2SR_IIF is set in temp you ack this irq without handling it. (Which > might happen if atomic is set and irqs are off?!) This patch is only about using the correct processor specific value for = acknowledging an IRQ... But I think that returning EAGAIN (which aborts the transfer) should be handling enough. At the next transfer, the controller w= ill be set back to master mode. > I see this idiom is used in a few more places in the driver already, I > didn't check but these might have the same problem maybe? Best regards Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel