* [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-30 2:51 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2020-09-30 2:51 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel, jeffrey.l.hugo, sam, rnayak,
zhengbin13, harigovi, linux-arm-msm, dri-devel, freedreno
It is redundant to do irqsave and irqrestore in hardIRQ context.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index b17ac6c..b2fb5c3 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-09-30 2:51 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2020-09-30 2:51 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel, jeffrey.l.hugo, sam, rnayak,
zhengbin13, harigovi, linux-arm-msm, dri-devel, freedreno
It is redundant to do irqsave and irqrestore in hardIRQ context.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index b17ac6c..b2fb5c3 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/dsi: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2021-02-07 6:17 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2021-02-07 6:17 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel; +Cc: linux-arm-msm, dri-devel
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index ab281cb..8ba204d 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/dsi: replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2021-02-07 6:17 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2021-02-07 6:17 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel; +Cc: linux-arm-msm, dri-devel
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index ab281cb..8ba204d 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ
2020-12-04 1:23 [PATCH drm/hisilicon 0/3] support reading resolutions from EDID Tian Tao
@ 2020-12-04 1:23 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2020-12-04 1:23 UTC (permalink / raw)
To: airlied, daniel, tzimmermann, kraxel, alexander.deucher, tglx,
dri-devel, xinliang.liu, linux-kernel
It is redundant to do irqsave and irqrestore in hardIRQ context.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index b17ac6c..b2fb5c3 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ
@ 2020-12-04 1:23 ` Tian Tao
0 siblings, 0 replies; 6+ messages in thread
From: Tian Tao @ 2020-12-04 1:23 UTC (permalink / raw)
To: airlied, daniel, tzimmermann, kraxel, alexander.deucher, tglx,
dri-devel, xinliang.liu, linux-kernel
It is redundant to do irqsave and irqrestore in hardIRQ context.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index b17ac6c..b2fb5c3 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -1555,15 +1555,14 @@ static irqreturn_t dsi_host_irq(int irq, void *ptr)
{
struct msm_dsi_host *msm_host = ptr;
u32 isr;
- unsigned long flags;
if (!msm_host->ctrl_base)
return IRQ_HANDLED;
- spin_lock_irqsave(&msm_host->intr_lock, flags);
+ spin_lock(&msm_host->intr_lock);
isr = dsi_read(msm_host, REG_DSI_INTR_CTRL);
dsi_write(msm_host, REG_DSI_INTR_CTRL, isr);
- spin_unlock_irqrestore(&msm_host->intr_lock, flags);
+ spin_unlock(&msm_host->intr_lock);
DBG("isr=0x%x, id=%d", isr, msm_host->id);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-07 8:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 2:51 [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-09-30 2:51 ` Tian Tao
2020-12-04 1:23 [PATCH drm/hisilicon 0/3] support reading resolutions from EDID Tian Tao
2020-12-04 1:23 ` [PATCH] drm/msm/dsi: Replace spin_lock_irqsave by spin_lock in hard IRQ Tian Tao
2020-12-04 1:23 ` Tian Tao
2021-02-07 6:17 [PATCH] drm/msm/dsi: replace " Tian Tao
2021-02-07 6:17 ` Tian Tao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.