From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] xfs: a few fixes and cleanups to GETFSMAP
Date: Thu, 01 Oct 2020 21:49:18 -0700 [thread overview]
Message-ID: <160161415855.1967459.13623226657245838117.stgit@magnolia> (raw)
Hi all,
This quick series cleans up a few warts in the XFS GETFSMAP ioctl
implementation. The first patch prevents an integer overflow when
counting the mappings. The second patch improves performance of the
ioctl by formatting reverse mappings to an in-kernel buffer and then
copying the entire buffer to userspace (instead of copying the records
one by one). That eliminates an indirect call and a lot of overhead
from copying things to userspace, which is a bit expensive.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This is an extraordinary way to destroy everything. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=getfsmap-cleanups-5.10
---
fs/xfs/xfs_fsmap.c | 38 +++++++++++++++++------------
fs/xfs/xfs_fsmap.h | 6 +----
fs/xfs/xfs_ioctl.c | 69 ++++++++++++++++++++++------------------------------
3 files changed, 53 insertions(+), 60 deletions(-)
next reply other threads:[~2020-10-02 4:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 4:49 Darrick J. Wong [this message]
2020-10-02 4:49 ` [PATCH 1/2] xfs: limit entries returned when counting fsmap records Darrick J. Wong
2020-10-02 7:06 ` Christoph Hellwig
2020-10-02 8:51 ` Chandan Babu R
2020-10-02 4:49 ` [PATCH 2/2] xfs: streamline xfs_getfsmap performance Darrick J. Wong
2020-10-02 7:15 ` Christoph Hellwig
2020-10-02 17:58 ` Darrick J. Wong
2020-10-05 6:30 ` Christoph Hellwig
2020-10-05 17:02 ` Darrick J. Wong
2020-10-02 8:52 ` Chandan Babu R
2020-10-04 19:14 ` [PATCH v1.2 2/2] xfs: fix deadlock and " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160161415855.1967459.13623226657245838117.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.