From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC17C4727F for ; Fri, 2 Oct 2020 08:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C3DE2074B for ; Fri, 2 Oct 2020 08:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601626829; bh=nNjOEAmXenV7kByqYczREIpR5MzajAytxxtfDgky/b0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=k1Dc/NfMmpd5oIkghoX7DjPd84JZiuJ5JvlW05pPWlJ325YxcaqM7SmU6R0hn4FqT VNj7aBWI2ZcKzFktIpR9DYMp8u9p0/ecCV/HpNgFSMDY9XFH1yvqTq8GBzvCkbp5bO iS+FYCdRiJp6+v+MXqd1XOSjkN1NR2tLZo6Bei1k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387600AbgJBIUQ (ORCPT ); Fri, 2 Oct 2020 04:20:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:57028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726517AbgJBIUO (ORCPT ); Fri, 2 Oct 2020 04:20:14 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8A8D207F7; Fri, 2 Oct 2020 08:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601626813; bh=nNjOEAmXenV7kByqYczREIpR5MzajAytxxtfDgky/b0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+DPBeGHoTMPbUfdsfcn7j4RvdBEomDvKcjosTJ+vKLcyQhu7cOr4fDs13Xb3twX0 ef8G6rIVcTBjwe9ZbdeTRiZGSbtCUVZHFoxMPS70c6oDW7oIcZPew1JqlQEy/h/0cs adHpIMHvPuanQP0MBym48WngG9cb+s868hTpj8LM= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOGIW-00GeG7-2n; Fri, 02 Oct 2020 09:20:12 +0100 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, David Brazdil , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dennis Zhou , Catalin Marinas , Tejun Heo , kernel-team@android.com, Christoph Lameter Subject: Re: [PATCH] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault Date: Fri, 2 Oct 2020 09:20:01 +0100 Message-Id: <160162675379.1930042.14641926420921373250.b4-ty@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200930131801.16889-1-will@kernel.org> References: <20200930131801.16889-1-will@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, dbrazdil@google.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dennis@kernel.org, catalin.marinas@arm.com, tj@kernel.org, kernel-team@android.com, cl@linux.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2020 14:18:01 +0100, Will Deacon wrote: > Alex pointed out that we don't pass a level hint to the TLBI instruction > when handling a stage-2 permission fault, even though the walker does > at some point have the level information in its hands. > > Rework stage2_update_leaf_attrs() so that it can optionally return the > level of the updated pte to its caller, which can in turn be used to > provide the correct TLBI level hint. Applied to next, thanks! [1/1] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault commit: b259d137e91d80bf92eac453ffab179eb7941ede Cheers, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85E8C4727F for ; Fri, 2 Oct 2020 08:20:20 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5E9DE2072E for ; Fri, 2 Oct 2020 08:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q+DPBeGH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E9DE2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 10BDE4B4DC; Fri, 2 Oct 2020 04:20:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pj1-xaVc2bPA; Fri, 2 Oct 2020 04:20:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D31544B5FE; Fri, 2 Oct 2020 04:20:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6C7164B4DC for ; Fri, 2 Oct 2020 04:20:16 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oap0TCGnRJjy for ; Fri, 2 Oct 2020 04:20:15 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B63FB4B5E3 for ; Fri, 2 Oct 2020 04:20:14 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8A8D207F7; Fri, 2 Oct 2020 08:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601626813; bh=nNjOEAmXenV7kByqYczREIpR5MzajAytxxtfDgky/b0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+DPBeGHoTMPbUfdsfcn7j4RvdBEomDvKcjosTJ+vKLcyQhu7cOr4fDs13Xb3twX0 ef8G6rIVcTBjwe9ZbdeTRiZGSbtCUVZHFoxMPS70c6oDW7oIcZPew1JqlQEy/h/0cs adHpIMHvPuanQP0MBym48WngG9cb+s868hTpj8LM= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOGIW-00GeG7-2n; Fri, 02 Oct 2020 09:20:12 +0100 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, David Brazdil , Will Deacon Subject: Re: [PATCH] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault Date: Fri, 2 Oct 2020 09:20:01 +0100 Message-Id: <160162675379.1930042.14641926420921373250.b4-ty@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200930131801.16889-1-will@kernel.org> References: <20200930131801.16889-1-will@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, dbrazdil@google.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dennis@kernel.org, catalin.marinas@arm.com, tj@kernel.org, kernel-team@android.com, cl@linux.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Catalin Marinas , linux-kernel@vger.kernel.org, Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 30 Sep 2020 14:18:01 +0100, Will Deacon wrote: > Alex pointed out that we don't pass a level hint to the TLBI instruction > when handling a stage-2 permission fault, even though the walker does > at some point have the level information in its hands. > > Rework stage2_update_leaf_attrs() so that it can optionally return the > level of the updated pte to its caller, which can in turn be used to > provide the correct TLBI level hint. Applied to next, thanks! [1/1] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault commit: b259d137e91d80bf92eac453ffab179eb7941ede Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763ABC4727F for ; Fri, 2 Oct 2020 08:21:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27BC0206A2 for ; Fri, 2 Oct 2020 08:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gON799U8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q+DPBeGH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27BC0206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HTphs5l4YOKPlECihUyFxAoVj8ta5UpjK0C0inrsJ7k=; b=gON799U8jnx+GPk6mIipyQfif eHu/EJMPFYLeMVgqBSEUNc4+TDNFXNgr1ID9xSLOlDHOl3s7GvadxTT7QbqdDuGAgeSTI0emA5SJ0 Q5DvmuYrUexeB/08U0xP3naqOxqsiYT9Me2/Cg+qIYMA8fq0wgA8PwAOVIrTeS7qpvgAc1cjCU2bE lRye2qtREurHaSF3JpnjPS6QNj+7lhoe4yjHBEcPgYeqz1Y7fr/Y0or298xU+S2aP//GKnxar7r5/ Lv08GwBVoH3UROx2lOM9pQoLxTFrI/hlq1PLOICDiOcqGZgsu9VO1cNoxirHMu0OxGD7bbWf3B9Hn ZP6h052fQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGIj-0004QQ-6L; Fri, 02 Oct 2020 08:20:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGIY-0004Le-HB for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 08:20:16 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8A8D207F7; Fri, 2 Oct 2020 08:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601626813; bh=nNjOEAmXenV7kByqYczREIpR5MzajAytxxtfDgky/b0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+DPBeGHoTMPbUfdsfcn7j4RvdBEomDvKcjosTJ+vKLcyQhu7cOr4fDs13Xb3twX0 ef8G6rIVcTBjwe9ZbdeTRiZGSbtCUVZHFoxMPS70c6oDW7oIcZPew1JqlQEy/h/0cs adHpIMHvPuanQP0MBym48WngG9cb+s868hTpj8LM= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOGIW-00GeG7-2n; Fri, 02 Oct 2020 09:20:12 +0100 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, David Brazdil , Will Deacon Subject: Re: [PATCH] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault Date: Fri, 2 Oct 2020 09:20:01 +0100 Message-Id: <160162675379.1930042.14641926420921373250.b4-ty@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200930131801.16889-1-will@kernel.org> References: <20200930131801.16889-1-will@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, dbrazdil@google.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dennis@kernel.org, catalin.marinas@arm.com, tj@kernel.org, kernel-team@android.com, cl@linux.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_042014_692353_2BC594CF X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-kernel@vger.kernel.org, Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 30 Sep 2020 14:18:01 +0100, Will Deacon wrote: > Alex pointed out that we don't pass a level hint to the TLBI instruction > when handling a stage-2 permission fault, even though the walker does > at some point have the level information in its hands. > > Rework stage2_update_leaf_attrs() so that it can optionally return the > level of the updated pte to its caller, which can in turn be used to > provide the correct TLBI level hint. Applied to next, thanks! [1/1] KVM: arm64: Pass level hint to TLBI during stage-2 permission fault commit: b259d137e91d80bf92eac453ffab179eb7941ede Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel