From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB4AC47095 for ; Tue, 6 Oct 2020 04:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71EF6208C3 for ; Tue, 6 Oct 2020 04:32:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="GzLo7leM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbgJFEcM (ORCPT ); Tue, 6 Oct 2020 00:32:12 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:21965 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725874AbgJFEcL (ORCPT ); Tue, 6 Oct 2020 00:32:11 -0400 X-Greylist: delayed 305 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Oct 2020 00:32:10 EDT X-UUID: fe44045d466046c2aa4dbc44ea12eb0b-20201006 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+pxD8I7KLNWeEZpM4bXar+ZxPMehQGOOhOWN3s3N3JU=; b=GzLo7leMLv2dfhFmyPQRF6WxaRUhzbUAB4qUkyU1Pzmy+n14iptRg2Iv7tHKv7/EYySuOuMjSu/HiePs8kA1CaxalvYlSeqiu9BDT/gT6lqBa/ZH0lsrHfJtQ/SbRirnONWccZOE0jZWRrstLecyZJsozmiqnhwXsmMsdumCvz8=; X-UUID: fe44045d466046c2aa4dbc44ea12eb0b-20201006 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 538139451; Tue, 06 Oct 2020 12:26:57 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 12:26:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 12:26:54 +0800 Message-ID: <1601958415.26323.25.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski CC: Joerg Roedel , Matthias Brugger , Rob Herring , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , , , , , , , , Nicolas Boichat , , , , Greg Kroah-Hartman , Date: Tue, 6 Oct 2020 12:26:55 +0800 In-Reply-To: <20201002110709.GC6888@pi3> References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9A9DF6700EE416CA650EB803451E471F73CB22B3E312AC0B29EBEE4AED21DE852000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDIwLTEwLTAyIGF0IDEzOjA3ICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdy b3RlOg0KPiBPbiBXZWQsIFNlcCAzMCwgMjAyMCBhdCAwMzowNjoyNFBNICswODAwLCBZb25nIFd1 IHdyb3RlOg0KPiA+IENvbnZlcnQgTWVkaWFUZWsgSU9NTVUgdG8gRFQgc2NoZW1hLg0KPiA+IA0K PiA+IFNpZ25lZC1vZmYtYnk6IFlvbmcgV3UgPHlvbmcud3VAbWVkaWF0ZWsuY29tPg0KPiA+IC0t LQ0KPiA+ICAuLi4vYmluZGluZ3MvaW9tbXUvbWVkaWF0ZWssaW9tbXUudHh0ICAgICAgICAgfCAx MDMgLS0tLS0tLS0tLS0tDQo+ID4gIC4uLi9iaW5kaW5ncy9pb21tdS9tZWRpYXRlayxpb21tdS55 YW1sICAgICAgICB8IDE1NCArKysrKysrKysrKysrKysrKysNCj4gPiAgMiBmaWxlcyBjaGFuZ2Vk LCAxNTQgaW5zZXJ0aW9ucygrKSwgMTAzIGRlbGV0aW9ucygtKQ0KPiA+ICBkZWxldGUgbW9kZSAx MDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2lvbW11L21lZGlhdGVrLGlv bW11LnR4dA0KPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL2lvbW11L21lZGlhdGVrLGlvbW11LnlhbWwNCj4gPiANCg0KWy4uLl0NCg0KPiA+ ICtwcm9wZXJ0aWVzOg0KPiA+ICsgIGNvbXBhdGlibGU6DQo+ID4gKyAgICBvbmVPZjoNCj4gPiAr ICAgICAgLSBlbnVtOg0KPiA+ICsgICAgICAgICAgLSBtZWRpYXRlayxtdDI3MDEtbTR1ICMgbXQy NzAxIGdlbmVyYXRpb24gb25lIEhXDQo+ID4gKyAgICAgICAgICAtIG1lZGlhdGVrLG10MjcxMi1t NHUgIyBtdDI3MTIgZ2VuZXJhdGlvbiB0d28gSFcNCj4gPiArICAgICAgICAgIC0gbWVkaWF0ZWss bXQ2Nzc5LW00dSAjIG10Njc3OSBnZW5lcmF0aW9uIHR3byBIVw0KPiA+ICsgICAgICAgICAgLSBt ZWRpYXRlayxtdDgxNzMtbTR1ICMgbXQ4MTczIGdlbmVyYXRpb24gdHdvIEhXDQo+ID4gKyAgICAg ICAgICAtIG1lZGlhdGVrLG10ODE4My1tNHUgIyBtdDgxODMgZ2VuZXJhdGlvbiB0d28gSFcNCj4g PiArDQo+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IG10NzYyMyBnZW5lcmF0aW9uIG9uZSBIVw0K PiA+ICsgICAgICAgIGl0ZW1zOg0KPiA+ICsgICAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ3 NjIzLW00dQ0KPiA+ICsgICAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQyNzAxLW00dQ0KPiA+ ICsNCj4gPiArICByZWc6DQo+ID4gKyAgICBtYXhJdGVtczogMQ0KPiA+ICsNCj4gPiArICBpbnRl cnJ1cHRzOg0KPiA+ICsgICAgbWF4SXRlbXM6IDENCj4gPiArDQo+ID4gKyAgY2xvY2tzOg0KPiA+ ICsgICAgZGVzY3JpcHRpb246IHwNCj4gPiArICAgICAgYmNsayBpcyBvcHRpb25hbC4gaGVyZSBp cyB0aGUgbGlzdCB3aGljaCByZXF1aXJlIHRoaXMgYmNsazoNCj4gPiArICAgICAgbXQyNzAxLCBt dDI3MTIsIG10NzYyMyBhbmQgbXQ4MTczLg0KPiANCj4gU2ltaWxhcmx5IHRvIG15IGNvbW1lbnQg aW4gb3RoZXIgcGF0Y2gsIHRoaXMgc2hvdWxkIGJlIHBhcnQgb2Ygc2NoZW1hDQo+IHdpdGhpbiAn aWYtdGhlbicuDQoNClRoYW5rcyBmb3IgdGhlIHJldmlldy4NCg0KSSB3aWxsIGNoYW5nZSBsaWtl IHRoaXM6DQoNCj09PT09PT09PT09PT0NCiAgY2xvY2tzOg0KICAgIGl0ZW1zOg0KICAgICAgLSBk ZXNjcmlwdGlvbjogYmNsayBpcyB0aGUgYmxvY2sgY2xvY2suDQoNCiAgY2xvY2stbmFtZXM6DQog ICAgaXRlbXM6DQogICAgICAtIGNvbnN0OiBiY2xrDQoNCnJlcXVpcmVkOg0KICAtIGNvbXBhdGli bGUNCiAgLSByZWcNCiAgLSBpbnRlcnJ1cHRzDQogIC0gbWVkaWF0ZWssbGFyYnMNCiAgLSAnI2lv bW11LWNlbGxzJw0KaWY6DQogIHByb3BlcnRpZXM6DQogICAgY29tcGF0aWJsZToNCiAgICAgIGNv bnRhaW5zOg0KICAgICAgICBlbnVtOg0KICAgICAgICAgIC0gbWVkaWF0ZWssbXQyNzAxLW00dQ0K ICAgICAgICAgIC0gbWVkaWF0ZWssbXQyNzEyLW00dQ0KICAgICAgICAgIC0gbWVkaWF0ZWssbXQ4 MTczLW00dQ0KDQp0aGVuOg0KIHJlcXVpcmVkOg0KICAgLSBjbG9ja3MNCj09PT09PT09PT09PT09 DQoNCklmIHRoaXMgaXMgbm90IHJpZ2h0LCBwbGVhc2UgdGVsbCBtZS4NCihkdF9iaW5kaW5nX2No ZWNrIGlzIG9rLikNCg0KPiANCj4gQmVzdCByZWdhcmRzLA0KPiBLcnp5c3p0b2YNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7D3C4727E for ; Tue, 6 Oct 2020 04:27:10 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9D41208B6 for ; Tue, 6 Oct 2020 04:27:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="GzLo7leM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9D41208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 37E55865D0; Tue, 6 Oct 2020 04:27:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e527igD2lXtZ; Tue, 6 Oct 2020 04:27:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 87472864FB; Tue, 6 Oct 2020 04:27:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 72025C016F; Tue, 6 Oct 2020 04:27:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B623CC0051 for ; Tue, 6 Oct 2020 04:27:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 55BB1204C5 for ; Tue, 6 Oct 2020 04:27:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3gswkhSy+3si for ; Tue, 6 Oct 2020 04:27:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw01.mediatek.com (unknown [1.203.163.78]) by silver.osuosl.org (Postfix) with ESMTP id DC95420133 for ; Tue, 6 Oct 2020 04:27:03 +0000 (UTC) X-UUID: fe44045d466046c2aa4dbc44ea12eb0b-20201006 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+pxD8I7KLNWeEZpM4bXar+ZxPMehQGOOhOWN3s3N3JU=; b=GzLo7leMLv2dfhFmyPQRF6WxaRUhzbUAB4qUkyU1Pzmy+n14iptRg2Iv7tHKv7/EYySuOuMjSu/HiePs8kA1CaxalvYlSeqiu9BDT/gT6lqBa/ZH0lsrHfJtQ/SbRirnONWccZOE0jZWRrstLecyZJsozmiqnhwXsmMsdumCvz8=; X-UUID: fe44045d466046c2aa4dbc44ea12eb0b-20201006 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 538139451; Tue, 06 Oct 2020 12:26:57 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 12:26:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 12:26:54 +0800 Message-ID: <1601958415.26323.25.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Tue, 6 Oct 2020 12:26:55 +0800 In-Reply-To: <20201002110709.GC6888@pi3> References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9A9DF6700EE416CA650EB803451E471F73CB22B3E312AC0B29EBEE4AED21DE852000:8 X-MTK: N Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > Convert MediaTek IOMMU to DT schema. > > > > Signed-off-by: Yong Wu > > --- > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > 2 files changed, 154 insertions(+), 103 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > [...] > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > + > > + - description: mt7623 generation one HW > > + items: > > + - const: mediatek,mt7623-m4u > > + - const: mediatek,mt2701-m4u > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + description: | > > + bclk is optional. here is the list which require this bclk: > > + mt2701, mt2712, mt7623 and mt8173. > > Similarly to my comment in other patch, this should be part of schema > within 'if-then'. Thanks for the review. I will change like this: ============= clocks: items: - description: bclk is the block clock. clock-names: items: - const: bclk required: - compatible - reg - interrupts - mediatek,larbs - '#iommu-cells' if: properties: compatible: contains: enum: - mediatek,mt2701-m4u - mediatek,mt2712-m4u - mediatek,mt8173-m4u then: required: - clocks ============== If this is not right, please tell me. (dt_binding_check is ok.) > > Best regards, > Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BEFC41604 for ; Tue, 6 Oct 2020 04:27:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 922F420757 for ; Tue, 6 Oct 2020 04:27:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qitfaarW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LlgiulCH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 922F420757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sRCXmtHhB30Ri4mmVT93sjGXVGNxz4bNfWYUoczqWRg=; b=qitfaarWPYHJi7jObb+xBsCpG VID4m7i2GTwHSP8NXZ0U9TKFjyowqPdoBVxzL7Yw/CLe5QsqEb/T62tGxixNof9H+d6zTJhFdJ6Rc qstzC9I15y/zSHzE8BK+z2ebJ9xORJUXlYngnrw2jdwacv3ng4KyP+E0PLucro196TT6GTDIPhIkO DtmzYpCozNnmdPx3A4L6nragLGKgbRgI2lSifOkfhT9DbUxMfTV4aPRylsli8hV0cOiEl5YSr+CWx uRoqFtUYNXTcImmFQ8s36GogR0meK3fITo/F2iYrQVyRntfb3yr5YCiCBYWckq7pfNFoRwzPK3TSe mnqtivAxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPeZI-0006Cm-9F; Tue, 06 Oct 2020 04:27:16 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPeZB-000698-Uu; Tue, 06 Oct 2020 04:27:12 +0000 X-UUID: f4156641e2af46b49d24e11a9f66c186-20201005 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+pxD8I7KLNWeEZpM4bXar+ZxPMehQGOOhOWN3s3N3JU=; b=LlgiulCH1vbtlqMqPKGj7lJV74EHGO8snpFZzj3MRv3r4yE3EjpwYuBsjimEZCZyDYVruQNOrG5ZO9ptSqm2ktrIDpIK2Duk9SUh45UuYdR14L8w10VROUMxGcMcm+QXgc58zJndND/q7NGk66clOiDBmXpJEcbrPWTPPvjlMuI=; X-UUID: f4156641e2af46b49d24e11a9f66c186-20201005 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 322720852; Mon, 05 Oct 2020 20:27:00 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 5 Oct 2020 21:26:59 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 12:26:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 12:26:54 +0800 Message-ID: <1601958415.26323.25.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Tue, 6 Oct 2020 12:26:55 +0800 In-Reply-To: <20201002110709.GC6888@pi3> References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9A9DF6700EE416CA650EB803451E471F73CB22B3E312AC0B29EBEE4AED21DE852000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_002710_155289_1032EE99 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > Convert MediaTek IOMMU to DT schema. > > > > Signed-off-by: Yong Wu > > --- > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > 2 files changed, 154 insertions(+), 103 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > [...] > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > + > > + - description: mt7623 generation one HW > > + items: > > + - const: mediatek,mt7623-m4u > > + - const: mediatek,mt2701-m4u > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + description: | > > + bclk is optional. here is the list which require this bclk: > > + mt2701, mt2712, mt7623 and mt8173. > > Similarly to my comment in other patch, this should be part of schema > within 'if-then'. Thanks for the review. I will change like this: ============= clocks: items: - description: bclk is the block clock. clock-names: items: - const: bclk required: - compatible - reg - interrupts - mediatek,larbs - '#iommu-cells' if: properties: compatible: contains: enum: - mediatek,mt2701-m4u - mediatek,mt2712-m4u - mediatek,mt8173-m4u then: required: - clocks ============== If this is not right, please tell me. (dt_binding_check is ok.) > > Best regards, > Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75ABBC4363D for ; Tue, 6 Oct 2020 04:28:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E23A420757 for ; Tue, 6 Oct 2020 04:28:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CrUf4riu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LlgiulCH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E23A420757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=foePM25h/Cs0ZdsJevldRaTeBekrrSnaNiYQzo1zUl4=; b=CrUf4riuSJOcRTnEa0kxHZqEn 2MwXuFPsvV4lV1rCXSoiaC8xkcDm8bnA9sZdmAzaPXcxw6Jt9XQP7HKU37pz7fTrzjQvOmMsimIdl beIKVJ4AVkmbqzHvoLIMaapEFFXjFhCjEYtrVkqsr+6KNO0zu2/Z/WDOuR6wQX1vx5LC8R2HGBpMI BVATG8MZH2wsSSZ3tJWVbx/aQiVWOe6Fg6seQJJb4LW0Vti3957dBk1xIN7Psk6JmR3Vk/Fr20Yse VdlUryvyUQxRgkMiags2atkLOZNs8hS13Opc03ThV1n5uV6Jvb+vrHeqgclxgULGuw6QuaRoI/a2k f1I4gKpTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPeZK-0006D0-7d; Tue, 06 Oct 2020 04:27:18 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPeZB-000698-Uu; Tue, 06 Oct 2020 04:27:12 +0000 X-UUID: f4156641e2af46b49d24e11a9f66c186-20201005 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+pxD8I7KLNWeEZpM4bXar+ZxPMehQGOOhOWN3s3N3JU=; b=LlgiulCH1vbtlqMqPKGj7lJV74EHGO8snpFZzj3MRv3r4yE3EjpwYuBsjimEZCZyDYVruQNOrG5ZO9ptSqm2ktrIDpIK2Duk9SUh45UuYdR14L8w10VROUMxGcMcm+QXgc58zJndND/q7NGk66clOiDBmXpJEcbrPWTPPvjlMuI=; X-UUID: f4156641e2af46b49d24e11a9f66c186-20201005 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 322720852; Mon, 05 Oct 2020 20:27:00 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 5 Oct 2020 21:26:59 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 12:26:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 12:26:54 +0800 Message-ID: <1601958415.26323.25.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Tue, 6 Oct 2020 12:26:55 +0800 In-Reply-To: <20201002110709.GC6888@pi3> References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9A9DF6700EE416CA650EB803451E471F73CB22B3E312AC0B29EBEE4AED21DE852000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_002710_155289_1032EE99 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > Convert MediaTek IOMMU to DT schema. > > > > Signed-off-by: Yong Wu > > --- > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > 2 files changed, 154 insertions(+), 103 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > [...] > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > + > > + - description: mt7623 generation one HW > > + items: > > + - const: mediatek,mt7623-m4u > > + - const: mediatek,mt2701-m4u > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + description: | > > + bclk is optional. here is the list which require this bclk: > > + mt2701, mt2712, mt7623 and mt8173. > > Similarly to my comment in other patch, this should be part of schema > within 'if-then'. Thanks for the review. I will change like this: ============= clocks: items: - description: bclk is the block clock. clock-names: items: - const: bclk required: - compatible - reg - interrupts - mediatek,larbs - '#iommu-cells' if: properties: compatible: contains: enum: - mediatek,mt2701-m4u - mediatek,mt2712-m4u - mediatek,mt8173-m4u then: required: - clocks ============== If this is not right, please tell me. (dt_binding_check is ok.) > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel