From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BF9C433E7 for ; Sat, 10 Oct 2020 06:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 517E320731 for ; Sat, 10 Oct 2020 06:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WYYJhsYI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgJJGTD (ORCPT ); Sat, 10 Oct 2020 02:19:03 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:29630 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725802AbgJJGS0 (ORCPT ); Sat, 10 Oct 2020 02:18:26 -0400 X-UUID: 4cbb3f6428a4490d8d4c9f57e03b12d2-20201010 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=61F5Tl8G56sPcS7KsAwbgCO83qs6Yq3c4B1Tn8qYWKc=; b=WYYJhsYIVVxypsuFEv489DssqpGZY5q/ViiyFiYFzpF397nRMxQgaEUuRvC+/vwCJXGrZaFwGTSJWLr2ZqvslF4YhXOBkJtao72m7S9nFXkCW8MQY1JgNflC7xcG3uWRPDtZpkGWe3BHq6VHH3PzU6wHVzGwQrymNnSUaOwNjKo=; X-UUID: 4cbb3f6428a4490d8d4c9f57e03b12d2-20201010 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1548687958; Sat, 10 Oct 2020 14:18:11 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Oct 2020 14:18:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 10 Oct 2020 14:18:08 +0800 Message-ID: <1602310691.26323.39.camel@mhfsdcap03> Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to DT schema From: Yong Wu To: Krzysztof Kozlowski CC: Joerg Roedel , Matthias Brugger , Rob Herring , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , , , , "linux-kernel@vger.kernel.org" , , , , Nicolas Boichat , , , , Greg Kroah-Hartman , Date: Sat, 10 Oct 2020 14:18:11 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-3-yong.wu@mediatek.com> <20201002110831.GD6888@pi3> <1601958428.26323.26.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 2F5B50D45BFEE5DEAF980977B4B60D0C1CC732DEAB64F85D93BF6AB7D84D9C0F2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIwLTEwLTA2IGF0IDA5OjE1ICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdy b3RlOg0KPiBPbiBUdWUsIDYgT2N0IDIwMjAgYXQgMDY6MjcsIFlvbmcgV3UgPHlvbmcud3VAbWVk aWF0ZWsuY29tPiB3cm90ZToNCj4gPg0KPiA+IE9uIEZyaSwgMjAyMC0xMC0wMiBhdCAxMzowOCAr MDIwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToNCj4gPiA+IE9uIFdlZCwgU2VwIDMwLCAy MDIwIGF0IDAzOjA2OjI1UE0gKzA4MDAsIFlvbmcgV3Ugd3JvdGU6DQo+ID4gPiA+IENvbnZlcnQg TWVkaWFUZWsgU01JIHRvIERUIHNjaGVtYS4NCj4gPiA+ID4NCj4gPiA+ID4gU2lnbmVkLW9mZi1i eTogWW9uZyBXdSA8eW9uZy53dUBtZWRpYXRlay5jb20+DQo+ID4gPiA+IC0tLQ0KPiA+ID4gPiAg Li4uL21lZGlhdGVrLHNtaS1jb21tb24udHh0ICAgICAgICAgICAgICAgICAgIHwgIDQ5IC0tLS0t LS0tLQ0KPiA+ID4gPiAgLi4uL21lZGlhdGVrLHNtaS1jb21tb24ueWFtbCAgICAgICAgICAgICAg ICAgIHwgMTAwICsrKysrKysrKysrKysrKysrKw0KPiA+ID4gPiAgLi4uL21lbW9yeS1jb250cm9s bGVycy9tZWRpYXRlayxzbWktbGFyYi50eHQgIHwgIDQ5IC0tLS0tLS0tLQ0KPiA+ID4gPiAgLi4u L21lbW9yeS1jb250cm9sbGVycy9tZWRpYXRlayxzbWktbGFyYi55YW1sIHwgIDkxICsrKysrKysr KysrKysrKysNCj4gPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTkxIGluc2VydGlvbnMoKyksIDk4 IGRlbGV0aW9ucygtKQ0KPiA+ID4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbWVkaWF0ZWssc21pLWNvbW1v bi50eHQNCj4gPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL21lZGlhdGVrLHNtaS1jb21tb24ueWFtbA0K PiA+ID4gPiAgZGVsZXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9tZW1vcnktY29udHJvbGxlcnMvbWVkaWF0ZWssc21pLWxhcmIudHh0DQo+ID4gPiA+ICBj cmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lbW9y eS1jb250cm9sbGVycy9tZWRpYXRlayxzbWktbGFyYi55YW1sDQo+ID4gLi4uDQo+ID4gPiA+ICtw cm9wZXJ0aWVzOg0KPiA+ID4gPiArICBjb21wYXRpYmxlOg0KPiA+ID4gPiArICAgIG9uZU9mOg0K PiA+ID4gPiArICAgICAgLSBlbnVtOg0KPiA+ID4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQy NzAxLXNtaS1jb21tb24NCj4gPiA+ID4gKyAgICAgICAgICAtIG1lZGlhdGVrLG10MjcxMi1zbWkt Y29tbW9uDQo+ID4gPiA+ICsgICAgICAgICAgLSBtZWRpYXRlayxtdDY3Nzktc21pLWNvbW1vbg0K PiA+ID4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQ4MTczLXNtaS1jb21tb24NCj4gPiA+ID4g KyAgICAgICAgICAtIG1lZGlhdGVrLG10ODE4My1zbWktY29tbW9uDQo+ID4gPiA+ICsNCj4gPiA+ ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IGZvciBtdDc2MjMNCj4gPiA+ID4gKyAgICAgICAgaXRl bXM6DQo+ID4gPiA+ICsgICAgICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ3NjIzLXNtaS1jb21t b24NCj4gPiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDI3MDEtc21pLWNvbW1v bg0KPiA+ID4gPiArDQo+ID4gPiA+ICsgIHJlZzoNCj4gPiA+ID4gKyAgICBtYXhJdGVtczogMQ0K PiA+ID4gPiArDQo+ID4gPiA+ICsgIGNsb2NrczoNCj4gPiA+ID4gKyAgICBkZXNjcmlwdGlvbjog fA0KPiA+ID4gPiArICAgICAgYXBiIGFuZCBzbWkgYXJlIG1hbmRhdG9yeS4gdGhlIGFzeW5jIGlz IG9ubHkgZm9yIGdlbmVyYXRpb24gMSBzbWkgSFcuDQo+ID4gPiA+ICsgICAgICBnYWxzKGdsb2Jh bCBhc3luYyBsb2NhbCBzeW5jKSBhbHNvIGlzIG9wdGlvbmFsLCBoZXJlIGlzIHRoZSBsaXN0IHdo aWNoDQo+ID4gPiA+ICsgICAgICByZXF1aXJlIGdhbHM6IG10Njc3OSBhbmQgbXQ4MTgzLg0KPiA+ ID4gPiArICAgIG1pbkl0ZW1zOiAyDQo+ID4gPiA+ICsgICAgbWF4SXRlbXM6IDQNCj4gPiA+ID4g KyAgICBpdGVtczoNCj4gPiA+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IGFwYiBpcyBBZHZhbmNl ZCBQZXJpcGhlcmFsIEJ1cyBjbG9jaywgSXQncyB0aGUgY2xvY2sgZm9yDQo+ID4gPiA+ICsgICAg ICAgICAgc2V0dGluZyB0aGUgcmVnaXN0ZXIuDQo+ID4gPiA+ICsgICAgICAtIGRlc2NyaXB0aW9u OiBzbWkgaXMgdGhlIGNsb2NrIGZvciB0cmFuc2ZlciBkYXRhIGFuZCBjb21tYW5kLg0KPiA+ID4g PiArICAgICAgLSBkZXNjcmlwdGlvbjogYXN5bmMgaXMgYXN5bmNocm9ub3VzIGNsb2NrLCBpdCBo ZWxwIHRyYW5zZm9ybSB0aGUgc21pIGNsb2NrDQo+ID4gPiA+ICsgICAgICAgICAgaW50byB0aGUg ZW1pIGNsb2NrIGRvbWFpbi4NCj4gPiA+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IGdhbHMwIGlz IHRoZSBwYXRoMCBjbG9jayBvZiBnYWxzLg0KPiA+ID4gPiArICAgICAgLSBkZXNjcmlwdGlvbjog Z2FsczEgaXMgdGhlIHBhdGgxIGNsb2NrIG9mIGdhbHMuDQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAg Y2xvY2stbmFtZXM6DQo+ID4gPiA+ICsgICAgb25lT2Y6DQo+ID4gPiA+ICsgICAgICAtIGl0ZW1z Og0KPiA+ID4gPiArICAgICAgICAgIC0gY29uc3Q6IGFwYg0KPiA+ID4gPiArICAgICAgICAgIC0g Y29uc3Q6IHNtaQ0KPiA+ID4gPiArICAgICAgLSBpdGVtczoNCj4gPiA+ID4gKyAgICAgICAgICAt IGNvbnN0OiBhcGINCj4gPiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBzbWkNCj4gPiA+ID4gKyAg ICAgICAgICAtIGNvbnN0OiBhc3luYw0KPiA+ID4gPiArICAgICAgLSBpdGVtczoNCj4gPiA+ID4g KyAgICAgICAgICAtIGNvbnN0OiBhcGINCj4gPiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBzbWkN Cj4gPiA+ID4gKyAgICAgICAgICAtIGNvbnN0OiBnYWxzMA0KPiA+ID4gPiArICAgICAgICAgIC0g Y29uc3Q6IGdhbHMxDQo+ID4gPg0KPiA+ID4gU2ltaWxhcmx5IHRvIG15IGNvbW1lbnQgdG8gb3Ro ZXIgcHJvcGVydGllcywgdGhpcyByZXF1aXJlbWVudCBwZXINCj4gPiA+IGNvbXBhdGlibGUgc2hv dWxkIGJlIHBhcnQgb2YgdGhlIHNjaGVtYSB3aXRoaW4gJ2lmLXRoZW4nLg0KPiA+DQo+ID4gSSdt IG5vdCBzbyBmYW1pbGlhciB3aXRoIHRoaXMgZm9ybWF0LiBEbyB0aGlzIGhhcyAiaWYtdGhlbi0n ZWxzZQ0KPiA+IGlmJy10aGVuLWVsc2UiPw0KPiANCj4gVGhlc2UgYXJlIG11dHVhbGx5IGV4Y2x1 c2l2ZSBjb25kaXRpb25zLCBzbyB5b3UgY2FuIHNraXAgZWxzZToNCj4gIC0gaWYtdGhlbg0KPiAg LSBpZi10aGVuDQo+ICAtIGlmLXRoZW4NCj4gSXQgd2lsbCBiZSBtb3JlIHJlYWRhYmxlIHRoZW4g c3RhY2tpbmcgJ2lmJyB1bmRlciAnZWxzZScNCg0KVGhhbmtzLiBJIHdpbGwgdXNlIHNvbWV0aGlu ZyBsaWtlIHRoaXM6DQoNCiBhbnlPZjoNCiAgIC0gaWY6ICNnZW4xIGh3DQogICAgIHRoZW46DQog ICAgICAgdXNlIGFwYi9zbWkvYXN5bmMgY2xvY2tzDQoNCiAgIC0gaWY6ICNnZW4yIGh3IHRoYXQg aGFzIGdhbHMuDQogICAgIHRoZW46DQogICAgICAgdXNlIGFwYi9zbWkvZ2FsczAvZ2FsczEgY2xv Y2tzDQogICAgIGVsc2U6ICMgZ2VuMiBodyB0aGF0IGRvZXNuJ3QgaGF2ZSBnYWxzLg0KICAgICAg IHVzZSBhcGIvc21pIGNsb2Nrcy4NCg0KPiANCj4gPg0KPiA+IEkgdHJpZWQgYmVsb3cgaW5zdGVh ZCBvZiB0aGUgY2xvY2tzIHNlZ21lbnQgYWJvdmU6DQo+ID4NCj4gPiA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KPiA+IGlmOg0KPiA+ICAgcHJvcGVydGllczoNCj4gPiAgICAg Y29tcGF0aWJsZToNCj4gDQo+IE1pc3NpbmcgY29udGFpbnMuIEp1c3QgdGFrZSBhbiBleGFtcGxl IGZyb20gc29tZSBleGlzdGluZyBzY2hlbWEuDQoNCg0KTGlrZSB0aGUgZXhhbXBsZSB5b3UgZ2F2 ZSBiZWxvdw0KKERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jbG9jay9pZHQsdmVy c2FjbG9jazUueWFtbCksIEl0IGFsc28NCmRvZXNuJ3QgaGF2ZSAiY29udGFpbnMiIGluICJpZiIu IEkgZ3Vlc3MgaXQgaXMgdW5uZWNlc3NhcnkgaWYgdGhlcmUgaXMNCm9ubHkgb25lIGNvbXBhdGli bGUgc3RyaW5nLiBpdCBtYXkgYmUgbmVjZXNzYXJ5IHdoZW4gaXQgaGFzIGJhY2t3YXJkDQpjb21w YXRpYmxlIHN0cmluZy4NCg0KPiANCj4gPiAgICAgICBlbnVtOg0KPiA+ICAgICAgICAgLSBtZWRp YXRlayxtdDY3Nzktc21pLWNvbW1vbg0KPiA+ICAgICAgICAgLSBtZWRpYXRlayxtdDgxODMtc21p LWNvbW1vbg0KPiA+DQo+ID4gdGhlbjoNCj4gPiAgIHByb3BlcnRpZXM6DQo+ID4gICAgIGNsb2Nr Og0KPiA+ICAgICAgIGl0ZW1zOg0KPiA+ICAgICAgICAgLSBkZXNjcmlwdGlvbjogYXBiIGlzIHRo ZSBjbG9jayBmb3Igc2V0dGluZyB0aGUgcmVnaXN0ZXIuLg0KPiA+ICAgICAgICAgLSBkZXNjcmlw dGlvbjogc21pIGlzIHRoZSBjbG9jayBmb3IgdHJhbnNmZXIgZGF0YSBhbmQgY29tbWFuZC4NCj4g PiAgICAgICAgIC0gZGVzY3JpcHRpb246IGdhbHMwIGlzIHRoZSBwYXRoMCBjbG9jayBvZiBnYWxz KGdsb2JhbCBhc3luYw0KPiA+IGxvY2FsIHN5bmMpLg0KPiA+ICAgICAgICAgLSBkZXNjcmlwdGlv bjogZ2FsczEgaXMgdGhlIHBhdGgxIGNsb2NrIG9mIGdhbHMuDQo+ID4gICAgIGNsb2NrLW5hbWVz Og0KPiA+ICAgICAgIGl0ZW1zOg0KPiA+ICAgICAgICAgLSBjb25zdDogYXBiDQo+ID4gICAgICAg ICAtIGNvbnN0OiBzbWkNCj4gPiAgICAgICAgIC0gY29uc3Q6IGdhbHMwDQo+ID4gICAgICAgICAt IGNvbnN0OiBnYWxzMQ0KPiA+IGVsc2U6DQo+ID4gICBpZjoNCj4gPiAgICAgcHJvcGVydGllczoN Cj4gPiAgICAgICBjb21wYXRpYmxlOg0KPiA+ICAgICAgICAgY29udGFpbnM6DQo+ID4gICAgICAg ICAgIGVudW06DQo+ID4gICAgICAgICAgICAgLSBtZWRpYXRlayxtdDI3MDEtc21pLWNvbW1vbg0K PiA+DQo+ID4gICB0aGVuOg0KPiA+ICAgICBwcm9wZXJ0aWVzOg0KPiA+ICAgICAgIGNsb2NrczoN Cj4gPiAgICAgICAgIGl0ZW1zOg0KPiA+ICAgICAgICAgICAtIGRlc2NyaXB0aW9uOiBhcGIgaXMg dGhlIGNsb2NrIGZvciBzZXR0aW5nIHRoZSByZWdpc3Rlci4NCj4gPiAgICAgICAgICAgLSBkZXNj cmlwdGlvbjogc21pIGlzIHRoZSBjbG9jayBmb3IgdHJhbnNmZXIgZGF0YSBhbmQgY29tbWFuZC4N Cj4gPiAgICAgICAgICAgLSBkZXNjcmlwdGlvbjogYXN5bmMgaXMgYXN5bmNocm9ub3VzIGNsb2Nr LCBpdCBoZWxwIHRyYW5zZm9ybQ0KPiA+IHRoZSBzbWkgY2xvY2sNCj4gPiAgICAgICAgICAgICAg IGludG8gdGhlIGVtaSBjbG9jayBkb21haW4uDQo+ID4gICAgICAgY2xvY2stbmFtZXM6DQo+ID4g ICAgICAgICBpdGVtczoNCj4gPiAgICAgICAgICAgLSBjb25zdDogYXBiDQo+ID4gICAgICAgICAg IC0gY29uc3Q6IHNtaQ0KPiA+ICAgICAgICAgICAtIGNvbnN0OiBhc3luYw0KPiA+ICAgZWxzZToN Cj4gPiAgICAgcHJvcGVydGllczoNCj4gPiAgICAgICBjbG9ja3M6DQo+ID4gICAgICAgICBpdGVt czoNCj4gPiAgICAgICAgICAgLSBkZXNjcmlwdGlvbjogYXBiIGlzIHRoZSBjbG9jayBmb3Igc2V0 dGluZyB0aGUgcmVnaXN0ZXIuDQo+ID4gICAgICAgICAgIC0gZGVzY3JpcHRpb246IHNtaSBpcyB0 aGUgY2xvY2sgZm9yIHRyYW5zZmVyIGRhdGEgYW5kDQo+ID4gY29tbWFuZC4NCj4gPiAgICAgICBj bG9jay1uYW1lczoNCj4gPiAgICAgICAgIGl0ZW1zOg0KPiA+ICAgICAgICAgICAtIGNvbnN0OiBh cGINCj4gPiAgICAgICAgICAgLSBjb25zdDogc21pDQo+ID4gPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCj4gPg0KPiA+IEJ1dCBJIGdvdCBhIHdhcm5pbmcgd2hlbiBkdF9iaW5kaW5n X2NoZWNrOg0KPiA+DQo+ID4gQ0hLRFQNCj4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL21lZGlhdGVrLHNtaS1jb21tb24ueWFtbA0KPiA+ICAg U0NIRU1BDQo+ID4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Byb2Nlc3NlZC1z Y2hlbWEtZXhhbXBsZXMueWFtbA0KPiA+ICAgRFRDDQo+ID4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL21lbW9yeS1jb250cm9sbGVycy9tZWRpYXRlayxzbWktY29tbW9uLmV4YW1w bGUuZHQueWFtbA0KPiA+ICAgQ0hFQ0sNCj4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL21lZGlhdGVrLHNtaS1jb21tb24uZXhhbXBsZS5kdC55 YW1sDQo+ID4gLi4uL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29u dHJvbGxlcnMvbWVkaWF0ZWssc21pLWNvbW1vbi5leGFtcGxlLmR0LnlhbWw6IHNtaUAxNDAyMjAw MDogJ2Nsb2NrLW5hbWVzJywgJ2Nsb2NrcycgZG8gbm90IG1hdGNoIGFueSBvZiB0aGUgcmVnZXhl czogJ3BpbmN0cmwtWzAtOV0rJw0KPiANCj4gVGhlcmUgYXJlIHNldmVyYWwgZmlsZXMgd2hpY2gg YWxyZWFkeSBjaG9vc2UgZGlmZmVyZW50IGNsb2NrcyBiYXNlZCBvbg0KPiBjb21wYXRpYmxlLCBz aW1wbGUgZ3JlcCBzaG93cyB0aGVtOg0KPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvaWlvL2FkYy9zYW1zdW5nLGV4eW5vcy1hZGMueWFtbA0KPiBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvY2xvY2svaWR0LHZlcnNhY2xvY2s1LnlhbWwNCg0KVGhhbmtzIGZvciB0 aGUgcmV2aWV3LiBJIHdpbGwgc2VuZCB0aGUgbmV4dCB2ZXJzaW9uIGFmdGVyIHY1LjEwLg0KDQo+ IA0KPiBCZXN0IHJlZ2FyZHMsDQo+IEtyenlzenRvZg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FC2C433E7 for ; Sat, 10 Oct 2020 06:18:36 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D92C20732 for ; Sat, 10 Oct 2020 06:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WYYJhsYI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D92C20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id D725520444; Sat, 10 Oct 2020 06:18:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NaJQEOADXLGu; Sat, 10 Oct 2020 06:18:33 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id BD18C20413; Sat, 10 Oct 2020 06:18:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AF2DEC07FF; Sat, 10 Oct 2020 06:18:33 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 56A7AC0051 for ; Sat, 10 Oct 2020 06:18:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3E7F32042B for ; Sat, 10 Oct 2020 06:18:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yYYnPcTOU8PM for ; Sat, 10 Oct 2020 06:18:29 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by silver.osuosl.org (Postfix) with ESMTP id B6EE920413 for ; Sat, 10 Oct 2020 06:18:24 +0000 (UTC) X-UUID: 4cbb3f6428a4490d8d4c9f57e03b12d2-20201010 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=61F5Tl8G56sPcS7KsAwbgCO83qs6Yq3c4B1Tn8qYWKc=; b=WYYJhsYIVVxypsuFEv489DssqpGZY5q/ViiyFiYFzpF397nRMxQgaEUuRvC+/vwCJXGrZaFwGTSJWLr2ZqvslF4YhXOBkJtao72m7S9nFXkCW8MQY1JgNflC7xcG3uWRPDtZpkGWe3BHq6VHH3PzU6wHVzGwQrymNnSUaOwNjKo=; X-UUID: 4cbb3f6428a4490d8d4c9f57e03b12d2-20201010 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1548687958; Sat, 10 Oct 2020 14:18:11 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Oct 2020 14:18:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 10 Oct 2020 14:18:08 +0800 Message-ID: <1602310691.26323.39.camel@mhfsdcap03> Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Sat, 10 Oct 2020 14:18:11 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-3-yong.wu@mediatek.com> <20201002110831.GD6888@pi3> <1601958428.26323.26.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 2F5B50D45BFEE5DEAF980977B4B60D0C1CC732DEAB64F85D93BF6AB7D84D9C0F2000:8 X-MTK: N Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, 2020-10-06 at 09:15 +0200, Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > > > On Fri, 2020-10-02 at 13:08 +0200, Krzysztof Kozlowski wrote: > > > On Wed, Sep 30, 2020 at 03:06:25PM +0800, Yong Wu wrote: > > > > Convert MediaTek SMI to DT schema. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > .../mediatek,smi-common.txt | 49 --------- > > > > .../mediatek,smi-common.yaml | 100 ++++++++++++++++++ > > > > .../memory-controllers/mediatek,smi-larb.txt | 49 --------- > > > > .../memory-controllers/mediatek,smi-larb.yaml | 91 ++++++++++++++++ > > > > 4 files changed, 191 insertions(+), 98 deletions(-) > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > > ... > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - enum: > > > > + - mediatek,mt2701-smi-common > > > > + - mediatek,mt2712-smi-common > > > > + - mediatek,mt6779-smi-common > > > > + - mediatek,mt8173-smi-common > > > > + - mediatek,mt8183-smi-common > > > > + > > > > + - description: for mt7623 > > > > + items: > > > > + - const: mediatek,mt7623-smi-common > > > > + - const: mediatek,mt2701-smi-common > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + description: | > > > > + apb and smi are mandatory. the async is only for generation 1 smi HW. > > > > + gals(global async local sync) also is optional, here is the list which > > > > + require gals: mt6779 and mt8183. > > > > + minItems: 2 > > > > + maxItems: 4 > > > > + items: > > > > + - description: apb is Advanced Peripheral Bus clock, It's the clock for > > > > + setting the register. > > > > + - description: smi is the clock for transfer data and command. > > > > + - description: async is asynchronous clock, it help transform the smi clock > > > > + into the emi clock domain. > > > > + - description: gals0 is the path0 clock of gals. > > > > + - description: gals1 is the path1 clock of gals. > > > > + > > > > + clock-names: > > > > + oneOf: > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: async > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: gals0 > > > > + - const: gals1 > > > > > > Similarly to my comment to other properties, this requirement per > > > compatible should be part of the schema within 'if-then'. > > > > I'm not so familiar with this format. Do this has "if-then-'else > > if'-then-else"? > > These are mutually exclusive conditions, so you can skip else: > - if-then > - if-then > - if-then > It will be more readable then stacking 'if' under 'else' Thanks. I will use something like this: anyOf: - if: #gen1 hw then: use apb/smi/async clocks - if: #gen2 hw that has gals. then: use apb/smi/gals0/gals1 clocks else: # gen2 hw that doesn't have gals. use apb/smi clocks. > > > > > I tried below instead of the clocks segment above: > > > > =================================== > > if: > > properties: > > compatible: > > Missing contains. Just take an example from some existing schema. Like the example you gave below (Documentation/devicetree/bindings/clock/idt,versaclock5.yaml), It also doesn't have "contains" in "if". I guess it is unnecessary if there is only one compatible string. it may be necessary when it has backward compatible string. > > > enum: > > - mediatek,mt6779-smi-common > > - mediatek,mt8183-smi-common > > > > then: > > properties: > > clock: > > items: > > - description: apb is the clock for setting the register.. > > - description: smi is the clock for transfer data and command. > > - description: gals0 is the path0 clock of gals(global async > > local sync). > > - description: gals1 is the path1 clock of gals. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: gals0 > > - const: gals1 > > else: > > if: > > properties: > > compatible: > > contains: > > enum: > > - mediatek,mt2701-smi-common > > > > then: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and command. > > - description: async is asynchronous clock, it help transform > > the smi clock > > into the emi clock domain. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: async > > else: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and > > command. > > clock-names: > > items: > > - const: apb > > - const: smi > > ================================ > > > > But I got a warning when dt_binding_check: > > > > CHKDT > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > SCHEMA > > Documentation/devicetree/bindings/processed-schema-examples.yaml > > DTC > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > CHECK > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > .../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml: smi@14022000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > There are several files which already choose different clocks based on > compatible, simple grep shows them: > Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > Documentation/devicetree/bindings/clock/idt,versaclock5.yaml Thanks for the review. I will send the next version after v5.10. > > Best regards, > Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEC5C433DF for ; Sat, 10 Oct 2020 06:18:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 654FC20731 for ; Sat, 10 Oct 2020 06:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VGhqD7Wz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="tTX5WoQW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 654FC20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k8MM2iwOYk5rvmXoV9xFxV66veBVsZJK0YMgFzbsg9g=; b=VGhqD7Wz2IUi0u5B/P/Z7Vvlu Kw/lLX660VjBYT1vDK0ZUyCDzdMuEthSAylFHHbmWEueIi8N6OpCeZXJfNtKP9hw8RioezGnU+rUD gBsUV5lcdX4cgS7+NJem2gMLxFmxuszNF3XgtL2ayFlOW8MPGj5m5CN2qibNwRK17DwwY+/GzTS9B HQBvDmo8+O7xQKXfhIxYX27eWb5p4USDAqdX9sYhe/vrKAUWrQYgtxkNJQguOPy7u01taDF4qXmeo rZiZHy7MubXVf6faiveWyLhyPU3MJwOvRADMwgLvJkq/MXiTRC9C1ZYL5NszJRtXLLK8CieCY9DLC +p8BFsBTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR8DA-0006dt-Sr; Sat, 10 Oct 2020 06:18:32 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR8D6-0006dR-Dj; Sat, 10 Oct 2020 06:18:30 +0000 X-UUID: a2090c63322d4a7fba7010c715d85acd-20201009 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=61F5Tl8G56sPcS7KsAwbgCO83qs6Yq3c4B1Tn8qYWKc=; b=tTX5WoQWKTWgrH9qVB4rbXuhNoS74yy7+7kV1Iurkbfs/2wEs+iSylm4pbHANRoDIrHeJ0Yy8V/2wzWJgDa2kX6ITumCJBZZRh8NnDrl8mbXebIBXoGUEgdFAREcGT5si3+gE3cUF1P5YIGpcKfL7i49vTZYtBVdk/2/z/R5EQk=; X-UUID: a2090c63322d4a7fba7010c715d85acd-20201009 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 516722907; Fri, 09 Oct 2020 22:18:16 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 23:18:14 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Oct 2020 14:18:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 10 Oct 2020 14:18:08 +0800 Message-ID: <1602310691.26323.39.camel@mhfsdcap03> Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Sat, 10 Oct 2020 14:18:11 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-3-yong.wu@mediatek.com> <20201002110831.GD6888@pi3> <1601958428.26323.26.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 2F5B50D45BFEE5DEAF980977B4B60D0C1CC732DEAB64F85D93BF6AB7D84D9C0F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201010_021828_665211_20FCB263 X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-10-06 at 09:15 +0200, Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > > > On Fri, 2020-10-02 at 13:08 +0200, Krzysztof Kozlowski wrote: > > > On Wed, Sep 30, 2020 at 03:06:25PM +0800, Yong Wu wrote: > > > > Convert MediaTek SMI to DT schema. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > .../mediatek,smi-common.txt | 49 --------- > > > > .../mediatek,smi-common.yaml | 100 ++++++++++++++++++ > > > > .../memory-controllers/mediatek,smi-larb.txt | 49 --------- > > > > .../memory-controllers/mediatek,smi-larb.yaml | 91 ++++++++++++++++ > > > > 4 files changed, 191 insertions(+), 98 deletions(-) > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > > ... > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - enum: > > > > + - mediatek,mt2701-smi-common > > > > + - mediatek,mt2712-smi-common > > > > + - mediatek,mt6779-smi-common > > > > + - mediatek,mt8173-smi-common > > > > + - mediatek,mt8183-smi-common > > > > + > > > > + - description: for mt7623 > > > > + items: > > > > + - const: mediatek,mt7623-smi-common > > > > + - const: mediatek,mt2701-smi-common > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + description: | > > > > + apb and smi are mandatory. the async is only for generation 1 smi HW. > > > > + gals(global async local sync) also is optional, here is the list which > > > > + require gals: mt6779 and mt8183. > > > > + minItems: 2 > > > > + maxItems: 4 > > > > + items: > > > > + - description: apb is Advanced Peripheral Bus clock, It's the clock for > > > > + setting the register. > > > > + - description: smi is the clock for transfer data and command. > > > > + - description: async is asynchronous clock, it help transform the smi clock > > > > + into the emi clock domain. > > > > + - description: gals0 is the path0 clock of gals. > > > > + - description: gals1 is the path1 clock of gals. > > > > + > > > > + clock-names: > > > > + oneOf: > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: async > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: gals0 > > > > + - const: gals1 > > > > > > Similarly to my comment to other properties, this requirement per > > > compatible should be part of the schema within 'if-then'. > > > > I'm not so familiar with this format. Do this has "if-then-'else > > if'-then-else"? > > These are mutually exclusive conditions, so you can skip else: > - if-then > - if-then > - if-then > It will be more readable then stacking 'if' under 'else' Thanks. I will use something like this: anyOf: - if: #gen1 hw then: use apb/smi/async clocks - if: #gen2 hw that has gals. then: use apb/smi/gals0/gals1 clocks else: # gen2 hw that doesn't have gals. use apb/smi clocks. > > > > > I tried below instead of the clocks segment above: > > > > =================================== > > if: > > properties: > > compatible: > > Missing contains. Just take an example from some existing schema. Like the example you gave below (Documentation/devicetree/bindings/clock/idt,versaclock5.yaml), It also doesn't have "contains" in "if". I guess it is unnecessary if there is only one compatible string. it may be necessary when it has backward compatible string. > > > enum: > > - mediatek,mt6779-smi-common > > - mediatek,mt8183-smi-common > > > > then: > > properties: > > clock: > > items: > > - description: apb is the clock for setting the register.. > > - description: smi is the clock for transfer data and command. > > - description: gals0 is the path0 clock of gals(global async > > local sync). > > - description: gals1 is the path1 clock of gals. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: gals0 > > - const: gals1 > > else: > > if: > > properties: > > compatible: > > contains: > > enum: > > - mediatek,mt2701-smi-common > > > > then: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and command. > > - description: async is asynchronous clock, it help transform > > the smi clock > > into the emi clock domain. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: async > > else: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and > > command. > > clock-names: > > items: > > - const: apb > > - const: smi > > ================================ > > > > But I got a warning when dt_binding_check: > > > > CHKDT > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > SCHEMA > > Documentation/devicetree/bindings/processed-schema-examples.yaml > > DTC > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > CHECK > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > .../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml: smi@14022000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > There are several files which already choose different clocks based on > compatible, simple grep shows them: > Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > Documentation/devicetree/bindings/clock/idt,versaclock5.yaml Thanks for the review. I will send the next version after v5.10. > > Best regards, > Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21C8C433DF for ; Sat, 10 Oct 2020 06:20:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C2CA20731 for ; Sat, 10 Oct 2020 06:20:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yH3FJReD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="tTX5WoQW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C2CA20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NHPl7a8l6Hnwaw3yU7WAn9IGBKR5RopakTEeVS7PLSM=; b=yH3FJReDA8R3exFY8bJArzyNT R5QTpQ9sKg1rEdEYxY9HgzH4wnz/z91j5PBVM1e4o2WscFRIXNrNM6mplQEuXNuuTNAxU4hQr2kqx ucKRG4CMxHwuGqghib2o0soj7wpS1+kMqGxqEYtgXLeJXh0uDshaonJLzdTokdgOEY1cHf7R9DZmQ PDE2b//3owtOmmhhJaCH0FlHcBuWgBF9RSwGZplI8X8zujYXDzAc0QDLWPNj7fQpq3NHNNdnGzHPw kfJiHMZCGkaKaryMN9JOWwH3qdnLMyJL3V8aOhoBipEhY/KrQ5t31+j1wPwqWzq8JK5J+v9dF8lZ4 4uPKUU9/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR8DB-0006e2-Rv; Sat, 10 Oct 2020 06:18:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kR8D6-0006dR-Dj; Sat, 10 Oct 2020 06:18:30 +0000 X-UUID: a2090c63322d4a7fba7010c715d85acd-20201009 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=61F5Tl8G56sPcS7KsAwbgCO83qs6Yq3c4B1Tn8qYWKc=; b=tTX5WoQWKTWgrH9qVB4rbXuhNoS74yy7+7kV1Iurkbfs/2wEs+iSylm4pbHANRoDIrHeJ0Yy8V/2wzWJgDa2kX6ITumCJBZZRh8NnDrl8mbXebIBXoGUEgdFAREcGT5si3+gE3cUF1P5YIGpcKfL7i49vTZYtBVdk/2/z/R5EQk=; X-UUID: a2090c63322d4a7fba7010c715d85acd-20201009 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 516722907; Fri, 09 Oct 2020 22:18:16 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 23:18:14 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Oct 2020 14:18:09 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 10 Oct 2020 14:18:08 +0800 Message-ID: <1602310691.26323.39.camel@mhfsdcap03> Subject: Re: [PATCH v3 02/24] dt-bindings: memory: mediatek: Convert SMI to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Sat, 10 Oct 2020 14:18:11 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-3-yong.wu@mediatek.com> <20201002110831.GD6888@pi3> <1601958428.26323.26.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 2F5B50D45BFEE5DEAF980977B4B60D0C1CC732DEAB64F85D93BF6AB7D84D9C0F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201010_021828_665211_20FCB263 X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Joerg Roedel , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-10-06 at 09:15 +0200, Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > > > On Fri, 2020-10-02 at 13:08 +0200, Krzysztof Kozlowski wrote: > > > On Wed, Sep 30, 2020 at 03:06:25PM +0800, Yong Wu wrote: > > > > Convert MediaTek SMI to DT schema. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > .../mediatek,smi-common.txt | 49 --------- > > > > .../mediatek,smi-common.yaml | 100 ++++++++++++++++++ > > > > .../memory-controllers/mediatek,smi-larb.txt | 49 --------- > > > > .../memory-controllers/mediatek,smi-larb.yaml | 91 ++++++++++++++++ > > > > 4 files changed, 191 insertions(+), 98 deletions(-) > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > > > delete mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > > > create mode 100644 Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > > ... > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - enum: > > > > + - mediatek,mt2701-smi-common > > > > + - mediatek,mt2712-smi-common > > > > + - mediatek,mt6779-smi-common > > > > + - mediatek,mt8173-smi-common > > > > + - mediatek,mt8183-smi-common > > > > + > > > > + - description: for mt7623 > > > > + items: > > > > + - const: mediatek,mt7623-smi-common > > > > + - const: mediatek,mt2701-smi-common > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + description: | > > > > + apb and smi are mandatory. the async is only for generation 1 smi HW. > > > > + gals(global async local sync) also is optional, here is the list which > > > > + require gals: mt6779 and mt8183. > > > > + minItems: 2 > > > > + maxItems: 4 > > > > + items: > > > > + - description: apb is Advanced Peripheral Bus clock, It's the clock for > > > > + setting the register. > > > > + - description: smi is the clock for transfer data and command. > > > > + - description: async is asynchronous clock, it help transform the smi clock > > > > + into the emi clock domain. > > > > + - description: gals0 is the path0 clock of gals. > > > > + - description: gals1 is the path1 clock of gals. > > > > + > > > > + clock-names: > > > > + oneOf: > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: async > > > > + - items: > > > > + - const: apb > > > > + - const: smi > > > > + - const: gals0 > > > > + - const: gals1 > > > > > > Similarly to my comment to other properties, this requirement per > > > compatible should be part of the schema within 'if-then'. > > > > I'm not so familiar with this format. Do this has "if-then-'else > > if'-then-else"? > > These are mutually exclusive conditions, so you can skip else: > - if-then > - if-then > - if-then > It will be more readable then stacking 'if' under 'else' Thanks. I will use something like this: anyOf: - if: #gen1 hw then: use apb/smi/async clocks - if: #gen2 hw that has gals. then: use apb/smi/gals0/gals1 clocks else: # gen2 hw that doesn't have gals. use apb/smi clocks. > > > > > I tried below instead of the clocks segment above: > > > > =================================== > > if: > > properties: > > compatible: > > Missing contains. Just take an example from some existing schema. Like the example you gave below (Documentation/devicetree/bindings/clock/idt,versaclock5.yaml), It also doesn't have "contains" in "if". I guess it is unnecessary if there is only one compatible string. it may be necessary when it has backward compatible string. > > > enum: > > - mediatek,mt6779-smi-common > > - mediatek,mt8183-smi-common > > > > then: > > properties: > > clock: > > items: > > - description: apb is the clock for setting the register.. > > - description: smi is the clock for transfer data and command. > > - description: gals0 is the path0 clock of gals(global async > > local sync). > > - description: gals1 is the path1 clock of gals. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: gals0 > > - const: gals1 > > else: > > if: > > properties: > > compatible: > > contains: > > enum: > > - mediatek,mt2701-smi-common > > > > then: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and command. > > - description: async is asynchronous clock, it help transform > > the smi clock > > into the emi clock domain. > > clock-names: > > items: > > - const: apb > > - const: smi > > - const: async > > else: > > properties: > > clocks: > > items: > > - description: apb is the clock for setting the register. > > - description: smi is the clock for transfer data and > > command. > > clock-names: > > items: > > - const: apb > > - const: smi > > ================================ > > > > But I got a warning when dt_binding_check: > > > > CHKDT > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > SCHEMA > > Documentation/devicetree/bindings/processed-schema-examples.yaml > > DTC > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > CHECK > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml > > .../Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.example.dt.yaml: smi@14022000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > > There are several files which already choose different clocks based on > compatible, simple grep shows them: > Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > Documentation/devicetree/bindings/clock/idt,versaclock5.yaml Thanks for the review. I will send the next version after v5.10. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel