From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC89C43457 for ; Tue, 13 Oct 2020 07:53:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1B3520872 for ; Tue, 13 Oct 2020 07:53:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="NfBmMAeS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390455AbgJMHxS (ORCPT ); Tue, 13 Oct 2020 03:53:18 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:44443 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390434AbgJMHxR (ORCPT ); Tue, 13 Oct 2020 03:53:17 -0400 X-UUID: 08507b90f26c4ecab32543976e863125-20201013 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hSQpx7aGiFaBvdW2xKyY2Ng20CMPICvnjIERCoViN0I=; b=NfBmMAeSCOJXXulcR1a0zazmOI998zqF+5u06u0xaBN+d0w/Rm4YTFs5ffJPaGehuk+KJ2ZFoLK7U5gTz22mSa07titI7bYt1+l3FQFdyfUzEVoKToXcLSMpKT4+ngMNCN/K3/OPxVYgo7hyQSbqOpaPG60t5ZJIfUeiBtJ1CfM=; X-UUID: 08507b90f26c4ecab32543976e863125-20201013 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1838484348; Tue, 13 Oct 2020 15:53:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Oct 2020 15:53:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 15:53:09 +0800 Message-ID: <1602575589.26323.58.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski CC: Joerg Roedel , Matthias Brugger , Rob Herring , Robin Murphy , Will Deacon , Evan Green , Tomasz Figa , , , , "linux-kernel@vger.kernel.org" , , , , Nicolas Boichat , , , , Greg Kroah-Hartman , Date: Tue, 13 Oct 2020 15:53:09 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: F0136768EC9E69320BFE32C8620BE1722F1A041A55A2EB7E73DFE4BD0D6C98E72000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIwLTEwLTEyIGF0IDE5OjA4ICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tpIHdy b3RlOg0KPiBPbiBUdWUsIDYgT2N0IDIwMjAgYXQgMDY6MjcsIFlvbmcgV3UgPHlvbmcud3VAbWVk aWF0ZWsuY29tPiB3cm90ZToNCj4gPg0KPiA+IE9uIEZyaSwgMjAyMC0xMC0wMiBhdCAxMzowNyAr MDIwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToNCj4gPiA+IE9uIFdlZCwgU2VwIDMwLCAy MDIwIGF0IDAzOjA2OjI0UE0gKzA4MDAsIFlvbmcgV3Ugd3JvdGU6DQo+ID4gPiA+IENvbnZlcnQg TWVkaWFUZWsgSU9NTVUgdG8gRFQgc2NoZW1hLg0KPiA+ID4gPg0KPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBZb25nIFd1IDx5b25nLnd1QG1lZGlhdGVrLmNvbT4NCj4gPiA+ID4gLS0tDQo+ID4gPiA+ ICAuLi4vYmluZGluZ3MvaW9tbXUvbWVkaWF0ZWssaW9tbXUudHh0ICAgICAgICAgfCAxMDMgLS0t LS0tLS0tLS0tDQo+ID4gPiA+ICAuLi4vYmluZGluZ3MvaW9tbXUvbWVkaWF0ZWssaW9tbXUueWFt bCAgICAgICAgfCAxNTQgKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ICAyIGZpbGVzIGNoYW5n ZWQsIDE1NCBpbnNlcnRpb25zKCspLCAxMDMgZGVsZXRpb25zKC0pDQo+ID4gPiA+ICBkZWxldGUg bW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2lvbW11L21lZGlh dGVrLGlvbW11LnR4dA0KPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9pb21tdS9tZWRpYXRlayxpb21tdS55YW1sDQo+ID4gPiA+DQo+ ID4NCj4gPiBbLi4uXQ0KPiA+DQo+ID4gPiA+ICtwcm9wZXJ0aWVzOg0KPiA+ID4gPiArICBjb21w YXRpYmxlOg0KPiA+ID4gPiArICAgIG9uZU9mOg0KPiA+ID4gPiArICAgICAgLSBlbnVtOg0KPiA+ ID4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQyNzAxLW00dSAjIG10MjcwMSBnZW5lcmF0aW9u IG9uZSBIVw0KPiA+ID4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQyNzEyLW00dSAjIG10Mjcx MiBnZW5lcmF0aW9uIHR3byBIVw0KPiA+ID4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQ2Nzc5 LW00dSAjIG10Njc3OSBnZW5lcmF0aW9uIHR3byBIVw0KPiA+ID4gPiArICAgICAgICAgIC0gbWVk aWF0ZWssbXQ4MTczLW00dSAjIG10ODE3MyBnZW5lcmF0aW9uIHR3byBIVw0KPiA+ID4gPiArICAg ICAgICAgIC0gbWVkaWF0ZWssbXQ4MTgzLW00dSAjIG10ODE4MyBnZW5lcmF0aW9uIHR3byBIVw0K PiA+ID4gPiArDQo+ID4gPiA+ICsgICAgICAtIGRlc2NyaXB0aW9uOiBtdDc2MjMgZ2VuZXJhdGlv biBvbmUgSFcNCj4gPiA+ID4gKyAgICAgICAgaXRlbXM6DQo+ID4gPiA+ICsgICAgICAgICAgLSBj b25zdDogbWVkaWF0ZWssbXQ3NjIzLW00dQ0KPiA+ID4gPiArICAgICAgICAgIC0gY29uc3Q6IG1l ZGlhdGVrLG10MjcwMS1tNHUNCj4gPiA+ID4gKw0KPiA+ID4gPiArICByZWc6DQo+ID4gPiA+ICsg ICAgbWF4SXRlbXM6IDENCj4gPiA+ID4gKw0KPiA+ID4gPiArICBpbnRlcnJ1cHRzOg0KPiA+ID4g PiArICAgIG1heEl0ZW1zOiAxDQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgY2xvY2tzOg0KPiA+ID4g PiArICAgIGRlc2NyaXB0aW9uOiB8DQo+ID4gPiA+ICsgICAgICBiY2xrIGlzIG9wdGlvbmFsLiBo ZXJlIGlzIHRoZSBsaXN0IHdoaWNoIHJlcXVpcmUgdGhpcyBiY2xrOg0KPiA+ID4gPiArICAgICAg bXQyNzAxLCBtdDI3MTIsIG10NzYyMyBhbmQgbXQ4MTczLg0KPiA+ID4NCj4gPiA+IFNpbWlsYXJs eSB0byBteSBjb21tZW50IGluIG90aGVyIHBhdGNoLCB0aGlzIHNob3VsZCBiZSBwYXJ0IG9mIHNj aGVtYQ0KPiA+ID4gd2l0aGluICdpZi10aGVuJy4NCj4gPg0KPiA+IFRoYW5rcyBmb3IgdGhlIHJl dmlldy4NCj4gPg0KPiA+IEkgd2lsbCBjaGFuZ2UgbGlrZSB0aGlzOg0KPiA+DQo+ID4gPT09PT09 PT09PT09PQ0KPiA+ICAgY2xvY2tzOg0KPiA+ICAgICBpdGVtczoNCj4gPiAgICAgICAtIGRlc2Ny aXB0aW9uOiBiY2xrIGlzIHRoZSBibG9jayBjbG9jay4NCj4gPg0KPiA+ICAgY2xvY2stbmFtZXM6 DQo+ID4gICAgIGl0ZW1zOg0KPiA+ICAgICAgIC0gY29uc3Q6IGJjbGsNCj4gPg0KPiA+IHJlcXVp cmVkOg0KPiA+ICAgLSBjb21wYXRpYmxlDQo+ID4gICAtIHJlZw0KPiA+ICAgLSBpbnRlcnJ1cHRz DQo+ID4gICAtIG1lZGlhdGVrLGxhcmJzDQo+ID4gICAtICcjaW9tbXUtY2VsbHMnDQo+ID4gaWY6 DQo+ID4gICBwcm9wZXJ0aWVzOg0KPiA+ICAgICBjb21wYXRpYmxlOg0KPiA+ICAgICAgIGNvbnRh aW5zOg0KPiA+ICAgICAgICAgZW51bToNCj4gPiAgICAgICAgICAgLSBtZWRpYXRlayxtdDI3MDEt bTR1DQo+ID4gICAgICAgICAgIC0gbWVkaWF0ZWssbXQyNzEyLW00dQ0KPiA+ICAgICAgICAgICAt IG1lZGlhdGVrLG10ODE3My1tNHUNCj4gPg0KPiA+IHRoZW46DQo+ID4gIHJlcXVpcmVkOg0KPiA+ ICAgIC0gY2xvY2tzDQo+ID4gPT09PT09PT09PT09PT0NCj4gPg0KPiA+IElmIHRoaXMgaXMgbm90 IHJpZ2h0LCBwbGVhc2UgdGVsbCBtZS4NCj4gPiAoZHRfYmluZGluZ19jaGVjayBpcyBvay4pDQo+ IA0KPiBMb29rcyBmaW5lLCBleGNlcHQgImlmIiBzaG91bGQgYmUgcGFydCBvZiBzb21lICJhbGxP ZiIgYmxvY2suDQoNClRoYW5rcyB2ZXJ5IG11Y2ggZm9yIHRoZSByZXZpZXcuDQpJIHdpbGwgYWRk ICJhbGxPZiIgaW4gbmV4dCB2ZXJzaW9uLg0KDQo+IA0KPiBCZXN0IHJlZ2FyZHMsDQo+IEtyenlz enRvZg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FD8C43457 for ; Tue, 13 Oct 2020 07:53:24 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 708AC214D8 for ; Tue, 13 Oct 2020 07:53:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="NfBmMAeS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 708AC214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 018D08744A; Tue, 13 Oct 2020 07:53:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qR2xgdHQ5ug5; Tue, 13 Oct 2020 07:53:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8240B87437; Tue, 13 Oct 2020 07:53:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7BA0DC07FF; Tue, 13 Oct 2020 07:53:22 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 514E8C0051 for ; Tue, 13 Oct 2020 07:53:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3764387437 for ; Tue, 13 Oct 2020 07:53:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kbcUcF9vjpyw for ; Tue, 13 Oct 2020 07:53:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw01.mediatek.com (unknown [1.203.163.78]) by fraxinus.osuosl.org (Postfix) with ESMTP id BBA9A87440 for ; Tue, 13 Oct 2020 07:53:18 +0000 (UTC) X-UUID: 08507b90f26c4ecab32543976e863125-20201013 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=hSQpx7aGiFaBvdW2xKyY2Ng20CMPICvnjIERCoViN0I=; b=NfBmMAeSCOJXXulcR1a0zazmOI998zqF+5u06u0xaBN+d0w/Rm4YTFs5ffJPaGehuk+KJ2ZFoLK7U5gTz22mSa07titI7bYt1+l3FQFdyfUzEVoKToXcLSMpKT4+ngMNCN/K3/OPxVYgo7hyQSbqOpaPG60t5ZJIfUeiBtJ1CfM=; X-UUID: 08507b90f26c4ecab32543976e863125-20201013 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1838484348; Tue, 13 Oct 2020 15:53:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Oct 2020 15:53:10 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 15:53:09 +0800 Message-ID: <1602575589.26323.58.camel@mhfsdcap03> Subject: Re: [PATCH v3 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema From: Yong Wu To: Krzysztof Kozlowski Date: Tue, 13 Oct 2020 15:53:09 +0800 In-Reply-To: References: <20200930070647.10188-1-yong.wu@mediatek.com> <20200930070647.10188-2-yong.wu@mediatek.com> <20201002110709.GC6888@pi3> <1601958415.26323.25.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: F0136768EC9E69320BFE32C8620BE1722F1A041A55A2EB7E73DFE4BD0D6C98E72000:8 X-MTK: N Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, kernel-team@android.com, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, Robin Murphy , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, 2020-10-12 at 19:08 +0200, Krzysztof Kozlowski wrote: > On Tue, 6 Oct 2020 at 06:27, Yong Wu wrote: > > > > On Fri, 2020-10-02 at 13:07 +0200, Krzysztof Kozlowski wrote: > > > On Wed, Sep 30, 2020 at 03:06:24PM +0800, Yong Wu wrote: > > > > Convert MediaTek IOMMU to DT schema. > > > > > > > > Signed-off-by: Yong Wu > > > > --- > > > > .../bindings/iommu/mediatek,iommu.txt | 103 ------------ > > > > .../bindings/iommu/mediatek,iommu.yaml | 154 ++++++++++++++++++ > > > > 2 files changed, 154 insertions(+), 103 deletions(-) > > > > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > > > create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > > > > > > > > [...] > > > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - enum: > > > > + - mediatek,mt2701-m4u # mt2701 generation one HW > > > > + - mediatek,mt2712-m4u # mt2712 generation two HW > > > > + - mediatek,mt6779-m4u # mt6779 generation two HW > > > > + - mediatek,mt8173-m4u # mt8173 generation two HW > > > > + - mediatek,mt8183-m4u # mt8183 generation two HW > > > > + > > > > + - description: mt7623 generation one HW > > > > + items: > > > > + - const: mediatek,mt7623-m4u > > > > + - const: mediatek,mt2701-m4u > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + interrupts: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + description: | > > > > + bclk is optional. here is the list which require this bclk: > > > > + mt2701, mt2712, mt7623 and mt8173. > > > > > > Similarly to my comment in other patch, this should be part of schema > > > within 'if-then'. > > > > Thanks for the review. > > > > I will change like this: > > > > ============= > > clocks: > > items: > > - description: bclk is the block clock. > > > > clock-names: > > items: > > - const: bclk > > > > required: > > - compatible > > - reg > > - interrupts > > - mediatek,larbs > > - '#iommu-cells' > > if: > > properties: > > compatible: > > contains: > > enum: > > - mediatek,mt2701-m4u > > - mediatek,mt2712-m4u > > - mediatek,mt8173-m4u > > > > then: > > required: > > - clocks > > ============== > > > > If this is not right, please tell me. > > (dt_binding_check is ok.) > > Looks fine, except "if" should be part of some "allOf" block. Thanks very much for the review. I will add "allOf" in next version. > > Best regards, > Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu