[U-Boot] [PATCH 0/3] rockchip: rk3188 fixed early stage and radxarock board

[U-Boot] [PATCH 0/3] rockchip: rk3188 fixed early stage and radxarock board

[Heiko Stuebner]

Applies on top of current rockchip master branch and needs
Kever's early_init patch for rk3188 and rk3399.

After this one series, there is of course still
    rockchip: rk3188: fixups and armclk speedup
series and
    rockchip: rk3188: enable remap function
patch open.


changes compared to the original patches:
- made it apply on top of current rockchip master
- arranged in a way to not create build errors
- so adapted the TPL_LIBGENERIC patch to be in front
  of the rock board addition

Heiko Stuebner (3):
  rockchip: rk3188: enable TPL_LIBGENERIC for generic memset
  rockchip: rk3188: Add Radxa Rock board
  rockchip: rk3188: add README.rockchip paragraph describing sd boot

 arch/arm/dts/Makefile                 |   1 +
 arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3188/Kconfig |  14 ++
 board/radxa/rock/Kconfig              |  15 ++
 board/radxa/rock/MAINTAINERS          |   6 +
 board/radxa/rock/Makefile             |   7 +
 board/radxa/rock/rock.c               |   7 +
 configs/rock_defconfig                |  58 ++++++
 doc/README.rockchip                   |  26 +++
 include/configs/rock.h                |  30 +++
 10 files changed, 546 insertions(+)
 create mode 100644 arch/arm/dts/rk3188-radxarock.dts
 create mode 100644 board/radxa/rock/Kconfig
 create mode 100644 board/radxa/rock/MAINTAINERS
 create mode 100644 board/radxa/rock/Makefile
 create mode 100644 board/radxa/rock/rock.c
 create mode 100644 configs/rock_defconfig
 create mode 100644 include/configs/rock.h

-- 
2.11.0

[U-Boot] [PATCH 1/3] rockchip: rk3188: enable TPL_LIBGENERIC for generic memset

[Heiko Stuebner]

Commit c67c8c604b6c ("board_init.c: Always use memset()") dropped the naive
memset alternative from board_init_f_init_reserve.
So activate CONFIG_TPL_LIBGENERIC for that common memset implementation.
We cannot use the ARCH-specific memset, as that would incur 200bytes of
additional TPL size, space we do not have.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm/mach-rockchip/rk3188/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3188/Kconfig b/arch/arm/mach-rockchip/rk3188/Kconfig
index f8e1d0316b..b70d45cd62 100644
--- a/arch/arm/mach-rockchip/rk3188/Kconfig
+++ b/arch/arm/mach-rockchip/rk3188/Kconfig
@@ -18,6 +18,9 @@ config SPL_SERIAL_SUPPORT
 config TPL_LIBCOMMON_SUPPORT
 	default y
 
+config TPL_LIBGENERIC_SUPPORT
+	default y
+
 config TPL_SERIAL_SUPPORT
 	default y
 
-- 
2.11.0

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

The Rock is a RK3188 based single board computer by Radxa.
Currently it still relies on the proprietary DDR init and
cannot use the generic SPL, but at least is able to boot
a linux kernel and system up to a regular login prompt.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Kever Yang <kever.yang@rock-chips.com>
---
 arch/arm/dts/Makefile                 |   1 +
 arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
 board/radxa/rock/Kconfig              |  15 ++
 board/radxa/rock/MAINTAINERS          |   6 +
 board/radxa/rock/Makefile             |   7 +
 board/radxa/rock/rock.c               |   7 +
 configs/rock_defconfig                |  58 ++++++
 include/configs/rock.h                |  30 +++
 9 files changed, 517 insertions(+)
 create mode 100644 arch/arm/dts/rk3188-radxarock.dts
 create mode 100644 board/radxa/rock/Kconfig
 create mode 100644 board/radxa/rock/MAINTAINERS
 create mode 100644 board/radxa/rock/Makefile
 create mode 100644 board/radxa/rock/rock.c
 create mode 100644 configs/rock_defconfig
 create mode 100644 include/configs/rock.h

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index d00651c74c..8c726c3d10 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -29,6 +29,7 @@ dtb-$(CONFIG_EXYNOS5) += exynos5250-arndale.dtb \
 dtb-$(CONFIG_EXYNOS7420) += exynos7420-espresso7420.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rk3036-sdk.dtb \
+	rk3188-radxarock.dtb \
 	rk3288-firefly.dtb \
 	rk3288-veyron-jerry.dtb \
 	rk3288-veyron-mickey.dtb \
diff --git a/arch/arm/dts/rk3188-radxarock.dts b/arch/arm/dts/rk3188-radxarock.dts
new file mode 100644
index 0000000000..5f5b5e9a1f
--- /dev/null
+++ b/arch/arm/dts/rk3188-radxarock.dts
@@ -0,0 +1,382 @@
+/*
+ * Copyright (c) 2013 Heiko Stuebner <heiko@sntech.de>
+ *
+ * SPDX-License-Identifier:     GPL-2.0+ or X11
+ */
+
+/dts-v1/;
+#include <dt-bindings/input/input.h>
+#include "rk3188.dtsi"
+
+/ {
+	model = "Radxa Rock";
+	compatible = "radxa,rock", "rockchip,rk3188";
+
+	chosen {
+/*		stdout-path = &uart2; */
+		stdout-path = "serial2:115200n8";
+	};
+
+	config {
+		u-boot,dm-pre-reloc;
+		u-boot,boot-led = "rock:red:power";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x60000000 0x80000000>;
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		autorepeat;
+
+		power {
+			gpios = <&gpio0 4 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_POWER>;
+			label = "GPIO Key Power";
+			linux,input-type = <1>;
+			wakeup-source;
+			debounce-interval = <100>;
+		};
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		green {
+			label = "rock:green:user1";
+			gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+
+		blue {
+			label = "rock:blue:user2";
+			gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
+			default-state = "off";
+		};
+
+		sleep {
+			label = "rock:red:power";
+			gpios = <&gpio0 15 0>;
+			default-state = "off";
+		};
+	};
+
+	sound {
+		compatible = "simple-audio-card";
+		simple-audio-card,name = "SPDIF";
+
+		simple-audio-card,dai-link at 1 {  /* S/PDIF - S/PDIF */
+			cpu { sound-dai = <&spdif>; };
+			codec { sound-dai = <&spdif_out>; };
+		};
+	};
+
+	spdif_out: spdif-out {
+		compatible = "linux,spdif-dit";
+		#sound-dai-cells = <0>;
+	};
+
+	ir_recv: gpio-ir-receiver {
+		compatible = "gpio-ir-receiver";
+		gpios = <&gpio0 10 1>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&ir_recv_pin>;
+	};
+
+	vcc_otg: usb-otg-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&otg_vbus_drv>;
+		regulator-name = "otg-vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vcc_sd0: sdmmc-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "sdmmc-supply";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio3 1 GPIO_ACTIVE_LOW>;
+		startup-delay-us = <100000>;
+		vin-supply = <&vcc_io>;
+	};
+
+	vcc_host: usb-host-regulator {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio0 3 GPIO_ACTIVE_HIGH>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&host_vbus_drv>;
+		regulator-name = "host-pwr";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vsys: vsys-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vsys";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-boot-on;
+	};
+};
+
+&dmc {
+	rockchip,pctl-timing = <0x12c 0xc8 0x1f4 0x1e 0x4e 0x4 0x69 0x6
+		0x3 0x0 0x6 0x5 0xc 0x10 0x6 0x4
+		0x4 0x5 0x4 0x200 0x3 0xa 0x40 0x0
+		0x1 0x5 0x5 0x3 0xc 0x1e 0x100 0x0
+		0x4 0x0>;
+	rockchip,phy-timing = <0x208c6690 0x690878 0x10022a00
+		0x220 0x40 0x0 0x0>;
+	rockchip,sdram-params = <0x24716310 0 2 300000000 3 9 0>;
+};
+
+&emac {
+	status = "okay";
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
+
+	phy = <&phy0>;
+	phy-supply = <&vcc_rmii>;
+
+	phy0: ethernet-phy at 0 {
+		reg = <0>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
+	};
+};
+
+&cpu0 {
+	cpu0-supply = <&vdd_arm>;
+};
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	rtc at 51 {
+		compatible = "haoyu,hym8563";
+		reg = <0x51>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&rtc_int>;
+		#clock-cells = <0>;
+		clock-output-names = "xin32k";
+	};
+
+	act8846: act8846 at 5a {
+		compatible = "active-semi,act8846";
+		reg = <0x5a>;
+		status = "okay";
+		system-power-controller;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&act8846_dvs0_ctl>;
+
+		vp1-supply = <&vsys>;
+		vp2-supply = <&vsys>;
+		vp3-supply = <&vsys>;
+		vp4-supply = <&vsys>;
+		inl1-supply = <&vcc_io>;
+		inl2-supply = <&vsys>;
+		inl3-supply = <&vsys>;
+
+		regulators {
+			vcc_ddr: REG1 {
+				regulator-name = "VCC_DDR";
+				regulator-min-microvolt = <1200000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+			};
+
+			vdd_log: REG2 {
+				regulator-name = "VDD_LOG";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+			};
+
+			vdd_arm: REG3 {
+				regulator-name = "VDD_ARM";
+				regulator-min-microvolt = <875000>;
+				regulator-max-microvolt = <1350000>;
+				regulator-always-on;
+			};
+
+			vcc_io: REG4 {
+				regulator-name = "VCC_IO";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vdd_10: REG5 {
+				regulator-name = "VDD_10";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+			};
+
+			vdd_hdmi: REG6 {
+				regulator-name = "VDD_HDMI";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <2500000>;
+				regulator-always-on;
+			};
+
+			vcc18: REG7 {
+				regulator-name = "VCC_18";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+			};
+
+			vcca_33: REG8 {
+				regulator-name = "VCCA_33";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vcc_rmii: REG9 {
+				regulator-name = "VCC_RMII";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+			};
+
+			vccio_wl: REG10 {
+				regulator-name = "VCCIO_WL";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+
+			vcc_18: REG11 {
+				regulator-name = "VCC18_IO";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+			};
+
+			vcc28: REG12 {
+				regulator-name = "VCC_28";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&mmc0 {
+	num-slots = <1>;
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
+	vmmc-supply = <&vcc_sd0>;
+
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	disable-wp;
+};
+
+&pwm1 {
+	status = "okay";
+};
+
+&pwm2 {
+	status = "okay";
+};
+
+&pwm3 {
+	status = "okay";
+};
+
+&pinctrl {
+	pcfg_output_low: pcfg-output-low {
+		output-low;
+	};
+
+	act8846 {
+		act8846_dvs0_ctl: act8846-dvs0-ctl {
+			rockchip,pins = <RK_GPIO3 27 RK_FUNC_GPIO &pcfg_output_low>;
+		};
+	};
+
+	hym8563 {
+		rtc_int: rtc-int {
+			rockchip,pins = <RK_GPIO0 0 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	lan8720a  {
+		phy_int: phy-int {
+			rockchip,pins = <RK_GPIO3 26 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+
+	ir-receiver {
+		ir_recv_pin: ir-recv-pin {
+			rockchip,pins = <RK_GPIO0 10 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	usb {
+		host_vbus_drv: host-vbus-drv {
+			rockchip,pins = <0 3 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+		otg_vbus_drv: otg-vbus-drv {
+			rockchip,pins = <2 31 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+};
+
+&spdif {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+	u-boot,dm-spl;
+};
+
+&uart3 {
+	status = "okay";
+};
+
+&usbphy {
+	status = "okay";
+};
+
+&usb_host {
+	status = "okay";
+};
+
+&usb_otg {
+	status = "okay";
+};
+
+&wdt {
+	status = "okay";
+};
diff --git a/arch/arm/mach-rockchip/rk3188/Kconfig b/arch/arm/mach-rockchip/rk3188/Kconfig
index b70d45cd62..d129fcda99 100644
--- a/arch/arm/mach-rockchip/rk3188/Kconfig
+++ b/arch/arm/mach-rockchip/rk3188/Kconfig
@@ -1,5 +1,14 @@
 if ROCKCHIP_RK3188
 
+config TARGET_ROCK
+	bool "Radxa Rock"
+	help
+	  Rock is a RK3188-based development board with 2 USB and 1 otg
+	  ports, HDMI, TV-out, micro-SD card, audio, WiFi  and 100MBit
+	  Ethernet, It also includes on-board nand and 1GB of SDRAM.
+	  Expansion connectors provide access to display pins, I2C, SPI,
+	  UART and GPIOs.
+
 config SYS_SOC
 	default "rockchip"
 
@@ -24,4 +33,6 @@ config TPL_LIBGENERIC_SUPPORT
 config TPL_SERIAL_SUPPORT
 	default y
 
+source "board/radxa/rock/Kconfig"
+
 endif
diff --git a/board/radxa/rock/Kconfig b/board/radxa/rock/Kconfig
new file mode 100644
index 0000000000..855b9b6954
--- /dev/null
+++ b/board/radxa/rock/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_ROCK
+
+config SYS_BOARD
+	default "rock"
+
+config SYS_VENDOR
+	default "radxa"
+
+config SYS_CONFIG_NAME
+	default "rock"
+
+config BOARD_SPECIFIC_OPTIONS # dummy
+	def_bool y
+
+endif
diff --git a/board/radxa/rock/MAINTAINERS b/board/radxa/rock/MAINTAINERS
new file mode 100644
index 0000000000..c5f59c0a6f
--- /dev/null
+++ b/board/radxa/rock/MAINTAINERS
@@ -0,0 +1,6 @@
+RADXA_ROCK
+M:	Heiko Stuebner <heiko@sntech.de>
+S:	Maintained
+F:	board/radxa/rock
+F:	include/configs/rock.h
+F:	configs/rock_defconfig
diff --git a/board/radxa/rock/Makefile b/board/radxa/rock/Makefile
new file mode 100644
index 0000000000..fe94b60c35
--- /dev/null
+++ b/board/radxa/rock/Makefile
@@ -0,0 +1,7 @@
+#
+# (C) Copyright 2015 Heiko Stuebner
+#
+# SPDX-License-Identifier:     GPL-2.0+
+#
+
+obj-y	+= rock.o
diff --git a/board/radxa/rock/rock.c b/board/radxa/rock/rock.c
new file mode 100644
index 0000000000..5119e95455
--- /dev/null
+++ b/board/radxa/rock/rock.c
@@ -0,0 +1,7 @@
+/*
+ * (C) Copyright 2015 Google, Inc
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#include <common.h>
diff --git a/configs/rock_defconfig b/configs/rock_defconfig
new file mode 100644
index 0000000000..86048c8fd7
--- /dev/null
+++ b/configs/rock_defconfig
@@ -0,0 +1,58 @@
+CONFIG_ARM=y
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_ROCKCHIP_RK3188=y
+CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y
+CONFIG_TARGET_ROCK=y
+CONFIG_SPL_STACK_R_ADDR=0x60080000
+CONFIG_DEFAULT_DEVICE_TREE="rk3188-radxarock"
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTZ=y
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_SPI=y
+CONFIG_CMD_I2C=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_SPL_OF_PLATDATA=y
+CONFIG_REGMAP=y
+CONFIG_SYSCON=y
+# CONFIG_SPL_SIMPLE_BUS is not set
+# CONFIG_SPL_MMC_SUPPORT is not set
+# CONFIG_SPL_USE_ARCH_MEMSET is not set
+# CONFIG_SPL_USE_ARCH_MEMCPY is not set
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_CLK=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_LED=y
+CONFIG_SYSRESET=y
+CONFIG_PINCTRL=y
+# CONFIG_SPL_PINCTRL_FULL is not set
+CONFIG_ROCKCHIP_RK3188_PINCTRL=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_RAM=y
+CONFIG_DEBUG_UART=y
+CONFIG_DEBUG_UART_BASE=0x20064000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_DEBUG_UART_NS16550=y
+CONFIG_SYS_NS16550=y
+CONFIG_CMD_DHRYSTONE=y
+CONFIG_ERRNO_STR=y
diff --git a/include/configs/rock.h b/include/configs/rock.h
new file mode 100644
index 0000000000..de5291cd05
--- /dev/null
+++ b/include/configs/rock.h
@@ -0,0 +1,30 @@
+/*
+ * (C) Copyright 2015 Google, Inc
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define ROCKCHIP_DEVICE_SETTINGS
+#include <configs/rk3188_common.h>
+
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_SYS_MMC_ENV_DEV 0
+
+#ifdef CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
+/* SPL @ 32k for 34k
+ * u-boot directly after @ 68k for 400k or so
+ * ENV @ 992k
+ */
+#define CONFIG_ENV_OFFSET ((1024-32) * 1024)
+#else
+/* SPL @ 32k for ~36k
+ * ENV @ 96k
+ * u-boot @ 128K
+ */
+#define CONFIG_ENV_OFFSET (96 * 1024)
+#endif
+
+#endif
-- 
2.11.0

[U-Boot] [PATCH 3/3] rockchip: rk3188: add README.rockchip paragraph describing sd boot

[Heiko Stuebner]

Building sd images for rk3188 requires more steps due to the needed split
into TPL and SPL as loaders. Describe how to build an image for it in a
separate paragraph in the READER.rockchip file.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 doc/README.rockchip | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/doc/README.rockchip b/doc/README.rockchip
index 186a1a007e..cb81efd4bf 100644
--- a/doc/README.rockchip
+++ b/doc/README.rockchip
@@ -147,6 +147,32 @@ For evb_rk3036 board:
 Note: rk3036 SDMMC and debug uart use the same iomux, so if you boot from SD, the
       debug uart must be disabled
 
+
+Booting from an SD card on RK3188
+=================================
+
+For rk3188 boards the general storage onto the card stays the same as
+described above, but the image creation needs a bit more care.
+
+The bootrom of rk3188 expects to find a small 1kb loader which returns
+control to the bootrom, after which it will load the real loader, which
+can then be up to 29kb in size and does the regular ddr init.
+
+Additionally the rk3188 requires everything the bootrom loads to be
+rc4-encrypted. Except for the very first stage the bootrom always reads
+and decodes 2kb pages, so files should be sized accordingly.
+
+# copy tpl, pad to 1020 bytes and append spl
+cat tpl/u-boot-tpl.bin > tplspl.bin
+truncate -s 1020 tplspl.bin
+cat spl/u-boot-spl.bin >> tplspl.bin
+tools/mkimage -n rk3188 -T rksd -d tplspl.bin out
+
+# truncate, encode and append u-boot.bin
+truncate -s %2048 u-boot.bin
+cat u-boot.bin | split -b 512 --filter='openssl rc4 -K 7C4E0304550509072D2C7B38170D1711' >> out
+
+
 Using fastboot on rk3288
 ========================
 - Write GPT partition layout to mmc device which fastboot want to use it to
-- 
2.11.0

[U-Boot] [PATCH 3/3] rockchip: rk3188: add README.rockchip paragraph describing sd boot

[Kever Yang]

Hi Heiko,

On 03/24/2017 07:41 AM, Heiko Stuebner wrote:
> Building sd images for rk3188 requires more steps due to the needed split
> into TPL and SPL as loaders. Describe how to build an image for it in a
> separate paragraph in the READER.rockchip file.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>   doc/README.rockchip | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/doc/README.rockchip b/doc/README.rockchip
> index 186a1a007e..cb81efd4bf 100644
> --- a/doc/README.rockchip
> +++ b/doc/README.rockchip
> @@ -147,6 +147,32 @@ For evb_rk3036 board:
>   Note: rk3036 SDMMC and debug uart use the same iomux, so if you boot from SD, the
>         debug uart must be disabled
>   
> +
> +Booting from an SD card on RK3188
> +=================================
> +
> +For rk3188 boards the general storage onto the card stays the same as
> +described above, but the image creation needs a bit more care.
> +
> +The bootrom of rk3188 expects to find a small 1kb loader which returns
> +control to the bootrom, after which it will load the real loader, which
> +can then be up to 29kb in size and does the regular ddr init.
> +
> +Additionally the rk3188 requires everything the bootrom loads to be
> +rc4-encrypted. Except for the very first stage the bootrom always reads
> +and decodes 2kb pages, so files should be sized accordingly.
> +
> +# copy tpl, pad to 1020 bytes and append spl
> +cat tpl/u-boot-tpl.bin > tplspl.bin
> +truncate -s 1020 tplspl.bin
> +cat spl/u-boot-spl.bin >> tplspl.bin
> +tools/mkimage -n rk3188 -T rksd -d tplspl.bin out
> +
> +# truncate, encode and append u-boot.bin
> +truncate -s %2048 u-boot.bin
> +cat u-boot.bin | split -b 512 --filter='openssl rc4 -K 7C4E0304550509072D2C7B38170D1711' >> out
> +
> +
>   Using fastboot on rk3288
>   ========================
>   - Write GPT partition layout to mmc device which fastboot want to use it to

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

Hi,

On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> The Rock is a RK3188 based single board computer by Radxa.
> Currently it still relies on the proprietary DDR init and
> cannot use the generic SPL, but at least is able to boot
> a linux kernel and system up to a regular login prompt.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>  arch/arm/dts/Makefile                 |   1 +
>  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
>  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
>  board/radxa/rock/Kconfig              |  15 ++
>  board/radxa/rock/MAINTAINERS          |   6 +
>  board/radxa/rock/Makefile             |   7 +
>  board/radxa/rock/rock.c               |   7 +
>  configs/rock_defconfig                |  58 ++++++
>  include/configs/rock.h                |  30 +++
>  9 files changed, 517 insertions(+)
>  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>  create mode 100644 board/radxa/rock/Kconfig
>  create mode 100644 board/radxa/rock/MAINTAINERS
>  create mode 100644 board/radxa/rock/Makefile
>  create mode 100644 board/radxa/rock/rock.c
>  create mode 100644 configs/rock_defconfig
>  create mode 100644 include/configs/rock.h

I am still having trouble applying this patch. I get build errors:

       arm:  +   rock
+arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
+make[2]: *** No rule to make target 'dts/dt.dtb', needed by
'tpl/u-boot-tpl.dtb'.  Stop.
+make[1]: *** [tpl/u-boot-tpl.bin] Error 2
+make: *** [sub-make] Error 2
    0    0    1 /1      rock

Also there seems to be a duplicate config:

       arm:  +   rock
+In file included from include/configs/rock.h:11:0,
+                 from include/config.h:5,
+                 from include/common.h:21,
+                 from arch/arm/lib/asm-offsets.c:15:
+ #define CONFIG_SYS_THUMB_BUILD
+ ^
+                 from lib/asm-offsets.c:15:
+In file included from include/linux/kconfig.h:4:0,
+                 from <command-line>:0:
+include/generated/autoconf.h:10:0: note: this is the location of the
previous definition
+ #define CONFIG_SYS_THUMB_BUILD 1


What toolchain are you using to build this?

Regards,
Simon

[U-Boot] [PATCH 1/3] rockchip: rk3188: enable TPL_LIBGENERIC for generic memset

[Simon Glass]

On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> Commit c67c8c604b6c ("board_init.c: Always use memset()") dropped the naive
> memset alternative from board_init_f_init_reserve.
> So activate CONFIG_TPL_LIBGENERIC for that common memset implementation.
> We cannot use the ARCH-specific memset, as that would incur 200bytes of
> additional TPL size, space we do not have.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  arch/arm/mach-rockchip/rk3188/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
>

Applied to u-boot-rockchip, thanks!

[U-Boot] [PATCH 3/3] rockchip: rk3188: add README.rockchip paragraph describing sd boot

[Simon Glass]

On 23 March 2017 at 20:40, Kever Yang <kever.yang@rock-chips.com> wrote:
> Hi Heiko,
>
>
> On 03/24/2017 07:41 AM, Heiko Stuebner wrote:
>>
>> Building sd images for rk3188 requires more steps due to the needed split
>> into TPL and SPL as loaders. Describe how to build an image for it in a
>> separate paragraph in the READER.rockchip file.
>>
>> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> ---
>>   doc/README.rockchip | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
[...]

>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Applied to u-boot-rockchip, thanks!

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Hi Simon,

Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> > The Rock is a RK3188 based single board computer by Radxa.
> > Currently it still relies on the proprietary DDR init and
> > cannot use the generic SPL, but at least is able to boot
> > a linux kernel and system up to a regular login prompt.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> > ---
> >  arch/arm/dts/Makefile                 |   1 +
> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> >  board/radxa/rock/Kconfig              |  15 ++
> >  board/radxa/rock/MAINTAINERS          |   6 +
> >  board/radxa/rock/Makefile             |   7 +
> >  board/radxa/rock/rock.c               |   7 +
> >  configs/rock_defconfig                |  58 ++++++
> >  include/configs/rock.h                |  30 +++
> >  9 files changed, 517 insertions(+)
> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> >  create mode 100644 board/radxa/rock/Kconfig
> >  create mode 100644 board/radxa/rock/MAINTAINERS
> >  create mode 100644 board/radxa/rock/Makefile
> >  create mode 100644 board/radxa/rock/rock.c
> >  create mode 100644 configs/rock_defconfig
> >  create mode 100644 include/configs/rock.h
> 
> I am still having trouble applying this patch. I get build errors:
> 
>        arm:  +   rock
> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> 'tpl/u-boot-tpl.dtb'.  Stop.
> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> +make: *** [sub-make] Error 2
>     0    0    1 /1      rock
> 
> Also there seems to be a duplicate config:
> 
>        arm:  +   rock
> +In file included from include/configs/rock.h:11:0,
> +                 from include/config.h:5,
> +                 from include/common.h:21,
> +                 from arch/arm/lib/asm-offsets.c:15:
> + #define CONFIG_SYS_THUMB_BUILD
> + ^
> +                 from lib/asm-offsets.c:15:
> +In file included from include/linux/kconfig.h:4:0,
> +                 from <command-line>:0:
> +include/generated/autoconf.h:10:0: note: this is the location of the
> previous definition
> + #define CONFIG_SYS_THUMB_BUILD 1

looks like this got run over by another Kconfig migration on march-18.
New patches (migration + rock board) coming up shortly.

Heiko

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

Hi Heiko,

On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> Hi Simon,
>
> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
>> > The Rock is a RK3188 based single board computer by Radxa.
>> > Currently it still relies on the proprietary DDR init and
>> > cannot use the generic SPL, but at least is able to boot
>> > a linux kernel and system up to a regular login prompt.
>> >
>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> > Reviewed-by: Simon Glass <sjg@chromium.org>
>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
>> > ---
>> >  arch/arm/dts/Makefile                 |   1 +
>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
>> >  board/radxa/rock/Kconfig              |  15 ++
>> >  board/radxa/rock/MAINTAINERS          |   6 +
>> >  board/radxa/rock/Makefile             |   7 +
>> >  board/radxa/rock/rock.c               |   7 +
>> >  configs/rock_defconfig                |  58 ++++++
>> >  include/configs/rock.h                |  30 +++
>> >  9 files changed, 517 insertions(+)
>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>> >  create mode 100644 board/radxa/rock/Kconfig
>> >  create mode 100644 board/radxa/rock/MAINTAINERS
>> >  create mode 100644 board/radxa/rock/Makefile
>> >  create mode 100644 board/radxa/rock/rock.c
>> >  create mode 100644 configs/rock_defconfig
>> >  create mode 100644 include/configs/rock.h
>>
>> I am still having trouble applying this patch. I get build errors:
>>
>>        arm:  +   rock
>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>> 'tpl/u-boot-tpl.dtb'.  Stop.
>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> +make: *** [sub-make] Error 2
>>     0    0    1 /1      rock
>>
>> Also there seems to be a duplicate config:
>>
>>        arm:  +   rock
>> +In file included from include/configs/rock.h:11:0,
>> +                 from include/config.h:5,
>> +                 from include/common.h:21,
>> +                 from arch/arm/lib/asm-offsets.c:15:
>> + #define CONFIG_SYS_THUMB_BUILD
>> + ^
>> +                 from lib/asm-offsets.c:15:
>> +In file included from include/linux/kconfig.h:4:0,
>> +                 from <command-line>:0:
>> +include/generated/autoconf.h:10:0: note: this is the location of the
>> previous definition
>> + #define CONFIG_SYS_THUMB_BUILD 1
>
> looks like this got run over by another Kconfig migration on march-18.
> New patches (migration + rock board) coming up shortly.

Thanks - what toolchain are you using to test this?

Regards,
Simon

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

Hi Heiko,

On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> Hi Heiko,
>
> On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
>> Hi Simon,
>>
>> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
>>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
>>> > The Rock is a RK3188 based single board computer by Radxa.
>>> > Currently it still relies on the proprietary DDR init and
>>> > cannot use the generic SPL, but at least is able to boot
>>> > a linux kernel and system up to a regular login prompt.
>>> >
>>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>>> > Reviewed-by: Simon Glass <sjg@chromium.org>
>>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
>>> > ---
>>> >  arch/arm/dts/Makefile                 |   1 +
>>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
>>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
>>> >  board/radxa/rock/Kconfig              |  15 ++
>>> >  board/radxa/rock/MAINTAINERS          |   6 +
>>> >  board/radxa/rock/Makefile             |   7 +
>>> >  board/radxa/rock/rock.c               |   7 +
>>> >  configs/rock_defconfig                |  58 ++++++
>>> >  include/configs/rock.h                |  30 +++
>>> >  9 files changed, 517 insertions(+)
>>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>>> >  create mode 100644 board/radxa/rock/Kconfig
>>> >  create mode 100644 board/radxa/rock/MAINTAINERS
>>> >  create mode 100644 board/radxa/rock/Makefile
>>> >  create mode 100644 board/radxa/rock/rock.c
>>> >  create mode 100644 configs/rock_defconfig
>>> >  create mode 100644 include/configs/rock.h
>>>
>>> I am still having trouble applying this patch. I get build errors:
>>>
>>>        arm:  +   rock
>>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
>>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>>> 'tpl/u-boot-tpl.dtb'.  Stop.
>>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>>> +make: *** [sub-make] Error 2
>>>     0    0    1 /1      rock
>>>
>>> Also there seems to be a duplicate config:
>>>
>>>        arm:  +   rock
>>> +In file included from include/configs/rock.h:11:0,
>>> +                 from include/config.h:5,
>>> +                 from include/common.h:21,
>>> +                 from arch/arm/lib/asm-offsets.c:15:
>>> + #define CONFIG_SYS_THUMB_BUILD
>>> + ^
>>> +                 from lib/asm-offsets.c:15:
>>> +In file included from include/linux/kconfig.h:4:0,
>>> +                 from <command-line>:0:
>>> +include/generated/autoconf.h:10:0: note: this is the location of the
>>> previous definition
>>> + #define CONFIG_SYS_THUMB_BUILD 1
>>
>> looks like this got run over by another Kconfig migration on march-18.
>> New patches (migration + rock board) coming up shortly.
>
> Thanks - what toolchain are you using to test this?

Also I am still getting this error:

 buildman rock$
boards.cfg is up to date. Nothing to do.
Building current source for 1 boards (1 thread, 8 jobs per thread)
       arm:  +   rock
+make[2]: *** No rule to make target 'dts/dt.dtb', needed by
'tpl/u-boot-tpl.dtb'.  Stop.
+make[1]: *** [tpl/u-boot-tpl.bin] Error 2
+make: *** [sub-make] Error 2
    0    0    1 /1      rock

Regards,
Simon

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
> Hi Heiko,
> 
> On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> > Hi Heiko,
> >
> > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> >> Hi Simon,
> >>
> >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> >>> > The Rock is a RK3188 based single board computer by Radxa.
> >>> > Currently it still relies on the proprietary DDR init and
> >>> > cannot use the generic SPL, but at least is able to boot
> >>> > a linux kernel and system up to a regular login prompt.
> >>> >
> >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> >>> > ---
> >>> >  arch/arm/dts/Makefile                 |   1 +
> >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> >>> >  board/radxa/rock/Kconfig              |  15 ++
> >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> >>> >  board/radxa/rock/Makefile             |   7 +
> >>> >  board/radxa/rock/rock.c               |   7 +
> >>> >  configs/rock_defconfig                |  58 ++++++
> >>> >  include/configs/rock.h                |  30 +++
> >>> >  9 files changed, 517 insertions(+)
> >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> >>> >  create mode 100644 board/radxa/rock/Kconfig
> >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> >>> >  create mode 100644 board/radxa/rock/Makefile
> >>> >  create mode 100644 board/radxa/rock/rock.c
> >>> >  create mode 100644 configs/rock_defconfig
> >>> >  create mode 100644 include/configs/rock.h
> >>>
> >>> I am still having trouble applying this patch. I get build errors:
> >>>
> >>>        arm:  +   rock
> >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> >>> +make: *** [sub-make] Error 2
> >>>     0    0    1 /1      rock
> >>>
> >>> Also there seems to be a duplicate config:
> >>>
> >>>        arm:  +   rock
> >>> +In file included from include/configs/rock.h:11:0,
> >>> +                 from include/config.h:5,
> >>> +                 from include/common.h:21,
> >>> +                 from arch/arm/lib/asm-offsets.c:15:
> >>> + #define CONFIG_SYS_THUMB_BUILD
> >>> + ^
> >>> +                 from lib/asm-offsets.c:15:
> >>> +In file included from include/linux/kconfig.h:4:0,
> >>> +                 from <command-line>:0:
> >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> >>> previous definition
> >>> + #define CONFIG_SYS_THUMB_BUILD 1
> >>
> >> looks like this got run over by another Kconfig migration on march-18.
> >> New patches (migration + rock board) coming up shortly.
> >
> > Thanks - what toolchain are you using to test this?
> 
> Also I am still getting this error:
> 
>  buildman rock$
> boards.cfg is up to date. Nothing to do.
> Building current source for 1 boards (1 thread, 8 jobs per thread)
>        arm:  +   rock
> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> 'tpl/u-boot-tpl.dtb'.  Stop.
> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> +make: *** [sub-make] Error 2
>     0    0    1 /1      rock

that is really strange.

I'm building with the armhf cross-compiler from Debian testing, which is

arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124

My git history also is up-to-date it seems:
14ef0b180b rockchip: rk3188: Add Radxa Rock board
d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
3bffe88d68 rockchip: video: Split out HDMI controller code
a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
903fae5666 rockchip: rk3188: Setup the armclk in spl
7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk

with 3bffe88d68 being your current head and my build commands being

make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-


Strangely the tpl shouldn't require a dtb at all, as it needs to use
OF_PLATDATA. Am I missing some config option somewhere?

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
> Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
> > Hi Heiko,
> > 
> > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> > > Hi Heiko,
> > >
> > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> > >> Hi Simon,
> > >>
> > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> > >>> > The Rock is a RK3188 based single board computer by Radxa.
> > >>> > Currently it still relies on the proprietary DDR init and
> > >>> > cannot use the generic SPL, but at least is able to boot
> > >>> > a linux kernel and system up to a regular login prompt.
> > >>> >
> > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> > >>> > ---
> > >>> >  arch/arm/dts/Makefile                 |   1 +
> > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> > >>> >  board/radxa/rock/Kconfig              |  15 ++
> > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> > >>> >  board/radxa/rock/Makefile             |   7 +
> > >>> >  board/radxa/rock/rock.c               |   7 +
> > >>> >  configs/rock_defconfig                |  58 ++++++
> > >>> >  include/configs/rock.h                |  30 +++
> > >>> >  9 files changed, 517 insertions(+)
> > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> > >>> >  create mode 100644 board/radxa/rock/Kconfig
> > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> > >>> >  create mode 100644 board/radxa/rock/Makefile
> > >>> >  create mode 100644 board/radxa/rock/rock.c
> > >>> >  create mode 100644 configs/rock_defconfig
> > >>> >  create mode 100644 include/configs/rock.h
> > >>>
> > >>> I am still having trouble applying this patch. I get build errors:
> > >>>
> > >>>        arm:  +   rock
> > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > >>> +make: *** [sub-make] Error 2
> > >>>     0    0    1 /1      rock
> > >>>
> > >>> Also there seems to be a duplicate config:
> > >>>
> > >>>        arm:  +   rock
> > >>> +In file included from include/configs/rock.h:11:0,
> > >>> +                 from include/config.h:5,
> > >>> +                 from include/common.h:21,
> > >>> +                 from arch/arm/lib/asm-offsets.c:15:
> > >>> + #define CONFIG_SYS_THUMB_BUILD
> > >>> + ^
> > >>> +                 from lib/asm-offsets.c:15:
> > >>> +In file included from include/linux/kconfig.h:4:0,
> > >>> +                 from <command-line>:0:
> > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> > >>> previous definition
> > >>> + #define CONFIG_SYS_THUMB_BUILD 1
> > >>
> > >> looks like this got run over by another Kconfig migration on march-18.
> > >> New patches (migration + rock board) coming up shortly.
> > >
> > > Thanks - what toolchain are you using to test this?
> > 
> > Also I am still getting this error:
> > 
> >  buildman rock$
> > boards.cfg is up to date. Nothing to do.
> > Building current source for 1 boards (1 thread, 8 jobs per thread)
> >        arm:  +   rock
> > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > 'tpl/u-boot-tpl.dtb'.  Stop.
> > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > +make: *** [sub-make] Error 2
> >     0    0    1 /1      rock
> 
> that is really strange.
> 
> I'm building with the armhf cross-compiler from Debian testing, which is
> 
> arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
> 
> My git history also is up-to-date it seems:
> 14ef0b180b rockchip: rk3188: Add Radxa Rock board
> d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
> 3bffe88d68 rockchip: video: Split out HDMI controller code
> a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
> 903fae5666 rockchip: rk3188: Setup the armclk in spl
> 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
> 
> with 3bffe88d68 being your current head and my build commands being
> 
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
> make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-

that also works with a "make mrproper" before everything else.


> Strangely the tpl shouldn't require a dtb at all, as it needs to use
> OF_PLATDATA. Am I missing some config option somewhere?

I also did play around a bit with buildman just now:

At first I forgot the "$" after rock, so build everything with rock in the
name and the radxarock failed because the somewhat old 4.9 toolchain
used seems to produce a TPL image that is over the size constraints.
I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .

When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
	tools/buildman/buildman -P rock
builds 14 boards and finishes sucessfully including the radxarock.


Now when I try buildman -P rock$ I seem to also get the error about the
missing dts/dt.dtb , which does not occur in my regular builds and also
not when building the bigger number of boards. I guess I need to figure
out what is different in that case.


Heiko

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Sonntag, 26. M채rz 2017, 22:41:35 CEST schrieb Heiko Stuebner:
> Am Sonntag, 26. M채rz 2017, 22:13:08 CEST schrieb Heiko Stuebner:
> > Am Sonntag, 26. M채rz 2017, 14:00:51 CEST schrieb Simon Glass:
> > > Hi Heiko,
> > > 
> > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> > > > Hi Heiko,
> > > >
> > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> > > >> Hi Simon,
> > > >>
> > > >> Am Samstag, 25. M채rz 2017, 20:39:08 CEST schrieb Simon Glass:
> > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> > > >>> > The Rock is a RK3188 based single board computer by Radxa.
> > > >>> > Currently it still relies on the proprietary DDR init and
> > > >>> > cannot use the generic SPL, but at least is able to boot
> > > >>> > a linux kernel and system up to a regular login prompt.
> > > >>> >
> > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> > > >>> > ---
> > > >>> >  arch/arm/dts/Makefile                 |   1 +
> > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> > > >>> >  board/radxa/rock/Kconfig              |  15 ++
> > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> > > >>> >  board/radxa/rock/Makefile             |   7 +
> > > >>> >  board/radxa/rock/rock.c               |   7 +
> > > >>> >  configs/rock_defconfig                |  58 ++++++
> > > >>> >  include/configs/rock.h                |  30 +++
> > > >>> >  9 files changed, 517 insertions(+)
> > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> > > >>> >  create mode 100644 board/radxa/rock/Kconfig
> > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> > > >>> >  create mode 100644 board/radxa/rock/Makefile
> > > >>> >  create mode 100644 board/radxa/rock/rock.c
> > > >>> >  create mode 100644 configs/rock_defconfig
> > > >>> >  create mode 100644 include/configs/rock.h
> > > >>>
> > > >>> I am still having trouble applying this patch. I get build errors:
> > > >>>
> > > >>>        arm:  +   rock
> > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > > >>> +make: *** [sub-make] Error 2
> > > >>>     0    0    1 /1      rock
> > > >>>
> > > >>> Also there seems to be a duplicate config:
> > > >>>
> > > >>>        arm:  +   rock
> > > >>> +In file included from include/configs/rock.h:11:0,
> > > >>> +                 from include/config.h:5,
> > > >>> +                 from include/common.h:21,
> > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
> > > >>> + #define CONFIG_SYS_THUMB_BUILD
> > > >>> + ^
> > > >>> +                 from lib/asm-offsets.c:15:
> > > >>> +In file included from include/linux/kconfig.h:4:0,
> > > >>> +                 from <command-line>:0:
> > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> > > >>> previous definition
> > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
> > > >>
> > > >> looks like this got run over by another Kconfig migration on march-18.
> > > >> New patches (migration + rock board) coming up shortly.
> > > >
> > > > Thanks - what toolchain are you using to test this?
> > > 
> > > Also I am still getting this error:
> > > 
> > >  buildman rock$
> > > boards.cfg is up to date. Nothing to do.
> > > Building current source for 1 boards (1 thread, 8 jobs per thread)
> > >        arm:  +   rock
> > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > > 'tpl/u-boot-tpl.dtb'.  Stop.
> > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > > +make: *** [sub-make] Error 2
> > >     0    0    1 /1      rock
> > 
> > that is really strange.
> > 
> > I'm building with the armhf cross-compiler from Debian testing, which is
> > 
> > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
> > 
> > My git history also is up-to-date it seems:
> > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
> > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
> > 3bffe88d68 rockchip: video: Split out HDMI controller code
> > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
> > 903fae5666 rockchip: rk3188: Setup the armclk in spl
> > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
> > 
> > with 3bffe88d68 being your current head and my build commands being
> > 
> > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
> > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
> > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> 
> that also works with a "make mrproper" before everything else.
> 
> 
> > Strangely the tpl shouldn't require a dtb at all, as it needs to use
> > OF_PLATDATA. Am I missing some config option somewhere?
> 
> I also did play around a bit with buildman just now:
> 
> At first I forgot the "$" after rock, so build everything with rock in the
> name and the radxarock failed because the somewhat old 4.9 toolchain
> used seems to produce a TPL image that is over the size constraints.
> I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
> 
> When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
> 	tools/buildman/buildman -P rock
> builds 14 boards and finishes sucessfully including the radxarock.
> 
> 
> Now when I try buildman -P rock$ I seem to also get the error about the
> missing dts/dt.dtb , which does not occur in my regular builds and also
> not when building the bigger number of boards. I guess I need to figure
> out what is different in that case.

sorry for spamming, but

also when entering .bm-work/rock where buildman failed and doing just my

	make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-

in that directory created by buildman, produces perfectly fine images.
(buildman does create the .config, so I'm just finishing the build, buildman
failed at for unknown reasons)


Heiko

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Sonntag, 26. März 2017, 22:52:16 CEST schrieb Heiko Stuebner:
> Am Sonntag, 26. März 2017, 22:41:35 CEST schrieb Heiko Stuebner:
> > Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
> > > Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
> > > > Hi Heiko,
> > > > 
> > > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> > > > > Hi Heiko,
> > > > >
> > > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> > > > >> Hi Simon,
> > > > >>
> > > > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> > > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> > > > >>> > The Rock is a RK3188 based single board computer by Radxa.
> > > > >>> > Currently it still relies on the proprietary DDR init and
> > > > >>> > cannot use the generic SPL, but at least is able to boot
> > > > >>> > a linux kernel and system up to a regular login prompt.
> > > > >>> >
> > > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> > > > >>> > ---
> > > > >>> >  arch/arm/dts/Makefile                 |   1 +
> > > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> > > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> > > > >>> >  board/radxa/rock/Kconfig              |  15 ++
> > > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> > > > >>> >  board/radxa/rock/Makefile             |   7 +
> > > > >>> >  board/radxa/rock/rock.c               |   7 +
> > > > >>> >  configs/rock_defconfig                |  58 ++++++
> > > > >>> >  include/configs/rock.h                |  30 +++
> > > > >>> >  9 files changed, 517 insertions(+)
> > > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> > > > >>> >  create mode 100644 board/radxa/rock/Kconfig
> > > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> > > > >>> >  create mode 100644 board/radxa/rock/Makefile
> > > > >>> >  create mode 100644 board/radxa/rock/rock.c
> > > > >>> >  create mode 100644 configs/rock_defconfig
> > > > >>> >  create mode 100644 include/configs/rock.h
> > > > >>>
> > > > >>> I am still having trouble applying this patch. I get build errors:
> > > > >>>
> > > > >>>        arm:  +   rock
> > > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> > > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> > > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > > > >>> +make: *** [sub-make] Error 2
> > > > >>>     0    0    1 /1      rock
> > > > >>>
> > > > >>> Also there seems to be a duplicate config:
> > > > >>>
> > > > >>>        arm:  +   rock
> > > > >>> +In file included from include/configs/rock.h:11:0,
> > > > >>> +                 from include/config.h:5,
> > > > >>> +                 from include/common.h:21,
> > > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
> > > > >>> + #define CONFIG_SYS_THUMB_BUILD
> > > > >>> + ^
> > > > >>> +                 from lib/asm-offsets.c:15:
> > > > >>> +In file included from include/linux/kconfig.h:4:0,
> > > > >>> +                 from <command-line>:0:
> > > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> > > > >>> previous definition
> > > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
> > > > >>
> > > > >> looks like this got run over by another Kconfig migration on march-18.
> > > > >> New patches (migration + rock board) coming up shortly.
> > > > >
> > > > > Thanks - what toolchain are you using to test this?
> > > > 
> > > > Also I am still getting this error:
> > > > 
> > > >  buildman rock$
> > > > boards.cfg is up to date. Nothing to do.
> > > > Building current source for 1 boards (1 thread, 8 jobs per thread)
> > > >        arm:  +   rock
> > > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> > > > 'tpl/u-boot-tpl.dtb'.  Stop.
> > > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> > > > +make: *** [sub-make] Error 2
> > > >     0    0    1 /1      rock
> > > 
> > > that is really strange.
> > > 
> > > I'm building with the armhf cross-compiler from Debian testing, which is
> > > 
> > > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
> > > 
> > > My git history also is up-to-date it seems:
> > > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
> > > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
> > > 3bffe88d68 rockchip: video: Split out HDMI controller code
> > > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
> > > 903fae5666 rockchip: rk3188: Setup the armclk in spl
> > > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
> > > 
> > > with 3bffe88d68 being your current head and my build commands being
> > > 
> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> > 
> > that also works with a "make mrproper" before everything else.
> > 
> > 
> > > Strangely the tpl shouldn't require a dtb at all, as it needs to use
> > > OF_PLATDATA. Am I missing some config option somewhere?
> > 
> > I also did play around a bit with buildman just now:
> > 
> > At first I forgot the "$" after rock, so build everything with rock in the
> > name and the radxarock failed because the somewhat old 4.9 toolchain
> > used seems to produce a TPL image that is over the size constraints.
> > I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
> > 
> > When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
> > 	tools/buildman/buildman -P rock
> > builds 14 boards and finishes sucessfully including the radxarock.
> > 
> > 
> > Now when I try buildman -P rock$ I seem to also get the error about the
> > missing dts/dt.dtb , which does not occur in my regular builds and also
> > not when building the bigger number of boards. I guess I need to figure
> > out what is different in that case.
> 
> sorry for spamming, but
> 
> also when entering .bm-work/rock where buildman failed and doing just my
> 
> 	make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> 
> in that directory created by buildman, produces perfectly fine images.
> (buildman does create the .config, so I'm just finishing the build, buildman
> failed at for unknown reasons)

and a 
	tools/buildman/buildman -PVv -T1 -j1 rock$

also finishes sucessfully, so it looks like that is more some sort of build
concurrency issue, with the platdata not being created in time for some
reason.

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

Hi Heiko,

On 26 March 2017 at 15:00, Heiko Stuebner <heiko@sntech.de> wrote:
> Am Sonntag, 26. März 2017, 22:52:16 CEST schrieb Heiko Stuebner:
>> Am Sonntag, 26. März 2017, 22:41:35 CEST schrieb Heiko Stuebner:
>> > Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
>> > > Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
>> > > > Hi Heiko,
>> > > >
>> > > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
>> > > > > Hi Heiko,
>> > > > >
>> > > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
>> > > > >> Hi Simon,
>> > > > >>
>> > > > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
>> > > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
>> > > > >>> > The Rock is a RK3188 based single board computer by Radxa.
>> > > > >>> > Currently it still relies on the proprietary DDR init and
>> > > > >>> > cannot use the generic SPL, but at least is able to boot
>> > > > >>> > a linux kernel and system up to a regular login prompt.
>> > > > >>> >
>> > > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> > > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
>> > > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
>> > > > >>> > ---
>> > > > >>> >  arch/arm/dts/Makefile                 |   1 +
>> > > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
>> > > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
>> > > > >>> >  board/radxa/rock/Kconfig              |  15 ++
>> > > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
>> > > > >>> >  board/radxa/rock/Makefile             |   7 +
>> > > > >>> >  board/radxa/rock/rock.c               |   7 +
>> > > > >>> >  configs/rock_defconfig                |  58 ++++++
>> > > > >>> >  include/configs/rock.h                |  30 +++
>> > > > >>> >  9 files changed, 517 insertions(+)
>> > > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>> > > > >>> >  create mode 100644 board/radxa/rock/Kconfig
>> > > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
>> > > > >>> >  create mode 100644 board/radxa/rock/Makefile
>> > > > >>> >  create mode 100644 board/radxa/rock/rock.c
>> > > > >>> >  create mode 100644 configs/rock_defconfig
>> > > > >>> >  create mode 100644 include/configs/rock.h
>> > > > >>>
>> > > > >>> I am still having trouble applying this patch. I get build errors:
>> > > > >>>
>> > > > >>>        arm:  +   rock
>> > > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
>> > > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>> > > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
>> > > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> > > > >>> +make: *** [sub-make] Error 2
>> > > > >>>     0    0    1 /1      rock
>> > > > >>>
>> > > > >>> Also there seems to be a duplicate config:
>> > > > >>>
>> > > > >>>        arm:  +   rock
>> > > > >>> +In file included from include/configs/rock.h:11:0,
>> > > > >>> +                 from include/config.h:5,
>> > > > >>> +                 from include/common.h:21,
>> > > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
>> > > > >>> + #define CONFIG_SYS_THUMB_BUILD
>> > > > >>> + ^
>> > > > >>> +                 from lib/asm-offsets.c:15:
>> > > > >>> +In file included from include/linux/kconfig.h:4:0,
>> > > > >>> +                 from <command-line>:0:
>> > > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
>> > > > >>> previous definition
>> > > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
>> > > > >>
>> > > > >> looks like this got run over by another Kconfig migration on march-18.
>> > > > >> New patches (migration + rock board) coming up shortly.
>> > > > >
>> > > > > Thanks - what toolchain are you using to test this?
>> > > >
>> > > > Also I am still getting this error:
>> > > >
>> > > >  buildman rock$
>> > > > boards.cfg is up to date. Nothing to do.
>> > > > Building current source for 1 boards (1 thread, 8 jobs per thread)
>> > > >        arm:  +   rock
>> > > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>> > > > 'tpl/u-boot-tpl.dtb'.  Stop.
>> > > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> > > > +make: *** [sub-make] Error 2
>> > > >     0    0    1 /1      rock
>> > >
>> > > that is really strange.
>> > >
>> > > I'm building with the armhf cross-compiler from Debian testing, which is
>> > >
>> > > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
>> > >
>> > > My git history also is up-to-date it seems:
>> > > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
>> > > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
>> > > 3bffe88d68 rockchip: video: Split out HDMI controller code
>> > > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
>> > > 903fae5666 rockchip: rk3188: Setup the armclk in spl
>> > > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
>> > >
>> > > with 3bffe88d68 being your current head and my build commands being
>> > >
>> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
>> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
>> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>> >
>> > that also works with a "make mrproper" before everything else.
>> >
>> >
>> > > Strangely the tpl shouldn't require a dtb at all, as it needs to use
>> > > OF_PLATDATA. Am I missing some config option somewhere?
>> >
>> > I also did play around a bit with buildman just now:
>> >
>> > At first I forgot the "$" after rock, so build everything with rock in the
>> > name and the radxarock failed because the somewhat old 4.9 toolchain
>> > used seems to produce a TPL image that is over the size constraints.
>> > I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
>> >
>> > When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
>> >     tools/buildman/buildman -P rock
>> > builds 14 boards and finishes sucessfully including the radxarock.
>> >
>> >
>> > Now when I try buildman -P rock$ I seem to also get the error about the
>> > missing dts/dt.dtb , which does not occur in my regular builds and also
>> > not when building the bigger number of boards. I guess I need to figure
>> > out what is different in that case.
>>
>> sorry for spamming, but
>>
>> also when entering .bm-work/rock where buildman failed and doing just my
>>
>>       make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>>
>> in that directory created by buildman, produces perfectly fine images.
>> (buildman does create the .config, so I'm just finishing the build, buildman
>> failed at for unknown reasons)
>
> and a
>         tools/buildman/buildman -PVv -T1 -j1 rock$
>
> also finishes sucessfully, so it looks like that is more some sort of build
> concurrency issue, with the platdata not being created in time for some
> reason.

Yes I think that is right. I will see if I can fix that.

Re the toolchain, if I pull in this patch then I will likely cause a
build breakable on common toolchains. What do you think is the best
option? Can the TPL be shrunk a little with gcc 4.9?

Regards,
Simon

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Sonntag, 26. März 2017, 15:28:44 CEST schrieb Simon Glass:
> Hi Heiko,
> 
> On 26 March 2017 at 15:00, Heiko Stuebner <heiko@sntech.de> wrote:
> > Am Sonntag, 26. März 2017, 22:52:16 CEST schrieb Heiko Stuebner:
> >> Am Sonntag, 26. März 2017, 22:41:35 CEST schrieb Heiko Stuebner:
> >> > Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
> >> > > Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
> >> > > > Hi Heiko,
> >> > > >
> >> > > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> >> > > > > Hi Heiko,
> >> > > > >
> >> > > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> >> > > > >> Hi Simon,
> >> > > > >>
> >> > > > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> >> > > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> >> > > > >>> > The Rock is a RK3188 based single board computer by Radxa.
> >> > > > >>> > Currently it still relies on the proprietary DDR init and
> >> > > > >>> > cannot use the generic SPL, but at least is able to boot
> >> > > > >>> > a linux kernel and system up to a regular login prompt.
> >> > > > >>> >
> >> > > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >> > > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >> > > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> >> > > > >>> > ---
> >> > > > >>> >  arch/arm/dts/Makefile                 |   1 +
> >> > > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> >> > > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> >> > > > >>> >  board/radxa/rock/Kconfig              |  15 ++
> >> > > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> >> > > > >>> >  board/radxa/rock/Makefile             |   7 +
> >> > > > >>> >  board/radxa/rock/rock.c               |   7 +
> >> > > > >>> >  configs/rock_defconfig                |  58 ++++++
> >> > > > >>> >  include/configs/rock.h                |  30 +++
> >> > > > >>> >  9 files changed, 517 insertions(+)
> >> > > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> >> > > > >>> >  create mode 100644 board/radxa/rock/Kconfig
> >> > > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> >> > > > >>> >  create mode 100644 board/radxa/rock/Makefile
> >> > > > >>> >  create mode 100644 board/radxa/rock/rock.c
> >> > > > >>> >  create mode 100644 configs/rock_defconfig
> >> > > > >>> >  create mode 100644 include/configs/rock.h
> >> > > > >>>
> >> > > > >>> I am still having trouble applying this patch. I get build errors:
> >> > > > >>>
> >> > > > >>>        arm:  +   rock
> >> > > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> >> > > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> >> > > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> >> > > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> >> > > > >>> +make: *** [sub-make] Error 2
> >> > > > >>>     0    0    1 /1      rock
> >> > > > >>>
> >> > > > >>> Also there seems to be a duplicate config:
> >> > > > >>>
> >> > > > >>>        arm:  +   rock
> >> > > > >>> +In file included from include/configs/rock.h:11:0,
> >> > > > >>> +                 from include/config.h:5,
> >> > > > >>> +                 from include/common.h:21,
> >> > > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD
> >> > > > >>> + ^
> >> > > > >>> +                 from lib/asm-offsets.c:15:
> >> > > > >>> +In file included from include/linux/kconfig.h:4:0,
> >> > > > >>> +                 from <command-line>:0:
> >> > > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> >> > > > >>> previous definition
> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
> >> > > > >>
> >> > > > >> looks like this got run over by another Kconfig migration on march-18.
> >> > > > >> New patches (migration + rock board) coming up shortly.
> >> > > > >
> >> > > > > Thanks - what toolchain are you using to test this?
> >> > > >
> >> > > > Also I am still getting this error:
> >> > > >
> >> > > >  buildman rock$
> >> > > > boards.cfg is up to date. Nothing to do.
> >> > > > Building current source for 1 boards (1 thread, 8 jobs per thread)
> >> > > >        arm:  +   rock
> >> > > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> >> > > > 'tpl/u-boot-tpl.dtb'.  Stop.
> >> > > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> >> > > > +make: *** [sub-make] Error 2
> >> > > >     0    0    1 /1      rock
> >> > >
> >> > > that is really strange.
> >> > >
> >> > > I'm building with the armhf cross-compiler from Debian testing, which is
> >> > >
> >> > > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
> >> > >
> >> > > My git history also is up-to-date it seems:
> >> > > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
> >> > > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
> >> > > 3bffe88d68 rockchip: video: Split out HDMI controller code
> >> > > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
> >> > > 903fae5666 rockchip: rk3188: Setup the armclk in spl
> >> > > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
> >> > >
> >> > > with 3bffe88d68 being your current head and my build commands being
> >> > >
> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >> >
> >> > that also works with a "make mrproper" before everything else.
> >> >
> >> >
> >> > > Strangely the tpl shouldn't require a dtb at all, as it needs to use
> >> > > OF_PLATDATA. Am I missing some config option somewhere?
> >> >
> >> > I also did play around a bit with buildman just now:
> >> >
> >> > At first I forgot the "$" after rock, so build everything with rock in the
> >> > name and the radxarock failed because the somewhat old 4.9 toolchain
> >> > used seems to produce a TPL image that is over the size constraints.
> >> > I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
> >> >
> >> > When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
> >> >     tools/buildman/buildman -P rock
> >> > builds 14 boards and finishes sucessfully including the radxarock.
> >> >
> >> >
> >> > Now when I try buildman -P rock$ I seem to also get the error about the
> >> > missing dts/dt.dtb , which does not occur in my regular builds and also
> >> > not when building the bigger number of boards. I guess I need to figure
> >> > out what is different in that case.
> >>
> >> sorry for spamming, but
> >>
> >> also when entering .bm-work/rock where buildman failed and doing just my
> >>
> >>       make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >>
> >> in that directory created by buildman, produces perfectly fine images.
> >> (buildman does create the .config, so I'm just finishing the build, buildman
> >> failed at for unknown reasons)
> >
> > and a
> >         tools/buildman/buildman -PVv -T1 -j1 rock$
> >
> > also finishes sucessfully, so it looks like that is more some sort of build
> > concurrency issue, with the platdata not being created in time for some
> > reason.
> 
> Yes I think that is right. I will see if I can fix that.
> 
> Re the toolchain, if I pull in this patch then I will likely cause a
> build breakable on common toolchains. What do you think is the best
> option? Can the TPL be shrunk a little with gcc 4.9?

I've added Tom for comments, executive summary:
- rk3188-tpl is size limited to 1020 bytes
- gcc 6.3 produces a rk3188-tpl of 792 bytes
- gcc 4.9 makes it 1020 bytes
- buildman seems to always use gcc-4.9
- rk3188 board does not compile with buildman


Isn't holding on to a pretty old compiler for everything somewhat
strange? ;-)


I think the recent memset change in commit
	c67c8c604b6c ("board_init.c: Always use memset()")
did hurt us the most sizewise, as we're now using the libgeneric memset
which is quite a bit bigger than the naive fallback that existed in
board_init.c before.

Reverting and using the naive memset again brings us down to 952 bytes
again even on gcc-4.9 .

I guess I could just remove the TPL_LIBGENERIC option again and provide
a similarly small/naive memset in the rk3188 tpl board?

################

Or maybe just check if the size limit in u-boot-spl.lds is actually correct.
In our example gcc-4.9 produces a 1020bytes result and the SPL_SIZE_LIMIT
is set to (0x400 - 0x4) = 1020, so of course doing

diff --git a/arch/arm/cpu/u-boot-spl.lds b/arch/arm/cpu/u-boot-spl.lds
index 068163b73a..c9643efd96 100644
--- a/arch/arm/cpu/u-boot-spl.lds
+++ b/arch/arm/cpu/u-boot-spl.lds
@@ -72,7 +72,7 @@ SECTIONS
 }
 
 #if defined(CONFIG_SPL_MAX_SIZE)
-ASSERT(__image_copy_end - __image_copy_start < (CONFIG_SPL_MAX_SIZE), \
+ASSERT(__image_copy_end - __image_copy_start <= (CONFIG_SPL_MAX_SIZE), \
        "SPL image too big");
 #endif
 
does look somewhat correct. But of course that rides way to much on the
edge when every additional byte will break the build.


Heiko

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

Hi Heiko,

On 26 March 2017 at 16:38, Heiko Stuebner <heiko@sntech.de> wrote:
> Am Sonntag, 26. März 2017, 15:28:44 CEST schrieb Simon Glass:
>> Hi Heiko,
>>
>> On 26 March 2017 at 15:00, Heiko Stuebner <heiko@sntech.de> wrote:
>> > Am Sonntag, 26. März 2017, 22:52:16 CEST schrieb Heiko Stuebner:
>> >> Am Sonntag, 26. März 2017, 22:41:35 CEST schrieb Heiko Stuebner:
>> >> > Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
>> >> > > Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
>> >> > > > Hi Heiko,
>> >> > > >
>> >> > > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
>> >> > > > > Hi Heiko,
>> >> > > > >
>> >> > > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
>> >> > > > >> Hi Simon,
>> >> > > > >>
>> >> > > > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
>> >> > > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
>> >> > > > >>> > The Rock is a RK3188 based single board computer by Radxa.
>> >> > > > >>> > Currently it still relies on the proprietary DDR init and
>> >> > > > >>> > cannot use the generic SPL, but at least is able to boot
>> >> > > > >>> > a linux kernel and system up to a regular login prompt.
>> >> > > > >>> >
>> >> > > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> >> > > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
>> >> > > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
>> >> > > > >>> > ---
>> >> > > > >>> >  arch/arm/dts/Makefile                 |   1 +
>> >> > > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
>> >> > > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
>> >> > > > >>> >  board/radxa/rock/Kconfig              |  15 ++
>> >> > > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
>> >> > > > >>> >  board/radxa/rock/Makefile             |   7 +
>> >> > > > >>> >  board/radxa/rock/rock.c               |   7 +
>> >> > > > >>> >  configs/rock_defconfig                |  58 ++++++
>> >> > > > >>> >  include/configs/rock.h                |  30 +++
>> >> > > > >>> >  9 files changed, 517 insertions(+)
>> >> > > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>> >> > > > >>> >  create mode 100644 board/radxa/rock/Kconfig
>> >> > > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
>> >> > > > >>> >  create mode 100644 board/radxa/rock/Makefile
>> >> > > > >>> >  create mode 100644 board/radxa/rock/rock.c
>> >> > > > >>> >  create mode 100644 configs/rock_defconfig
>> >> > > > >>> >  create mode 100644 include/configs/rock.h
>> >> > > > >>>
>> >> > > > >>> I am still having trouble applying this patch. I get build errors:
>> >> > > > >>>
>> >> > > > >>>        arm:  +   rock
>> >> > > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
>> >> > > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>> >> > > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
>> >> > > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> >> > > > >>> +make: *** [sub-make] Error 2
>> >> > > > >>>     0    0    1 /1      rock
>> >> > > > >>>
>> >> > > > >>> Also there seems to be a duplicate config:
>> >> > > > >>>
>> >> > > > >>>        arm:  +   rock
>> >> > > > >>> +In file included from include/configs/rock.h:11:0,
>> >> > > > >>> +                 from include/config.h:5,
>> >> > > > >>> +                 from include/common.h:21,
>> >> > > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
>> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD
>> >> > > > >>> + ^
>> >> > > > >>> +                 from lib/asm-offsets.c:15:
>> >> > > > >>> +In file included from include/linux/kconfig.h:4:0,
>> >> > > > >>> +                 from <command-line>:0:
>> >> > > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
>> >> > > > >>> previous definition
>> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
>> >> > > > >>
>> >> > > > >> looks like this got run over by another Kconfig migration on march-18.
>> >> > > > >> New patches (migration + rock board) coming up shortly.
>> >> > > > >
>> >> > > > > Thanks - what toolchain are you using to test this?
>> >> > > >
>> >> > > > Also I am still getting this error:
>> >> > > >
>> >> > > >  buildman rock$
>> >> > > > boards.cfg is up to date. Nothing to do.
>> >> > > > Building current source for 1 boards (1 thread, 8 jobs per thread)
>> >> > > >        arm:  +   rock
>> >> > > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
>> >> > > > 'tpl/u-boot-tpl.dtb'.  Stop.
>> >> > > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> >> > > > +make: *** [sub-make] Error 2
>> >> > > >     0    0    1 /1      rock
>> >> > >
>> >> > > that is really strange.
>> >> > >
>> >> > > I'm building with the armhf cross-compiler from Debian testing, which is
>> >> > >
>> >> > > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
>> >> > >
>> >> > > My git history also is up-to-date it seems:
>> >> > > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
>> >> > > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
>> >> > > 3bffe88d68 rockchip: video: Split out HDMI controller code
>> >> > > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
>> >> > > 903fae5666 rockchip: rk3188: Setup the armclk in spl
>> >> > > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
>> >> > >
>> >> > > with 3bffe88d68 being your current head and my build commands being
>> >> > >
>> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
>> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
>> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>> >> >
>> >> > that also works with a "make mrproper" before everything else.
>> >> >
>> >> >
>> >> > > Strangely the tpl shouldn't require a dtb at all, as it needs to use
>> >> > > OF_PLATDATA. Am I missing some config option somewhere?
>> >> >
>> >> > I also did play around a bit with buildman just now:
>> >> >
>> >> > At first I forgot the "$" after rock, so build everything with rock in the
>> >> > name and the radxarock failed because the somewhat old 4.9 toolchain
>> >> > used seems to produce a TPL image that is over the size constraints.
>> >> > I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
>> >> >
>> >> > When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
>> >> >     tools/buildman/buildman -P rock
>> >> > builds 14 boards and finishes sucessfully including the radxarock.
>> >> >
>> >> >
>> >> > Now when I try buildman -P rock$ I seem to also get the error about the
>> >> > missing dts/dt.dtb , which does not occur in my regular builds and also
>> >> > not when building the bigger number of boards. I guess I need to figure
>> >> > out what is different in that case.
>> >>
>> >> sorry for spamming, but
>> >>
>> >> also when entering .bm-work/rock where buildman failed and doing just my
>> >>
>> >>       make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
>> >>
>> >> in that directory created by buildman, produces perfectly fine images.
>> >> (buildman does create the .config, so I'm just finishing the build, buildman
>> >> failed at for unknown reasons)
>> >
>> > and a
>> >         tools/buildman/buildman -PVv -T1 -j1 rock$
>> >
>> > also finishes sucessfully, so it looks like that is more some sort of build
>> > concurrency issue, with the platdata not being created in time for some
>> > reason.
>>
>> Yes I think that is right. I will see if I can fix that.
>>
>> Re the toolchain, if I pull in this patch then I will likely cause a
>> build breakable on common toolchains. What do you think is the best
>> option? Can the TPL be shrunk a little with gcc 4.9?
>
> I've added Tom for comments, executive summary:
> - rk3188-tpl is size limited to 1020 bytes
> - gcc 6.3 produces a rk3188-tpl of 792 bytes
> - gcc 4.9 makes it 1020 bytes
> - buildman seems to always use gcc-4.9
> - rk3188 board does not compile with buildman
>
>
> Isn't holding on to a pretty old compiler for everything somewhat
> strange? ;-)

Well it's not that old. 4.6 would be old. We do need to be careful not
to drop old toolchains too aggressively, although for new platforms
such as this is doesn't matter. I try to test with older things to
avoid problems applying things to mainline (with Tom's automated
tests, etc.)

Regards,
Simon

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Tom Rini]

On Fri, Mar 31, 2017 at 10:24:07PM -0600, Simon Glass wrote:
> Hi Heiko,
> 
> On 26 March 2017 at 16:38, Heiko Stuebner <heiko@sntech.de> wrote:
> > Am Sonntag, 26. März 2017, 15:28:44 CEST schrieb Simon Glass:
> >> Hi Heiko,
> >>
> >> On 26 March 2017 at 15:00, Heiko Stuebner <heiko@sntech.de> wrote:
> >> > Am Sonntag, 26. März 2017, 22:52:16 CEST schrieb Heiko Stuebner:
> >> >> Am Sonntag, 26. März 2017, 22:41:35 CEST schrieb Heiko Stuebner:
> >> >> > Am Sonntag, 26. März 2017, 22:13:08 CEST schrieb Heiko Stuebner:
> >> >> > > Am Sonntag, 26. März 2017, 14:00:51 CEST schrieb Simon Glass:
> >> >> > > > Hi Heiko,
> >> >> > > >
> >> >> > > > On 26 March 2017 at 13:59, Simon Glass <sjg@chromium.org> wrote:
> >> >> > > > > Hi Heiko,
> >> >> > > > >
> >> >> > > > > On 26 March 2017 at 13:06, Heiko Stuebner <heiko@sntech.de> wrote:
> >> >> > > > >> Hi Simon,
> >> >> > > > >>
> >> >> > > > >> Am Samstag, 25. März 2017, 20:39:08 CEST schrieb Simon Glass:
> >> >> > > > >>> On 23 March 2017 at 17:41, Heiko Stuebner <heiko@sntech.de> wrote:
> >> >> > > > >>> > The Rock is a RK3188 based single board computer by Radxa.
> >> >> > > > >>> > Currently it still relies on the proprietary DDR init and
> >> >> > > > >>> > cannot use the generic SPL, but at least is able to boot
> >> >> > > > >>> > a linux kernel and system up to a regular login prompt.
> >> >> > > > >>> >
> >> >> > > > >>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >> >> > > > >>> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >> >> > > > >>> > Tested-by: Kever Yang <kever.yang@rock-chips.com>
> >> >> > > > >>> > ---
> >> >> > > > >>> >  arch/arm/dts/Makefile                 |   1 +
> >> >> > > > >>> >  arch/arm/dts/rk3188-radxarock.dts     | 382 ++++++++++++++++++++++++++++++++++
> >> >> > > > >>> >  arch/arm/mach-rockchip/rk3188/Kconfig |  11 +
> >> >> > > > >>> >  board/radxa/rock/Kconfig              |  15 ++
> >> >> > > > >>> >  board/radxa/rock/MAINTAINERS          |   6 +
> >> >> > > > >>> >  board/radxa/rock/Makefile             |   7 +
> >> >> > > > >>> >  board/radxa/rock/rock.c               |   7 +
> >> >> > > > >>> >  configs/rock_defconfig                |  58 ++++++
> >> >> > > > >>> >  include/configs/rock.h                |  30 +++
> >> >> > > > >>> >  9 files changed, 517 insertions(+)
> >> >> > > > >>> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> >> >> > > > >>> >  create mode 100644 board/radxa/rock/Kconfig
> >> >> > > > >>> >  create mode 100644 board/radxa/rock/MAINTAINERS
> >> >> > > > >>> >  create mode 100644 board/radxa/rock/Makefile
> >> >> > > > >>> >  create mode 100644 board/radxa/rock/rock.c
> >> >> > > > >>> >  create mode 100644 configs/rock_defconfig
> >> >> > > > >>> >  create mode 100644 include/configs/rock.h
> >> >> > > > >>>
> >> >> > > > >>> I am still having trouble applying this patch. I get build errors:
> >> >> > > > >>>
> >> >> > > > >>>        arm:  +   rock
> >> >> > > > >>> +arch/arm/Makefile:22: CONFIG_CPU_V7  -march=armv7-a
> >> >> > > > >>> +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> >> >> > > > >>> 'tpl/u-boot-tpl.dtb'.  Stop.
> >> >> > > > >>> +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> >> >> > > > >>> +make: *** [sub-make] Error 2
> >> >> > > > >>>     0    0    1 /1      rock
> >> >> > > > >>>
> >> >> > > > >>> Also there seems to be a duplicate config:
> >> >> > > > >>>
> >> >> > > > >>>        arm:  +   rock
> >> >> > > > >>> +In file included from include/configs/rock.h:11:0,
> >> >> > > > >>> +                 from include/config.h:5,
> >> >> > > > >>> +                 from include/common.h:21,
> >> >> > > > >>> +                 from arch/arm/lib/asm-offsets.c:15:
> >> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD
> >> >> > > > >>> + ^
> >> >> > > > >>> +                 from lib/asm-offsets.c:15:
> >> >> > > > >>> +In file included from include/linux/kconfig.h:4:0,
> >> >> > > > >>> +                 from <command-line>:0:
> >> >> > > > >>> +include/generated/autoconf.h:10:0: note: this is the location of the
> >> >> > > > >>> previous definition
> >> >> > > > >>> + #define CONFIG_SYS_THUMB_BUILD 1
> >> >> > > > >>
> >> >> > > > >> looks like this got run over by another Kconfig migration on march-18.
> >> >> > > > >> New patches (migration + rock board) coming up shortly.
> >> >> > > > >
> >> >> > > > > Thanks - what toolchain are you using to test this?
> >> >> > > >
> >> >> > > > Also I am still getting this error:
> >> >> > > >
> >> >> > > >  buildman rock$
> >> >> > > > boards.cfg is up to date. Nothing to do.
> >> >> > > > Building current source for 1 boards (1 thread, 8 jobs per thread)
> >> >> > > >        arm:  +   rock
> >> >> > > > +make[2]: *** No rule to make target 'dts/dt.dtb', needed by
> >> >> > > > 'tpl/u-boot-tpl.dtb'.  Stop.
> >> >> > > > +make[1]: *** [tpl/u-boot-tpl.bin] Error 2
> >> >> > > > +make: *** [sub-make] Error 2
> >> >> > > >     0    0    1 /1      rock
> >> >> > >
> >> >> > > that is really strange.
> >> >> > >
> >> >> > > I'm building with the armhf cross-compiler from Debian testing, which is
> >> >> > >
> >> >> > > arm-linux-gnueabihf-gcc (Debian 6.3.0-5) 6.3.0 20170124
> >> >> > >
> >> >> > > My git history also is up-to-date it seems:
> >> >> > > 14ef0b180b rockchip: rk3188: Add Radxa Rock board
> >> >> > > d0348986cc rockchip: rk3188: follow THUMB_BUILD Kconfig migration
> >> >> > > 3bffe88d68 rockchip: video: Split out HDMI controller code
> >> >> > > a188a5a35c rockchip: i2c: Add compatibles for Rockchip Cortex-A9 socs
> >> >> > > 903fae5666 rockchip: rk3188: Setup the armclk in spl
> >> >> > > 7957cc4bd0 rockchip: clk: rk3188: Allow configuration of the armclk
> >> >> > >
> >> >> > > with 3bffe88d68 being your current head and my build commands being
> >> >> > >
> >> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- clean
> >> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- rock_defconfig
> >> >> > > make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >> >> >
> >> >> > that also works with a "make mrproper" before everything else.
> >> >> >
> >> >> >
> >> >> > > Strangely the tpl shouldn't require a dtb at all, as it needs to use
> >> >> > > OF_PLATDATA. Am I missing some config option somewhere?
> >> >> >
> >> >> > I also did play around a bit with buildman just now:
> >> >> >
> >> >> > At first I forgot the "$" after rock, so build everything with rock in the
> >> >> > name and the radxarock failed because the somewhat old 4.9 toolchain
> >> >> > used seems to produce a TPL image that is over the size constraints.
> >> >> > I.e. 1020 bytes on 4.9 vs. 792 bytes on 6.3.0 .
> >> >> >
> >> >> > When I drop the SPL_MAX_SIZE from rk3188_common.h for the TPL build
> >> >> >     tools/buildman/buildman -P rock
> >> >> > builds 14 boards and finishes sucessfully including the radxarock.
> >> >> >
> >> >> >
> >> >> > Now when I try buildman -P rock$ I seem to also get the error about the
> >> >> > missing dts/dt.dtb , which does not occur in my regular builds and also
> >> >> > not when building the bigger number of boards. I guess I need to figure
> >> >> > out what is different in that case.
> >> >>
> >> >> sorry for spamming, but
> >> >>
> >> >> also when entering .bm-work/rock where buildman failed and doing just my
> >> >>
> >> >>       make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf-
> >> >>
> >> >> in that directory created by buildman, produces perfectly fine images.
> >> >> (buildman does create the .config, so I'm just finishing the build, buildman
> >> >> failed at for unknown reasons)
> >> >
> >> > and a
> >> >         tools/buildman/buildman -PVv -T1 -j1 rock$
> >> >
> >> > also finishes sucessfully, so it looks like that is more some sort of build
> >> > concurrency issue, with the platdata not being created in time for some
> >> > reason.
> >>
> >> Yes I think that is right. I will see if I can fix that.
> >>
> >> Re the toolchain, if I pull in this patch then I will likely cause a
> >> build breakable on common toolchains. What do you think is the best
> >> option? Can the TPL be shrunk a little with gcc 4.9?
> >
> > I've added Tom for comments, executive summary:
> > - rk3188-tpl is size limited to 1020 bytes
> > - gcc 6.3 produces a rk3188-tpl of 792 bytes
> > - gcc 4.9 makes it 1020 bytes
> > - buildman seems to always use gcc-4.9
> > - rk3188 board does not compile with buildman
> >
> >
> > Isn't holding on to a pretty old compiler for everything somewhat
> > strange? ;-)
> 
> Well it's not that old. 4.6 would be old. We do need to be careful not
> to drop old toolchains too aggressively, although for new platforms
> such as this is doesn't matter. I try to test with older things to
> avoid problems applying things to mainline (with Tom's automated
> tests, etc.)

wrt buildman using certain toolchains, it comes down to the order in
which it finds matches for a given arch and then it picks (and I don't
recall which off the top of my head) the first or last match.

I do agree that gcc-4.9 isn't something we can drop just yet (as for
example it's what'll be used in travis-ci today.  But it's getting
pretty long in the tooth and we will have to at some point say that
"platform X requires gcc-6.x or later" as we start running into hard
walls that are solved in 6.x.

Finally, I have no objection to adding TPL_USE_ARCH_MEMSET as an option
so that in cases like this it can be disabled due to space just as it is
on SPL.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170404/ae2c561c/attachment.sig>

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Heiko Stuebner]

Am Dienstag, 4. April 2017, 12:29:53 CEST schrieb Tom Rini:
> On Fri, Mar 31, 2017 at 10:24:07PM -0600, Simon Glass wrote:
> > On 26 March 2017 at 16:38, Heiko Stuebner <heiko@sntech.de> wrote:
> > > I've added Tom for comments, executive summary:
> > > - rk3188-tpl is size limited to 1020 bytes
> > > - gcc 6.3 produces a rk3188-tpl of 792 bytes
> > > - gcc 4.9 makes it 1020 bytes
> > > - buildman seems to always use gcc-4.9
> > > - rk3188 board does not compile with buildman
> > >
> > >
> > > Isn't holding on to a pretty old compiler for everything somewhat
> > > strange? ;-)
> > 
> > Well it's not that old. 4.6 would be old. We do need to be careful not
> > to drop old toolchains too aggressively, although for new platforms
> > such as this is doesn't matter. I try to test with older things to
> > avoid problems applying things to mainline (with Tom's automated
> > tests, etc.)
> 
> wrt buildman using certain toolchains, it comes down to the order in
> which it finds matches for a given arch and then it picks (and I don't
> recall which off the top of my head) the first or last match.
> 
> I do agree that gcc-4.9 isn't something we can drop just yet (as for
> example it's what'll be used in travis-ci today.  But it's getting
> pretty long in the tooth and we will have to at some point say that
> "platform X requires gcc-6.x or later" as we start running into hard
> walls that are solved in 6.x.
> 
> Finally, I have no objection to adding TPL_USE_ARCH_MEMSET as an option
> so that in cases like this it can be disabled due to space just as it is
> on SPL.

The problem wasn't ARCH_MEMSET - which already was way outsize the size
constraints, but the general memset also being somewhat big, with its
slight speed optimizations.

But thanks to Simon's recent patches [0] we got a really nice size-
reduction on the Rock's TPL (from 1020 to 488 bytes) . So with these
we're really good with all toolchains now.

Heiko


[0] https://www.mail-archive.com/u-boot at lists.denx.de/msg243443.html

[U-Boot] [PATCH 2/3] rockchip: rk3188: Add Radxa Rock board

[Simon Glass]

On 4 April 2017 at 11:06, Heiko Stuebner <heiko@sntech.de> wrote:
> Am Dienstag, 4. April 2017, 12:29:53 CEST schrieb Tom Rini:
>> On Fri, Mar 31, 2017 at 10:24:07PM -0600, Simon Glass wrote:
>> > On 26 March 2017 at 16:38, Heiko Stuebner <heiko@sntech.de> wrote:
>> > > I've added Tom for comments, executive summary:
>> > > - rk3188-tpl is size limited to 1020 bytes
>> > > - gcc 6.3 produces a rk3188-tpl of 792 bytes
>> > > - gcc 4.9 makes it 1020 bytes
>> > > - buildman seems to always use gcc-4.9
>> > > - rk3188 board does not compile with buildman
>> > >
>> > >
>> > > Isn't holding on to a pretty old compiler for everything somewhat
>> > > strange? ;-)
>> >
>> > Well it's not that old. 4.6 would be old. We do need to be careful not
>> > to drop old toolchains too aggressively, although for new platforms
>> > such as this is doesn't matter. I try to test with older things to
>> > avoid problems applying things to mainline (with Tom's automated
>> > tests, etc.)
>>
>> wrt buildman using certain toolchains, it comes down to the order in
>> which it finds matches for a given arch and then it picks (and I don't
>> recall which off the top of my head) the first or last match.
>>
>> I do agree that gcc-4.9 isn't something we can drop just yet (as for
>> example it's what'll be used in travis-ci today.  But it's getting
>> pretty long in the tooth and we will have to at some point say that
>> "platform X requires gcc-6.x or later" as we start running into hard
>> walls that are solved in 6.x.
>>
>> Finally, I have no objection to adding TPL_USE_ARCH_MEMSET as an option
>> so that in cases like this it can be disabled due to space just as it is
>> on SPL.
>
> The problem wasn't ARCH_MEMSET - which already was way outsize the size
> constraints, but the general memset also being somewhat big, with its
> slight speed optimizations.
>
> But thanks to Simon's recent patches [0] we got a really nice size-
> reduction on the Rock's TPL (from 1020 to 488 bytes) . So with these
> we're really good with all toolchains now.
>
> Heiko
>
>
> [0] https://www.mail-archive.com/u-boot at lists.denx.de/msg243443.html

Well, hopefully for the last time, this patch:

Applied to u-boot-rockchip, thanks!