From: Chunguang Xu <brookxu.cn@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH v2 7/8] ext4: delete invalid code inside ext4_xattr_block_set()
Date: Mon, 19 Oct 2020 17:02:37 +0800 [thread overview]
Message-ID: <1603098158-30406-7-git-send-email-brookxu@tencent.com> (raw)
In-Reply-To: <1603098158-30406-1-git-send-email-brookxu@tencent.com>
Delete invalid code inside ext4_xattr_block_set().
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
---
fs/ext4/xattr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index cba4b87..56728f3 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1927,7 +1927,6 @@ struct ext4_xattr_block_find {
} else {
/* Allocate a buffer where we construct the new block. */
s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
- /* assert(header == s->base) */
error = -ENOMEM;
if (s->base == NULL)
goto cleanup;
--
1.8.3.1
next prev parent reply other threads:[~2020-10-19 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 9:02 [PATCH v2 1/8] ext4: use ASSERT() to replace J_ASSERT() Chunguang Xu
2020-10-19 9:02 ` [PATCH v2 2/8] ext4: remove redundant mb_regenerate_buddy() Chunguang Xu
2020-10-19 9:02 ` [PATCH v2 3/8] ext4: simplify the code of mb_find_order_for_block Chunguang Xu
2020-10-19 9:02 ` [PATCH v2 4/8] ext4: add the gdt block of meta_bg to system_zone Chunguang Xu
2020-10-19 9:02 ` [PATCH v2 5/8] ext4: update ext4_data_block_valid related comments Chunguang Xu
2020-10-19 9:02 ` [PATCH v2 6/8] ext4: add a helper function to validate metadata block Chunguang Xu
2020-10-19 9:02 ` Chunguang Xu [this message]
2020-10-19 9:02 ` [PATCH v2 8/8] ext4: fix a memory leak of ext4_free_data Chunguang Xu
2020-10-20 3:37 ` [PATCH v2 1/8] ext4: use ASSERT() to replace J_ASSERT() Andreas Dilger
2020-10-20 5:03 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603098158-30406-7-git-send-email-brookxu@tencent.com \
--to=brookxu.cn@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.