From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Reject 90/270 degree rotated initial fbs
Date: Tue, 20 Oct 2020 22:09:15 +0100 [thread overview]
Message-ID: <160322815540.17091.3501283187261356616@build.alporthouse.com> (raw)
In-Reply-To: <20201020194330.28568-1-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2020-10-20 20:43:29)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't currently handle the initial fb readout correctly
> for 90/270 degree rotated scanout. Reject it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 60bacdbe7f92..fd0103f6cc95 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -10696,6 +10696,10 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
> val & PLANE_CTL_FLIP_HORIZONTAL)
> plane_config->rotation |= DRM_MODE_REFLECT_X;
>
> + /* 90/270 degree rotation would require extra work */
> + if (drm_rotation_90_or_270(plane_config->rotation))
> + goto error;
Only skl+ have 90/270 rotation so i9xx_get_initial_plane_config() does
not require the check.
error: seems valid
And as evidenced by the next patch, plenty needs to be done to handle
90/270.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
I expect you intend cc:stable for sanity?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-20 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:43 [Intel-gfx] [PATCH 1/2] drm/i915: Reject 90/270 degree rotated initial fbs Ville Syrjala
2020-10-20 19:43 ` [Intel-gfx] [PATCH 2/2] drm/i915: Try to handle 90/270 degree rotated initial fb Ville Syrjala
2020-10-20 21:12 ` Chris Wilson
2020-10-21 13:22 ` Ville Syrjälä
2020-10-20 20:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Reject 90/270 degree rotated initial fbs Patchwork
2020-10-20 21:09 ` Chris Wilson [this message]
2020-10-20 23:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160322815540.17091.3501283187261356616@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.