From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/8] Dynamic RSS Configuration for Bonding
Date: Mon, 13 Jul 2015 13:03:21 +0200
Message-ID: <1604538.YavAJG9xMg@xps13>
References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com>
 <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <5593BB53.2060204@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id BF0863239
 for <dev@dpdk.org>; Mon, 13 Jul 2015 13:04:34 +0200 (CEST)
Received: by widic2 with SMTP id ic2so9039008wid.0
 for <dev@dpdk.org>; Mon, 13 Jul 2015 04:04:34 -0700 (PDT)
In-Reply-To: <5593BB53.2060204@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-01 11:05, Declan Doherty:
> On 29/06/15 15:50, Tomasz Kulasek wrote:
> > OVERVIEW
> > --------
> > 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS makes bonding
> > device fully RSS-capable, so all slaves are synchronized with its configuration.
> > This mode is intended to provide RSS configuration as known from "dynamic RSS
> > configuration for one port" and made slaves transparent for client application
> > implementation.
> >
> > 2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, slaves are not
> > synchronized. That provides an ability to configure them manually. This mode may
> > be useful when application wants to manage RSS in an unusual way and the
> > consistency of RSS configuration for slaves isn't required.
> >
> > Turning on/off RSS mode for slaves when bonding is started is not possible.
> > Other RSS configuration is propagated over slaves, when bonding device API is
> > used to do it.
> >
> > v3 changes:
> >   - checkpatch cleanups
> ...
> 
> Acked-by : Declan Doherty <declan.doherty@intel.com>

Applied without patches 5 and 6:

- As discussed earlier, patch 5 workaround a missing flag to announce stats
per queue availability.

- Patch 6 introduce a new dependency (ncurses) to build a new bond_rss example.
Examples are useful to show how to use some features. Maybe you can show
bonding RSS in the existing bonding example without adding bells and whistles.
The example directory must be kept reasonnably maintainable.