From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH maint v2 4/4] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh
Date: Thu, 10 Sep 2020 11:32:08 +0200 [thread overview]
Message-ID: <1604713.itQ50Tx4xl@prime> (raw)
In-Reply-To: <20200909152756.GD2391@otheros>
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
On Wednesday, September 9, 2020 5:27:56 PM CEST Linus Lüssing wrote:
> On Wed, Sep 09, 2020 at 02:15:51PM +0200, Simon Wunderlich wrote:
> > On Friday, September 4, 2020 8:28:03 PM CEST Linus Lüssing wrote:
> > > @@ -1626,7 +1626,8 @@ bool batadv_bla_check_bcast_duplist(struct
> > > batadv_priv *bat_priv, if (entry->crc != crc)
> > >
> > > continue;
> > >
> > > - if (batadv_compare_eth(entry->orig, bcast_packet->orig))
> > > + if (!is_zero_ether_addr(entry->orig) &&
> > > + batadv_compare_eth(entry->orig, orig))
> > >
> > > continue;
> > >
> > > /* this entry seems to match: same crc, not too old,
> >
> > Shouldn't this check also be skipped if the orig parameter is a zero mac
> > address? i.e.:
> >
> > if (!is_zero_ether_addr(orig)) {
> >
> > if (!is_zero_ether_addr(entry->orig) && batadv_compare_eth(entry->orig,
> >
> > orig))
> >
> > continue;
> >
> > }
>
> Would be redundant. If entry->orig is non-zero and
> the compare_eth() says they are equal, then orig must also be
> non-zero.
OK good point, that's not really obvious (at least to me).
>
> I initially wanted to leave the code as unchanged as possible for
> net / maint. Should I do the restructuring to enhance readability, with
> the bool in this patch or in additional patch for net-next?
Personally, I would prefer having a bit more readability or verbose comments
in front of those kind of logic if statements. Or avoid those logic
connections and have multiple "ifs" in a row where possible to enhance
readbility.
This patch is pretty heavy already as is, adding a bool doesn't make a big
difference IMHO.
Cheers,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-10 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 18:27 [PATCH maint v2 0/4] batman-adv: mcast: TT/BLA fixes Linus Lüssing
2020-09-04 18:28 ` [PATCH maint v2 1/4] batman-adv: mcast/TT: fix wrongly dropped or rerouted packets Linus Lüssing
2020-09-09 11:50 ` Simon Wunderlich
2020-09-04 18:28 ` [PATCH maint v2 2/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN Linus Lüssing
2020-09-09 11:38 ` Simon Wunderlich
2020-09-04 18:28 ` [PATCH maint v2 3/4] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh Linus Lüssing
2020-09-05 7:14 ` Sven Eckelmann
2020-09-09 12:06 ` Simon Wunderlich
2020-09-09 14:53 ` Linus Lüssing
2020-09-09 15:03 ` Linus Lüssing
2020-09-09 20:14 ` Linus Lüssing
2020-09-10 9:34 ` Simon Wunderlich
2020-09-04 18:28 ` [PATCH maint v2 4/4] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh Linus Lüssing
2020-09-09 12:15 ` Simon Wunderlich
2020-09-09 15:27 ` Linus Lüssing
2020-09-10 9:32 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604713.itQ50Tx4xl@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.