From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E7AC388F7 for ; Fri, 13 Nov 2020 13:28:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7B0D2085B for ; Fri, 13 Nov 2020 13:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7B0D2085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A8EF6E4D4; Fri, 13 Nov 2020 13:28:56 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24A726E4D4 for ; Fri, 13 Nov 2020 13:28:53 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 22983520-1500050 for multiple; Fri, 13 Nov 2020 13:28:26 +0000 MIME-Version: 1.0 In-Reply-To: <20201113132510.2298483-1-tvrtko.ursulin@linux.intel.com> References: <20201113132510.2298483-1-tvrtko.ursulin@linux.intel.com> From: Chris Wilson To: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin Date: Fri, 13 Nov 2020 13:28:25 +0000 Message-ID: <160527410568.29612.11507482692981664548@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Avoid memory leak with more than 16 workarounds on a list X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Tvrtko Ursulin (2020-11-13 13:25:10) > From: Tvrtko Ursulin > > I forgot to free the old list when growing past 16 entries. > > Luckily, as much as I checked, none of the current platforms has more than > 16 workarounds on a single list. And I couldn't see any magics, such as the first wal->list being embedded, so it looks straightforward. > Signed-off-by: Tvrtko Ursulin > Fixes: 452420d22d5b ("drm/i915: Fuse per-context workaround handling with the common framework") > Reported-by: Chris Wilson Reviewed-by: Chris Wilson -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx