From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA7BC5519F for ; Mon, 16 Nov 2020 10:49:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DC532068D for ; Mon, 16 Nov 2020 10:49:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DC532068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BD1A8825E; Mon, 16 Nov 2020 10:49:51 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 770FE8825E for ; Mon, 16 Nov 2020 10:49:50 +0000 (UTC) IronPort-SDR: z98QuUP3GEURQ7U9kKY/fKn/7TG8m926AtevV40x7Gqumwn+4b57HUE4+qi5BOsyK4nBERJWC+ YdNfk86zCwWw== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="157753360" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="157753360" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 02:49:49 -0800 IronPort-SDR: PLFPEsGMuZSUvWcCY0vRcjrbaGbKRs+1H67PZ+7TbSzR1iIEPBl/zuRpfVZRdO+RbelVU6PfD9 jgG33Hjm8OwQ== X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="475480527" Received: from joejam1x-mobl.ger.corp.intel.com (HELO localhost) ([10.252.3.39]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 02:49:47 -0800 MIME-Version: 1.0 In-Reply-To: <20201115210815.5272-22-sean.z.huang@intel.com> References: <20201115210815.5272-1-sean.z.huang@intel.com> <20201115210815.5272-22-sean.z.huang@intel.com> To: "Huang, Sean Z" , Intel-gfx@lists.freedesktop.org From: Joonas Lahtinen Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID: <160552378493.10586.12498711265507162036@jlahtine-mobl.ger.corp.intel.com> User-Agent: alot/0.8.1 Date: Mon, 16 Nov 2020 12:49:45 +0200 Subject: Re: [Intel-gfx] [PATCH 22/27] drm/i915/pxp: Expose session state for display protection flip X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Huang, Sean Z (2020-11-15 23:08:10) > Implement the intel_pxp_gem_object_status() to allow ring0 i915 > display querying the current PXP session state. In the design, > ring0 display should not perform protection flip on the protected > buffers if there is no PXP session alive. No users for this code? Dead code should not be included. If this is only to be used by following patches, it should only be included at that point. It's better to introduce the code in the same patch that uses it, to make review easier. Regards, Joonas > Signed-off-by: Huang, Sean Z > --- > drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++++++ > drivers/gpu/drm/i915/pxp/intel_pxp.h | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c > index 44d17ae27b94..05fe143675b1 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c > @@ -334,3 +334,11 @@ void intel_pxp_irq_handler(struct intel_gt *gt, u16 iir) > end: > return; > } > + > +bool intel_pxp_gem_object_status(struct drm_i915_private *i915, u64 gem_object_metadata) > +{ > + if (i915->pxp.r0ctx && i915->pxp.r0ctx->flag_display_hm_surface_keys) > + return true; > + else > + return false; > +} > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h b/drivers/gpu/drm/i915/pxp/intel_pxp.h > index c0119ccdab08..eb0e548ce434 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp.h > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.h > @@ -111,4 +111,6 @@ int i915_pxp_global_terminate_complete_callback(struct drm_i915_private *i915); > int intel_pxp_init(struct drm_i915_private *i915); > void intel_pxp_uninit(struct drm_i915_private *i915); > > +bool intel_pxp_gem_object_status(struct drm_i915_private *i915, u64 gem_object_metadata); > + > #endif > -- > 2.17.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx