From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686B0C5519F for ; Mon, 16 Nov 2020 10:53:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D197D20781 for ; Mon, 16 Nov 2020 10:53:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D197D20781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14B1589DED; Mon, 16 Nov 2020 10:53:12 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59B0C89DED for ; Mon, 16 Nov 2020 10:53:09 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23004009-1500050 for multiple; Mon, 16 Nov 2020 10:53:00 +0000 MIME-Version: 1.0 In-Reply-To: <160552214303.10586.7473931663804369779@jlahtine-mobl.ger.corp.intel.com> References: <20201115210815.5272-1-sean.z.huang@intel.com> <20201115210815.5272-5-sean.z.huang@intel.com> <160552214303.10586.7473931663804369779@jlahtine-mobl.ger.corp.intel.com> From: Chris Wilson To: "Huang, Sean Z" , Intel-gfx@lists.freedesktop.org, Joonas Lahtinen Date: Mon, 16 Nov 2020 10:53:01 +0000 Message-ID: <160552398177.29277.12717240770735377320@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 05/27] drm/i915/pxp: Enable ioctl action to set the ring3 context X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Joonas Lahtinen (2020-11-16 10:22:23) > Quoting Huang, Sean Z (2020-11-15 23:07:53) > > Enable one ioctl action to allow ring3 driver to set its ring3 > > context, so ring0 PXP can track the context id through this ring3 > > context list. > > Overall the patches should refer to "userspace" not "ring3" to avoid > confusion. "kernel" vs "user" not ring0 vs ring3. There's also a missing chunk as to why this is not associated with the existing user context, rather than introducing a new incomplete encapsulation. Overall, you've left in an awful lot of debug code and failed to follow the coding style. A confusion as to whether your hw interactions is on the GT or the whole device (it's GT). Wrt the flow of the patches, robust setup and termination must be early in the series, not tacked onto the end. And you seem to confuse the kernel contexts as something special, you use them as non-privileged, just like ordinary userspace. Do not use the engine->kernel_context! You risk breaking (and judging from the waits you do add, it is inevitable that you have broken) power management and heartbeats. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx