From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABFCC64E7A for ; Tue, 17 Nov 2020 09:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F075724686 for ; Tue, 17 Nov 2020 09:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="U5lIN4U/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727321AbgKQJwz (ORCPT ); Tue, 17 Nov 2020 04:52:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:36142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727267AbgKQJwz (ORCPT ); Tue, 17 Nov 2020 04:52:55 -0500 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63F282168B; Tue, 17 Nov 2020 09:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605606774; bh=ggnpr+O+ulhNOCccALoUri6Fk2ZyffMjTgWfEg9lRbQ=; h=From:To:Cc:Subject:Date:From; b=U5lIN4U/6Nvt8rRibv0Eri3jJoY2wtKi1eIkQLY1G7SpkHiYjJq+pmJ2CQnORIhJI JVHC/MuM3RJcmQQydgVQsHWduk/tMlU8LmxnU6JyYFbhKs1Xp0mRlGuVEvyE4NuY6t MpUvf1VQeLb7VnerhcJWgZcyDLlToI8ypsmlnsTQ= From: Masami Hiramatsu To: Steven Rostedt , Linus Torvalds Cc: Chen Yu , Chen Yu , Masami Hiramatsu , LKML , Ingo Molnar , Jonathan Corbet Subject: [PATCH v3 0/3] tools/bootconfig: Align the bootconfig applied initrd Date: Tue, 17 Nov 2020 18:52:49 +0900 Message-Id: <160560676899.144950.4148778261999789656.stgit@devnote2> X-Mailer: git-send-email 2.25.1 User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is the 3rd version of the bootconfig tool update to align the total size of initrd + bootconfig to 4. Previous version is here; https://lkml.kernel.org/r/160554375807.96595.16142008590130221699.stgit@devnote2 This version adds a new partial-write fix patch as [1/3], and update main patch [2/3] by unifying writeU) and check write error correctly as Linus pointed. To adjust the file size, the bootconfig tool adds padding null characters in between the boot configuration data and the footer. The changing points are - The bootconfig applied initrd image size is aligned to 4. - To insert the padding null ('\0') bytes, the size in the footer can be bigger than the actual bootconfig file size. - But the max size of the boot configuration file is same, because the max size doesn't include the last null characters. In this series I keep 4 bytes aligned instead of longer size, because only I could found was that the grub might align the initrd filesize to 4, and U-Boot/EDK2 would not change it. So I couldn't say what is the best size. Anyway, I updated the documentation too, which clearly says that the above changing points, and if the bootloader pass the wrong size, kernel will not find bootconfig from the initrd. Thank you, --- Masami Hiramatsu (3): tools/bootconfig: Fix to check the write failure correctly tools/bootconfig: Align the bootconfig applied initrd image size to 4 docs: bootconfig: Update file format on initrd image Documentation/admin-guide/bootconfig.rst | 18 +++++++-- include/linux/bootconfig.h | 1 + tools/bootconfig/main.c | 57 ++++++++++++++++++++++-------- tools/bootconfig/test-bootconfig.sh | 6 +++ 4 files changed, 60 insertions(+), 22 deletions(-) -- Masami Hiramatsu (Linaro)