All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dfaggioli@suse.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH] Fix `make -jN trace-cmd gui`
Date: Tue, 17 Nov 2020 21:16:45 +0000	[thread overview]
Message-ID: <160564780533.18208.2518938894299815863.stgit@toolbox-dario-user-work> (raw)

Doing `make -j8 trace-cmd gui` fails like this:

  CMake Error at build/FindTraceCmd.cmake:110 (MESSAGE):

    Could not find libtraceevent!

  Call Stack (most recent call first):
    CMakeLists.txt:24 (include)

Or like this:

  CMake Error at build/FindTraceCmd.cmake:64 (MESSAGE):

    Could not find trace-cmd!

  Call Stack (most recent call first):
    CMakeLists.txt:20 (include)

That's because we need `trace-cmd` to have finished
building before starting to build `gui`.

Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
---
 Makefile |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b034042..c8d1e02 100644
--- a/Makefile
+++ b/Makefile
@@ -301,7 +301,9 @@ BUILD_TYPE ?= RelWithDebInfo
 $(kshark-dir)/build/Makefile: $(kshark-dir)/CMakeLists.txt
 	$(Q) cd $(kshark-dir)/build && $(CMAKE_COMMAND) -DCMAKE_BUILD_TYPE=$(BUILD_TYPE) -D_INSTALL_PREFIX=$(prefix) -D_LIBDIR=$(libdir) ..
 
-gui: force $(CMD_TARGETS) $(kshark-dir)/build/Makefile
+gui: force
+	$(MAKE) $(CMD_TARGETS)
+	$(MAKE) $(kshark-dir)/build/Makefile
 	$(Q)$(MAKE) $(S) -C $(kshark-dir)/build
 	@echo "gui build complete"
 	@echo "  kernelshark located at $(kshark-dir)/bin"



             reply	other threads:[~2020-11-17 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 21:16 Dario Faggioli [this message]
2020-11-20  3:09 ` [PATCH] Fix `make -jN trace-cmd gui` Steven Rostedt
2020-11-20 12:06   ` Dario Faggioli
2020-11-20 12:32     ` Yordan Karadzhov (VMware)
2020-11-20 13:43       ` Accuracy of traces sync [Was: Re: [PATCH] Fix `make -jN trace-cmd gui`] Dario Faggioli
2020-11-20 14:08         ` Steven Rostedt
2020-11-26  0:15           ` Dario Faggioli
2020-11-26  3:53             ` Tzvetomir Stoyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160564780533.18208.2518938894299815863.stgit@toolbox-dario-user-work \
    --to=dfaggioli@suse.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.