All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-24 11:57 ` Maarten Lankhorst
  0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-24 11:57 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx, Maarten Lankhorst, stable, Niranjana Vishwanathapura

We hardcode the maximum number of shared fences to 4, instead of
respecting num_fences. Use a minimum of 4, but more if num_fences
is higher.

This seems to have been an oversight when first implementing the
api.

Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
Cc: <stable@vger.kernel.org> # v3.17+
Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/dma-buf/dma-resv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index bb5a42b10c29..6ddbeb5dfbf6 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -200,7 +200,7 @@ int dma_resv_reserve_shared(struct dma_resv *obj, unsigned int num_fences)
 			max = max(old->shared_count + num_fences,
 				  old->shared_max * 2);
 	} else {
-		max = 4;
+		max = max(4ul, roundup_pow_of_two(num_fences));
 	}
 
 	new = dma_resv_list_alloc(max);

base-commit: d08ea807a6466f311fe921872bc18cfc384ae281
prerequisite-patch-id: 67ededd6181f1f0d00b98376bcacefb776ebfd1b
prerequisite-patch-id: 36ea30085b8b6095303642e82a6d9c2373d331c2
prerequisite-patch-id: 453c3fe559333daea47bc5d24171b32ae8483c2d
prerequisite-patch-id: 3792e6478845da3a19dda5fdca5d094d3847c6e3
prerequisite-patch-id: 7d4e280d1197ead2e3f90d10d0c38c4685bedd86
prerequisite-patch-id: 6db8468aba0d92cd5d67af028caebe4146b9f02e
prerequisite-patch-id: 6550921ad75aaa9ddd30db6a75878d06c13ab6bb
prerequisite-patch-id: 35cfae6d6d6c30453026284fc2b25733f005f950
prerequisite-patch-id: 3bf03aa3ed1532d6c67fa47cec3ba34418ea5a79
prerequisite-patch-id: 580e28da7a0e724c293eb5b36a35be0964554885
prerequisite-patch-id: 61932497d71dc764e040deea7a58286dca51a6e0
prerequisite-patch-id: b3f6ac925fd9f3517e63b0595ce138fdd0196db2
prerequisite-patch-id: 609d83e906e26c4d9c0fb5ba29f66eec0234d11b
prerequisite-patch-id: 88264df437b404b00bba07edb7761762c52daa9d
prerequisite-patch-id: 2d3d4efeb0e32423938d546a683513ee8077143e
prerequisite-patch-id: 675d46b64f98322e8ab90b947598d030f1133120
prerequisite-patch-id: fbd3c4bf0ea604f9ab30aa21f28fb26b953f8889
prerequisite-patch-id: d51e789c6ddc37cb65b6e49aaf567ba2a6168841
prerequisite-patch-id: 1e05b33595d37f01087a82f11344b0e3cca2580a
prerequisite-patch-id: 64151f1e9a5ae900c09322ef2bade0e1dad06568
prerequisite-patch-id: af71a3e75f28e0ee92721491b27f260500567d92
prerequisite-patch-id: 30c6b42d4bd39703a865ee9ebce41d986a803ce4
prerequisite-patch-id: 15a26c36a233ee3f738faa4a666b4f9c8749494d
prerequisite-patch-id: 9733d60910fb3e14ba5caa2eecc97a8c50592d7d
prerequisite-patch-id: b7b484c19e966041b39b7e3f089e9fb407c0b641
prerequisite-patch-id: dd2adee5d7c941363193ad4033f419ca8f535b69
prerequisite-patch-id: 89142874b57f3120e4dcdefd7e40168766fc7f52
prerequisite-patch-id: df6983cc3366963afb6e4229cddd5b1a42406e3c
prerequisite-patch-id: 7d90d37f7e7545c5710ebdbd3db9967c1d1b5b4d
prerequisite-patch-id: 07041f82bdb5a5f886dd13a0a6a27b66d06d17c2
prerequisite-patch-id: 6086254edae9372a2a2a79521a9713c8d30e695c
prerequisite-patch-id: 6ad40b13b98391ed21da873bdf88c04f23ecb6fb
prerequisite-patch-id: 9fbbbc72209b81bc26573427ec70246eb2d04af1
prerequisite-patch-id: 5cc8743cf655d791faca7934683dd0d758151321
prerequisite-patch-id: 5bd8d06716d6cbae7a9fd904ff8713f3a5d0c8a0
prerequisite-patch-id: 2271226e9ac9ab8d8d93c7c3b2384c3c7bd84b87
prerequisite-patch-id: 19497288dc06ceb627a6eab0c75754a945eb1d71
prerequisite-patch-id: 85867a867694055295ce127a7ce1e9818d76801f
prerequisite-patch-id: 1b1d6aa8f4b96f82548917135d7747ed6e250fc7
prerequisite-patch-id: 39838eac42ec51ce7fb0951d4da3c64c801d71cf
prerequisite-patch-id: 846be3c76fbbca1890b3874e1fdb2af846d8f3e2
prerequisite-patch-id: 35af5ef849b3b4e207d9d9385580768c75c0827b
prerequisite-patch-id: b6aa080addba2ac4c851f41a01b72004e14fe7ca
prerequisite-patch-id: c4ba87ce6d1e48bddafb896f3c3d1fe514bf3b5c
prerequisite-patch-id: f8e4fec905fb4d6e000df3f17717f7b47d22ae27
prerequisite-patch-id: 8c0f82cdfb3c0995cdff96f9c6fc2971faf60a1e
prerequisite-patch-id: b89d16d373447225b2821d784b21331fb62e7a7c
prerequisite-patch-id: 1486fef342202199cb746fcf1601621ef07a02c4
prerequisite-patch-id: efad6151fb2cedb2cbe18d3873aa8a9b1ec4ee4f
prerequisite-patch-id: 7993a9682b498599a2fca2b7bc9c871c4bc3a374
prerequisite-patch-id: a4c31ca38e3009e9e0f15ec5531f0fa09d4929b8
prerequisite-patch-id: 3e3b4dccd7abc5c1de05d70aa397221d0a6e9c91
prerequisite-patch-id: 421ba703353af51b801fa948d862e6102b52ea9f
prerequisite-patch-id: c2ad0f1f0b00408b0068c2f8b235910fe19ce430
prerequisite-patch-id: 13a554c8d1b77415d2bf11ff260a8f932902f11c
prerequisite-patch-id: b00e4016272f55195941fedf49de1cb8f0b68dc4
prerequisite-patch-id: f89b24990377441eaf3f45d9b822ff699874af59
prerequisite-patch-id: 97d90df0f9d0499e5d3b4fd5ce37f3bb964c2370
prerequisite-patch-id: 45989d03b7508141fff2b99bee1ed9296841c3dd
prerequisite-patch-id: 77549a6ae8ce281254b876b05727983bb9b7560a
prerequisite-patch-id: 2ceee10179ceeef045bd54f0d0afa57b3e45a18a
prerequisite-patch-id: 28d94479e5cb8294668a6e8f26c1f3abc548fc11
prerequisite-patch-id: c25cb8c4efc803a3103098a043cce9d3db362050
-- 
2.29.2.222.g5d2a92d10f8


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-24 11:57 ` Maarten Lankhorst
  0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-24 11:57 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx, Niranjana Vishwanathapura, stable

We hardcode the maximum number of shared fences to 4, instead of
respecting num_fences. Use a minimum of 4, but more if num_fences
is higher.

This seems to have been an oversight when first implementing the
api.

Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
Cc: <stable@vger.kernel.org> # v3.17+
Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/dma-buf/dma-resv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index bb5a42b10c29..6ddbeb5dfbf6 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -200,7 +200,7 @@ int dma_resv_reserve_shared(struct dma_resv *obj, unsigned int num_fences)
 			max = max(old->shared_count + num_fences,
 				  old->shared_max * 2);
 	} else {
-		max = 4;
+		max = max(4ul, roundup_pow_of_two(num_fences));
 	}
 
 	new = dma_resv_list_alloc(max);

base-commit: d08ea807a6466f311fe921872bc18cfc384ae281
prerequisite-patch-id: 67ededd6181f1f0d00b98376bcacefb776ebfd1b
prerequisite-patch-id: 36ea30085b8b6095303642e82a6d9c2373d331c2
prerequisite-patch-id: 453c3fe559333daea47bc5d24171b32ae8483c2d
prerequisite-patch-id: 3792e6478845da3a19dda5fdca5d094d3847c6e3
prerequisite-patch-id: 7d4e280d1197ead2e3f90d10d0c38c4685bedd86
prerequisite-patch-id: 6db8468aba0d92cd5d67af028caebe4146b9f02e
prerequisite-patch-id: 6550921ad75aaa9ddd30db6a75878d06c13ab6bb
prerequisite-patch-id: 35cfae6d6d6c30453026284fc2b25733f005f950
prerequisite-patch-id: 3bf03aa3ed1532d6c67fa47cec3ba34418ea5a79
prerequisite-patch-id: 580e28da7a0e724c293eb5b36a35be0964554885
prerequisite-patch-id: 61932497d71dc764e040deea7a58286dca51a6e0
prerequisite-patch-id: b3f6ac925fd9f3517e63b0595ce138fdd0196db2
prerequisite-patch-id: 609d83e906e26c4d9c0fb5ba29f66eec0234d11b
prerequisite-patch-id: 88264df437b404b00bba07edb7761762c52daa9d
prerequisite-patch-id: 2d3d4efeb0e32423938d546a683513ee8077143e
prerequisite-patch-id: 675d46b64f98322e8ab90b947598d030f1133120
prerequisite-patch-id: fbd3c4bf0ea604f9ab30aa21f28fb26b953f8889
prerequisite-patch-id: d51e789c6ddc37cb65b6e49aaf567ba2a6168841
prerequisite-patch-id: 1e05b33595d37f01087a82f11344b0e3cca2580a
prerequisite-patch-id: 64151f1e9a5ae900c09322ef2bade0e1dad06568
prerequisite-patch-id: af71a3e75f28e0ee92721491b27f260500567d92
prerequisite-patch-id: 30c6b42d4bd39703a865ee9ebce41d986a803ce4
prerequisite-patch-id: 15a26c36a233ee3f738faa4a666b4f9c8749494d
prerequisite-patch-id: 9733d60910fb3e14ba5caa2eecc97a8c50592d7d
prerequisite-patch-id: b7b484c19e966041b39b7e3f089e9fb407c0b641
prerequisite-patch-id: dd2adee5d7c941363193ad4033f419ca8f535b69
prerequisite-patch-id: 89142874b57f3120e4dcdefd7e40168766fc7f52
prerequisite-patch-id: df6983cc3366963afb6e4229cddd5b1a42406e3c
prerequisite-patch-id: 7d90d37f7e7545c5710ebdbd3db9967c1d1b5b4d
prerequisite-patch-id: 07041f82bdb5a5f886dd13a0a6a27b66d06d17c2
prerequisite-patch-id: 6086254edae9372a2a2a79521a9713c8d30e695c
prerequisite-patch-id: 6ad40b13b98391ed21da873bdf88c04f23ecb6fb
prerequisite-patch-id: 9fbbbc72209b81bc26573427ec70246eb2d04af1
prerequisite-patch-id: 5cc8743cf655d791faca7934683dd0d758151321
prerequisite-patch-id: 5bd8d06716d6cbae7a9fd904ff8713f3a5d0c8a0
prerequisite-patch-id: 2271226e9ac9ab8d8d93c7c3b2384c3c7bd84b87
prerequisite-patch-id: 19497288dc06ceb627a6eab0c75754a945eb1d71
prerequisite-patch-id: 85867a867694055295ce127a7ce1e9818d76801f
prerequisite-patch-id: 1b1d6aa8f4b96f82548917135d7747ed6e250fc7
prerequisite-patch-id: 39838eac42ec51ce7fb0951d4da3c64c801d71cf
prerequisite-patch-id: 846be3c76fbbca1890b3874e1fdb2af846d8f3e2
prerequisite-patch-id: 35af5ef849b3b4e207d9d9385580768c75c0827b
prerequisite-patch-id: b6aa080addba2ac4c851f41a01b72004e14fe7ca
prerequisite-patch-id: c4ba87ce6d1e48bddafb896f3c3d1fe514bf3b5c
prerequisite-patch-id: f8e4fec905fb4d6e000df3f17717f7b47d22ae27
prerequisite-patch-id: 8c0f82cdfb3c0995cdff96f9c6fc2971faf60a1e
prerequisite-patch-id: b89d16d373447225b2821d784b21331fb62e7a7c
prerequisite-patch-id: 1486fef342202199cb746fcf1601621ef07a02c4
prerequisite-patch-id: efad6151fb2cedb2cbe18d3873aa8a9b1ec4ee4f
prerequisite-patch-id: 7993a9682b498599a2fca2b7bc9c871c4bc3a374
prerequisite-patch-id: a4c31ca38e3009e9e0f15ec5531f0fa09d4929b8
prerequisite-patch-id: 3e3b4dccd7abc5c1de05d70aa397221d0a6e9c91
prerequisite-patch-id: 421ba703353af51b801fa948d862e6102b52ea9f
prerequisite-patch-id: c2ad0f1f0b00408b0068c2f8b235910fe19ce430
prerequisite-patch-id: 13a554c8d1b77415d2bf11ff260a8f932902f11c
prerequisite-patch-id: b00e4016272f55195941fedf49de1cb8f0b68dc4
prerequisite-patch-id: f89b24990377441eaf3f45d9b822ff699874af59
prerequisite-patch-id: 97d90df0f9d0499e5d3b4fd5ce37f3bb964c2370
prerequisite-patch-id: 45989d03b7508141fff2b99bee1ed9296841c3dd
prerequisite-patch-id: 77549a6ae8ce281254b876b05727983bb9b7560a
prerequisite-patch-id: 2ceee10179ceeef045bd54f0d0afa57b3e45a18a
prerequisite-patch-id: 28d94479e5cb8294668a6e8f26c1f3abc548fc11
prerequisite-patch-id: c25cb8c4efc803a3103098a043cce9d3db362050
-- 
2.29.2.222.g5d2a92d10f8

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-24 11:57 ` Maarten Lankhorst
  0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-24 11:57 UTC (permalink / raw)
  To: dri-devel; +Cc: intel-gfx, stable

We hardcode the maximum number of shared fences to 4, instead of
respecting num_fences. Use a minimum of 4, but more if num_fences
is higher.

This seems to have been an oversight when first implementing the
api.

Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
Cc: <stable@vger.kernel.org> # v3.17+
Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/dma-buf/dma-resv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index bb5a42b10c29..6ddbeb5dfbf6 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -200,7 +200,7 @@ int dma_resv_reserve_shared(struct dma_resv *obj, unsigned int num_fences)
 			max = max(old->shared_count + num_fences,
 				  old->shared_max * 2);
 	} else {
-		max = 4;
+		max = max(4ul, roundup_pow_of_two(num_fences));
 	}
 
 	new = dma_resv_list_alloc(max);

base-commit: d08ea807a6466f311fe921872bc18cfc384ae281
prerequisite-patch-id: 67ededd6181f1f0d00b98376bcacefb776ebfd1b
prerequisite-patch-id: 36ea30085b8b6095303642e82a6d9c2373d331c2
prerequisite-patch-id: 453c3fe559333daea47bc5d24171b32ae8483c2d
prerequisite-patch-id: 3792e6478845da3a19dda5fdca5d094d3847c6e3
prerequisite-patch-id: 7d4e280d1197ead2e3f90d10d0c38c4685bedd86
prerequisite-patch-id: 6db8468aba0d92cd5d67af028caebe4146b9f02e
prerequisite-patch-id: 6550921ad75aaa9ddd30db6a75878d06c13ab6bb
prerequisite-patch-id: 35cfae6d6d6c30453026284fc2b25733f005f950
prerequisite-patch-id: 3bf03aa3ed1532d6c67fa47cec3ba34418ea5a79
prerequisite-patch-id: 580e28da7a0e724c293eb5b36a35be0964554885
prerequisite-patch-id: 61932497d71dc764e040deea7a58286dca51a6e0
prerequisite-patch-id: b3f6ac925fd9f3517e63b0595ce138fdd0196db2
prerequisite-patch-id: 609d83e906e26c4d9c0fb5ba29f66eec0234d11b
prerequisite-patch-id: 88264df437b404b00bba07edb7761762c52daa9d
prerequisite-patch-id: 2d3d4efeb0e32423938d546a683513ee8077143e
prerequisite-patch-id: 675d46b64f98322e8ab90b947598d030f1133120
prerequisite-patch-id: fbd3c4bf0ea604f9ab30aa21f28fb26b953f8889
prerequisite-patch-id: d51e789c6ddc37cb65b6e49aaf567ba2a6168841
prerequisite-patch-id: 1e05b33595d37f01087a82f11344b0e3cca2580a
prerequisite-patch-id: 64151f1e9a5ae900c09322ef2bade0e1dad06568
prerequisite-patch-id: af71a3e75f28e0ee92721491b27f260500567d92
prerequisite-patch-id: 30c6b42d4bd39703a865ee9ebce41d986a803ce4
prerequisite-patch-id: 15a26c36a233ee3f738faa4a666b4f9c8749494d
prerequisite-patch-id: 9733d60910fb3e14ba5caa2eecc97a8c50592d7d
prerequisite-patch-id: b7b484c19e966041b39b7e3f089e9fb407c0b641
prerequisite-patch-id: dd2adee5d7c941363193ad4033f419ca8f535b69
prerequisite-patch-id: 89142874b57f3120e4dcdefd7e40168766fc7f52
prerequisite-patch-id: df6983cc3366963afb6e4229cddd5b1a42406e3c
prerequisite-patch-id: 7d90d37f7e7545c5710ebdbd3db9967c1d1b5b4d
prerequisite-patch-id: 07041f82bdb5a5f886dd13a0a6a27b66d06d17c2
prerequisite-patch-id: 6086254edae9372a2a2a79521a9713c8d30e695c
prerequisite-patch-id: 6ad40b13b98391ed21da873bdf88c04f23ecb6fb
prerequisite-patch-id: 9fbbbc72209b81bc26573427ec70246eb2d04af1
prerequisite-patch-id: 5cc8743cf655d791faca7934683dd0d758151321
prerequisite-patch-id: 5bd8d06716d6cbae7a9fd904ff8713f3a5d0c8a0
prerequisite-patch-id: 2271226e9ac9ab8d8d93c7c3b2384c3c7bd84b87
prerequisite-patch-id: 19497288dc06ceb627a6eab0c75754a945eb1d71
prerequisite-patch-id: 85867a867694055295ce127a7ce1e9818d76801f
prerequisite-patch-id: 1b1d6aa8f4b96f82548917135d7747ed6e250fc7
prerequisite-patch-id: 39838eac42ec51ce7fb0951d4da3c64c801d71cf
prerequisite-patch-id: 846be3c76fbbca1890b3874e1fdb2af846d8f3e2
prerequisite-patch-id: 35af5ef849b3b4e207d9d9385580768c75c0827b
prerequisite-patch-id: b6aa080addba2ac4c851f41a01b72004e14fe7ca
prerequisite-patch-id: c4ba87ce6d1e48bddafb896f3c3d1fe514bf3b5c
prerequisite-patch-id: f8e4fec905fb4d6e000df3f17717f7b47d22ae27
prerequisite-patch-id: 8c0f82cdfb3c0995cdff96f9c6fc2971faf60a1e
prerequisite-patch-id: b89d16d373447225b2821d784b21331fb62e7a7c
prerequisite-patch-id: 1486fef342202199cb746fcf1601621ef07a02c4
prerequisite-patch-id: efad6151fb2cedb2cbe18d3873aa8a9b1ec4ee4f
prerequisite-patch-id: 7993a9682b498599a2fca2b7bc9c871c4bc3a374
prerequisite-patch-id: a4c31ca38e3009e9e0f15ec5531f0fa09d4929b8
prerequisite-patch-id: 3e3b4dccd7abc5c1de05d70aa397221d0a6e9c91
prerequisite-patch-id: 421ba703353af51b801fa948d862e6102b52ea9f
prerequisite-patch-id: c2ad0f1f0b00408b0068c2f8b235910fe19ce430
prerequisite-patch-id: 13a554c8d1b77415d2bf11ff260a8f932902f11c
prerequisite-patch-id: b00e4016272f55195941fedf49de1cb8f0b68dc4
prerequisite-patch-id: f89b24990377441eaf3f45d9b822ff699874af59
prerequisite-patch-id: 97d90df0f9d0499e5d3b4fd5ce37f3bb964c2370
prerequisite-patch-id: 45989d03b7508141fff2b99bee1ed9296841c3dd
prerequisite-patch-id: 77549a6ae8ce281254b876b05727983bb9b7560a
prerequisite-patch-id: 2ceee10179ceeef045bd54f0d0afa57b3e45a18a
prerequisite-patch-id: 28d94479e5cb8294668a6e8f26c1f3abc548fc11
prerequisite-patch-id: c25cb8c4efc803a3103098a043cce9d3db362050
-- 
2.29.2.222.g5d2a92d10f8

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
  2020-11-24 11:57 ` Maarten Lankhorst
  (?)
@ 2020-11-24 13:10   ` Thomas Hellström
  -1 siblings, 0 replies; 12+ messages in thread
From: Thomas Hellström @ 2020-11-24 13:10 UTC (permalink / raw)
  To: Maarten Lankhorst, dri-devel; +Cc: intel-gfx, stable


On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
> We hardcode the maximum number of shared fences to 4, instead of
> respecting num_fences. Use a minimum of 4, but more if num_fences
> is higher.
>
> This seems to have been an oversight when first implementing the
> api.
>
> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
> Cc: <stable@vger.kernel.org> # v3.17+
> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>   drivers/dma-buf/dma-resv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>



^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-24 13:10   ` Thomas Hellström
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Hellström @ 2020-11-24 13:10 UTC (permalink / raw)
  To: Maarten Lankhorst, dri-devel; +Cc: intel-gfx, stable


On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
> We hardcode the maximum number of shared fences to 4, instead of
> respecting num_fences. Use a minimum of 4, but more if num_fences
> is higher.
>
> This seems to have been an oversight when first implementing the
> api.
>
> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
> Cc: <stable@vger.kernel.org> # v3.17+
> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>   drivers/dma-buf/dma-resv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-24 13:10   ` Thomas Hellström
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Hellström @ 2020-11-24 13:10 UTC (permalink / raw)
  To: Maarten Lankhorst, dri-devel; +Cc: intel-gfx, stable


On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
> We hardcode the maximum number of shared fences to 4, instead of
> respecting num_fences. Use a minimum of 4, but more if num_fences
> is higher.
>
> This seems to have been an oversight when first implementing the
> api.
>
> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
> Cc: <stable@vger.kernel.org> # v3.17+
> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>   drivers/dma-buf/dma-resv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
  2020-11-24 11:57 ` Maarten Lankhorst
                   ` (2 preceding siblings ...)
  (?)
@ 2020-11-24 16:22 ` Patchwork
  -1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-24 16:22 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: intel-gfx

== Series Details ==

Series: dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
URL   : https://patchwork.freedesktop.org/series/84210/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a3e8d02ad6be dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
-:18: WARNING:BAD_SIGN_OFF: email address '<stable@vger.kernel.org> # v3.17+' might be better as 'stable@vger.kernel.org# v3.17+'
#18: 
Cc: <stable@vger.kernel.org> # v3.17+

-:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19: 
Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

total: 0 errors, 2 warnings, 0 checks, 8 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
  2020-11-24 11:57 ` Maarten Lankhorst
                   ` (3 preceding siblings ...)
  (?)
@ 2020-11-24 16:52 ` Patchwork
  -1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-24 16:52 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 4902 bytes --]

== Series Details ==

Series: dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
URL   : https://patchwork.freedesktop.org/series/84210/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9383 -> Patchwork_18966
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/index.html

New tests
---------

  New tests have been introduced between CI_DRM_9383 and Patchwork_18966:

### New CI tests (1) ###

  * boot:
    - Statuses : 39 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_18966 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-icl-u2:          [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-icl-u2/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-icl-u2/igt@i915_module_load@reload.html

  * igt@kms_busy@basic@flip:
    - fi-kbl-soraka:      [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-kbl-soraka/igt@kms_busy@basic@flip.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-kbl-soraka/igt@kms_busy@basic@flip.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-byt-j1900:       [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - {fi-ehl-1}:         [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-ehl-1/igt@core_hotunplug@unbind-rebind.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-ehl-1/igt@core_hotunplug@unbind-rebind.html
    - fi-icl-u2:          [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html

  * igt@i915_module_load@reload:
    - fi-byt-j1900:       [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-byt-j1900/igt@i915_module_load@reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-byt-j1900/igt@i915_module_load@reload.html

  * igt@kms_busy@basic@flip:
    - {fi-kbl-7560u}:     [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-kbl-7560u/igt@kms_busy@basic@flip.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-kbl-7560u/igt@kms_busy@basic@flip.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-cml-u2:          [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-bsw-kefka:       [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982


Participating hosts (43 -> 39)
------------------------------

  Additional (1): fi-tgl-y 
  Missing    (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_9383 -> Patchwork_18966

  CI-20190529: 20190529
  CI_DRM_9383: 2096ebc6896ed1b99fddf7c979ea9209dc3b4f73 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5870: 08b13995b85df26a77212e4fb21fd772976ef33c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18966: a3e8d02ad6beaff42880573f9d4db06775c96516 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

a3e8d02ad6be dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/index.html

[-- Attachment #1.2: Type: text/html, Size: 6307 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
  2020-11-24 11:57 ` Maarten Lankhorst
                   ` (4 preceding siblings ...)
  (?)
@ 2020-11-24 21:11 ` Patchwork
  -1 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-24 21:11 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 19515 bytes --]

== Series Details ==

Series: dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
URL   : https://patchwork.freedesktop.org/series/84210/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9383_full -> Patchwork_18966_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_18966_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_18966_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_18966_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_eio@reset-stress:
    - shard-skl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl4/igt@gem_eio@reset-stress.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl2/igt@gem_eio@reset-stress.html

  * igt@i915_selftest@live@gem_contexts:
    - shard-skl:          NOTRUN -> [INCOMPLETE][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl9/igt@i915_selftest@live@gem_contexts.html

  
New tests
---------

  New tests have been introduced between CI_DRM_9383_full and Patchwork_18966_full:

### New CI tests (1) ###

  * boot:
    - Statuses : 200 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_18966_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_create@forked:
    - shard-kbl:          [PASS][4] -> [INCOMPLETE][5] ([i915#794])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-kbl1/igt@gem_exec_create@forked.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-kbl1/igt@gem_exec_create@forked.html

  * igt@gem_exec_whisper@basic-fds-forked:
    - shard-glk:          [PASS][6] -> [DMESG-WARN][7] ([i915#118] / [i915#95])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-glk7/igt@gem_exec_whisper@basic-fds-forked.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-glk9/igt@gem_exec_whisper@basic-fds-forked.html

  * igt@gem_reg_read@timestamp-monotonic:
    - shard-iclb:         [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb1/igt@gem_reg_read@timestamp-monotonic.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb2/igt@gem_reg_read@timestamp-monotonic.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen:
    - shard-skl:          [PASS][10] -> [FAIL][11] ([i915#54])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen.html

  * igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
    - shard-tglb:         [PASS][12] -> [FAIL][13] ([i915#2346])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
    - shard-tglb:         [PASS][14] -> [FAIL][15] ([i915#2598])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
    - shard-glk:          [PASS][16] -> [FAIL][17] ([i915#79])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html

  * igt@kms_flip@plain-flip-fb-recreate@c-edp1:
    - shard-skl:          [PASS][18] -> [FAIL][19] ([i915#2122])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
    - shard-tglb:         [PASS][20] -> [DMESG-WARN][21] ([i915#1982])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite:
    - shard-skl:          [PASS][22] -> [DMESG-WARN][23] ([i915#1982]) +4 similar issues
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-apl:          [PASS][24] -> [DMESG-WARN][25] ([i915#1635] / [i915#1982] / [i915#2621])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-apl1/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-apl2/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [PASS][26] -> [SKIP][27] ([fdo#109441])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb2/igt@kms_psr@psr2_basic.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb7/igt@kms_psr@psr2_basic.html

  * igt@kms_vblank@pipe-b-wait-forked-busy:
    - shard-kbl:          [PASS][28] -> [DMESG-WARN][29] ([i915#1982]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-kbl2/igt@kms_vblank@pipe-b-wait-forked-busy.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-kbl7/igt@kms_vblank@pipe-b-wait-forked-busy.html
    - shard-apl:          [PASS][30] -> [DMESG-WARN][31] ([i915#1635] / [i915#1982]) +1 similar issue
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-apl4/igt@kms_vblank@pipe-b-wait-forked-busy.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-apl4/igt@kms_vblank@pipe-b-wait-forked-busy.html

  * igt@perf@polling-parameterized:
    - shard-hsw:          [PASS][32] -> [FAIL][33] ([i915#1542])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-hsw8/igt@perf@polling-parameterized.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-hsw6/igt@perf@polling-parameterized.html
    - shard-skl:          [PASS][34] -> [FAIL][35] ([i915#1542])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl6/igt@perf@polling-parameterized.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl8/igt@perf@polling-parameterized.html

  * igt@perf_pmu@module-unload:
    - shard-tglb:         [PASS][36] -> [DMESG-WARN][37] ([i915#1982] / [i915#262])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-tglb1/igt@perf_pmu@module-unload.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-tglb5/igt@perf_pmu@module-unload.html
    - shard-iclb:         [PASS][38] -> [DMESG-WARN][39] ([i915#1982] / [i915#262])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb7/igt@perf_pmu@module-unload.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb7/igt@perf_pmu@module-unload.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - shard-apl:          [DMESG-WARN][40] ([i915#1635] / [i915#1982]) -> [PASS][41] +4 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-apl1/igt@core_hotunplug@unbind-rebind.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-apl2/igt@core_hotunplug@unbind-rebind.html

  * igt@gem_exec_reloc@basic-many-active@rcs0:
    - shard-glk:          [FAIL][42] ([i915#2389]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html

  * igt@gem_exec_reloc@basic-write-cpu-noreloc:
    - shard-skl:          [DMESG-WARN][44] ([i915#1982]) -> [PASS][45]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl8/igt@gem_exec_reloc@basic-write-cpu-noreloc.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl10/igt@gem_exec_reloc@basic-write-cpu-noreloc.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-skl:          [INCOMPLETE][46] ([i915#151]) -> [PASS][47]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl5/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
    - shard-skl:          [FAIL][48] ([i915#54]) -> [PASS][49] +3 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html

  * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
    - shard-skl:          [FAIL][50] ([i915#2346]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-skl:          [INCOMPLETE][52] ([i915#198]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl5/igt@kms_fbcon_fbt@psr-suspend.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl4/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_flip@flip-vs-expired-vblank@c-edp1:
    - shard-skl:          [FAIL][54] ([i915#79]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt:
    - shard-kbl:          [DMESG-WARN][56] ([i915#1982]) -> [PASS][57] +4 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
    - shard-iclb:         [DMESG-WARN][58] ([i915#1982]) -> [PASS][59]
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb8/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb8/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [FAIL][60] ([i915#1188]) -> [PASS][61] +1 similar issue
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          [FAIL][62] ([fdo#108145] / [i915#265]) -> [PASS][63] +1 similar issue
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html

  * igt@kms_psr@psr2_cursor_blt:
    - shard-iclb:         [SKIP][64] ([fdo#109441]) -> [PASS][65] +1 similar issue
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb1/igt@kms_psr@psr2_cursor_blt.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html

  * igt@sysfs_preempt_timeout@timeout@rcs0:
    - shard-skl:          [FAIL][66] ([i915#2060]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl9/igt@sysfs_preempt_timeout@timeout@rcs0.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl2/igt@sysfs_preempt_timeout@timeout@rcs0.html

  * igt@sysfs_timeslice_duration@timeout@bcs0:
    - shard-skl:          [FAIL][68] ([i915#1732]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl6/igt@sysfs_timeslice_duration@timeout@bcs0.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl8/igt@sysfs_timeslice_duration@timeout@bcs0.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][70] ([i915#2681] / [i915#2684]) -> [WARN][71] ([i915#2684])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][72] ([i915#1804]) -> [WARN][73] ([i915#2681])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-skl:          [FAIL][74] ([i915#54]) -> [INCOMPLETE][75] ([i915#300])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@runner@aborted:
    - shard-hsw:          [FAIL][76] ([i915#2283] / [i915#2295] / [i915#483]) -> [FAIL][77] ([i915#2283] / [i915#2295])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-hsw1/igt@runner@aborted.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-hsw5/igt@runner@aborted.html
    - shard-glk:          ([FAIL][78], [FAIL][79]) ([i915#2295] / [k.org#202321]) -> ([FAIL][80], [FAIL][81]) ([i915#2295] / [i915#483] / [k.org#202321])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-glk8/igt@runner@aborted.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-glk4/igt@runner@aborted.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-glk8/igt@runner@aborted.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-glk7/igt@runner@aborted.html
    - shard-skl:          ([FAIL][82], [FAIL][83]) ([i915#2029] / [i915#2295] / [i915#483]) -> ([FAIL][84], [FAIL][85], [FAIL][86]) ([i915#1814] / [i915#2029] / [i915#2295] / [i915#483])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl3/igt@runner@aborted.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9383/shard-skl3/igt@runner@aborted.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl1/igt@runner@aborted.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl3/igt@runner@aborted.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/shard-skl3/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#1732]: https://gitlab.freedesktop.org/drm/intel/issues/1732
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2060]: https://gitlab.freedesktop.org/drm/intel/issues/2060
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
  [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
  [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
  [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#2621]: https://gitlab.freedesktop.org/drm/intel/issues/2621
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9383 -> Patchwork_18966

  CI-20190529: 20190529
  CI_DRM_9383: 2096ebc6896ed1b99fddf7c979ea9209dc3b4f73 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5870: 08b13995b85df26a77212e4fb21fd772976ef33c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_18966: a3e8d02ad6beaff42880573f9d4db06775c96516 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18966/index.html

[-- Attachment #1.2: Type: text/html, Size: 23559 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
  2020-11-24 13:10   ` Thomas Hellström
  (?)
@ 2020-11-25  9:50     ` Maarten Lankhorst
  -1 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-25  9:50 UTC (permalink / raw)
  To: Thomas Hellström, dri-devel; +Cc: intel-gfx, stable

Op 24-11-2020 om 14:10 schreef Thomas Hellström:
>
> On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
>> We hardcode the maximum number of shared fences to 4, instead of
>> respecting num_fences. Use a minimum of 4, but more if num_fences
>> is higher.
>>
>> This seems to have been an oversight when first implementing the
>> api.
>>
>> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
>> Cc: <stable@vger.kernel.org> # v3.17+
>> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>   drivers/dma-buf/dma-resv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>
Thanks, pushed!


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-25  9:50     ` Maarten Lankhorst
  0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-25  9:50 UTC (permalink / raw)
  To: Thomas Hellström, dri-devel; +Cc: intel-gfx, stable

Op 24-11-2020 om 14:10 schreef Thomas Hellström:
>
> On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
>> We hardcode the maximum number of shared fences to 4, instead of
>> respecting num_fences. Use a minimum of 4, but more if num_fences
>> is higher.
>>
>> This seems to have been an oversight when first implementing the
>> api.
>>
>> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
>> Cc: <stable@vger.kernel.org> # v3.17+
>> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>   drivers/dma-buf/dma-resv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>
Thanks, pushed!

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list.
@ 2020-11-25  9:50     ` Maarten Lankhorst
  0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2020-11-25  9:50 UTC (permalink / raw)
  To: Thomas Hellström, dri-devel; +Cc: intel-gfx, stable

Op 24-11-2020 om 14:10 schreef Thomas Hellström:
>
> On 11/24/20 12:57 PM, Maarten Lankhorst wrote:
>> We hardcode the maximum number of shared fences to 4, instead of
>> respecting num_fences. Use a minimum of 4, but more if num_fences
>> is higher.
>>
>> This seems to have been an oversight when first implementing the
>> api.
>>
>> Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers")
>> Cc: <stable@vger.kernel.org> # v3.17+
>> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>>   drivers/dma-buf/dma-resv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
>
>
Thanks, pushed!

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-25  9:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 11:57 [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list Maarten Lankhorst
2020-11-24 11:57 ` [Intel-gfx] " Maarten Lankhorst
2020-11-24 11:57 ` Maarten Lankhorst
2020-11-24 13:10 ` [Intel-gfx] " Thomas Hellström
2020-11-24 13:10   ` Thomas Hellström
2020-11-24 13:10   ` Thomas Hellström
2020-11-25  9:50   ` Maarten Lankhorst
2020-11-25  9:50     ` Maarten Lankhorst
2020-11-25  9:50     ` Maarten Lankhorst
2020-11-24 16:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-11-24 16:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-11-24 21:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.