From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH/RFC v3 15/22] clk: renesas: r8a7796: Obtain mode pin values from R-Car RST driver Date: Fri, 03 Jun 2016 01:02:21 +0300 Message-ID: <1606406.2DcGx2H7dc@avalon> References: <1464808880-343-1-git-send-email-geert+renesas@glider.be> <1464808880-343-16-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1464808880-343-16-git-send-email-geert+renesas@glider.be> Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Laurent Pinchart , Philipp Zabel , Michael Turquette , Stephen Boyd , Dirk Behme , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Geert, Thank you for the patch. On Wednesday 01 Jun 2016 21:21:13 Geert Uytterhoeven wrote: > Obtain the values of the mode pins from the R-Car RST driver, which > relies on the presence in DT of a device node for the RST module. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > v3: > - New. > --- > drivers/clk/renesas/r8a7796-cpg-mssr.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c > b/drivers/clk/renesas/r8a7796-cpg-mssr.c index > c84b549c14d2e57d..3db2d1cfc8cd788e 100644 > --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include > > @@ -159,7 +160,12 @@ static const struct rcar_gen3_cpg_pll_config > cpg_pll_configs[16] __initconst = { static int __init > r8a7796_cpg_mssr_init(struct device *dev) > { > const struct rcar_gen3_cpg_pll_config *cpg_pll_config; > - u32 cpg_mode = rcar_gen3_read_mode_pins(); > + u32 cpg_mode; > + int error; > + > + error = rcar_rst_read_mode_pins(&cpg_mode); > + if (error) > + return error; > > cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > if (!cpg_pll_config->extal_div) { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Fri, 03 Jun 2016 01:02:21 +0300 Subject: [PATCH/RFC v3 15/22] clk: renesas: r8a7796: Obtain mode pin values from R-Car RST driver In-Reply-To: <1464808880-343-16-git-send-email-geert+renesas@glider.be> References: <1464808880-343-1-git-send-email-geert+renesas@glider.be> <1464808880-343-16-git-send-email-geert+renesas@glider.be> Message-ID: <1606406.2DcGx2H7dc@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Geert, Thank you for the patch. On Wednesday 01 Jun 2016 21:21:13 Geert Uytterhoeven wrote: > Obtain the values of the mode pins from the R-Car RST driver, which > relies on the presence in DT of a device node for the RST module. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > v3: > - New. > --- > drivers/clk/renesas/r8a7796-cpg-mssr.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c > b/drivers/clk/renesas/r8a7796-cpg-mssr.c index > c84b549c14d2e57d..3db2d1cfc8cd788e 100644 > --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include > > @@ -159,7 +160,12 @@ static const struct rcar_gen3_cpg_pll_config > cpg_pll_configs[16] __initconst = { static int __init > r8a7796_cpg_mssr_init(struct device *dev) > { > const struct rcar_gen3_cpg_pll_config *cpg_pll_config; > - u32 cpg_mode = rcar_gen3_read_mode_pins(); > + u32 cpg_mode; > + int error; > + > + error = rcar_rst_read_mode_pins(&cpg_mode); > + if (error) > + return error; > > cpg_pll_config = &cpg_pll_configs[CPG_PLL_CONFIG_INDEX(cpg_mode)]; > if (!cpg_pll_config->extal_div) { -- Regards, Laurent Pinchart