From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF152C2D0E4 for ; Fri, 27 Nov 2020 06:21:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F8BA221FF for ; Fri, 27 Nov 2020 06:21:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WSUb2Jke" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392554AbgK0GVl (ORCPT ); Fri, 27 Nov 2020 01:21:41 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:9470 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2392545AbgK0GVl (ORCPT ); Fri, 27 Nov 2020 01:21:41 -0500 X-UUID: 0166de49f31e400fbe36e0a6b4f576b7-20201127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=k6991k1USSeF9xBY2RrFpj24tWMV0+Y0E7njcNgEzrA=; b=WSUb2JkeLbCR7ASWwSPHvXoBOxCiLeZxB9PcOr1TeSr4lXi1/1u8dxwYjPnsRqLRc9ae/lcfDKyHZYlsUW9C/kKoMhFYXx+CWkKFna25lN/pUYCX49lpgJ3l6b7OqwIkigCMS+MZYKhTgD/sWrK39L3l0L/TS6BPOlpLkEZaUgI=; X-UUID: 0166de49f31e400fbe36e0a6b4f576b7-20201127 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2031242701; Fri, 27 Nov 2020 14:21:34 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 14:21:32 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 14:21:31 +0800 Message-ID: <1606458092.26323.192.camel@mhfsdcap03> Subject: Re: [PATCH v4 17/24] iommu/mediatek: Add single domain From: Yong Wu To: Robin Murphy CC: Joerg Roedel , Matthias Brugger , Rob Herring , Will Deacon , Krzysztof Kozlowski , Evan Green , Tomasz Figa , , , , , , , , Nicolas Boichat , , , Greg Kroah-Hartman , Date: Fri, 27 Nov 2020 14:21:32 +0800 In-Reply-To: <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> References: <20201111123838.15682-1-yong.wu@mediatek.com> <20201111123838.15682-18-yong.wu@mediatek.com> <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DFD6FF2D0FFC111E8E3A9221E6491E4E883A7AD97F964DC7A2DB8863C42809542000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIwLTExLTI2IGF0IDE3OjExICswMDAwLCBSb2JpbiBNdXJwaHkgd3JvdGU6DQo+ IE9uIDIwMjAtMTEtMTEgMTI6MzgsIFlvbmcgV3Ugd3JvdGU6DQo+ID4gRGVmYXVsdGx5IHRoZSBp b3ZhIHJhbmdlIGlzIDAtNEcuIGhlcmUgd2UgYWRkIGEgc2luZ2xlLWRvbWFpbigwLTRHKQ0KPiA+ IGZvciB0aGUgcHJldmlvdXMgU29DLiB0aGlzIGFsc28gaXMgYSBwcmVwYXJpbmcgcGF0Y2ggZm9y IHN1cHBvcnRpbmcNCj4gPiBtdWx0aS1kb21haW5zLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6 IFlvbmcgV3UgPHlvbmcud3VAbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICAgZHJpdmVycy9p b21tdS9tdGtfaW9tbXUuYyB8IDEyICsrKysrKysrKysrKw0KPiA+ICAgMSBmaWxlIGNoYW5nZWQs IDEyIGluc2VydGlvbnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9t dGtfaW9tbXUuYyBiL2RyaXZlcnMvaW9tbXUvbXRrX2lvbW11LmMNCj4gPiBpbmRleCBiZjNmNGUw ZjQ3NDguLmE3NzI3YTM4OTlkMSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL2lvbW11L210a19p b21tdS5jDQo+ID4gKysrIGIvZHJpdmVycy9pb21tdS9tdGtfaW9tbXUuYw0KPiA+IEBAIC0xNjEs NiArMTYxLDEwIEBAIHN0cnVjdCBtdGtfaW9tbXVfaW92YV9yZWdpb24gew0KPiA+ICAgCXVuc2ln bmVkIGxvbmcgbG9uZwlzaXplOw0KPiA+ICAgfTsNCj4gPiAgIA0KPiA+ICtzdGF0aWMgY29uc3Qg c3RydWN0IG10a19pb21tdV9pb3ZhX3JlZ2lvbiBzaW5nbGVfZG9tYWluW10gPSB7DQo+ID4gKwl7 LmlvdmFfYmFzZSA9IDAsCQkuc2l6ZSA9IFNaXzRHfSwNCj4gPiArfTsNCj4gDQo+IEhhbmcgb24s IGdpdmVuIGhvdyB0aGUgcHJldmlvdXMgcGF0Y2ggd29ya3MsIHN1cmVseSB0aGlzIG1lYW5zIHlv dSdyZSANCj4gbm93IGdvaW5nIHRvICpyZXNlcnZlKiB0aGUgZW50aXJlIGFkZHJlc3Mgc3BhY2U/ IFRoYXQgZG9lc24ndCBzZWVtIA0KPiByaWdodC4uLiA6Lw0KDQpDb3VsZCB5b3UgaGVscCBzaGFy ZSBtb3JlPyBpbiB3aGljaCBjYXNlIGl0IGlzIG5vdCByaWdodD8NCg0KSW4gdGhlIGNvZGU6DQpk b21haW4tPmdlb21ldHJ5LmFwZXJ0dXJlX2VuZCA9IGlvdmFfYmFzZSArIHNpemUgLSAxLiANCg0K dGhpcyBpcyBzYW1lIHdpdGggRE1BX0JJVF9NQVNLKDMyKS4gSXQgbG9va3MgZG9uJ3QgY2hhbmdl IGFueXRoaW5nLg0KDQo+IA0KPiBSb2Jpbi4NCj4gDQo+ID4gKw0KPiA+ICAgLyoNCj4gPiAgICAq IFRoZXJlIG1heSBiZSAxIG9yIDIgTTRVIEhXcywgQnV0IHdlIGFsd2F5cyBleHBlY3QgdGhleSBh cmUgaW4gdGhlIHNhbWUgZG9tYWluDQo+ID4gICAgKiBmb3IgdGhlIHBlcmZvcm1hbmNlLg0KPiA+ IEBAIC05MjIsNiArOTI2LDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBtdGtfaW9tbXVfcGxhdF9k YXRhIG10MjcxMl9kYXRhID0gew0KPiA+ICAgCS5tNHVfcGxhdCAgICAgPSBNNFVfTVQyNzEyLA0K PiA+ICAgCS5mbGFncyAgICAgICAgPSBIQVNfNEdCX01PREUgfCBIQVNfQkNMSyB8IEhBU19WTERf UEFfUk5HLA0KPiA+ICAgCS5pbnZfc2VsX3JlZyAgPSBSRUdfTU1VX0lOVl9TRUxfR0VOMSwNCj4g PiArCS5pb3ZhX3JlZ2lvbiAgPSBzaW5nbGVfZG9tYWluLA0KPiA+ICsJLmlvdmFfcmVnaW9uX25y ID0gQVJSQVlfU0laRShzaW5nbGVfZG9tYWluKSwNCj4gPiAgIAkubGFyYmlkX3JlbWFwID0ge3sw fSwgezF9LCB7Mn0sIHszfSwgezR9LCB7NX0sIHs2fSwgezd9fSwNCj4gPiAgIH07DQo+ID4gICAN Cj4gPiBAQCAtOTI5LDYgKzkzNSw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2lvbW11X3Bs YXRfZGF0YSBtdDY3NzlfZGF0YSA9IHsNCj4gPiAgIAkubTR1X3BsYXQgICAgICA9IE00VV9NVDY3 NzksDQo+ID4gICAJLmZsYWdzICAgICAgICAgPSBIQVNfU1VCX0NPTU0gfCBPVVRfT1JERVJfV1Jf RU4gfCBXUl9USFJPVF9FTiwNCj4gPiAgIAkuaW52X3NlbF9yZWcgICA9IFJFR19NTVVfSU5WX1NF TF9HRU4yLA0KPiA+ICsJLmlvdmFfcmVnaW9uICAgPSBzaW5nbGVfZG9tYWluLA0KPiA+ICsJLmlv dmFfcmVnaW9uX25yID0gQVJSQVlfU0laRShzaW5nbGVfZG9tYWluKSwNCj4gPiAgIAkubGFyYmlk X3JlbWFwICA9IHt7MH0sIHsxfSwgezJ9LCB7M30sIHs1fSwgezcsIDh9LCB7MTB9LCB7OX19LA0K PiA+ICAgfTsNCj4gPiAgIA0KPiA+IEBAIC05NDQsNiArOTUyLDggQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCBtdGtfaW9tbXVfcGxhdF9kYXRhIG10ODE3M19kYXRhID0gew0KPiA+ICAgCS5mbGFncwkg ICAgICA9IEhBU180R0JfTU9ERSB8IEhBU19CQ0xLIHwgUkVTRVRfQVhJIHwNCj4gPiAgIAkJCUhB U19MRUdBQ1lfSVZSUF9QQUREUiwNCj4gPiAgIAkuaW52X3NlbF9yZWcgID0gUkVHX01NVV9JTlZf U0VMX0dFTjEsDQo+ID4gKwkuaW92YV9yZWdpb24gID0gc2luZ2xlX2RvbWFpbiwNCj4gPiArCS5p b3ZhX3JlZ2lvbl9uciA9IEFSUkFZX1NJWkUoc2luZ2xlX2RvbWFpbiksDQo+ID4gICAJLmxhcmJp ZF9yZW1hcCA9IHt7MH0sIHsxfSwgezJ9LCB7M30sIHs0fSwgezV9fSwgLyogTGluZWFyIG1hcHBp bmcuICovDQo+ID4gICB9Ow0KPiA+ICAgDQo+ID4gQEAgLTk1MSw2ICs5NjEsOCBAQCBzdGF0aWMg Y29uc3Qgc3RydWN0IG10a19pb21tdV9wbGF0X2RhdGEgbXQ4MTgzX2RhdGEgPSB7DQo+ID4gICAJ Lm00dV9wbGF0ICAgICA9IE00VV9NVDgxODMsDQo+ID4gICAJLmZsYWdzICAgICAgICA9IFJFU0VU X0FYSSwNCj4gPiAgIAkuaW52X3NlbF9yZWcgID0gUkVHX01NVV9JTlZfU0VMX0dFTjEsDQo+ID4g KwkuaW92YV9yZWdpb24gID0gc2luZ2xlX2RvbWFpbiwNCj4gPiArCS5pb3ZhX3JlZ2lvbl9uciA9 IEFSUkFZX1NJWkUoc2luZ2xlX2RvbWFpbiksDQo+ID4gICAJLmxhcmJpZF9yZW1hcCA9IHt7MH0s IHs0fSwgezV9LCB7Nn0sIHs3fSwgezJ9LCB7M30sIHsxfX0sDQo+ID4gICB9Ow0KPiA+ICAgDQo+ ID4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A100CC63777 for ; Fri, 27 Nov 2020 06:21:44 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC8F221FD for ; Fri, 27 Nov 2020 06:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WSUb2Jke" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC8F221FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 88C752E2DA; Fri, 27 Nov 2020 06:21:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A6+r9ltbZZs4; Fri, 27 Nov 2020 06:21:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id A7215203ED; Fri, 27 Nov 2020 06:21:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 83F41C163C; Fri, 27 Nov 2020 06:21:42 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5620C0052 for ; Fri, 27 Nov 2020 06:21:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D396487BC8 for ; Fri, 27 Nov 2020 06:21:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9qFsLxkte3xM for ; Fri, 27 Nov 2020 06:21:41 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mailgw02.mediatek.com (unknown [1.203.163.81]) by whitealder.osuosl.org (Postfix) with ESMTP id E19E087BC1 for ; Fri, 27 Nov 2020 06:21:37 +0000 (UTC) X-UUID: 0166de49f31e400fbe36e0a6b4f576b7-20201127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=k6991k1USSeF9xBY2RrFpj24tWMV0+Y0E7njcNgEzrA=; b=WSUb2JkeLbCR7ASWwSPHvXoBOxCiLeZxB9PcOr1TeSr4lXi1/1u8dxwYjPnsRqLRc9ae/lcfDKyHZYlsUW9C/kKoMhFYXx+CWkKFna25lN/pUYCX49lpgJ3l6b7OqwIkigCMS+MZYKhTgD/sWrK39L3l0L/TS6BPOlpLkEZaUgI=; X-UUID: 0166de49f31e400fbe36e0a6b4f576b7-20201127 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2031242701; Fri, 27 Nov 2020 14:21:34 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 14:21:32 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 14:21:31 +0800 Message-ID: <1606458092.26323.192.camel@mhfsdcap03> Subject: Re: [PATCH v4 17/24] iommu/mediatek: Add single domain From: Yong Wu To: Robin Murphy Date: Fri, 27 Nov 2020 14:21:32 +0800 In-Reply-To: <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> References: <20201111123838.15682-1-yong.wu@mediatek.com> <20201111123838.15682-18-yong.wu@mediatek.com> <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DFD6FF2D0FFC111E8E3A9221E6491E4E883A7AD97F964DC7A2DB8863C42809542000:8 X-MTK: N Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, kernel-team@android.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , Matthias Brugger , anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, 2020-11-26 at 17:11 +0000, Robin Murphy wrote: > On 2020-11-11 12:38, Yong Wu wrote: > > Defaultly the iova range is 0-4G. here we add a single-domain(0-4G) > > for the previous SoC. this also is a preparing patch for supporting > > multi-domains. > > > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/mtk_iommu.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index bf3f4e0f4748..a7727a3899d1 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -161,6 +161,10 @@ struct mtk_iommu_iova_region { > > unsigned long long size; > > }; > > > > +static const struct mtk_iommu_iova_region single_domain[] = { > > + {.iova_base = 0, .size = SZ_4G}, > > +}; > > Hang on, given how the previous patch works, surely this means you're > now going to *reserve* the entire address space? That doesn't seem > right... :/ Could you help share more? in which case it is not right? In the code: domain->geometry.aperture_end = iova_base + size - 1. this is same with DMA_BIT_MASK(32). It looks don't change anything. > > Robin. > > > + > > /* > > * There may be 1 or 2 M4U HWs, But we always expect they are in the same domain > > * for the performance. > > @@ -922,6 +926,8 @@ static const struct mtk_iommu_plat_data mt2712_data = { > > .m4u_plat = M4U_MT2712, > > .flags = HAS_4GB_MODE | HAS_BCLK | HAS_VLD_PA_RNG, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, > > }; > > > > @@ -929,6 +935,8 @@ static const struct mtk_iommu_plat_data mt6779_data = { > > .m4u_plat = M4U_MT6779, > > .flags = HAS_SUB_COMM | OUT_ORDER_WR_EN | WR_THROT_EN, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN2, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {5}, {7, 8}, {10}, {9}}, > > }; > > > > @@ -944,6 +952,8 @@ static const struct mtk_iommu_plat_data mt8173_data = { > > .flags = HAS_4GB_MODE | HAS_BCLK | RESET_AXI | > > HAS_LEGACY_IVRP_PADDR, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */ > > }; > > > > @@ -951,6 +961,8 @@ static const struct mtk_iommu_plat_data mt8183_data = { > > .m4u_plat = M4U_MT8183, > > .flags = RESET_AXI, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {4}, {5}, {6}, {7}, {2}, {3}, {1}}, > > }; > > > > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B023DC2D0E4 for ; Fri, 27 Nov 2020 06:22:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36018221FD for ; Fri, 27 Nov 2020 06:22:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SwkptnpT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rSoryBLV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36018221FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w5JE7y+QBAttOQZMD4bMCzFOks4M8HqC/7EXVj0JSsc=; b=SwkptnpTKcBUKRYKhVwUalRk6 Bwn5knBjeawjgx+rgxzSYsbqhqOZQoHv+stbAnXgS0s1v3b//JKRLPOsJVN1HwJ7iQ8ThJReHbPrU J7wKnfaucCSYP9rXzVS23UK6FzzUm7wOEyrzC7NlAnR5N0tz9QEDuBHPYLB++msFezT90D/ncl+vh QplBu4fuhBKSI0Mu340gpZLX4dJ/1PJYRfWBon83QofAgYrGG919UOQlhG0AIqNzhAshfpneeq952 dxjw6YMZQblfjsc+VT73oC5cIZ9Znf1a/ywrZhbWyvNbCgb7hPtjEzQECe6ht7e4mC9AGCP2/ZkY2 MqP2Iz8jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiX8f-0005sY-KZ; Fri, 27 Nov 2020 06:21:50 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiX8a-0005pr-Ci; Fri, 27 Nov 2020 06:21:45 +0000 X-UUID: a9f74f4536bd435083ad869a475bb7bd-20201126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=k6991k1USSeF9xBY2RrFpj24tWMV0+Y0E7njcNgEzrA=; b=rSoryBLVHnFriwI3Qs7ZufeGHicLmFLdtkI6rcwUqGH175aMaLER4Hkj69cOuhwxDmnbPXjpg+Rs9w1PckK6vl6iXu+ggwYIpCBanyJMJO/1JF8hhMgS6rs7t0qcAry/MK8wIGV1oJhnjxaDNlW2i79RGHaXJFIeFQYxE8MP1lo=; X-UUID: a9f74f4536bd435083ad869a475bb7bd-20201126 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1934430638; Thu, 26 Nov 2020 22:21:39 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 26 Nov 2020 22:21:36 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 14:21:32 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 14:21:31 +0800 Message-ID: <1606458092.26323.192.camel@mhfsdcap03> Subject: Re: [PATCH v4 17/24] iommu/mediatek: Add single domain From: Yong Wu To: Robin Murphy Date: Fri, 27 Nov 2020 14:21:32 +0800 In-Reply-To: <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> References: <20201111123838.15682-1-yong.wu@mediatek.com> <20201111123838.15682-18-yong.wu@mediatek.com> <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DFD6FF2D0FFC111E8E3A9221E6491E4E883A7AD97F964DC7A2DB8863C42809542000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_012144_628274_519D3A68 X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, kernel-team@android.com, Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , Matthias Brugger , anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-11-26 at 17:11 +0000, Robin Murphy wrote: > On 2020-11-11 12:38, Yong Wu wrote: > > Defaultly the iova range is 0-4G. here we add a single-domain(0-4G) > > for the previous SoC. this also is a preparing patch for supporting > > multi-domains. > > > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/mtk_iommu.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index bf3f4e0f4748..a7727a3899d1 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -161,6 +161,10 @@ struct mtk_iommu_iova_region { > > unsigned long long size; > > }; > > > > +static const struct mtk_iommu_iova_region single_domain[] = { > > + {.iova_base = 0, .size = SZ_4G}, > > +}; > > Hang on, given how the previous patch works, surely this means you're > now going to *reserve* the entire address space? That doesn't seem > right... :/ Could you help share more? in which case it is not right? In the code: domain->geometry.aperture_end = iova_base + size - 1. this is same with DMA_BIT_MASK(32). It looks don't change anything. > > Robin. > > > + > > /* > > * There may be 1 or 2 M4U HWs, But we always expect they are in the same domain > > * for the performance. > > @@ -922,6 +926,8 @@ static const struct mtk_iommu_plat_data mt2712_data = { > > .m4u_plat = M4U_MT2712, > > .flags = HAS_4GB_MODE | HAS_BCLK | HAS_VLD_PA_RNG, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, > > }; > > > > @@ -929,6 +935,8 @@ static const struct mtk_iommu_plat_data mt6779_data = { > > .m4u_plat = M4U_MT6779, > > .flags = HAS_SUB_COMM | OUT_ORDER_WR_EN | WR_THROT_EN, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN2, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {5}, {7, 8}, {10}, {9}}, > > }; > > > > @@ -944,6 +952,8 @@ static const struct mtk_iommu_plat_data mt8173_data = { > > .flags = HAS_4GB_MODE | HAS_BCLK | RESET_AXI | > > HAS_LEGACY_IVRP_PADDR, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */ > > }; > > > > @@ -951,6 +961,8 @@ static const struct mtk_iommu_plat_data mt8183_data = { > > .m4u_plat = M4U_MT8183, > > .flags = RESET_AXI, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {4}, {5}, {6}, {7}, {2}, {3}, {1}}, > > }; > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E2FC2D0E4 for ; Fri, 27 Nov 2020 06:23:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18950221FD for ; Fri, 27 Nov 2020 06:23:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h8E9LS/h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rSoryBLV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18950221FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6+av6OOoB6ixrGHFB/FJ+Q21+XzYjgXMI/NyX2mQdeo=; b=h8E9LS/hVdlWtGY+8ncARLlVj 18QIFPkflA/Cm2gvwBXjBhtj6ORuEV2xfaHHCViwb61MEuWMDWCMMYmDuSrIYHZ0gfULpv7uL4gjX 8mKd6r0VJhkix41OkTMC8PW8QDVaa4zLtfOFEtZywmYGLcGXnsxKZi5sPRv4OtpGjouAGnXk3Bbkx chXNG5aZttFnQfI51m/Izbm7KLqURC6TkXLDmBNH5T9TMnqLqMODEKFxdoxpabuLMrp3cOyFoire1 QXntPqDl8cEyppR39usyTNK3cut4Q8luAr6BQertt3ZM1boUNzyuk+9K6rWJ6Sl55zrDGBFcfirer v02P89VqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiX8k-0005tJ-Ie; Fri, 27 Nov 2020 06:21:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiX8a-0005pr-Ci; Fri, 27 Nov 2020 06:21:45 +0000 X-UUID: a9f74f4536bd435083ad869a475bb7bd-20201126 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=k6991k1USSeF9xBY2RrFpj24tWMV0+Y0E7njcNgEzrA=; b=rSoryBLVHnFriwI3Qs7ZufeGHicLmFLdtkI6rcwUqGH175aMaLER4Hkj69cOuhwxDmnbPXjpg+Rs9w1PckK6vl6iXu+ggwYIpCBanyJMJO/1JF8hhMgS6rs7t0qcAry/MK8wIGV1oJhnjxaDNlW2i79RGHaXJFIeFQYxE8MP1lo=; X-UUID: a9f74f4536bd435083ad869a475bb7bd-20201126 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1934430638; Thu, 26 Nov 2020 22:21:39 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 26 Nov 2020 22:21:36 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Nov 2020 14:21:32 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 27 Nov 2020 14:21:31 +0800 Message-ID: <1606458092.26323.192.camel@mhfsdcap03> Subject: Re: [PATCH v4 17/24] iommu/mediatek: Add single domain From: Yong Wu To: Robin Murphy Date: Fri, 27 Nov 2020 14:21:32 +0800 In-Reply-To: <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> References: <20201111123838.15682-1-yong.wu@mediatek.com> <20201111123838.15682-18-yong.wu@mediatek.com> <22e49f08-6d23-86cf-bb9c-79d54ce55beb@arm.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DFD6FF2D0FFC111E8E3A9221E6491E4E883A7AD97F964DC7A2DB8863C42809542000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_012144_628274_519D3A68 X-CRM114-Status: GOOD ( 22.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, chao.hao@mediatek.com, kernel-team@android.com, Joerg Roedel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Evan Green , Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , Matthias Brugger , anan.sun@mediatek.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-11-26 at 17:11 +0000, Robin Murphy wrote: > On 2020-11-11 12:38, Yong Wu wrote: > > Defaultly the iova range is 0-4G. here we add a single-domain(0-4G) > > for the previous SoC. this also is a preparing patch for supporting > > multi-domains. > > > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/mtk_iommu.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index bf3f4e0f4748..a7727a3899d1 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -161,6 +161,10 @@ struct mtk_iommu_iova_region { > > unsigned long long size; > > }; > > > > +static const struct mtk_iommu_iova_region single_domain[] = { > > + {.iova_base = 0, .size = SZ_4G}, > > +}; > > Hang on, given how the previous patch works, surely this means you're > now going to *reserve* the entire address space? That doesn't seem > right... :/ Could you help share more? in which case it is not right? In the code: domain->geometry.aperture_end = iova_base + size - 1. this is same with DMA_BIT_MASK(32). It looks don't change anything. > > Robin. > > > + > > /* > > * There may be 1 or 2 M4U HWs, But we always expect they are in the same domain > > * for the performance. > > @@ -922,6 +926,8 @@ static const struct mtk_iommu_plat_data mt2712_data = { > > .m4u_plat = M4U_MT2712, > > .flags = HAS_4GB_MODE | HAS_BCLK | HAS_VLD_PA_RNG, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}, {6}, {7}}, > > }; > > > > @@ -929,6 +935,8 @@ static const struct mtk_iommu_plat_data mt6779_data = { > > .m4u_plat = M4U_MT6779, > > .flags = HAS_SUB_COMM | OUT_ORDER_WR_EN | WR_THROT_EN, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN2, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {5}, {7, 8}, {10}, {9}}, > > }; > > > > @@ -944,6 +952,8 @@ static const struct mtk_iommu_plat_data mt8173_data = { > > .flags = HAS_4GB_MODE | HAS_BCLK | RESET_AXI | > > HAS_LEGACY_IVRP_PADDR, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */ > > }; > > > > @@ -951,6 +961,8 @@ static const struct mtk_iommu_plat_data mt8183_data = { > > .m4u_plat = M4U_MT8183, > > .flags = RESET_AXI, > > .inv_sel_reg = REG_MMU_INV_SEL_GEN1, > > + .iova_region = single_domain, > > + .iova_region_nr = ARRAY_SIZE(single_domain), > > .larbid_remap = {{0}, {4}, {5}, {6}, {7}, {2}, {3}, {1}}, > > }; > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel