From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED0DC4361A for ; Fri, 4 Dec 2020 01:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7346224F4 for ; Fri, 4 Dec 2020 01:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbgLDBe4 (ORCPT ); Thu, 3 Dec 2020 20:34:56 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:45172 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725903AbgLDBe4 (ORCPT ); Thu, 3 Dec 2020 20:34:56 -0500 X-UUID: 0bc7a8b8818f4c6e8ea4af27196f3ffb-20201204 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qpJag3JOEGGUczkknHZEtGGVXhrvUUQwFODEalRuGIQ=; b=k2WlSq/iAxSGxWVmbKEwPGM07ymL5zzz3mARqAJnwnbtYgtS4ecSyt9y+VdPMoHxp7Hr4ELb43RVV7eqh3ISXTw00cwXcHY0fltqpnPAvwwNhDrrG/I9eftHyonHGZR9Q5IVos8X5wiLyvKYGp4dHTvQIFLWHk74/PFhtq8WB2M=; X-UUID: 0bc7a8b8818f4c6e8ea4af27196f3ffb-20201204 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 110740681; Fri, 04 Dec 2020 09:34:10 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 4 Dec 2020 09:34:07 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 4 Dec 2020 09:34:09 +0800 Message-ID: <1607045648.22275.7.camel@mtkswgap22> Subject: Re: [PATCH v2] proc: use untagged_addr() for pagemap_read addresses From: Miles Chen To: Catalin Marinas CC: Alexey Dobriyan , Andrew Morton , , , , , Andrey Konovalov , Alexander Potapenko , Vincenzo Frascino , Andrey Ryabinin , Dmitry Vyukov , Marco Elver , "Will Deacon" , "Eric W . Biederman" , Song Bao Hua , Date: Fri, 4 Dec 2020 09:34:08 +0800 In-Reply-To: <20201203113020.GE2224@gaia> References: <20201127050738.14440-1-miles.chen@mediatek.com> <20201203113020.GE2224@gaia> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 552F8B8F974629EEEA03397AF0B305287B0DA99E5025DF5071FD727CF3EB5E5F2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIwLTEyLTAzIGF0IDExOjMwICswMDAwLCBDYXRhbGluIE1hcmluYXMgd3JvdGU6 DQo+IE9uIEZyaSwgTm92IDI3LCAyMDIwIGF0IDAxOjA3OjM4UE0gKzA4MDAsIE1pbGVzIENoZW4g d3JvdGU6DQo+ID4gQ2M6IFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0uY29tPg0KPiANCj4g VGhhdCBzaG91bGQgYmUgd2lsbEBrZXJuZWwub3JnLg0KDQpvaywgSSB3aWxsIGZpeCBpdCBhbmQg c3VibWl0IHYzDQo+IA0KPiA+IGRpZmYgLS1naXQgYS9mcy9wcm9jL3Rhc2tfbW11LmMgYi9mcy9w cm9jL3Rhc2tfbW11LmMNCj4gPiBpbmRleCAyMTdhYTI3MDVkNWQuLjkyYjI3NzM4OGYwNSAxMDA2 NDQNCj4gPiAtLS0gYS9mcy9wcm9jL3Rhc2tfbW11LmMNCj4gPiArKysgYi9mcy9wcm9jL3Rhc2tf bW11LmMNCj4gPiBAQCAtMTU5OSwxMSArMTU5OSwxNSBAQCBzdGF0aWMgc3NpemVfdCBwYWdlbWFw X3JlYWQoc3RydWN0IGZpbGUgKmZpbGUsIGNoYXIgX191c2VyICpidWYsDQo+ID4gIA0KPiA+ICAJ c3JjID0gKnBwb3M7DQo+ID4gIAlzdnBmbiA9IHNyYyAvIFBNX0VOVFJZX0JZVEVTOw0KPiA+IC0J c3RhcnRfdmFkZHIgPSBzdnBmbiA8PCBQQUdFX1NISUZUOw0KPiA+ICAJZW5kX3ZhZGRyID0gbW0t PnRhc2tfc2l6ZTsNCj4gPiAgDQo+ID4gIAkvKiB3YXRjaCBvdXQgZm9yIHdyYXBhcm91bmQgKi8N Cj4gPiAtCWlmIChzdnBmbiA+IG1tLT50YXNrX3NpemUgPj4gUEFHRV9TSElGVCkNCj4gPiArCXN0 YXJ0X3ZhZGRyID0gZW5kX3ZhZGRyOw0KPiA+ICsJaWYgKHN2cGZuIDwgKFVMT05HX01BWCA+PiBQ QUdFX1NISUZUKSkNCj4gDQo+IERvZXMgdGhpcyBuZWVkIHRvIGJlIHN0cmljdCBsZXNzLXRoYW4/ IEkgdGhpbmsgYSBsZXNzLXRoYW4gb3IgZXF1YWwNCj4gd291bGQgd29yayBiZXR0ZXIuDQoNClRo YW5rcywgSSB3aWxsIGZpeCBpdCBhbmQgc3VibWl0IHYzLg0KPiANCj4gPiArCQlzdGFydF92YWRk ciA9IHVudGFnZ2VkX2FkZHIoc3ZwZm4gPDwgUEFHRV9TSElGVCk7DQo+ID4gKw0KPiA+ICsJLyog RW5zdXJlIHRoZSBhZGRyZXNzIGlzIGluc2lkZSB0aGUgdGFzayAqLw0KPiA+ICsJaWYgKHN0YXJ0 X3ZhZGRyID4gbW0tPnRhc2tfc2l6ZSkNCj4gPiAgCQlzdGFydF92YWRkciA9IGVuZF92YWRkcjsN Cj4gDQo+IE90aGVyd2lzZSB0aGUgbG9naWMgbG9va3MgZmluZSB0byBtZS4gV2l0aCB0aGUgYWJv dmU6DQo+IA0KPiBSZXZpZXdlZC1ieTogQ2F0YWxpbiBNYXJpbmFzIDxjYXRhbGluLm1hcmluYXNA YXJtLmNvbT4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30FEC4361B for ; Fri, 4 Dec 2020 01:42:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 583FB224DF for ; Fri, 4 Dec 2020 01:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 583FB224DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=imVCxUG7jcUMJF6V/ilp61Nnp8w+gsbnearzgkTIvVU=; b=WPMaf/H6dvLB2hRe7TVLoPB9G EAqMO7+ygFB2/scliM6Jixu7XqcaU6EPO4p27yCrAxHHM0exS51SzrehFKWd7NR5TZ3hasPpDe3MG 0UKh49cRoM6/EPK6qaU6e29F/Uc5Jl5LCNgs5Gp17a82tJSQLIiyFNya0HUHl0CWBZfx5GhQERkwV QwFg2u/ocrJlIgYg5nG+Neex6aaVNKekjAU3TTM+N4/CWAzJr0ib3gY6CeGT9BeeX0aE0yPbiC0UM 0A3MC9Fn2mmO367FQSwT8x0r6XtnwjYMt7gvQ13Oc9t+pOBSZpyyv8rkBpgKnRA/L8RurkeyoW191 +eEoMompA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl07T-0003iL-AZ; Fri, 04 Dec 2020 01:42:47 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kl07Q-0003h4-2v for linux-mediatek@lists.infradead.org; Fri, 04 Dec 2020 01:42:45 +0000 X-UUID: a4de14ad5b3b458a8694173ba4a16b8c-20201203 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qpJag3JOEGGUczkknHZEtGGVXhrvUUQwFODEalRuGIQ=; b=K/KjUiBFN6+laNMBzZcBvbL+1pSvY4m/JyGUX5m4MFXtWKZyvwtkgtc3RBi8dwYFA1EbhGlnFPf5ysTb4PYIHsqY0GkF7Ly1rS3W2L0ZksThwmqg7EYRfOhQrL+It93yQM5mNWYoC8AeRyE2i7FornrIioFLe5aCUvnj6eIUR60=; X-UUID: a4de14ad5b3b458a8694173ba4a16b8c-20201203 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1606779229; Thu, 03 Dec 2020 17:42:38 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 3 Dec 2020 17:34:10 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 4 Dec 2020 09:34:07 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 4 Dec 2020 09:34:09 +0800 Message-ID: <1607045648.22275.7.camel@mtkswgap22> Subject: Re: [PATCH v2] proc: use untagged_addr() for pagemap_read addresses From: Miles Chen To: Catalin Marinas Date: Fri, 4 Dec 2020 09:34:08 +0800 In-Reply-To: <20201203113020.GE2224@gaia> References: <20201127050738.14440-1-miles.chen@mediatek.com> <20201203113020.GE2224@gaia> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 552F8B8F974629EEEA03397AF0B305287B0DA99E5025DF5071FD727CF3EB5E5F2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_204244_346985_72DAC4A5 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Bao Hua , Marco Elver , wsd_upstream@mediatek.com, Andrey Konovalov , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mediatek@lists.infradead.org, "Eric W . Biederman" , Andrey Ryabinin , linux-fsdevel@vger.kernel.org, Alexander Potapenko , Andrew Morton , Vincenzo Frascino , Will Deacon , Alexey Dobriyan , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-12-03 at 11:30 +0000, Catalin Marinas wrote: > On Fri, Nov 27, 2020 at 01:07:38PM +0800, Miles Chen wrote: > > Cc: Will Deacon > > That should be will@kernel.org. ok, I will fix it and submit v3 > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index 217aa2705d5d..92b277388f05 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -1599,11 +1599,15 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, > > > > src = *ppos; > > svpfn = src / PM_ENTRY_BYTES; > > - start_vaddr = svpfn << PAGE_SHIFT; > > end_vaddr = mm->task_size; > > > > /* watch out for wraparound */ > > - if (svpfn > mm->task_size >> PAGE_SHIFT) > > + start_vaddr = end_vaddr; > > + if (svpfn < (ULONG_MAX >> PAGE_SHIFT)) > > Does this need to be strict less-than? I think a less-than or equal > would work better. Thanks, I will fix it and submit v3. > > > + start_vaddr = untagged_addr(svpfn << PAGE_SHIFT); > > + > > + /* Ensure the address is inside the task */ > > + if (start_vaddr > mm->task_size) > > start_vaddr = end_vaddr; > > Otherwise the logic looks fine to me. With the above: > > Reviewed-by: Catalin Marinas _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek