From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53271C4361B for ; Tue, 8 Dec 2020 01:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F3832388C for ; Tue, 8 Dec 2020 01:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727366AbgLHBus (ORCPT ); Mon, 7 Dec 2020 20:50:48 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:37151 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727075AbgLHBus (ORCPT ); Mon, 7 Dec 2020 20:50:48 -0500 X-UUID: fdbb80fd9bda4663a4dd7c600d47bb8f-20201208 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=dCzH311+U2RFvjPiv7C+GlVUPgKHpvOsRKaE8jAB0UM=; b=dAks2qEQ9ToMg60OeCOyZKIZs2vHSPVaZtFyg63SUZxre5J+IYe0U1+QO+yv1ePO/vFjjqU/SyP7MLSZZaCooHp4ruB658gHV+xp9vdN4SCpMhIqYRxEan8hqQf+B6Fnp6IGd8zktk8cW25wiYpPb0JDnroWJRsQBsnmEJCFsXc=; X-UUID: fdbb80fd9bda4663a4dd7c600d47bb8f-20201208 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 630910657; Tue, 08 Dec 2020 09:50:04 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 09:49:59 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Dec 2020 09:49:57 +0800 Message-ID: <1607392202.23328.1.camel@mhfsdcap03> Subject: Re: [PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message From: Chunfeng Yun To: Colin King CC: Chun-Kuang Hu , Philipp Zabel , Kishon Vijay Abraham I , "Vinod Koul" , Matthias Brugger , CK Hu , chunhui dai , , , , , Date: Tue, 8 Dec 2020 09:50:02 +0800 In-Reply-To: <20201207150937.170435-1-colin.king@canonical.com> References: <20201207150937.170435-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIwLTEyLTA3IGF0IDE1OjA5ICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy cmVudGx5IHRoZXJlIGlzIGEgbnVsbCBwb2ludGVyIGNoZWNrIGZvciBoZG1pX3BoeSB0aGF0IGlt cGxpZXMgaXQNCj4gbWF5IGJlIG51bGwsIGhvd2V2ZXIgYSBkZXZfZXJyIG1lc3NhZ2VzIGRlcmVm ZXJlbmNlcyB0aGlzIHBvdGVudGlhbCBudWxsDQo+IHBvaW50ZXIuICBBdm9pZCBhIG51bGwgcG9p bnRlciBkZXJlZmVyZW5jZSBieSBvbmx5IGVtaXR0aW5nIHRoZSBkZXZfZXJyDQo+IG1lc3NhZ2Ug aWYgaGRtaV9waHkgaXMgbm9uLW51bGwuICBJdCBpcyBhIG1vb3QgcG9pbnQgaWYgdGhlIGVycm9y IG1lc3NhZ2UNCj4gbmVlZHMgdG8gYmUgcHJpbnRlZCBhdCBhbGwsIGJ1dCBzaW5jZSB0aGlzIGlz IGEgcmVsYXRpdmVseSBuZXcgcGllY2Ugb2YNCj4gY29kZSBpdCBtYXkgYmUgdXNlZnVsIHRvIGtl ZXAgdGhlIG1lc3NhZ2UgaW4gZm9yIHRoZSBtb21lbnQgaW4gY2FzZSB0aGVyZQ0KPiBhcmUgdW5m b3JzZWVuIGVycm9ycyB0aGF0IG5lZWQgdG8gYmUgcmVwb3J0ZWQuDQo+IA0KPiBBZGRyZXNzZXMt Q292ZXJpdHk6ICgiRGVyZWZlcmVuY2UgYWZ0ZXIgbnVsbCBjaGVjayIpDQo+IEZpeGVzOiBiZTI4 YjY1MDdjNDYgKCJkcm0vbWVkaWF0ZWs6IHNlcGFyYXRlIGhkbWkgcGh5IHRvIGRpZmZlcmVudCBm aWxlIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25p Y2FsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWhkbWkuYyB8 IDUgKysrLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1oZG1p LmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWhkbWkuYw0KPiBpbmRleCBjNWM2MWY1 YTllYTAuLjUxODQwNTQ3ODNjNyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsv cGh5LW10ay1oZG1pLmMNCj4gKysrIGIvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1oZG1p LmMNCj4gQEAgLTg0LDggKzg0LDkgQEAgbXRrX2hkbWlfcGh5X2Rldl9nZXRfb3BzKGNvbnN0IHN0 cnVjdCBtdGtfaGRtaV9waHkgKmhkbWlfcGh5KQ0KPiAgCSAgICBoZG1pX3BoeS0+Y29uZi0+aGRt aV9waHlfZGlzYWJsZV90bWRzKQ0KPiAgCQlyZXR1cm4gJm10a19oZG1pX3BoeV9kZXZfb3BzOw0K PiAgDQo+IC0JZGV2X2VycihoZG1pX3BoeS0+ZGV2LCAiRmFpbGVkIHRvIGdldCBkZXYgb3BzIG9m IHBoeVxuIik7DQo+IC0JCXJldHVybiBOVUxMOw0KPiArCWlmIChoZG1pX3BoeSkNCj4gKwkJZGV2 X2VycihoZG1pX3BoeS0+ZGV2LCAiRmFpbGVkIHRvIGdldCBkZXYgb3BzIG9mIHBoeVxuIik7DQo+ ICsJCQlyZXR1cm4gTlVMTDsNCmluZGVudGF0aW9uOiBvbmUgdGFiIGJlZm9yZSByZXR1cm4NCg0K VGhhbmtzDQoNCj4gIH0NCj4gIA0KPiAgc3RhdGljIHZvaWQgbXRrX2hkbWlfcGh5X2Nsa19nZXRf ZGF0YShzdHJ1Y3QgbXRrX2hkbWlfcGh5ICpoZG1pX3BoeSwNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Date: Tue, 08 Dec 2020 01:50:02 +0000 Subject: Re: [PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message Message-Id: <1607392202.23328.1.camel@mhfsdcap03> List-Id: References: <20201207150937.170435-1-colin.king@canonical.com> In-Reply-To: <20201207150937.170435-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Chun-Kuang Hu , chunhui dai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , Vinod Koul , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org T24gTW9uLCAyMDIwLTEyLTA3IGF0IDE1OjA5ICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3Vy cmVudGx5IHRoZXJlIGlzIGEgbnVsbCBwb2ludGVyIGNoZWNrIGZvciBoZG1pX3BoeSB0aGF0IGlt cGxpZXMgaXQNCj4gbWF5IGJlIG51bGwsIGhvd2V2ZXIgYSBkZXZfZXJyIG1lc3NhZ2VzIGRlcmVm ZXJlbmNlcyB0aGlzIHBvdGVudGlhbCBudWxsDQo+IHBvaW50ZXIuICBBdm9pZCBhIG51bGwgcG9p bnRlciBkZXJlZmVyZW5jZSBieSBvbmx5IGVtaXR0aW5nIHRoZSBkZXZfZXJyDQo+IG1lc3NhZ2Ug aWYgaGRtaV9waHkgaXMgbm9uLW51bGwuICBJdCBpcyBhIG1vb3QgcG9pbnQgaWYgdGhlIGVycm9y IG1lc3NhZ2UNCj4gbmVlZHMgdG8gYmUgcHJpbnRlZCBhdCBhbGwsIGJ1dCBzaW5jZSB0aGlzIGlz IGEgcmVsYXRpdmVseSBuZXcgcGllY2Ugb2YNCj4gY29kZSBpdCBtYXkgYmUgdXNlZnVsIHRvIGtl ZXAgdGhlIG1lc3NhZ2UgaW4gZm9yIHRoZSBtb21lbnQgaW4gY2FzZSB0aGVyZQ0KPiBhcmUgdW5m b3JzZWVuIGVycm9ycyB0aGF0IG5lZWQgdG8gYmUgcmVwb3J0ZWQuDQo+IA0KPiBBZGRyZXNzZXMt Q292ZXJpdHk6ICgiRGVyZWZlcmVuY2UgYWZ0ZXIgbnVsbCBjaGVjayIpDQo+IEZpeGVzOiBiZTI4 YjY1MDdjNDYgKCJkcm0vbWVkaWF0ZWs6IHNlcGFyYXRlIGhkbWkgcGh5IHRvIGRpZmZlcmVudCBm aWxlIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25p Y2FsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWhkbWkuYyB8 IDUgKysrLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1oZG1p LmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWhkbWkuYw0KPiBpbmRleCBjNWM2MWY1 YTllYTAuLjUxODQwNTQ3ODNjNyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsv cGh5LW10ay1oZG1pLmMNCj4gKysrIGIvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1oZG1p LmMNCj4gQEAgLTg0LDggKzg0LDkgQEAgbXRrX2hkbWlfcGh5X2Rldl9nZXRfb3BzKGNvbnN0IHN0 cnVjdCBtdGtfaGRtaV9waHkgKmhkbWlfcGh5KQ0KPiAgCSAgICBoZG1pX3BoeS0+Y29uZi0+aGRt aV9waHlfZGlzYWJsZV90bWRzKQ0KPiAgCQlyZXR1cm4gJm10a19oZG1pX3BoeV9kZXZfb3BzOw0K PiAgDQo+IC0JZGV2X2VycihoZG1pX3BoeS0+ZGV2LCAiRmFpbGVkIHRvIGdldCBkZXYgb3BzIG9m IHBoeVxuIik7DQo+IC0JCXJldHVybiBOVUxMOw0KPiArCWlmIChoZG1pX3BoeSkNCj4gKwkJZGV2 X2VycihoZG1pX3BoeS0+ZGV2LCAiRmFpbGVkIHRvIGdldCBkZXYgb3BzIG9mIHBoeVxuIik7DQo+ ICsJCQlyZXR1cm4gTlVMTDsNCmluZGVudGF0aW9uOiBvbmUgdGFiIGJlZm9yZSByZXR1cm4NCg0K VGhhbmtzDQoNCj4gIH0NCj4gIA0KPiAgc3RhdGljIHZvaWQgbXRrX2hkbWlfcGh5X2Nsa19nZXRf ZGF0YShzdHJ1Y3QgbXRrX2hkbWlfcGh5ICpoZG1pX3BoeSwNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DC8C433FE for ; Tue, 8 Dec 2020 01:50:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144EE238E7 for ; Tue, 8 Dec 2020 01:50:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144EE238E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P4u0dj11taaDfQLAcMjR81jXwy239fHNjrIbOO7xpH0=; b=YlmUzG9rY2KgcSCB0Vk3W8jB6 3Alcp9ou/RleOmEI6YXGVX3wayuoA421fKouOu8D1WWVgrE1KRNhE4wLCKuRaCMQ1PshjirUZBMIq CtB/cXL6p6Jkya6AduXd2AKFNmfXOtX7vzuMI6RRkk4CIrHoIjwjh8PU0alceDgrCQ3Jcs/vRu9ZW 7eFr2HMQcf5b7rXubPm4veIRY+OGaiz6RT1AHRWaM1DG/5OaTZ+W+2KrHC1ARCrd1jxDfDFtXwKY3 z5SwO1KQtRqOBL2HAdp4m/COUZfclLjc+qY66DsHn//nZzvHx6sr2N3wKI57dQ5MfgF3ixa88XY6M v3QT99rCQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmS8r-0006wi-I9; Tue, 08 Dec 2020 01:50:13 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmS8o-0006w2-EO; Tue, 08 Dec 2020 01:50:11 +0000 X-UUID: 9006af38c67042e1a05a8666cbf4a0c4-20201207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=dCzH311+U2RFvjPiv7C+GlVUPgKHpvOsRKaE8jAB0UM=; b=dAks2qEQ9ToMg60OeCOyZKIZs2vHSPVaZtFyg63SUZxre5J+IYe0U1+QO+yv1ePO/vFjjqU/SyP7MLSZZaCooHp4ruB658gHV+xp9vdN4SCpMhIqYRxEan8hqQf+B6Fnp6IGd8zktk8cW25wiYpPb0JDnroWJRsQBsnmEJCFsXc=; X-UUID: 9006af38c67042e1a05a8666cbf4a0c4-20201207 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1783293279; Mon, 07 Dec 2020 17:50:06 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Dec 2020 17:50:04 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 09:49:59 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Dec 2020 09:49:57 +0800 Message-ID: <1607392202.23328.1.camel@mhfsdcap03> Subject: Re: [PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message From: Chunfeng Yun To: Colin King Date: Tue, 8 Dec 2020 09:50:02 +0800 In-Reply-To: <20201207150937.170435-1-colin.king@canonical.com> References: <20201207150937.170435-1-colin.king@canonical.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_205010_634942_5DBDA134 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , chunhui dai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , CK Hu , Vinod Koul , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2020-12-07 at 15:09 +0000, Colin King wrote: > From: Colin Ian King > > Currently there is a null pointer check for hdmi_phy that implies it > may be null, however a dev_err messages dereferences this potential null > pointer. Avoid a null pointer dereference by only emitting the dev_err > message if hdmi_phy is non-null. It is a moot point if the error message > needs to be printed at all, but since this is a relatively new piece of > code it may be useful to keep the message in for the moment in case there > are unforseen errors that need to be reported. > > Addresses-Coverity: ("Dereference after null check") > Fixes: be28b6507c46 ("drm/mediatek: separate hdmi phy to different file") > Signed-off-by: Colin Ian King > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c > index c5c61f5a9ea0..5184054783c7 100644 > --- a/drivers/phy/mediatek/phy-mtk-hdmi.c > +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c > @@ -84,8 +84,9 @@ mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy) > hdmi_phy->conf->hdmi_phy_disable_tmds) > return &mtk_hdmi_phy_dev_ops; > > - dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > - return NULL; > + if (hdmi_phy) > + dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > + return NULL; indentation: one tab before return Thanks > } > > static void mtk_hdmi_phy_clk_get_data(struct mtk_hdmi_phy *hdmi_phy, _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6C1C4361B for ; Tue, 8 Dec 2020 01:51:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87D882388C for ; Tue, 8 Dec 2020 01:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87D882388C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QSqjzgS2BIvm42GYOR9YG/hTXfNhlS/Rn0hf1pw7h/M=; b=XUw/uRri01aYGKwsnVYYL/7+g DEeAwgovdy1dQn9BXfQGftHKcFQSqL4UZHYawPkjaPwGzG/BvCCMaicuXwAjG3LkB7mfNXSO9jl8t PjFsOtj3VptSKKTa28FLMwdOny41A1NWS/o45LEdLRadZb+f48bTO8FU4ppvdsg3YLDgZ6WDl5XE9 Ru3arCkHVSx74MvTJXW8i97TUneNGnfq2ybQQJiQWKxYMN1s7qAxoOp8dpBmGe6D/Mt5SyU/olknw xpp/Brw33jr/+1W+AXnH6O5hmNI9v4CUGqNijTol6rb8TCCTD9ot6bn+HPxnTCHvyYRY6A1mi1nrk uTdYwc36A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmS8s-0006wt-7T; Tue, 08 Dec 2020 01:50:14 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmS8o-0006w2-EO; Tue, 08 Dec 2020 01:50:11 +0000 X-UUID: 9006af38c67042e1a05a8666cbf4a0c4-20201207 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=dCzH311+U2RFvjPiv7C+GlVUPgKHpvOsRKaE8jAB0UM=; b=dAks2qEQ9ToMg60OeCOyZKIZs2vHSPVaZtFyg63SUZxre5J+IYe0U1+QO+yv1ePO/vFjjqU/SyP7MLSZZaCooHp4ruB658gHV+xp9vdN4SCpMhIqYRxEan8hqQf+B6Fnp6IGd8zktk8cW25wiYpPb0JDnroWJRsQBsnmEJCFsXc=; X-UUID: 9006af38c67042e1a05a8666cbf4a0c4-20201207 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1783293279; Mon, 07 Dec 2020 17:50:06 -0800 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Dec 2020 17:50:04 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 09:49:59 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Dec 2020 09:49:57 +0800 Message-ID: <1607392202.23328.1.camel@mhfsdcap03> Subject: Re: [PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message From: Chunfeng Yun To: Colin King Date: Tue, 8 Dec 2020 09:50:02 +0800 In-Reply-To: <20201207150937.170435-1-colin.king@canonical.com> References: <20201207150937.170435-1-colin.king@canonical.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_205010_634942_5DBDA134 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , chunhui dai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , CK Hu , Vinod Koul , linux-mediatek@lists.infradead.org, Philipp Zabel , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-12-07 at 15:09 +0000, Colin King wrote: > From: Colin Ian King > > Currently there is a null pointer check for hdmi_phy that implies it > may be null, however a dev_err messages dereferences this potential null > pointer. Avoid a null pointer dereference by only emitting the dev_err > message if hdmi_phy is non-null. It is a moot point if the error message > needs to be printed at all, but since this is a relatively new piece of > code it may be useful to keep the message in for the moment in case there > are unforseen errors that need to be reported. > > Addresses-Coverity: ("Dereference after null check") > Fixes: be28b6507c46 ("drm/mediatek: separate hdmi phy to different file") > Signed-off-by: Colin Ian King > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c > index c5c61f5a9ea0..5184054783c7 100644 > --- a/drivers/phy/mediatek/phy-mtk-hdmi.c > +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c > @@ -84,8 +84,9 @@ mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy) > hdmi_phy->conf->hdmi_phy_disable_tmds) > return &mtk_hdmi_phy_dev_ops; > > - dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > - return NULL; > + if (hdmi_phy) > + dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > + return NULL; indentation: one tab before return Thanks > } > > static void mtk_hdmi_phy_clk_get_data(struct mtk_hdmi_phy *hdmi_phy, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AD9C433FE for ; Tue, 8 Dec 2020 08:33:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51B9C23A7D for ; Tue, 8 Dec 2020 08:33:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51B9C23A7D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5F016E9B0; Tue, 8 Dec 2020 08:32:24 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id 2EBC16E8A7 for ; Tue, 8 Dec 2020 01:50:06 +0000 (UTC) X-UUID: fdbb80fd9bda4663a4dd7c600d47bb8f-20201208 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=dCzH311+U2RFvjPiv7C+GlVUPgKHpvOsRKaE8jAB0UM=; b=dAks2qEQ9ToMg60OeCOyZKIZs2vHSPVaZtFyg63SUZxre5J+IYe0U1+QO+yv1ePO/vFjjqU/SyP7MLSZZaCooHp4ruB658gHV+xp9vdN4SCpMhIqYRxEan8hqQf+B6Fnp6IGd8zktk8cW25wiYpPb0JDnroWJRsQBsnmEJCFsXc=; X-UUID: fdbb80fd9bda4663a4dd7c600d47bb8f-20201208 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 630910657; Tue, 08 Dec 2020 09:50:04 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 09:49:59 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Dec 2020 09:49:57 +0800 Message-ID: <1607392202.23328.1.camel@mhfsdcap03> Subject: Re: [PATCH][next] drm/mediatek: avoid dereferencing a null hdmi_phy on an error message From: Chunfeng Yun To: Colin King Date: Tue, 8 Dec 2020 09:50:02 +0800 In-Reply-To: <20201207150937.170435-1-colin.king@canonical.com> References: <20201207150937.170435-1-colin.king@canonical.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Tue, 08 Dec 2020 08:32:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , chunhui dai , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , Vinod Koul , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 2020-12-07 at 15:09 +0000, Colin King wrote: > From: Colin Ian King > > Currently there is a null pointer check for hdmi_phy that implies it > may be null, however a dev_err messages dereferences this potential null > pointer. Avoid a null pointer dereference by only emitting the dev_err > message if hdmi_phy is non-null. It is a moot point if the error message > needs to be printed at all, but since this is a relatively new piece of > code it may be useful to keep the message in for the moment in case there > are unforseen errors that need to be reported. > > Addresses-Coverity: ("Dereference after null check") > Fixes: be28b6507c46 ("drm/mediatek: separate hdmi phy to different file") > Signed-off-by: Colin Ian King > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c > index c5c61f5a9ea0..5184054783c7 100644 > --- a/drivers/phy/mediatek/phy-mtk-hdmi.c > +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c > @@ -84,8 +84,9 @@ mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy) > hdmi_phy->conf->hdmi_phy_disable_tmds) > return &mtk_hdmi_phy_dev_ops; > > - dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > - return NULL; > + if (hdmi_phy) > + dev_err(hdmi_phy->dev, "Failed to get dev ops of phy\n"); > + return NULL; indentation: one tab before return Thanks > } > > static void mtk_hdmi_phy_clk_get_data(struct mtk_hdmi_phy *hdmi_phy, _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel