From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A53F6EAD0 for ; Wed, 9 Dec 2020 16:47:10 +0000 (UTC) MIME-Version: 1.0 In-Reply-To: <20201209162502.GA6486@intel.com> References: <20201209160642.6317-1-anshuman.gupta@intel.com> <20201209160642.6317-3-anshuman.gupta@intel.com> <160753115527.595.15173510320238280650@build.alporthouse.com> <20201209162502.GA6486@intel.com> From: Chris Wilson Date: Wed, 09 Dec 2020 16:47:01 +0000 Message-ID: <160753242185.595.5436148780497590017@build.alporthouse.com> Subject: Re: [igt-dev] [PATCH i-g-t 2/6] i915/i915_pm_rpm.c: create PC state subtest group List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Anshuman Gupta Cc: igt-dev@lists.freedesktop.org List-ID: Quoting Anshuman Gupta (2020-12-09 16:25:02) > On 2020-12-09 at 16:25:55 +0000, Chris Wilson wrote: > > Quoting Anshuman Gupta (2020-12-09 16:06:38) > > > Create a separate igt test group and move package C > > > state in to this subgroup. > > > Run powertop --auto-tune to tune SOC power configuration > > > for package C state tests. > > > > > > Signed-off-by: Anshuman Gupta > > > --- > > > tests/i915/i915_pm_rpm.c | 35 +++++++++++++++++++++++++++++++---- > > > 1 file changed, 31 insertions(+), 4 deletions(-) > > > > > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c > > > index af55b569..42bc44d9 100644 > > > --- a/tests/i915/i915_pm_rpm.c > > > +++ b/tests/i915/i915_pm_rpm.c > > > @@ -832,6 +832,25 @@ static void basic_subtest(void) > > > /* XXX Also we can test wake up via exec nop */ > > > } > > > > > > +static bool setup_powertop(void) > > > +{ > > > + FILE *fp; > > > + char tmp[512]; > > > + > > > + fp = popen("powertop --auto-tune", "r"); > > > > Doesn't this defeat the point of having it work out of the box? > > -Chris > Yes, but there is no other way as PC state are being dependent on other > non-gfx devices as well. These test kept disabled since gen9 platforms. Could you be explicit in the steps required so that it is clear that powertop is not working around our own bugs? -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev