All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: richard.henderson@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v4 00/43] Mirror map JIT memory for TCG
Date: Mon, 14 Dec 2020 13:01:11 -0800 (PST)	[thread overview]
Message-ID: <160797967049.11398.17065640045028621864@600e7e483b3a> (raw)
In-Reply-To: <20201214140314.18544-1-richard.henderson@linaro.org>

Patchew URL: https://patchew.org/QEMU/20201214140314.18544-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201214140314.18544-1-richard.henderson@linaro.org
Subject: [PATCH v4 00/43] Mirror map JIT memory for TCG

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   37f04b7..aa14de0  master     -> master
 - [tag update]      patchew/20201211220529.2290218-1-ehabkost@redhat.com -> patchew/20201211220529.2290218-1-ehabkost@redhat.com
 * [new tag]         patchew/20201214140314.18544-1-richard.henderson@linaro.org -> patchew/20201214140314.18544-1-richard.henderson@linaro.org
 * [new tag]         patchew/20201214155733.207430-1-laurent@vivier.eu -> patchew/20201214155733.207430-1-laurent@vivier.eu
 * [new tag]         patchew/20201214200713.3886611-1-keithp@keithp.com -> patchew/20201214200713.3886611-1-keithp@keithp.com
Switched to a new branch 'test'
5861ba1 tcg: Constify TCGLabelQemuLdst.raddr
8b66138 tcg: Constify tcg_code_gen_epilogue
b60ae50 tcg: Remove TCG_TARGET_SUPPORT_MIRROR
ceb2ae8 tcg/arm: Support split-wx code generation
ddb32ce tcg/mips: Support split-wx code generation
d286278 tcg/mips: Do not assert on relocation overflow
c6603c2 accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd
f472d2a tcg/riscv: Support split-wx code generation
c7b4c9e tcg/riscv: Remove branch-over-branch fallback
5a73605 tcg/riscv: Fix branch range checks
b07237d tcg/s390: Support split-wx code generation
1b609a5 tcg/s390: Use tcg_tbrel_diff
ab6c76a tcg/sparc: Support split-wx code generation
eeb9f35 tcg/sparc: Use tcg_tbrel_diff
5d2fb73 tcg/ppc: Support split-wx code generation
54626b4 tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB
a810384 tcg/ppc: Use tcg_tbrel_diff
4327613 tcg: Introduce tcg_tbrel_diff
b5817c5 tcg/tci: Push const down through bytecode reading
3a0b856 disas: Push const down through host disasassembly
875346c tcg/aarch64: Support split-wx code generation
d8fca0b tcg/aarch64: Use B not BL for tcg_out_goto_long
5c1da59 tcg/i386: Support split-wx code generation
cf974dc tcg: Return the TB pointer from the rx region from exit_tb
4e63180 accel/tcg: Support split-wx for darwin/iOS with vm_remap
2acd41d accel/tcg: Support split-wx for linux with memfd
43dc2fc tcg: Add --accel tcg,split-wx property
a93d787 tcg: Use Error with alloc_code_gen_buffer
14f4dae tcg: Make tb arg to synchronize_from_tb const
6d2cbe3 tcg: Make DisasContextBase.tb const
1ff4e38 tcg: Adjust tb_target_set_jmp_target for split-wx
9163383 tcg: Adjust tcg_register_jit for const
ef98b3c tcg: Adjust tcg_out_label for const
ff58797 tcg: Adjust tcg_out_call for const
204f5dd tcg: Adjust TCGLabel for const
3a0629b tcg: Introduce tcg_splitwx_to_{rx,rw}
e69b13a tcg: Add in_code_gen_buffer
0c55fbc tcg: Move tcg epilogue pointer out of TCGContext
5b1eb71 tcg: Move tcg prologue pointer out of TCGContext
22fc3b0 util: Specialize flush_idcache_range for aarch64
4a47d91 util: Enhance flush_icache_range with separate data pointer
722b23b util: Extract flush_icache_range to cacheflush.c
2a3aaed tcg: Do not flush icache for interpreter

=== OUTPUT BEGIN ===
1/43 Checking commit 2a3aaedef170 (tcg: Do not flush icache for interpreter)
2/43 Checking commit 722b23b5bb81 (util: Extract flush_icache_range to cacheflush.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

WARNING: architecture specific defines should be avoided
#43: FILE: include/qemu/cacheflush.h:11:
+#if defined(__i386__) || defined(__x86_64__) || defined(__s390__)

WARNING: architecture specific defines should be avoided
#277: FILE: util/cacheflush.c:12:
+#if defined(__i386__) || defined(__x86_64__) || defined(__s390__)

WARNING: architecture specific defines should be avoided
#283: FILE: util/cacheflush.c:18:
+#ifdef __OpenBSD__

total: 0 errors, 4 warnings, 232 lines checked

Patch 2/43 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/43 Checking commit 4a47d9160cc1 (util: Enhance flush_icache_range with separate data pointer)
4/43 Checking commit 22fc3b028090 (util: Specialize flush_idcache_range for aarch64)
ERROR: externs should be avoided in .c files
#38: FILE: util/cacheflush.c:21:
+extern void sys_icache_invalidate(void *start, size_t len);

ERROR: externs should be avoided in .c files
#39: FILE: util/cacheflush.c:22:
+extern void sys_dcache_flush(void *start, size_t len);

total: 2 errors, 0 warnings, 81 lines checked

Patch 4/43 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/43 Checking commit 5b1eb71d0d3a (tcg: Move tcg prologue pointer out of TCGContext)
6/43 Checking commit 0c55fbc2c214 (tcg: Move tcg epilogue pointer out of TCGContext)
7/43 Checking commit e69b13a6c541 (tcg: Add in_code_gen_buffer)
8/43 Checking commit 3a0629b80930 (tcg: Introduce tcg_splitwx_to_{rx,rw})
9/43 Checking commit 204f5dd20af1 (tcg: Adjust TCGLabel for const)
10/43 Checking commit ff58797d1164 (tcg: Adjust tcg_out_call for const)
11/43 Checking commit ef98b3c104ed (tcg: Adjust tcg_out_label for const)
12/43 Checking commit 91633839ff16 (tcg: Adjust tcg_register_jit for const)
13/43 Checking commit 1ff4e38e1db3 (tcg: Adjust tb_target_set_jmp_target for split-wx)
14/43 Checking commit 6d2cbe338b4c (tcg: Make DisasContextBase.tb const)
15/43 Checking commit 14f4daed4c08 (tcg: Make tb arg to synchronize_from_tb const)
16/43 Checking commit a93d787bb9c9 (tcg: Use Error with alloc_code_gen_buffer)
17/43 Checking commit 43dc2fccc410 (tcg: Add --accel tcg,split-wx property)
18/43 Checking commit 2acd41d2d9f5 (accel/tcg: Support split-wx for linux with memfd)
19/43 Checking commit 4e63180ada66 (accel/tcg: Support split-wx for darwin/iOS with vm_remap)
ERROR: externs should be avoided in .c files
#25: FILE: accel/tcg/translate-all.c:1172:
+extern kern_return_t mach_vm_remap(vm_map_t target_task,

total: 1 errors, 0 warnings, 80 lines checked

Patch 19/43 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/43 Checking commit cf974dcd5791 (tcg: Return the TB pointer from the rx region from exit_tb)
21/43 Checking commit 5c1da59df861 (tcg/i386: Support split-wx code generation)
22/43 Checking commit d8fca0b8d088 (tcg/aarch64: Use B not BL for tcg_out_goto_long)
23/43 Checking commit 875346c2f10b (tcg/aarch64: Support split-wx code generation)
24/43 Checking commit 3a0b856585ee (disas: Push const down through host disasassembly)
25/43 Checking commit b5817c5ffe00 (tcg/tci: Push const down through bytecode reading)
26/43 Checking commit 43276137bef1 (tcg: Introduce tcg_tbrel_diff)
27/43 Checking commit a81038425cc1 (tcg/ppc: Use tcg_tbrel_diff)
28/43 Checking commit 54626b45773b (tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB)
29/43 Checking commit 5d2fb73b63eb (tcg/ppc: Support split-wx code generation)
30/43 Checking commit eeb9f35b5237 (tcg/sparc: Use tcg_tbrel_diff)
31/43 Checking commit ab6c76aedab4 (tcg/sparc: Support split-wx code generation)
32/43 Checking commit 1b609a5e826c (tcg/s390: Use tcg_tbrel_diff)
33/43 Checking commit b07237ddf5df (tcg/s390: Support split-wx code generation)
34/43 Checking commit 5a73605068a9 (tcg/riscv: Fix branch range checks)
35/43 Checking commit c7b4c9ef06e0 (tcg/riscv: Remove branch-over-branch fallback)
36/43 Checking commit f472d2a9a4ed (tcg/riscv: Support split-wx code generation)
37/43 Checking commit c6603c22b80e (accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd)
WARNING: architecture specific defines should be avoided
#25: FILE: accel/tcg/translate-all.c:1143:
+#ifdef __mips__

WARNING: architecture specific defines should be avoided
#43: FILE: accel/tcg/translate-all.c:1160:
+#ifdef __mips__

total: 0 errors, 2 warnings, 68 lines checked

Patch 37/43 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/43 Checking commit d2862788fc63 (tcg/mips: Do not assert on relocation overflow)
39/43 Checking commit ddb32ce98dcc (tcg/mips: Support split-wx code generation)
40/43 Checking commit ceb2ae8c947b (tcg/arm: Support split-wx code generation)
41/43 Checking commit b60ae504f046 (tcg: Remove TCG_TARGET_SUPPORT_MIRROR)
42/43 Checking commit 8b66138f4c23 (tcg: Constify tcg_code_gen_epilogue)
43/43 Checking commit 5861ba146e9c (tcg: Constify TCGLabelQemuLdst.raddr)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201214140314.18544-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

      parent reply	other threads:[~2020-12-14 21:03 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 14:02 [PATCH v4 00/43] Mirror map JIT memory for TCG Richard Henderson
2020-12-14 14:02 ` [PATCH v4 01/43] tcg: Do not flush icache for interpreter Richard Henderson
2020-12-14 21:17   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 02/43] util: Extract flush_icache_range to cacheflush.c Richard Henderson
2020-12-14 21:59   ` Philippe Mathieu-Daudé
2020-12-15  1:41   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 03/43] util: Enhance flush_icache_range with separate data pointer Richard Henderson
2020-12-15  1:43   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 04/43] util: Specialize flush_idcache_range for aarch64 Richard Henderson
2020-12-15  1:46   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 05/43] tcg: Move tcg prologue pointer out of TCGContext Richard Henderson
2020-12-14 22:01   ` Philippe Mathieu-Daudé
2020-12-15  1:48   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 06/43] tcg: Move tcg epilogue " Richard Henderson
2020-12-15  1:54   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 07/43] tcg: Add in_code_gen_buffer Richard Henderson
2020-12-14 22:09   ` Philippe Mathieu-Daudé
2020-12-15 22:43     ` Richard Henderson
2020-12-15 23:15       ` Philippe Mathieu-Daudé
2020-12-14 14:02 ` [PATCH v4 08/43] tcg: Introduce tcg_splitwx_to_{rx,rw} Richard Henderson
2021-01-02 20:00   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 09/43] tcg: Adjust TCGLabel for const Richard Henderson
2021-01-02 20:01   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 10/43] tcg: Adjust tcg_out_call " Richard Henderson
2020-12-14 22:16   ` Philippe Mathieu-Daudé
2021-01-02 20:02   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 11/43] tcg: Adjust tcg_out_label " Richard Henderson
2020-12-14 22:18   ` Philippe Mathieu-Daudé
2021-01-02 20:03   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 12/43] tcg: Adjust tcg_register_jit " Richard Henderson
2021-01-02 20:03   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 13/43] tcg: Adjust tb_target_set_jmp_target for split-wx Richard Henderson
2021-01-02 20:05   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 14/43] tcg: Make DisasContextBase.tb const Richard Henderson
2020-12-14 22:14   ` Philippe Mathieu-Daudé
2021-01-02 20:05   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 15/43] tcg: Make tb arg to synchronize_from_tb const Richard Henderson
2020-12-14 22:15   ` Philippe Mathieu-Daudé
2021-01-02 20:06   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 16/43] tcg: Use Error with alloc_code_gen_buffer Richard Henderson
2021-01-02 20:09   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 17/43] tcg: Add --accel tcg,split-wx property Richard Henderson
2020-12-15  2:05   ` Joelle van Dyne
2020-12-15 22:50     ` Richard Henderson
2020-12-14 14:02 ` [PATCH v4 18/43] accel/tcg: Support split-wx for linux with memfd Richard Henderson
2021-01-02 20:11   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 19/43] accel/tcg: Support split-wx for darwin/iOS with vm_remap Richard Henderson
2021-01-05  6:02   ` Joelle van Dyne
2021-01-05 16:57     ` Richard Henderson
2020-12-14 14:02 ` [PATCH v4 20/43] tcg: Return the TB pointer from the rx region from exit_tb Richard Henderson
2021-01-02 20:14   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 21/43] tcg/i386: Support split-wx code generation Richard Henderson
2021-01-02 20:15   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 22/43] tcg/aarch64: Use B not BL for tcg_out_goto_long Richard Henderson
2021-01-02 20:15   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 23/43] tcg/aarch64: Support split-wx code generation Richard Henderson
2021-01-02 20:16   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 24/43] disas: Push const down through host disasassembly Richard Henderson
2020-12-14 22:13   ` Philippe Mathieu-Daudé
2021-01-02 20:18   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 25/43] tcg/tci: Push const down through bytecode reading Richard Henderson
2021-01-02 20:19   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 26/43] tcg: Introduce tcg_tbrel_diff Richard Henderson
2021-01-02 20:19   ` Joelle van Dyne
2020-12-14 14:02 ` [PATCH v4 27/43] tcg/ppc: Use tcg_tbrel_diff Richard Henderson
2020-12-14 14:02 ` [PATCH v4 28/43] tcg/ppc: Use tcg_out_mem_long to reset TCG_REG_TB Richard Henderson
2020-12-14 14:03 ` [PATCH v4 29/43] tcg/ppc: Support split-wx code generation Richard Henderson
2020-12-14 14:03 ` [PATCH v4 30/43] tcg/sparc: Use tcg_tbrel_diff Richard Henderson
2020-12-14 14:03 ` [PATCH v4 31/43] tcg/sparc: Support split-wx code generation Richard Henderson
2020-12-14 14:03 ` [PATCH v4 32/43] tcg/s390: Use tcg_tbrel_diff Richard Henderson
2020-12-14 14:03 ` [PATCH v4 33/43] tcg/s390: Support split-wx code generation Richard Henderson
2020-12-14 14:03 ` [PATCH v4 34/43] tcg/riscv: Fix branch range checks Richard Henderson
2020-12-15 17:29   ` Alistair Francis
2020-12-14 14:03 ` [PATCH v4 35/43] tcg/riscv: Remove branch-over-branch fallback Richard Henderson
2020-12-15 17:30   ` Alistair Francis
2020-12-14 14:03 ` [PATCH v4 36/43] tcg/riscv: Support split-wx code generation Richard Henderson
2020-12-15 17:31   ` Alistair Francis
2020-12-14 14:03 ` [PATCH v4 37/43] accel/tcg: Add mips support to alloc_code_gen_buffer_splitwx_memfd Richard Henderson
2020-12-14 14:03 ` [PATCH v4 38/43] tcg/mips: Do not assert on relocation overflow Richard Henderson
2020-12-14 14:03 ` [PATCH v4 39/43] tcg/mips: Support split-wx code generation Richard Henderson
2020-12-14 14:03 ` [PATCH v4 40/43] tcg/arm: " Richard Henderson
2020-12-14 14:03 ` [PATCH v4 41/43] tcg: Remove TCG_TARGET_SUPPORT_MIRROR Richard Henderson
2021-01-02 20:22   ` Joelle van Dyne
2020-12-14 14:03 ` [PATCH v4 42/43] tcg: Constify tcg_code_gen_epilogue Richard Henderson
2021-01-02 20:23   ` Joelle van Dyne
2020-12-14 14:03 ` [PATCH v4 43/43] tcg: Constify TCGLabelQemuLdst.raddr Richard Henderson
2021-01-02 20:24   ` Joelle van Dyne
2020-12-14 21:01 ` no-reply [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160797967049.11398.17065640045028621864@600e7e483b3a \
    --to=no-reply@patchew.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.