All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: perex@perex.cz, tiwai@suse.com, akpm@linux-foundation.org,
	xiang@kernel.org, pierre-louis.bossart@linux.intel.com,
	gustavoars@kernel.org, shengjiu.wang@nxp.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram
Date: Fri, 18 Dec 2020 00:15:47 +0800	[thread overview]
Message-ID: <1608221747-3474-1-git-send-email-yibin.gong@nxp.com> (raw)

Since mmap for userspace is based on page alignment, add page alignment
for iram alloc from pool, otherwise, some good data located in the same
page of dmab->area maybe touched wrongly by userspace like pulseaudio.

Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
 sound/core/memalloc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
index 0aeeb62..0f33516 100644
--- a/sound/core/memalloc.c
+++ b/sound/core/memalloc.c
@@ -77,7 +77,8 @@ static void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size)
 	/* Assign the pool into private_data field */
 	dmab->private_data = pool;
 
-	dmab->area = gen_pool_dma_alloc(pool, size, &dmab->addr);
+	dmab->area = gen_pool_dma_alloc_align(pool, size, &dmab->addr,
+					PAGE_SIZE);
 }
 
 /**
-- 
2.7.4


             reply	other threads:[~2020-12-17  8:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 16:15 Robin Gong [this message]
2020-12-17  9:38 ` [PATCH v1 ] ALSA: core: memalloc: add page alignment for iram Takashi Iwai
2020-12-17  9:38   ` Takashi Iwai
2020-12-17  9:43 ` Lars-Peter Clausen
2020-12-17  9:55   ` Takashi Iwai
2020-12-17  9:55     ` Takashi Iwai
2020-12-17 10:14     ` Takashi Iwai
2020-12-17 10:14       ` Takashi Iwai
2020-12-17 10:44       ` Lars-Peter Clausen
2020-12-17 10:44         ` Lars-Peter Clausen
2020-12-17 10:59     ` Lars-Peter Clausen
2020-12-17 10:59       ` Lars-Peter Clausen
2020-12-17 11:06       ` Takashi Iwai
2020-12-17 11:06         ` Takashi Iwai
2020-12-17 13:16         ` Lars-Peter Clausen
2020-12-17 14:24           ` Takashi Iwai
2020-12-17 14:57             ` Lars-Peter Clausen
2020-12-17 15:18               ` Takashi Iwai
2020-12-17 15:38                 ` Lars-Peter Clausen
2020-12-17 16:28                   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1608221747-3474-1-git-send-email-yibin.gong@nxp.com \
    --to=yibin.gong@nxp.com \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=shengjiu.wang@nxp.com \
    --cc=tiwai@suse.com \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.