From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A43D7C433E0 for ; Sun, 27 Dec 2020 15:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 695F92250F for ; Sun, 27 Dec 2020 15:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbgL0PLq (ORCPT ); Sun, 27 Dec 2020 10:11:46 -0500 Received: from mail-m965.mail.126.com ([123.126.96.5]:44576 "EHLO mail-m965.mail.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbgL0PLp (ORCPT ); Sun, 27 Dec 2020 10:11:45 -0500 X-Greylist: delayed 2016 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Dec 2020 10:11:43 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=arGaXfT9hHcCAzWG5e 5RPiv2ifF/YyMiSpUcRiFWkhA=; b=cBq4bAg8gey0S0eJo1WsgVykCED+dnYNnb Kpr3YT0JmpRyRppWX60t4QYAajIEg8CEsSsTwM1THTdyeGhJ0tMfIyuFvMBE8iuA RFSeBpxSc+mdfCAbbZZp89FBDDqfxTRHDbHFGHp6xSzL82k0Lb6wTsykO1LvR7ia +J3HjPTSE= Received: from localhost.localdomain (unknown [36.112.86.14]) by smtp10 (Coremail) with SMTP id NuRpCgBHWKvQm+hf44Isig--.54645S2; Sun, 27 Dec 2020 22:36:01 +0800 (CST) From: Defang Bo To: gerg@linux-m68k.org, geert@linux-m68k.org Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, Defang Bo Subject: [PATCH 2/2] m68k: let clk_enable() return immediately if clk is NULL Date: Sun, 27 Dec 2020 22:35:53 +0800 Message-Id: <1609079753-4038536-1-git-send-email-bodefang@126.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: NuRpCgBHWKvQm+hf44Isig--.54645S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RRUDXUUUUU X-Originating-IP: [36.112.86.14] X-CM-SenderInfo: pergvwxdqjqiyswou0bp/1tbiCxEI11x5cpoSBQAAsf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There should be a check for clk to prevent NULL pointer dereference. Signed-off-by: Defang Bo --- arch/m68k/coldfire/clk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c index 7bc666e..cf1ed97 100644 --- a/arch/m68k/coldfire/clk.c +++ b/arch/m68k/coldfire/clk.c @@ -90,6 +90,9 @@ EXPORT_SYMBOL(clk_get); int clk_enable(struct clk *clk) { unsigned long flags; + if (!clk) + return; + spin_lock_irqsave(&clk_lock, flags); if ((clk->enabled++ == 0) && clk->clk_ops) clk->clk_ops->enable(clk); -- 2.7.4