From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 193AFC433DB for ; Mon, 28 Dec 2020 09:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4002208BA for ; Mon, 28 Dec 2020 09:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726961AbgL1J7D (ORCPT ); Mon, 28 Dec 2020 04:59:03 -0500 Received: from mail-m963.mail.126.com ([123.126.96.3]:44784 "EHLO mail-m963.mail.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgL1J7C (ORCPT ); Mon, 28 Dec 2020 04:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=7Talz/lFvusOYa6P4c tOD4KbtRRHAT+PHWA9WD6jOe0=; b=hFoOEthnViifPN/PZLFjX3MmqjQL2I87YM ZPDySn9fLcuY9ek8QT3FQJqGd7NHkdDHanw+9YsSw9krG58Sdz+vYapKmYpbxq0A k/xsOZOZGP8yS6Bm45P7FB4Wr/mC/cc1iMOyiNw4NyQ5FgV805fIb8Fcsdm+5yfu fCN8Yf3NY= Received: from localhost.localdomain (unknown [36.112.86.14]) by smtp8 (Coremail) with SMTP id NORpCgBHVqbJOulfiL6OBA--.38746S2; Mon, 28 Dec 2020 09:54:18 +0800 (CST) From: Defang Bo To: jason.wessel@windriver.com, daniel.thompson@linaro.org, dianders@chromium.org, arnd@arndb.de, gregkh@linuxfoundation.org, kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Defang Bo Subject: [PATCH] kgdbts: Passing ekgdbts to command line causes panic Date: Mon, 28 Dec 2020 09:54:10 +0800 Message-Id: <1609120450-199726-1-git-send-email-bodefang@126.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: NORpCgBHVqbJOulfiL6OBA--.38746S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFW3Kr1UAF4xuF13Zry3CFg_yoW3urX_Ca y5XF1xX3yj9w1qg3W2y393Zr9Fya17u3Z3XFn293yfCry5Cr4q9FWqvFs5WF18XFsFyFsr ZrZIvrW09F1IqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRRoqcUUUUUU== X-Originating-IP: [36.112.86.14] X-CM-SenderInfo: pergvwxdqjqiyswou0bp/1tbi4woJ11pD81jTKwAAs9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Similar to commit<1bd54d851f50>(("kgdboc: Passing ekgdboc to command line causes panic"), kgdbts_option_setup does not check input argument before passing it to strlen. The argument would be a NULL pointer. Signed-off-by: Defang Bo --- drivers/misc/kgdbts.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c index 945701b..b077547 100644 --- a/drivers/misc/kgdbts.c +++ b/drivers/misc/kgdbts.c @@ -1057,6 +1057,11 @@ static void kgdbts_run_tests(void) static int kgdbts_option_setup(char *opt) { + if (!opt) { + pr_err("kgdbts: config string not provided\n"); + return -EINVAL; + } + if (strlen(opt) >= MAX_CONFIG_LEN) { printk(KERN_ERR "kgdbts: config string too long\n"); return -ENOSPC; -- 2.7.4