From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41326C433DB for ; Wed, 30 Dec 2020 10:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18C48217BA for ; Wed, 30 Dec 2020 10:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbgL3KjN (ORCPT ); Wed, 30 Dec 2020 05:39:13 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10012 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgL3KjM (ORCPT ); Wed, 30 Dec 2020 05:39:12 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D5SR908sGzj1G8; Wed, 30 Dec 2020 18:37:41 +0800 (CST) Received: from localhost (10.174.243.127) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Wed, 30 Dec 2020 18:38:20 +0800 From: wangyunjian To: CC: , , , , Yunjian Wang Subject: [PATCH net] macvlan: fix null pointer dereference in macvlan_changelink_sources() Date: Wed, 30 Dec 2020 18:38:15 +0800 Message-ID: <1609324695-1516-1-git-send-email-wangyunjian@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.243.127] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yunjian Wang Currently pointer data is dereferenced when declaring addr before pointer data is null checked. This could lead to a null pointer dereference. Fix this by checking if pointer data is null first. Fixes: 79cf79abce71 ("macvlan: add source mode") Signed-off-by: Yunjian Wang --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index fb51329f8964..e412fd6b6798 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1356,7 +1356,7 @@ static int macvlan_changelink_sources(struct macvlan_dev *vlan, u32 mode, struct nlattr *nla, *head; struct macvlan_source_entry *entry; - if (data[IFLA_MACVLAN_MACADDR]) + if (data && data[IFLA_MACVLAN_MACADDR]) addr = nla_data(data[IFLA_MACVLAN_MACADDR]); if (mode == MACVLAN_MACADDR_ADD) { -- 2.23.0