All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Xu, Rosen" <rosen.xu@intel.com>, "Pei, Andy" <andy.pei@intel.com>
Cc: stable@dpdk.org, "dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"liq3ea@163.com" <liq3ea@163.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr
Date: Mon, 22 Apr 2019 19:52:08 +0200	[thread overview]
Message-ID: <1609679.gfMthc3lC5@xps> (raw)
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6B85AA@SHSMSX104.ccr.corp.intel.com>

> > In rte_fpga_do_pr() function, if 'stat' returns error,
> > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been
> > opened.
> > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL
> > when 'stat' returns error
> > 
> > Coverity issue: 279441
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Cc: rosen.xu@intel.com
> > Cc: marko.kovacevic@intel.com
> > Cc: liq3ea@163.com
> > Cc: andy.pei@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> 
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Li Qiang <liq3ea@163.com> proposed the same patch.
Why he is not referenced here?
Which patch should I merge?




  reply	other threads:[~2019-04-22 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  6:49 [dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei
2019-04-17  7:14 ` Xu, Rosen
2019-04-17  7:17   ` Pei, Andy
2019-04-17  7:16 ` [dpdk-dev] [PATCH v2] raw/ifpga_rawdev: " Andy Pei
2019-04-17  8:03   ` Xu, Rosen
2019-04-22 17:52     ` Thomas Monjalon [this message]
2019-04-23  1:19       ` [dpdk-dev] [dpdk-stable] " Pei, Andy
2019-04-23  1:36         ` Xu, Rosen
2019-04-23  8:45           ` Thomas Monjalon
2019-04-24  1:13             ` Pei, Andy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609679.gfMthc3lC5@xps \
    --to=thomas@monjalon.net \
    --cc=andy.pei@intel.com \
    --cc=dev@dpdk.org \
    --cc=liq3ea@163.com \
    --cc=marko.kovacevic@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.