From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0622CC433E0 for ; Wed, 6 Jan 2021 03:10:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 486E522D6E for ; Wed, 6 Jan 2021 03:10:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 486E522D6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88538893CD; Wed, 6 Jan 2021 03:10:01 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4CAC893CD for ; Wed, 6 Jan 2021 03:09:59 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23513427-1500050 for multiple; Wed, 06 Jan 2021 03:09:57 +0000 MIME-Version: 1.0 In-Reply-To: <8010f48e-94cf-699b-b3f2-b3eae3753cdf@intel.com> References: <20210105231947.31235-1-daniele.ceraolospurio@intel.com> <20210105231947.31235-5-daniele.ceraolospurio@intel.com> <160989494374.14894.15158476900955777220@build.alporthouse.com> <8010f48e-94cf-699b-b3f2-b3eae3753cdf@intel.com> From: Chris Wilson To: Daniele Ceraolo Spurio , intel-gfx@lists.freedesktop.org Date: Wed, 06 Jan 2021 03:09:55 +0000 Message-ID: <160990259521.22606.5618391021082649871@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: stop calling execlists_set_default_submission X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Daniele Ceraolo Spurio (2021-01-06 02:38:09) > > > On 1/5/2021 5:02 PM, Chris Wilson wrote: > > Quoting Daniele Ceraolo Spurio (2021-01-05 23:19:46) > >> Initialize all required entries from guc_set_default_submission, instead > >> of calling the execlists function. The previously inherited setup has > >> been copied over from the execlist code and simplified by removing the > >> execlists submission-specific parts. > >> > >> Signed-off-by: Daniele Ceraolo Spurio > >> Cc: Matthew Brost > >> Cc: John Harrison > >> --- > >> + if (INTEL_GEN(engine->i915) >= 12) > >> + engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO; > > We should probably lift this to intel_engine_setup(). > > GuC requires a more extensive usage of the relative mmio stuff, given > that it picks which engine to submit to when using virtual engines, so > I'm not sure if the support is going to look exactly the same for both > back-ends. There is an old patch from John H to rework the relative mmio > (https://patchwork.freedesktop.org/patch/332558/), which will have to > land in some form as part of the GuC submission re-enabling. I'd prefer > to wait for that to land before moving this flag. Whether or not LR* take the flag is independent of the submission backend. As to when to use the flag, I think that patch needs a lot more refinement. I915_ENGINE_HAS_RELATIVE_MMIO is the odd-one-out in the flags atm as it reflects HW capability. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx