All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Lyude Paul" <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev5)
Date: Wed, 06 Jan 2021 04:26:12 -0000	[thread overview]
Message-ID: <160990717205.18710.5071764868512550010@emeril.freedesktop.org> (raw)
In-Reply-To: <20210106013408.271217-1-lyude@redhat.com>

== Series Details ==

Series: drm/i915: Add support for Intel's eDP backlight controls (rev5)
URL   : https://patchwork.freedesktop.org/series/81702/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ec0e241787db drm/i915: Keep track of pwm-related backlight hooks separately
-:593: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#593: FILE: drivers/gpu/drm/i915/display/intel_panel.c:1815:
+	panel->backlight.pwm_level_max = intel_de_read(dev_priv,
+						 BXT_BLC_PWM_FREQ(panel->backlight.controller));

-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_panel.c:1849:
+	panel->backlight.pwm_level_max = intel_de_read(dev_priv,
+						 BXT_BLC_PWM_FREQ(panel->backlight.controller));

total: 0 errors, 0 warnings, 2 checks, 740 lines checked
36a625852ac9 drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
-:162: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#162: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:149:
+			return panel->backlight.max;
+		} else {

-:202: WARNING:LINE_SPACING: Missing a blank line after declarations
#202: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:189:
+		const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		intel_panel_set_pwm_level(conn_state, pwm_level);

-:229: WARNING:LINE_SPACING: Missing a blank line after declarations
#229: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:216:
+		u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level);

total: 0 errors, 3 warnings, 0 checks, 401 lines checked
2c68f1b5fd1a drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight
eafe126010a5 drm/dp: Revert "drm/dp: Introduce EDID-based quirks"


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-06  4:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06  1:34 [Intel-gfx] [PATCH v4 0/4] drm/i915: Add support for Intel's eDP backlight controls Lyude Paul
2021-01-06  1:34 ` [PATCH v4 1/4] drm/i915: Keep track of pwm-related backlight hooks separately Lyude Paul
2021-01-06  1:34   ` [Intel-gfx] " Lyude Paul
2021-01-06  1:34   ` Lyude Paul
2021-01-06  1:34 ` [PATCH v4 2/4] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now) Lyude Paul
2021-01-06  1:34   ` [Intel-gfx] " Lyude Paul
2021-01-06  1:34   ` Lyude Paul
2021-01-06  1:34 ` [PATCH v4 3/4] drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight Lyude Paul
2021-01-06  1:34   ` [Intel-gfx] " Lyude Paul
2021-01-06  1:34   ` Lyude Paul
2021-01-06  1:34 ` [PATCH v4 4/4] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" Lyude Paul
2021-01-06  1:34   ` [Intel-gfx] " Lyude Paul
2021-01-06  1:34   ` Lyude Paul
2021-01-06  4:26 ` Patchwork [this message]
2021-01-06  4:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add support for Intel's eDP backlight controls (rev5) Patchwork
2021-01-06  6:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev6) Patchwork
2021-01-06  7:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-01-06 19:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev7) Patchwork
2021-01-06 19:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160990717205.18710.5071764868512550010@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.