From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CDBC433DB for ; Wed, 6 Jan 2021 09:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 499F12310B for ; Wed, 6 Jan 2021 09:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725905AbhAFJ0a (ORCPT ); Wed, 6 Jan 2021 04:26:30 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:53879 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725868AbhAFJ03 (ORCPT ); Wed, 6 Jan 2021 04:26:29 -0500 X-UUID: 1b1acfb439384d78a32acd87f25d5b70-20210106 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zOuLnq2988VcCoJP2KaUOG1UC0p7HGPhxsgATLl5fuU=; b=q1aDPvqbJEz8uedknKGYXsOPVx3xFNpHppP5FHHAOdz7kfe8Qd3WkTCG/zaIeFlr0HH30f8CgWVBQjb5Rv1LAiTXDbo3IsLQM2pe5E07rgfQ+GGcbojW5S9I2kewCYW56Z5W45Aj9nRfE2TRgCRe9b5v10zlrC9ZCTACIxmBkIA=; X-UUID: 1b1acfb439384d78a32acd87f25d5b70-20210106 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 603406478; Wed, 06 Jan 2021 17:25:42 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 17:25:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 17:25:40 +0800 Message-ID: <1609925140.5373.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings From: EastL To: Rob Herring CC: Sean Wang , , , , , , , , , , Date: Wed, 6 Jan 2021 17:25:40 +0800 In-Reply-To: <20210103165842.GA4024251@robh.at.kernel.org> References: <1608715847-28956-1-git-send-email-EastL.Lee@mediatek.com> <1608715847-28956-2-git-send-email-EastL.Lee@mediatek.com> <20210103165842.GA4024251@robh.at.kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org T24gU3VuLCAyMDIxLTAxLTAzIGF0IDA5OjU4IC0wNzAwLCBSb2IgSGVycmluZyB3cm90ZToNCj4g T24gV2VkLCBEZWMgMjMsIDIwMjAgYXQgMDU6MzA6NDRQTSArMDgwMCwgRWFzdEwgTGVlIHdyb3Rl Og0KPiA+IERvY3VtZW50IHRoZSBkZXZpY2V0cmVlIGJpbmRpbmdzIGZvciBNZWRpYVRlayBDb21t YW5kLVF1ZXVlIERNQSBjb250cm9sbGVyDQo+ID4gd2hpY2ggY291bGQgYmUgZm91bmQgb24gTVQ2 Nzc5IFNvQyBvciBvdGhlciBzaW1pbGFyIE1lZGlhdGVrIFNvQ3MuDQo+ID4gDQo+ID4gU2lnbmVk LW9mZi1ieTogRWFzdEwgTGVlIDxFYXN0TC5MZWVAbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvbXRrLWNxZG1hLnlhbWwgICAgICAgICB8IDEw NCArKysrKysrKysrKysrKysrKysrKysNCj4gDQo+IFVzZSBjb21wYXRpYmxlIHN0cmluZyBmb3Ig ZmlsZW5hbWU6DQpPSw0KPiANCj4gbWVkaWF0ZWssY3FkbWEueWFtbA0KPiANCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDEwNCBpbnNlcnRpb25zKCspDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL210ay1jcWRtYS55YW1sDQo+ID4gDQo+ ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvbXRr LWNxZG1hLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL210ay1j cWRtYS55YW1sDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwLi5h NzZhMjYzDQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9kbWEvbXRrLWNxZG1hLnlhbWwNCj4gPiBAQCAtMCwwICsxLDEwNCBAQA0K PiA+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNs YXVzZSkNCj4gPiArJVlBTUwgMS4yDQo+ID4gKy0tLQ0KPiA+ICskaWQ6IGh0dHA6Ly9kZXZpY2V0 cmVlLm9yZy9zY2hlbWFzL2RtYS9tdGstY3FkbWEueWFtbCMNCj4gDQo+IERvbid0IGZvcmdldCB0 byB1cGRhdGUgdGhpcy4NCk9LDQo+IA0KPiA+ICskc2NoZW1hOiBodHRwOi8vZGV2aWNldHJlZS5v cmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMNCj4gPiArDQo+ID4gK3RpdGxlOiBNZWRpYVRlayBD b21tYW5kLVF1ZXVlIERNQSBjb250cm9sbGVyIERldmljZSBUcmVlIEJpbmRpbmcNCj4gPiArDQo+ ID4gK21haW50YWluZXJzOg0KPiA+ICsgIC0gRWFzdEwgTGVlIDxFYXN0TC5MZWVAbWVkaWF0ZWsu Y29tPg0KPiA+ICsNCj4gPiArZGVzY3JpcHRpb246DQo+ID4gKyAgTWVkaWFUZWsgQ29tbWFuZC1R dWV1ZSBETUEgY29udHJvbGxlciAoQ1FETUEpIG9uIE1lZGlhdGVrIFNvQw0KPiA+ICsgIGlzIGRl ZGljYXRlZCB0byBtZW1vcnktdG8tbWVtb3J5IHRyYW5zZmVyIHRocm91Z2ggcXVldWUgYmFzZWQN Cj4gPiArICBkZXNjcmlwdG9yIG1hbmFnZW1lbnQuDQo+ID4gKw0KPiA+ICthbGxPZjoNCj4gPiAr ICAtICRyZWY6ICJkbWEtY29udHJvbGxlci55YW1sIyINCj4gPiArDQo+ID4gK3Byb3BlcnRpZXM6 DQo+ID4gKyAgY29tcGF0aWJsZToNCj4gPiArICAgIGl0ZW1zOg0KPiA+ICsgICAgICAtIGVudW06 DQo+ID4gKyAgICAgICAgICAtIG1lZGlhdGVrLG10Njc2NS1jcWRtYQ0KPiA+ICsgICAgICAgICAg LSBtZWRpYXRlayxtdDY3NzktY3FkbWENCj4gPiArICAgICAgLSBjb25zdDogbWVkaWF0ZWssY3Fk bWENCj4gPiArDQo+ID4gKyAgcmVnOg0KPiA+ICsgICAgbWluSXRlbXM6IDENCj4gPiArICAgIG1h eEl0ZW1zOiA1DQo+ID4gKyAgICBkZXNjcmlwdGlvbjoNCj4gPiArICAgICAgICBBIGJhc2UgYWRk cmVzcyBvZiBNZWRpYVRlayBDb21tYW5kLVF1ZXVlIERNQSBjb250cm9sbGVyLA0KPiA+ICsgICAg ICAgIGEgY2hhbm5lbCB3aWxsIGhhdmUgYSBzZXQgb2YgYmFzZSBhZGRyZXNzLg0KPiA+ICsNCj4g PiArICBpbnRlcnJ1cHRzOg0KPiA+ICsgICAgbWluSXRlbXM6IDENCj4gPiArICAgIG1heEl0ZW1z OiA1DQo+ID4gKyAgICBkZXNjcmlwdGlvbjoNCj4gPiArICAgICAgICBBIGludGVycnVwdCBudW1i ZXIgb2YgTWVkaWFUZWsgQ29tbWFuZC1RdWV1ZSBETUEgY29udHJvbGxlciwNCj4gPiArICAgICAg ICBvbmUgaW50ZXJydXB0IG51bWJlciBwZXIgZG1hLWNoYW5uZWxzLg0KPiA+ICsNCj4gPiArICBj bG9ja3M6DQo+ID4gKyAgICBtYXhJdGVtczogMQ0KPiA+ICsNCj4gPiArICBjbG9jay1uYW1lczoN Cj4gPiArICAgIGNvbnN0OiBjcWRtYQ0KPiA+ICsNCj4gPiArICBkbWEtY2hhbm5lbC1tYXNrOg0K PiA+ICsgICAgZGVzY3JpcHRpb246DQo+ID4gKyAgICAgICBGb3IgRE1BIGNhcGFiaWxpdHksIFdl IHdpbGwga25vdyB0aGUgYWRkcmVzc2luZyBjYXBhYmlsaXR5IG9mDQo+ID4gKyAgICAgICBNZWRp YVRlayBDb21tYW5kLVF1ZXVlIERNQSBjb250cm9sbGVyIHRocm91Z2ggZG1hLWNoYW5uZWwtbWFz ay4NCj4gPiArICAgICAgbWluaW11bTogMQ0KPiA+ICsgICAgICBtYXhpbXVtOiA2Mw0KPiANCj4g SW5kZW50YXRpb24gaXMgd3JvbmcgaGVyZSBzbyB0aGlzIGhhcyBubyBlZmZlY3QuDQpJJ2xsIGZp eCBpdA0KPiANCj4gQSBtYXNrIG9mIDYzIGlzIDYgY2hhbm5lbHMuLi4NCkluIG15IG9waW5pb24s IGtlcm5lbCBkbWEgbWFzayBpZiBmb3IgMzIvNjQgYml0IGNhcGFiaWxpdHkuLi4NCklmIEkgZG9u J3Qgc2V0IGRtYSBtYXNrIEkgd2lsbCBnZXQgZmFpbCBvbiBETUFURVNULg0KPiANCj4gPiArDQo+ ID4gKyAgZG1hLWNoYW5uZWxzOg0KPiA+ICsgICAgZGVzY3JpcHRpb246DQo+ID4gKyAgICAgIE51 bWJlciBvZiBETUEgY2hhbm5lbHMgc3VwcG9ydGVkIGJ5IE1lZGlhVGVrIENvbW1hbmQtUXVldWUg RE1BDQo+ID4gKyAgICAgIGNvbnRyb2xsZXIsIHN1cHBvcnQgdXAgdG8gZml2ZS4NCj4gPiArICAg ICAgbWluaW11bTogMQ0KPiA+ICsgICAgICBtYXhpbXVtOiA1DQo+IA0KPiBTYW1lIGhlcmUuDQpP Sw0KPiANCj4gRG8geW91IHJlYWxseSBuZWVkIGJvdGggZG1hLWNoYW5uZWxzIGFuZCBkbWEtY2hh bm5lbC1tYXNrPyBZb3Ugc2hvdWxkIGJlIA0KPiBhYmxlIHRvIGdldCBvbmUgZnJvbSB0aGUgb3Ro ZXIuDQo+IA0KPiA+ICsNCj4gPiArICBkbWEtcmVxdWVzdHM6DQo+ID4gKyAgICBkZXNjcmlwdGlv bjoNCj4gPiArICAgICAgTnVtYmVyIG9mIERNQSByZXF1ZXN0ICh2aXJ0dWFsIGNoYW5uZWwpIHN1 cHBvcnRlZCBieSBNZWRpYVRlaw0KPiA+ICsgICAgICBDb21tYW5kLVF1ZXVlIERNQSBjb250cm9s bGVyLCBzdXBwb3J0IHVwIHRvIDMyLg0KPiA+ICsgICAgICBtaW5pbXVtOiAxDQo+ID4gKyAgICAg IG1heGltdW06IDMyDQo+IA0KPiBBbmQgaGVyZS4NCj4gDQo+IFlvdSBhcmUgbWlzc2luZyAnI2Rt YS1jZWxscycgYWxzby4NCk9LIEknbGwgZml4IGl0Lg0KPiANCj4gPiArDQo+ID4gK3JlcXVpcmVk Og0KPiA+ICsgIC0gIiNkbWEtY2VsbHMiDQo+ID4gKyAgLSBjb21wYXRpYmxlDQo+ID4gKyAgLSBy ZWcNCj4gPiArICAtIGludGVycnVwdHMNCj4gPiArICAtIGNsb2Nrcw0KPiA+ICsgIC0gY2xvY2st bmFtZXMNCj4gPiArICAtIGRtYS1jaGFubmVsLW1hc2sNCj4gPiArICAtIGRtYS1jaGFubmVscw0K PiA+ICsgIC0gZG1hLXJlcXVlc3RzDQo+ID4gKw0KPiA+ICthZGRpdGlvbmFsUHJvcGVydGllczog ZmFsc2UNCj4gPiArDQo+ID4gK2V4YW1wbGVzOg0KPiA+ICsgIC0gfA0KPiA+ICsgICAgI2luY2x1 ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2lycS5oPg0KPiA+ICsgICAgI2lu Y2x1ZGUgPGR0LWJpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4NCj4gPiAr ICAgICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9jbG9jay9tdDY3NzktY2xrLmg+DQo+ID4gKyAgICBj cWRtYTogZG1hLWNvbnRyb2xsZXJAMTAyMTIwMDAgew0KPiA+ICsgICAgICAgIGNvbXBhdGlibGUg PSAibWVkaWF0ZWssbXQ2Nzc5LWNxZG1hIjsNCj4gDQo+IFRoaXMgc2hvdWxkIGZhaWwgdmFsaWRh dGlvbiBiZWNhdXNlIGl0IGRvZXNuJ3QgbWF0Y2ggdGhlIHNjaGVtYS4gWW91IHJhbiANCj4gJ21h a2UgZHRfYmluZGluZ19jaGVjaycsIHJpZ2h0Pw0KWWVzLCBidXQgSSBnb3Qgb3RoZXIgZmFpbCBv biBrZXJuZWwtNS4xMC4uLg0KPiANCj4gPiArICAgICAgICByZWcgPSA8MHgxMDIxMjAwMCAweDgw PiwNCj4gPiArICAgICAgICAgICAgPDB4MTAyMTIwODAgMHg4MD4sDQo+ID4gKyAgICAgICAgICAg IDwweDEwMjEyMTAwIDB4ODA+Ow0KPiA+ICsgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAx MzkgSVJRX1RZUEVfTEVWRUxfTE9XPiwNCj4gPiArICAgICAgICAgICAgPEdJQ19TUEkgMTQwIElS UV9UWVBFX0xFVkVMX0xPVz4sDQo+ID4gKyAgICAgICAgICAgIDxHSUNfU1BJIDE0MSBJUlFfVFlQ RV9MRVZFTF9MT1c+Ow0KPiA+ICsgICAgICAgIGNsb2NrcyA9IDwmaW5mcmFjZmdfYW8gQ0xLX0lO RlJBX0NRX0RNQT47DQo+ID4gKyAgICAgICAgY2xvY2stbmFtZXMgPSAiY3FkbWEiOw0KPiA+ICsg ICAgICAgIGRtYS1jaGFubmVsLW1hc2sgPSA8NjM+Ow0KPiANCj4gNiBjaGFubmVscyBvci4uLg0K PiANCj4gPiArICAgICAgICBkbWEtY2hhbm5lbHMgPSA8Mz47DQo+IA0KPiAzPw0KMyBjaGFubmVs LCB0aGUgbWFzayBpcyBmb3IgRE1BVEVTVCBQQVNTLg0KPiANCj4gPiArICAgICAgICBkbWEtcmVx dWVzdHMgPSA8MzI+Ow0KPiA+ICsgICAgICAgICNkbWEtY2VsbHMgPSA8MT47DQo+ID4gKyAgICB9 Ow0KPiA+ICsNCj4gPiArLi4uDQo+ID4gLS0gDQo+ID4gMS45LjENCj4gPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEACC433E0 for ; Wed, 6 Jan 2021 09:26:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 110592310B for ; Wed, 6 Jan 2021 09:26:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 110592310B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b/MwaF/nuJ1jwGp2nFihe9oH6js34vQCgKjFeQBRbOk=; b=W5ijOgTKpbvUqGnWpNMD5c+MN uAN0dkkOa5xurcDdTN7gXmm6/ZvdW+WAlIHSnA+XQEN77gT5/GdzZNBTNPFV9oo0S6fkQUh1HwH9m vBHi7y2M6riXmwIsJabS7b8547pOCJfCPxtNe1GWN6ailC0aN8D7x+gkkVml56j7ngeJyHnua8/b9 VlVi/Moixxaw3YpFtfb5OVaKrE9SUDj4ya16PhG+F8tF9ptyMuxVlGXueCNySjpivGZFMrBAwHSy7 DNNnFy0wcNsQkbwzq0/iv+pojFQZMlq/3U7MNhO5+f2I3OB2iPANVNj+1gFiU4uhpMl6RhnnMeBoR LrKaIXfTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx54k-0001PS-2W; Wed, 06 Jan 2021 09:25:54 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx54e-0001O0-Gh; Wed, 06 Jan 2021 09:25:50 +0000 X-UUID: 8a99c76b29544e2abb8ee21e87238365-20210106 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zOuLnq2988VcCoJP2KaUOG1UC0p7HGPhxsgATLl5fuU=; b=q1aDPvqbJEz8uedknKGYXsOPVx3xFNpHppP5FHHAOdz7kfe8Qd3WkTCG/zaIeFlr0HH30f8CgWVBQjb5Rv1LAiTXDbo3IsLQM2pe5E07rgfQ+GGcbojW5S9I2kewCYW56Z5W45Aj9nRfE2TRgCRe9b5v10zlrC9ZCTACIxmBkIA=; X-UUID: 8a99c76b29544e2abb8ee21e87238365-20210106 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1365285091; Wed, 06 Jan 2021 01:25:43 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 01:25:42 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 17:25:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 17:25:40 +0800 Message-ID: <1609925140.5373.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings From: EastL To: Rob Herring Date: Wed, 6 Jan 2021 17:25:40 +0800 In-Reply-To: <20210103165842.GA4024251@robh.at.kernel.org> References: <1608715847-28956-1-git-send-email-EastL.Lee@mediatek.com> <1608715847-28956-2-git-send-email-EastL.Lee@mediatek.com> <20210103165842.GA4024251@robh.at.kernel.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_042549_323492_0F8CA166 X-CRM114-Status: GOOD ( 27.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, cc.hwang@mediatek.com, wsd_upstream@mediatek.com, Sean Wang , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, 2021-01-03 at 09:58 -0700, Rob Herring wrote: > On Wed, Dec 23, 2020 at 05:30:44PM +0800, EastL Lee wrote: > > Document the devicetree bindings for MediaTek Command-Queue DMA controller > > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > > > Signed-off-by: EastL Lee > > --- > > .../devicetree/bindings/dma/mtk-cqdma.yaml | 104 +++++++++++++++++++++ > > Use compatible string for filename: OK > > mediatek,cqdma.yaml > > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > > > diff --git a/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > new file mode 100644 > > index 0000000..a76a263 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/dma/mtk-cqdma.yaml# > > Don't forget to update this. OK > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek Command-Queue DMA controller Device Tree Binding > > + > > +maintainers: > > + - EastL Lee > > + > > +description: > > + MediaTek Command-Queue DMA controller (CQDMA) on Mediatek SoC > > + is dedicated to memory-to-memory transfer through queue based > > + descriptor management. > > + > > +allOf: > > + - $ref: "dma-controller.yaml#" > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt6765-cqdma > > + - mediatek,mt6779-cqdma > > + - const: mediatek,cqdma > > + > > + reg: > > + minItems: 1 > > + maxItems: 5 > > + description: > > + A base address of MediaTek Command-Queue DMA controller, > > + a channel will have a set of base address. > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 5 > > + description: > > + A interrupt number of MediaTek Command-Queue DMA controller, > > + one interrupt number per dma-channels. > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: cqdma > > + > > + dma-channel-mask: > > + description: > > + For DMA capability, We will know the addressing capability of > > + MediaTek Command-Queue DMA controller through dma-channel-mask. > > + minimum: 1 > > + maximum: 63 > > Indentation is wrong here so this has no effect. I'll fix it > > A mask of 63 is 6 channels... In my opinion, kernel dma mask if for 32/64 bit capability... If I don't set dma mask I will get fail on DMATEST. > > > + > > + dma-channels: > > + description: > > + Number of DMA channels supported by MediaTek Command-Queue DMA > > + controller, support up to five. > > + minimum: 1 > > + maximum: 5 > > Same here. OK > > Do you really need both dma-channels and dma-channel-mask? You should be > able to get one from the other. > > > + > > + dma-requests: > > + description: > > + Number of DMA request (virtual channel) supported by MediaTek > > + Command-Queue DMA controller, support up to 32. > > + minimum: 1 > > + maximum: 32 > > And here. > > You are missing '#dma-cells' also. OK I'll fix it. > > > + > > +required: > > + - "#dma-cells" > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - dma-channel-mask > > + - dma-channels > > + - dma-requests > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + cqdma: dma-controller@10212000 { > > + compatible = "mediatek,mt6779-cqdma"; > > This should fail validation because it doesn't match the schema. You ran > 'make dt_binding_check', right? Yes, but I got other fail on kernel-5.10... > > > + reg = <0x10212000 0x80>, > > + <0x10212080 0x80>, > > + <0x10212100 0x80>; > > + interrupts = , > > + , > > + ; > > + clocks = <&infracfg_ao CLK_INFRA_CQ_DMA>; > > + clock-names = "cqdma"; > > + dma-channel-mask = <63>; > > 6 channels or... > > > + dma-channels = <3>; > > 3? 3 channel, the mask is for DMATEST PASS. > > > + dma-requests = <32>; > > + #dma-cells = <1>; > > + }; > > + > > +... > > -- > > 1.9.1 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F617C433E0 for ; Wed, 6 Jan 2021 09:27:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A37A223102 for ; Wed, 6 Jan 2021 09:27:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A37A223102 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V9VHkRqFtJYiAjmwAQvkqtNYZVILmxBXZWfo6nTI9PY=; b=SofrKC0efu0wiL3X/QYG8eU/E 9PWbv5r5vkHckZ+QNCNsrBxlBQJN2zvC5Fo/aBnUeb+8d6P5UO9CY+BUR13Z/T8HKTethZ079Jqml R5A8IPHeQXFUoxq6RM6+ISxkuWmrbGrbZJjASNb1Msu2TkE8Nhcq2xntaNJKHPBaZfEqhQWiFLVvd jPU8/jxajU+ZCoO8BBija9CmvfnXHZp7gBZoPkJIJvxmzrSr1SAPk+4HW9K/tsZW8cGW5HsPqXVEb h0tMuUlGPXFfI7AJxhNEXyA3+BcC0R5QcG7wP+Ph5Lbxr87sd7h4gLklUMN9lmwtXfHkhbmxveTWR iRTQiolhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx54h-0001Ow-Ox; Wed, 06 Jan 2021 09:25:51 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx54e-0001O0-Gh; Wed, 06 Jan 2021 09:25:50 +0000 X-UUID: 8a99c76b29544e2abb8ee21e87238365-20210106 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zOuLnq2988VcCoJP2KaUOG1UC0p7HGPhxsgATLl5fuU=; b=q1aDPvqbJEz8uedknKGYXsOPVx3xFNpHppP5FHHAOdz7kfe8Qd3WkTCG/zaIeFlr0HH30f8CgWVBQjb5Rv1LAiTXDbo3IsLQM2pe5E07rgfQ+GGcbojW5S9I2kewCYW56Z5W45Aj9nRfE2TRgCRe9b5v10zlrC9ZCTACIxmBkIA=; X-UUID: 8a99c76b29544e2abb8ee21e87238365-20210106 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1365285091; Wed, 06 Jan 2021 01:25:43 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 01:25:42 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 6 Jan 2021 17:25:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 6 Jan 2021 17:25:40 +0800 Message-ID: <1609925140.5373.5.camel@mtkswgap22> Subject: Re: [PATCH v8 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings From: EastL To: Rob Herring Date: Wed, 6 Jan 2021 17:25:40 +0800 In-Reply-To: <20210103165842.GA4024251@robh.at.kernel.org> References: <1608715847-28956-1-git-send-email-EastL.Lee@mediatek.com> <1608715847-28956-2-git-send-email-EastL.Lee@mediatek.com> <20210103165842.GA4024251@robh.at.kernel.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_042549_323492_0F8CA166 X-CRM114-Status: GOOD ( 27.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, cc.hwang@mediatek.com, wsd_upstream@mediatek.com, Sean Wang , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 2021-01-03 at 09:58 -0700, Rob Herring wrote: > On Wed, Dec 23, 2020 at 05:30:44PM +0800, EastL Lee wrote: > > Document the devicetree bindings for MediaTek Command-Queue DMA controller > > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > > > Signed-off-by: EastL Lee > > --- > > .../devicetree/bindings/dma/mtk-cqdma.yaml | 104 +++++++++++++++++++++ > > Use compatible string for filename: OK > > mediatek,cqdma.yaml > > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > > > diff --git a/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > new file mode 100644 > > index 0000000..a76a263 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/dma/mtk-cqdma.yaml# > > Don't forget to update this. OK > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek Command-Queue DMA controller Device Tree Binding > > + > > +maintainers: > > + - EastL Lee > > + > > +description: > > + MediaTek Command-Queue DMA controller (CQDMA) on Mediatek SoC > > + is dedicated to memory-to-memory transfer through queue based > > + descriptor management. > > + > > +allOf: > > + - $ref: "dma-controller.yaml#" > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt6765-cqdma > > + - mediatek,mt6779-cqdma > > + - const: mediatek,cqdma > > + > > + reg: > > + minItems: 1 > > + maxItems: 5 > > + description: > > + A base address of MediaTek Command-Queue DMA controller, > > + a channel will have a set of base address. > > + > > + interrupts: > > + minItems: 1 > > + maxItems: 5 > > + description: > > + A interrupt number of MediaTek Command-Queue DMA controller, > > + one interrupt number per dma-channels. > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: cqdma > > + > > + dma-channel-mask: > > + description: > > + For DMA capability, We will know the addressing capability of > > + MediaTek Command-Queue DMA controller through dma-channel-mask. > > + minimum: 1 > > + maximum: 63 > > Indentation is wrong here so this has no effect. I'll fix it > > A mask of 63 is 6 channels... In my opinion, kernel dma mask if for 32/64 bit capability... If I don't set dma mask I will get fail on DMATEST. > > > + > > + dma-channels: > > + description: > > + Number of DMA channels supported by MediaTek Command-Queue DMA > > + controller, support up to five. > > + minimum: 1 > > + maximum: 5 > > Same here. OK > > Do you really need both dma-channels and dma-channel-mask? You should be > able to get one from the other. > > > + > > + dma-requests: > > + description: > > + Number of DMA request (virtual channel) supported by MediaTek > > + Command-Queue DMA controller, support up to 32. > > + minimum: 1 > > + maximum: 32 > > And here. > > You are missing '#dma-cells' also. OK I'll fix it. > > > + > > +required: > > + - "#dma-cells" > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - dma-channel-mask > > + - dma-channels > > + - dma-requests > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + cqdma: dma-controller@10212000 { > > + compatible = "mediatek,mt6779-cqdma"; > > This should fail validation because it doesn't match the schema. You ran > 'make dt_binding_check', right? Yes, but I got other fail on kernel-5.10... > > > + reg = <0x10212000 0x80>, > > + <0x10212080 0x80>, > > + <0x10212100 0x80>; > > + interrupts = , > > + , > > + ; > > + clocks = <&infracfg_ao CLK_INFRA_CQ_DMA>; > > + clock-names = "cqdma"; > > + dma-channel-mask = <63>; > > 6 channels or... > > > + dma-channels = <3>; > > 3? 3 channel, the mask is for DMATEST PASS. > > > + dma-requests = <32>; > > + #dma-cells = <1>; > > + }; > > + > > +... > > -- > > 1.9.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel