From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93D5C433EF for ; Fri, 24 Jun 2022 08:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiFXIea (ORCPT ); Fri, 24 Jun 2022 04:34:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbiFXIe1 (ORCPT ); Fri, 24 Jun 2022 04:34:27 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A2414A3D6; Fri, 24 Jun 2022 01:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656059667; x=1687595667; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GL7gNHkZqM1sWdOok001Mz0b5ZGecYzNGjnRUb23NBQ=; b=A8gxWgVNKoGYCXxxommMEyl9F2eyFoyZfJK3OUxc6YBCOSv8BsYgIo5Z FLSVRp0cBQaKJ9lNZtPDTCkRQ0c9/2nlELekYKb/ex+PDbhIan+ywwoUm vJ+PNfIbqEriUtRjnFUSIn1lObYOwMvHvhQV1NNCxRWnhWt4snVqxE7ge fhXXe0Sh0/3TdZCSrllSJiORNG7VBdjbNLkkLaEMfzmokg7zXb/uS+2S8 ww9xT0MYlP3p8A/MA+gYxxcURlU6plD80EmkdZ+C0JFyRQfiEf9pWvUFF Dcon13CnfCxineRuG5PyiRyEFIjAHj9BOIGgAIqAOKgUIvsOY5KvXFQHI g==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="282038036" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="282038036" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="915596863" Received: from acamigob-mobl.amr.corp.intel.com (HELO [10.212.103.132]) ([10.212.103.132]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:22 -0700 Message-ID: <160e613f-a0a8-18ff-5d4b-249d4280caa8@linux.intel.com> Date: Fri, 24 Jun 2022 09:34:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets Content-Language: en-US To: Andi Shyti , Mauro Carvalho Chehab Cc: Chris Wilson , Fei Yang , Thomas Hellstrom , Bruce Chang , Daniel Vetter , Dave Airlie , David Airlie , Jani Nikula , John Harrison , Joonas Lahtinen , Matt Roper , Matthew Brost , Rodrigo Vivi , Tejas Upadhyay , Umesh Nerlige Ramappa , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, mauro.chehab@linux.intel.com, Mika Kuoppala , Chris Wilson , stable@vger.kernel.org, =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= References: <5ee647f243a774927ec328bfca8212abc4957909.1655306128.git.mchehab@kernel.org> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/2022 12:17, Andi Shyti wrote: > Hi Mauro, > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: >> From: Chris Wilson >> >> Don't allow two engines to be reset in parallel, as they would both >> try to select a reset bit (and send requests to common registers) >> and wait on that register, at the same time. Serialize control of >> the reset requests/acks using the uncore->lock, which will also ensure >> that no other GT state changes at the same time as the actual reset. >> >> Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") >> >> Reported-by: Mika Kuoppala >> Signed-off-by: Chris Wilson >> Cc: Mika Kuoppala >> Cc: Andi Shyti >> Cc: stable@vger.kernel.org >> Acked-by: Thomas Hellström >> Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Andi Shyti Notice I had a bunch of questions and asks in this series so please do not merge until those are addressed. In this particular patch (and some others) for instance Fixes: tag, at least against that sha, shouldn't be there. Regards, Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71017C43334 for ; Fri, 24 Jun 2022 08:34:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A011C10F695; Fri, 24 Jun 2022 08:34:27 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD41F10FC50; Fri, 24 Jun 2022 08:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656059666; x=1687595666; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GL7gNHkZqM1sWdOok001Mz0b5ZGecYzNGjnRUb23NBQ=; b=WuBGWNCyBYKwCdVT3AWZOGl2wphgyNXiCkeW21lfuLPfaerAVr+mBCQK siLJBBKUy7zObDq3zEYns135BVU3sarQQgx2QLE3mLY2jfpoGZ/Y/Y1aA MDsCYhzXg2vzm690EYIV7pWNWHmywnABwd9OLdQ0sMbadz2dQiCT6oYND k4s7RUxGI2R3++9DwWVCcSHWzOhaNOQM+lXbanAyQ6evjGCBB9GQyGOY9 JGBsvKmr6QOEDjKy7KJyLqEipAeXh532bNU6zXL1s96dNmSQNBl2phqNV 9boqw7VlWat083JbcFg9eqPyOPNCQgWN1qr+OOXcpFmyq4rYqdfN1ax6H A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="279720883" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="279720883" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="915596863" Received: from acamigob-mobl.amr.corp.intel.com (HELO [10.212.103.132]) ([10.212.103.132]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:22 -0700 Message-ID: <160e613f-a0a8-18ff-5d4b-249d4280caa8@linux.intel.com> Date: Fri, 24 Jun 2022 09:34:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets Content-Language: en-US To: Andi Shyti , Mauro Carvalho Chehab References: <5ee647f243a774927ec328bfca8212abc4957909.1655306128.git.mchehab@kernel.org> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Chris Wilson , Fei Yang , Matthew Brost , Mika Kuoppala , Chris Wilson , Dave Airlie , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, Thomas Hellstrom , Rodrigo Vivi , mauro.chehab@linux.intel.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bruce Chang , Tejas Upadhyay , Umesh Nerlige Ramappa , John Harrison Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/06/2022 12:17, Andi Shyti wrote: > Hi Mauro, > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: >> From: Chris Wilson >> >> Don't allow two engines to be reset in parallel, as they would both >> try to select a reset bit (and send requests to common registers) >> and wait on that register, at the same time. Serialize control of >> the reset requests/acks using the uncore->lock, which will also ensure >> that no other GT state changes at the same time as the actual reset. >> >> Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") >> >> Reported-by: Mika Kuoppala >> Signed-off-by: Chris Wilson >> Cc: Mika Kuoppala >> Cc: Andi Shyti >> Cc: stable@vger.kernel.org >> Acked-by: Thomas Hellström >> Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Andi Shyti Notice I had a bunch of questions and asks in this series so please do not merge until those are addressed. In this particular patch (and some others) for instance Fixes: tag, at least against that sha, shouldn't be there. Regards, Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B87F9CCA473 for ; Fri, 24 Jun 2022 08:34:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B04410FC50; Fri, 24 Jun 2022 08:34:28 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD41F10FC50; Fri, 24 Jun 2022 08:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656059666; x=1687595666; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GL7gNHkZqM1sWdOok001Mz0b5ZGecYzNGjnRUb23NBQ=; b=WuBGWNCyBYKwCdVT3AWZOGl2wphgyNXiCkeW21lfuLPfaerAVr+mBCQK siLJBBKUy7zObDq3zEYns135BVU3sarQQgx2QLE3mLY2jfpoGZ/Y/Y1aA MDsCYhzXg2vzm690EYIV7pWNWHmywnABwd9OLdQ0sMbadz2dQiCT6oYND k4s7RUxGI2R3++9DwWVCcSHWzOhaNOQM+lXbanAyQ6evjGCBB9GQyGOY9 JGBsvKmr6QOEDjKy7KJyLqEipAeXh532bNU6zXL1s96dNmSQNBl2phqNV 9boqw7VlWat083JbcFg9eqPyOPNCQgWN1qr+OOXcpFmyq4rYqdfN1ax6H A==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="279720883" X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="279720883" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,218,1650956400"; d="scan'208";a="915596863" Received: from acamigob-mobl.amr.corp.intel.com (HELO [10.212.103.132]) ([10.212.103.132]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2022 01:34:22 -0700 Message-ID: <160e613f-a0a8-18ff-5d4b-249d4280caa8@linux.intel.com> Date: Fri, 24 Jun 2022 09:34:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Andi Shyti , Mauro Carvalho Chehab References: <5ee647f243a774927ec328bfca8212abc4957909.1655306128.git.mchehab@kernel.org> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Chris Wilson , Chris Wilson , Dave Airlie , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, Thomas Hellstrom , Rodrigo Vivi , mauro.chehab@linux.intel.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tejas Upadhyay Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 23/06/2022 12:17, Andi Shyti wrote: > Hi Mauro, > > On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: >> From: Chris Wilson >> >> Don't allow two engines to be reset in parallel, as they would both >> try to select a reset bit (and send requests to common registers) >> and wait on that register, at the same time. Serialize control of >> the reset requests/acks using the uncore->lock, which will also ensure >> that no other GT state changes at the same time as the actual reset. >> >> Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") >> >> Reported-by: Mika Kuoppala >> Signed-off-by: Chris Wilson >> Cc: Mika Kuoppala >> Cc: Andi Shyti >> Cc: stable@vger.kernel.org >> Acked-by: Thomas Hellström >> Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Andi Shyti Notice I had a bunch of questions and asks in this series so please do not merge until those are addressed. In this particular patch (and some others) for instance Fixes: tag, at least against that sha, shouldn't be there. Regards, Tvrtko