From: Dave Jiang <dave.jiang@intel.com>
To: bp@alien8.de, x86@kernel.org
Cc: kernel test robot <lkp@intel.com>,
Ben Widawsky <ben.widawsky@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
dan.j.williams@intel.com, ben.widawsky@intel.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v3] x86: fix enqcmds() with missing __iomem annotation
Date: Thu, 07 Jan 2021 09:45:21 -0700 [thread overview]
Message-ID: <161003789741.4062451.14362269365703761223.stgit@djiang5-desk3.ch.intel.com> (raw)
Add missing __iomem annotation to address sparse warning. Caller is expected
to pass an __iomem annotated pointer to this function. The current usages
send a 64bytes command descriptor to an MMIO location (portal) on a
device for consumption.
Also, from the comment in movdir64b(), which also applies to enqcmds(),
@__dst must be supplied as an lvalue because this tells the compiler what
the object is (its size) the instruction accesses. I.e., not the pointers
but what they point to, thus the deref'ing '*'."
"sparse warnings: (new ones prefixed by >>)"
drivers/dma/idxd/submit.c: note: in included file (through include/linux/io.h, include/linux/pci.h):
arch/x86/include/asm/io.h:422:27: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *dst @@ got void [noderef] __iomem *dst @@
arch/x86/include/asm/io.h:422:27: sparse: expected void *dst
arch/x86/include/asm/io.h:422:27: sparse: got void [noderef] __iomem *dst
drivers/dma/idxd/submit.c: note: in included file (through arch/x86/include/asm/processor.h, arch/x86/include/asm/timex.h, include/linux/timex.h, ...):
>> arch/x86/include/asm/special_insns.h:289:41: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected struct <noident> *__dst @@ got void [noderef] __iomem *dst @@
arch/x86/include/asm/special_insns.h:289:41: sparse: expected struct <noident> *__dst
arch/x86/include/asm/special_insns.h:289:41: sparse: got void [noderef] __iomem *dst
Fixes: 7f5933f81bd8 ("x86/asm: Add an enqcmds() wrapper for the ENQCMDS instruction")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v3:
- Update subject with comments from Boris.
v2:
- Update commit log with comments from Dan.
arch/x86/include/asm/special_insns.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/special_insns.h b/arch/x86/include/asm/special_insns.h
index 4e234645f0c6..1d3cbaef4bb7 100644
--- a/arch/x86/include/asm/special_insns.h
+++ b/arch/x86/include/asm/special_insns.h
@@ -286,7 +286,7 @@ static inline void movdir64b(void __iomem *dst, const void *src)
static inline int enqcmds(void __iomem *dst, const void *src)
{
const struct { char _[64]; } *__src = src;
- struct { char _[64]; } *__dst = dst;
+ struct { char _[64]; } __iomem *__dst = dst;
int zf;
/*
next reply other threads:[~2021-01-07 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:45 Dave Jiang [this message]
2021-01-08 11:08 ` [tip: x86/asm] x86/asm: Add a missing __iomem annotation in enqcmds() tip-bot2 for Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161003789741.4062451.14362269365703761223.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=ben.widawsky@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.