From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044B2C433DB for ; Fri, 8 Jan 2021 15:25:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8399023770 for ; Fri, 8 Jan 2021 15:25:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8399023770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C1AD6E170; Fri, 8 Jan 2021 15:25:05 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65B956E170 for ; Fri, 8 Jan 2021 15:25:03 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23539822-1500050 for multiple; Fri, 08 Jan 2021 15:24:48 +0000 MIME-Version: 1.0 In-Reply-To: References: <20210107221724.10036-1-chris@chris-wilson.co.uk> <20210107221724.10036-2-chris@chris-wilson.co.uk> From: Chris Wilson To: Andi Shyti Date: Fri, 08 Jan 2021 15:24:47 +0000 Message-ID: <161011948741.28368.9687495779764618235@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 2/5] drm/i915/gt: Restore ce->signal flush before releasing virtual engine X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Andi Shyti (2021-01-08 15:18:22) > Hi Chris, > > > +void intel_context_remove_breadcrumbs(struct intel_context *ce, > > + struct intel_breadcrumbs *b) > > +{ > > + struct i915_request *rq, *rn; > > + bool release = false; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&ce->signal_lock, flags); > > + > > + if (list_empty(&ce->signals)) > > + goto unlock; > > does "list_empty" need to be under lock or you've been lazy? This check is required to be under the lock, we have to be careful about not calling remove_signaling_context() from here and signal_irq_work. I put the unlocked check in the caller to avoid the function call as well. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx