From: Launchpad Bug Tracker <1712027@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1712027] Re: qemu: Cryptography adding encrypted disk with luks format failed
Date: Sat, 09 Jan 2021 04:17:51 -0000 [thread overview]
Message-ID: <161016587168.8490.12377279554741922945.malone@loganberry.canonical.com> (raw)
In-Reply-To: 150330672268.8725.17665790368733773133.malonedeb@soybean.canonical.com
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1712027
Title:
qemu: Cryptography adding encrypted disk with luks format failed
Status in QEMU:
Expired
Bug description:
I'm using libvirt to attach luks encrypted disk to a running VM. The
qemu-monitor-command like the
following:
{"execute":"object-add","arguments":{"qom-type":"secret","id":"virtio-
disk11-luks-
secret0","props":{"data":"El7jOYLCZwrij2Mue0q2tA==","keyid":"masterKey0","iv":"J2je0WJjCa89L3iKc1lceg==","format":"base64"}}
the masterKey0 specify the secret which has been created before.
command above return with error message "Incorrect number of padding
bytes XXX found on decrypted
data". This is triggered by the following code snippets in qemu/crypto/secret.c:
if (plaintext[ciphertextlen - 1] > 16 ||
plaintext[ciphertextlen - 1] > ciphertextlen) {
error_setg(errp, "Incorrect number of padding bytes (%d) "
"found on decrypted data",
(int)plaintext[ciphertextlen - 1]);
…
}
The bug is: There is on padding in plaintext if the actual length of
the plaintext decrypted is
equal to ciphertext.
In this case, the last element in plaintext array may be one of the
character in base64 code table
or other.
I would like to know why length of padding bytes cannot exceed 16 and
whether i can remove
judement: “plaintext[ciphertextlen - 1] > 16” so that I can eliminate
the error above.
Much appreciate it if doubts above is cleared up.
libvirt/qemu version:
# virsh version
Compiled against library: libvirt 3.0.0
Using library: libvirt 3.0.0
Using API: QEMU 3.0.0
Running hypervisor: QEMU 2.7.1
OS: Ubuntu 12.04 LTS
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1712027/+subscriptions
prev parent reply other threads:[~2021-01-09 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 9:12 [Qemu-devel] [Bug 1712027] [NEW] qemu: Cryptography adding encrypted disk with luks format failed Huang Yong
2017-08-24 10:08 ` [Qemu-devel] [Bug 1712027] " Huang Yong
2020-11-09 18:29 ` Thomas Huth
2021-01-09 4:17 ` Launchpad Bug Tracker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161016587168.8490.12377279554741922945.malone@loganberry.canonical.com \
--to=1712027@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.