* [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes
@ 2021-01-11 19:29 Aditya Swarup
2021-01-11 19:29 ` [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs Aditya Swarup
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Aditya Swarup @ 2021-01-11 19:29 UTC (permalink / raw)
To: intel-gfx
v1:
1. Change TGL REVID enums/macros to TGL stepping info to apply TGL WAs.
2. Add ADL-S platform info and PCI IDs and add TGL style stepping macros
for applying WAs.
v2:
- Replace macros with PCI IDs based on Matt Roper's suggestion.
Aditya Swarup (1):
drm/i915/tgl: Use TGL stepping info for applying WAs
Caz Yokoyama (1):
drm/i915/adl_s: Add ADL-S platform info and PCI ids
.../drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/display/intel_psr.c | 4 +-
drivers/gpu/drm/i915/display/intel_sprite.c | 2 +-
drivers/gpu/drm/i915/gt/intel_workarounds.c | 34 +++++---
drivers/gpu/drm/i915/i915_drv.h | 79 ++++++++++++-------
drivers/gpu/drm/i915/i915_pci.c | 13 +++
drivers/gpu/drm/i915/intel_device_info.c | 1 +
drivers/gpu/drm/i915/intel_device_info.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 2 +-
include/drm/i915_pciids.h | 11 +++
10 files changed, 104 insertions(+), 45 deletions(-)
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
@ 2021-01-11 19:29 ` Aditya Swarup
2021-01-11 19:30 ` [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids Aditya Swarup
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Aditya Swarup @ 2021-01-11 19:29 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
TGL adds another level of indirection for applying WA based on stepping
information rather than PCI REVID. So change TGL_REVID enum into
stepping enum and use PCI REVID as index into revid to stepping table to
fetch correct display and GT stepping for application of WAs as
suggested by Matt Roper.
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
---
.../drm/i915/display/intel_display_power.c | 2 +-
drivers/gpu/drm/i915/display/intel_psr.c | 4 +-
drivers/gpu/drm/i915/display/intel_sprite.c | 2 +-
drivers/gpu/drm/i915/gt/intel_workarounds.c | 26 +++++-----
drivers/gpu/drm/i915/i915_drv.h | 50 +++++++++----------
drivers/gpu/drm/i915/intel_pm.c | 2 +-
6 files changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index d52374f01316..bb04b502a442 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5340,7 +5340,7 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)
int config, i;
if (IS_DG1_REVID(dev_priv, DG1_REVID_A0, DG1_REVID_A0) ||
- IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_B0))
+ IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_B0))
/* Wa_1409767108:tgl,dg1 */
table = wa_1409767108_buddy_page_masks;
else
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index c24ae69426cf..a93717178957 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -550,7 +550,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
if (dev_priv->psr.psr2_sel_fetch_enabled) {
/* WA 1408330847 */
- if (IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0) ||
+ if (IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_A0) ||
IS_RKL_REVID(dev_priv, RKL_REVID_A0, RKL_REVID_A0))
intel_de_rmw(dev_priv, CHICKEN_PAR1_1,
DIS_RAM_BYPASS_PSR2_MAN_TRACK,
@@ -1102,7 +1102,7 @@ static void intel_psr_disable_locked(struct intel_dp *intel_dp)
/* WA 1408330847 */
if (dev_priv->psr.psr2_sel_fetch_enabled &&
- (IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0) ||
+ (IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_A0) ||
IS_RKL_REVID(dev_priv, RKL_REVID_A0, RKL_REVID_A0)))
intel_de_rmw(dev_priv, CHICKEN_PAR1_1,
DIS_RAM_BYPASS_PSR2_MAN_TRACK, 0);
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index cf3589fd0ddb..4ce32df3855f 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -3033,7 +3033,7 @@ static bool gen12_plane_supports_mc_ccs(struct drm_i915_private *dev_priv,
{
/* Wa_14010477008:tgl[a0..c0],rkl[all],dg1[all] */
if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
- IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_C0))
+ IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_C0))
return false;
return plane_id < PLANE_SPRITE4;
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index c21a9726326a..111d01e2f81e 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -71,17 +71,17 @@ const struct i915_rev_steppings kbl_revids[] = {
[7] = { .gt_stepping = KBL_REVID_G0, .disp_stepping = KBL_REVID_C0 },
};
-const struct i915_rev_steppings tgl_uy_revids[] = {
- [0] = { .gt_stepping = TGL_REVID_A0, .disp_stepping = TGL_REVID_A0 },
- [1] = { .gt_stepping = TGL_REVID_B0, .disp_stepping = TGL_REVID_C0 },
- [2] = { .gt_stepping = TGL_REVID_B1, .disp_stepping = TGL_REVID_C0 },
- [3] = { .gt_stepping = TGL_REVID_C0, .disp_stepping = TGL_REVID_D0 },
+const struct i915_rev_steppings tgl_uy_revid_step_tbl[] = {
+ [0] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_A0 },
+ [1] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_C0 },
+ [2] = { .gt_stepping = STEP_B1, .disp_stepping = STEP_C0 },
+ [3] = { .gt_stepping = STEP_C0, .disp_stepping = STEP_D0 },
};
/* Same GT stepping between tgl_uy_revids and tgl_revids don't mean the same HW */
-const struct i915_rev_steppings tgl_revids[] = {
- [0] = { .gt_stepping = TGL_REVID_A0, .disp_stepping = TGL_REVID_B0 },
- [1] = { .gt_stepping = TGL_REVID_B0, .disp_stepping = TGL_REVID_D0 },
+const struct i915_rev_steppings tgl_revid_step_tbl[] = {
+ [0] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_B0 },
+ [1] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_D0 },
};
static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
@@ -1211,19 +1211,19 @@ tgl_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
gen12_gt_workarounds_init(i915, wal);
/* Wa_1409420604:tgl */
- if (IS_TGL_UY_GT_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
+ if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
wa_write_or(wal,
SUBSLICE_UNIT_LEVEL_CLKGATE2,
CPSSUNIT_CLKGATE_DIS);
/* Wa_1607087056:tgl also know as BUG:1409180338 */
- if (IS_TGL_UY_GT_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
+ if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
wa_write_or(wal,
SLICE_UNIT_LEVEL_CLKGATE,
L3_CLKGATE_DIS | L3_CR2X_CLKGATE_DIS);
/* Wa_1408615072:tgl[a0] */
- if (IS_TGL_UY_GT_REVID(i915, TGL_REVID_A0, TGL_REVID_A0))
+ if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0))
wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
VSUNIT_CLKGATE_DIS_TGL);
}
@@ -1700,7 +1700,7 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
struct drm_i915_private *i915 = engine->i915;
if (IS_DG1_REVID(i915, DG1_REVID_A0, DG1_REVID_A0) ||
- IS_TGL_UY_GT_REVID(i915, TGL_REVID_A0, TGL_REVID_A0)) {
+ IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0)) {
/*
* Wa_1607138336:tgl[a0],dg1[a0]
* Wa_1607063988:tgl[a0],dg1[a0]
@@ -1710,7 +1710,7 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
}
- if (IS_TGL_UY_GT_REVID(i915, TGL_REVID_A0, TGL_REVID_A0)) {
+ if (IS_TGL_UY_GT_STEPPING(i915, STEP_A0, STEP_A0)) {
/*
* Wa_1606679103:tgl
* (see also Wa_1606682166:icl)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5e5bcef20e33..11d6e8abde46 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1559,54 +1559,54 @@ extern const struct i915_rev_steppings kbl_revids[];
(IS_JSL_EHL(p) && IS_REVID(p, since, until))
enum {
- TGL_REVID_A0,
- TGL_REVID_B0,
- TGL_REVID_B1,
- TGL_REVID_C0,
- TGL_REVID_D0,
+ STEP_A0,
+ STEP_B0,
+ STEP_B1,
+ STEP_C0,
+ STEP_D0,
};
-#define TGL_UY_REVIDS_SIZE 4
-#define TGL_REVIDS_SIZE 2
+#define TGL_UY_REVID_STEP_TBL_SIZE 4
+#define TGL_REVID_STEP_TBL_SIZE 2
-extern const struct i915_rev_steppings tgl_uy_revids[TGL_UY_REVIDS_SIZE];
-extern const struct i915_rev_steppings tgl_revids[TGL_REVIDS_SIZE];
+extern const struct i915_rev_steppings tgl_uy_revid_step_tbl[TGL_UY_REVID_STEP_TBL_SIZE];
+extern const struct i915_rev_steppings tgl_revid_step_tbl[TGL_REVID_STEP_TBL_SIZE];
static inline const struct i915_rev_steppings *
-tgl_revids_get(struct drm_i915_private *dev_priv)
+tgl_stepping_get(struct drm_i915_private *dev_priv)
{
u8 revid = INTEL_REVID(dev_priv);
u8 size;
- const struct i915_rev_steppings *tgl_revid_tbl;
+ const struct i915_rev_steppings *revid_step_tbl;
if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
- tgl_revid_tbl = tgl_uy_revids;
- size = ARRAY_SIZE(tgl_uy_revids);
+ revid_step_tbl = tgl_uy_revid_step_tbl;
+ size = ARRAY_SIZE(tgl_uy_revid_step_tbl);
} else {
- tgl_revid_tbl = tgl_revids;
- size = ARRAY_SIZE(tgl_revids);
+ revid_step_tbl = tgl_revid_step_tbl;
+ size = ARRAY_SIZE(tgl_revid_step_tbl);
}
revid = min_t(u8, revid, size - 1);
- return &tgl_revid_tbl[revid];
+ return &revid_step_tbl[revid];
}
-#define IS_TGL_DISP_REVID(p, since, until) \
+#define IS_TGL_DISP_STEPPING(p, since, until) \
(IS_TIGERLAKE(p) && \
- tgl_revids_get(p)->disp_stepping >= (since) && \
- tgl_revids_get(p)->disp_stepping <= (until))
+ tgl_stepping_get(p)->disp_stepping >= (since) && \
+ tgl_stepping_get(p)->disp_stepping <= (until))
-#define IS_TGL_UY_GT_REVID(p, since, until) \
+#define IS_TGL_UY_GT_STEPPING(p, since, until) \
((IS_TGL_U(p) || IS_TGL_Y(p)) && \
- tgl_revids_get(p)->gt_stepping >= (since) && \
- tgl_revids_get(p)->gt_stepping <= (until))
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
-#define IS_TGL_GT_REVID(p, since, until) \
+#define IS_TGL_GT_STEPPING(p, since, until) \
(IS_TIGERLAKE(p) && \
!(IS_TGL_U(p) || IS_TGL_Y(p)) && \
- tgl_revids_get(p)->gt_stepping >= (since) && \
- tgl_revids_get(p)->gt_stepping <= (until))
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
#define RKL_REVID_A0 0x0
#define RKL_REVID_B0 0x1
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index bbc73df7f753..319acca2630b 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7110,7 +7110,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
ILK_DPFC_CHICKEN_COMP_DUMMY_PIXEL);
/* Wa_1409825376:tgl (pre-prod)*/
- if (IS_TGL_DISP_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_B1))
+ if (IS_TGL_DISP_STEPPING(dev_priv, STEP_A0, STEP_B1))
intel_uncore_write(&dev_priv->uncore, GEN9_CLKGATE_DIS_3, intel_uncore_read(&dev_priv->uncore, GEN9_CLKGATE_DIS_3) |
TGL_VRH_GATING_DIS);
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
2021-01-11 19:29 ` [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs Aditya Swarup
@ 2021-01-11 19:30 ` Aditya Swarup
2021-01-19 19:40 ` Lucas De Marchi
2021-01-11 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use TGL stepping info and add ADLS platform changes (rev2) Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Aditya Swarup @ 2021-01-11 19:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi
From: Caz Yokoyama <caz.yokoyama@intel.com>
- Add the initial platform information for Alderlake-S.
- Specify ppgtt_size value
- Add dma_mask_size
- Add ADLS REVIDs
- HW tracking(Selective Update Tracking Enable) has been
removed from ADLS. Disable PSR2 till we enable software/
manual tracking.
v2:
- Add support for different ADLS SOC steppings to select
correct GT/DISP stepping based on Bspec 53655 based on
feedback from Matt Roper.(aswarup)
v3:
- Make display/gt steppings info generic for reuse with TGL and ADLS.
- Modify the macros to reuse tgl_revids_get()
- Add HTI support to adls device info.(mdroper)
v4:
- Rebase on TGL patch for applying WAs based on stepping info from
Matt Roper's feedback.(aswarup)
v5:
- Replace macros with PCI IDs in revid to stepping table.
Bspec: 53597
Bspec: 53648
Bspec: 53655
Bspec: 48028
Bspec: 53650
BSpec: 50422
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++
drivers/gpu/drm/i915/i915_drv.h | 27 ++++++++++++++++++++-
drivers/gpu/drm/i915/i915_pci.c | 13 ++++++++++
drivers/gpu/drm/i915/intel_device_info.c | 1 +
drivers/gpu/drm/i915/intel_device_info.h | 1 +
include/drm/i915_pciids.h | 11 +++++++++
6 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 111d01e2f81e..cb9220925fe7 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -84,6 +84,14 @@ const struct i915_rev_steppings tgl_revid_step_tbl[] = {
[1] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_D0 },
};
+const struct i915_rev_steppings adls_revid_step_tbl[] = {
+ [0x0] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_A0 },
+ [0x1] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_A2 },
+ [0x4] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_B0 },
+ [0x8] = { .gt_stepping = STEP_C0, .disp_stepping = STEP_B0 },
+ [0xC] = { .gt_stepping = STEP_D0, .disp_stepping = STEP_C0 },
+};
+
static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
{
wal->name = name;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 11d6e8abde46..8d8a046a7b0c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1417,6 +1417,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
#define IS_TIGERLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_TIGERLAKE)
#define IS_ROCKETLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_ROCKETLAKE)
#define IS_DG1(dev_priv) IS_PLATFORM(dev_priv, INTEL_DG1)
+#define IS_ALDERLAKE_S(dev_priv) IS_PLATFORM(dev_priv, INTEL_ALDERLAKE_S)
#define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
(INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
#define IS_BDW_ULT(dev_priv) \
@@ -1560,6 +1561,7 @@ extern const struct i915_rev_steppings kbl_revids[];
enum {
STEP_A0,
+ STEP_A2,
STEP_B0,
STEP_B1,
STEP_C0,
@@ -1568,9 +1570,11 @@ enum {
#define TGL_UY_REVID_STEP_TBL_SIZE 4
#define TGL_REVID_STEP_TBL_SIZE 2
+#define ADLS_REVID_STEP_TBL_SIZE 13
extern const struct i915_rev_steppings tgl_uy_revid_step_tbl[TGL_UY_REVID_STEP_TBL_SIZE];
extern const struct i915_rev_steppings tgl_revid_step_tbl[TGL_REVID_STEP_TBL_SIZE];
+extern const struct i915_rev_steppings adls_revid_step_tbl[ADLS_REVID_STEP_TBL_SIZE];
static inline const struct i915_rev_steppings *
tgl_stepping_get(struct drm_i915_private *dev_priv)
@@ -1579,7 +1583,10 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
u8 size;
const struct i915_rev_steppings *revid_step_tbl;
- if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
+ if (IS_ALDERLAKE_S(dev_priv)) {
+ revid_step_tbl = adls_revid_step_tbl;
+ size = ARRAY_SIZE(adls_revid_step_tbl);
+ } else if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
revid_step_tbl = tgl_uy_revid_step_tbl;
size = ARRAY_SIZE(tgl_uy_revid_step_tbl);
} else {
@@ -1621,6 +1628,24 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
#define IS_DG1_REVID(p, since, until) \
(IS_DG1(p) && IS_REVID(p, since, until))
+#define ADLS_REVID_A0 0x0
+#define ADLS_REVID_A2 0x1
+#define ADLS_REVID_B0 0x4
+#define ADLS_REVID_G0 0x8
+#define ADLS_REVID_C0 0xC /*Same as H0 ADLS SOC stepping*/
+
+extern const struct i915_rev_steppings adls_revids[];
+
+#define IS_ADLS_DISP_STEPPING(p, since, until) \
+ (IS_ALDERLAKE_S(p) && \
+ tgl_stepping_get(p)->disp_stepping >= (since) && \
+ tgl_stepping_get(p)->disp_stepping <= (until))
+
+#define IS_ADLS_GT_STEPPING(p, since, until) \
+ (IS_ALDERLAKE_S(p) && \
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
+
#define IS_LP(dev_priv) (INTEL_INFO(dev_priv)->is_lp)
#define IS_GEN9_LP(dev_priv) (IS_GEN(dev_priv, 9) && IS_LP(dev_priv))
#define IS_GEN9_BC(dev_priv) (IS_GEN(dev_priv, 9) && !IS_LP(dev_priv))
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 11fe790b1969..26e4bf8bb4ef 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -925,6 +925,18 @@ static const struct intel_device_info dg1_info __maybe_unused = {
.ppgtt_size = 47,
};
+static const struct intel_device_info adl_s_info = {
+ GEN12_FEATURES,
+ PLATFORM(INTEL_ALDERLAKE_S),
+ .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
+ .require_force_probe = 1,
+ .display.has_hti = 1,
+ .display.has_psr_hw_tracking = 0,
+ .platform_engine_mask =
+ BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
+ .dma_mask_size = 46,
+};
+
#undef GEN
#undef PLATFORM
@@ -1001,6 +1013,7 @@ static const struct pci_device_id pciidlist[] = {
INTEL_JSL_IDS(&jsl_info),
INTEL_TGL_12_IDS(&tgl_info),
INTEL_RKL_IDS(&rkl_info),
+ INTEL_ADLS_IDS(&adl_s_info),
{0, 0, 0}
};
MODULE_DEVICE_TABLE(pci, pciidlist);
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index f2d5ae59081e..699412c14c1d 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -66,6 +66,7 @@ static const char * const platform_names[] = {
PLATFORM_NAME(TIGERLAKE),
PLATFORM_NAME(ROCKETLAKE),
PLATFORM_NAME(DG1),
+ PLATFORM_NAME(ALDERLAKE_S),
};
#undef PLATFORM_NAME
diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
index 17d0fdb94d2d..d09857cdc954 100644
--- a/drivers/gpu/drm/i915/intel_device_info.h
+++ b/drivers/gpu/drm/i915/intel_device_info.h
@@ -84,6 +84,7 @@ enum intel_platform {
INTEL_TIGERLAKE,
INTEL_ROCKETLAKE,
INTEL_DG1,
+ INTEL_ALDERLAKE_S,
INTEL_MAX_PLATFORMS
};
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 931e46191047..ebd0dd1c35b3 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -634,4 +634,15 @@
INTEL_VGA_DEVICE(0x4907, info), \
INTEL_VGA_DEVICE(0x4908, info)
+/* ADL-S */
+#define INTEL_ADLS_IDS(info) \
+ INTEL_VGA_DEVICE(0x4680, info), \
+ INTEL_VGA_DEVICE(0x4681, info), \
+ INTEL_VGA_DEVICE(0x4682, info), \
+ INTEL_VGA_DEVICE(0x4683, info), \
+ INTEL_VGA_DEVICE(0x4690, info), \
+ INTEL_VGA_DEVICE(0x4691, info), \
+ INTEL_VGA_DEVICE(0x4692, info), \
+ INTEL_VGA_DEVICE(0x4693, info)
+
#endif /* _I915_PCIIDS_H */
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use TGL stepping info and add ADLS platform changes (rev2)
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
2021-01-11 19:29 ` [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs Aditya Swarup
2021-01-11 19:30 ` [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids Aditya Swarup
@ 2021-01-11 19:44 ` Patchwork
2021-01-11 20:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-11 22:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-01-11 19:44 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
== Series Details ==
Series: Use TGL stepping info and add ADLS platform changes (rev2)
URL : https://patchwork.freedesktop.org/series/85639/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5e2bd50d9a37 drm/i915/tgl: Use TGL stepping info for applying WAs
-:197: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#197: FILE: drivers/gpu/drm/i915/i915_drv.h:1595:
+#define IS_TGL_DISP_STEPPING(p, since, until) \
(IS_TIGERLAKE(p) && \
+ tgl_stepping_get(p)->disp_stepping >= (since) && \
+ tgl_stepping_get(p)->disp_stepping <= (until))
-:205: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#205: FILE: drivers/gpu/drm/i915/i915_drv.h:1600:
+#define IS_TGL_UY_GT_STEPPING(p, since, until) \
((IS_TGL_U(p) || IS_TGL_Y(p)) && \
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
-:213: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#213: FILE: drivers/gpu/drm/i915/i915_drv.h:1605:
+#define IS_TGL_GT_STEPPING(p, since, until) \
(IS_TIGERLAKE(p) && \
!(IS_TGL_U(p) || IS_TGL_Y(p)) && \
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
total: 0 errors, 0 warnings, 3 checks, 182 lines checked
f919d3dd38ae drm/i915/adl_s: Add ADL-S platform info and PCI ids
-:126: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#126: FILE: drivers/gpu/drm/i915/i915_drv.h:1639:
+#define IS_ADLS_DISP_STEPPING(p, since, until) \
+ (IS_ALDERLAKE_S(p) && \
+ tgl_stepping_get(p)->disp_stepping >= (since) && \
+ tgl_stepping_get(p)->disp_stepping <= (until))
-:131: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#131: FILE: drivers/gpu/drm/i915/i915_drv.h:1644:
+#define IS_ADLS_GT_STEPPING(p, since, until) \
+ (IS_ALDERLAKE_S(p) && \
+ tgl_stepping_get(p)->gt_stepping >= (since) && \
+ tgl_stepping_get(p)->gt_stepping <= (until))
-:203: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#203: FILE: include/drm/i915_pciids.h:638:
+#define INTEL_ADLS_IDS(info) \
+ INTEL_VGA_DEVICE(0x4680, info), \
+ INTEL_VGA_DEVICE(0x4681, info), \
+ INTEL_VGA_DEVICE(0x4682, info), \
+ INTEL_VGA_DEVICE(0x4683, info), \
+ INTEL_VGA_DEVICE(0x4690, info), \
+ INTEL_VGA_DEVICE(0x4691, info), \
+ INTEL_VGA_DEVICE(0x4692, info), \
+ INTEL_VGA_DEVICE(0x4693, info)
-:203: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#203: FILE: include/drm/i915_pciids.h:638:
+#define INTEL_ADLS_IDS(info) \
+ INTEL_VGA_DEVICE(0x4680, info), \
+ INTEL_VGA_DEVICE(0x4681, info), \
+ INTEL_VGA_DEVICE(0x4682, info), \
+ INTEL_VGA_DEVICE(0x4683, info), \
+ INTEL_VGA_DEVICE(0x4690, info), \
+ INTEL_VGA_DEVICE(0x4691, info), \
+ INTEL_VGA_DEVICE(0x4692, info), \
+ INTEL_VGA_DEVICE(0x4693, info)
total: 1 errors, 0 warnings, 3 checks, 128 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Use TGL stepping info and add ADLS platform changes (rev2)
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
` (2 preceding siblings ...)
2021-01-11 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use TGL stepping info and add ADLS platform changes (rev2) Patchwork
@ 2021-01-11 20:14 ` Patchwork
2021-01-11 22:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-01-11 20:14 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6579 bytes --]
== Series Details ==
Series: Use TGL stepping info and add ADLS platform changes (rev2)
URL : https://patchwork.freedesktop.org/series/85639/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9581 -> Patchwork_19317
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/index.html
Known issues
------------
Here are the changes found in Patchwork_19317 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +26 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-tgl-y: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +15 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@amdgpu/amd_cs_nop@fork-gfx0.html
* igt@amdgpu/amd_cs_nop@sync-compute0:
- fi-kbl-r: NOTRUN -> [SKIP][3] ([fdo#109271]) +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-kbl-r/igt@amdgpu/amd_cs_nop@sync-compute0.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][4] ([i915#2283])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-r: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-kbl-r/igt@gem_huc_copy@huc-copy.html
* igt@gem_tiled_blits@basic:
- fi-tgl-y: NOTRUN -> [DMESG-WARN][6] ([i915#402]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@gt_lrc:
- fi-tgl-y: NOTRUN -> [DMESG-FAIL][7] ([i915#2373])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- fi-tgl-y: NOTRUN -> [DMESG-FAIL][8] ([i915#1759])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@i915_selftest@live@gt_pm.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-snb-2600: NOTRUN -> [SKIP][9] ([fdo#109271]) +30 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-snb-2600/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-snb-2600: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-snb-2600/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-r: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-kbl-r/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@vga-edid-read:
- fi-tgl-y: NOTRUN -> [SKIP][13] ([fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@kms_chamelium@vga-edid-read.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-y: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-tgl-y/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-r: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#533])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-kbl-r/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-snb-2600: [DMESG-WARN][16] ([i915#2772]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-snb-2600/igt@gem_exec_suspend@basic-s3.html
#### Warnings ####
* igt@i915_hangman@error-state-basic:
- fi-apl-guc: [DMESG-WARN][18] -> [DMESG-WARN][19] ([i915#1610])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/fi-apl-guc/igt@i915_hangman@error-state-basic.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/fi-apl-guc/igt@i915_hangman@error-state-basic.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2772]: https://gitlab.freedesktop.org/drm/intel/issues/2772
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (43 -> 38)
------------------------------
Additional (1): fi-tgl-y
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-cml-drallion fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9581 -> Patchwork_19317
CI-20190529: 20190529
CI_DRM_9581: 6f3bd6b19cb6cf20481e7c275d04b54ef7539655 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5953: 65c5eea699141e6f942ce0a8fc85db76ce53cd19 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19317: f919d3dd38ae363eb2e89f03660d353e4acf5d9c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f919d3dd38ae drm/i915/adl_s: Add ADL-S platform info and PCI ids
5e2bd50d9a37 drm/i915/tgl: Use TGL stepping info for applying WAs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/index.html
[-- Attachment #1.2: Type: text/html, Size: 8265 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Use TGL stepping info and add ADLS platform changes (rev2)
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
` (3 preceding siblings ...)
2021-01-11 20:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-01-11 22:19 ` Patchwork
2021-01-19 18:09 ` Aditya Swarup
4 siblings, 1 reply; 8+ messages in thread
From: Patchwork @ 2021-01-11 22:19 UTC (permalink / raw)
To: Aditya Swarup; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18741 bytes --]
== Series Details ==
Series: Use TGL stepping info and add ADLS platform changes (rev2)
URL : https://patchwork.freedesktop.org/series/85639/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9581_full -> Patchwork_19317_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19317_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19317_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19317_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@gem_ctx_persistence@close-replace-race.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl4/igt@gem_ctx_persistence@close-replace-race.html
* igt@sysfs_timeslice_duration@timeout@rcs0:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl9/igt@sysfs_timeslice_duration@timeout@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl8/igt@sysfs_timeslice_duration@timeout@rcs0.html
Known issues
------------
Here are the changes found in Patchwork_19317_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@prime:
- shard-kbl: [PASS][5] -> [INCOMPLETE][6] ([i915#2895])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl1/igt@drm_import_export@prime.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@drm_import_export@prime.html
* igt@gem_ctx_persistence@engines-hang:
- shard-hsw: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@gem_ctx_persistence@engines-hang.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-hsw: NOTRUN -> [FAIL][8] ([i915#2389]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw2/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#118] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk9/igt@gem_exec_whisper@basic-fds-forked-all.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk4/igt@gem_exec_whisper@basic-fds-forked-all.html
* igt@kms_color@pipe-c-ctm-red-to-blue:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl8/igt@kms_color@pipe-c-ctm-red-to-blue.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_color@pipe-c-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-hsw: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +14 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
- shard-skl: [PASS][14] -> [FAIL][15] ([i915#54]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][16] -> [FAIL][17] ([i915#2370])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#2346])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#79])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [PASS][22] -> [FAIL][23] ([i915#2598])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][24] -> [FAIL][25] ([i915#2122]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl10/igt@kms_flip@plain-flip-ts-check@c-edp1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl1/igt@kms_flip@plain-flip-ts-check@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271]) +6 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-hsw: NOTRUN -> [DMESG-WARN][27] ([i915#2637])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108145] / [i915#265]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min:
- shard-hsw: NOTRUN -> [SKIP][30] ([fdo#109271]) +198 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw2/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][31] -> [DMESG-FAIL][32] ([i915#1226])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
- shard-glk: [PASS][33] -> [DMESG-FAIL][34] ([i915#118] / [i915#95])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-x.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl4/igt@perf@polling-parameterized.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@perf@polling-parameterized.html
* igt@runner@aborted:
- shard-hsw: NOTRUN -> [FAIL][39] ([i915#2295] / [i915#2505])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_ctx_persistence@smoketest:
- shard-iclb: [FAIL][40] ([i915#2896]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb3/igt@gem_ctx_persistence@smoketest.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb5/igt@gem_ctx_persistence@smoketest.html
* {igt@gem_exec_fair@basic-none-share@rcs0}:
- shard-apl: [SKIP][42] ([fdo#109271]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-glk: [FAIL][44] ([i915#2842]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk8/igt@gem_exec_fair@basic-none-share@rcs0.html
* {igt@gem_exec_fair@basic-pace@rcs0}:
- shard-kbl: [FAIL][46] ([i915#2842]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
* {igt@gem_vm_create@destroy-race}:
- shard-tglb: [TIMEOUT][48] ([i915#2795]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb3/igt@gem_vm_create@destroy-race.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb2/igt@gem_vm_create@destroy-race.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- shard-skl: [FAIL][50] ([i915#54]) -> [PASS][51] +6 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][52] ([i915#79]) -> [PASS][53] +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][54] ([i915#2122]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-skl: [INCOMPLETE][56] ([i915#146] / [i915#648]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][58] ([fdo#109642] / [fdo#111068]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb7/igt@kms_psr2_su@page_flip.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-tglb: [SKIP][60] ([i915#668]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb3/igt@kms_psr@psr2_primary_mmap_cpu.html
* {igt@perf@non-zero-reason}:
- shard-skl: [FAIL][62] -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl2/igt@perf@non-zero-reason.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@perf@non-zero-reason.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][64] ([i915#1804] / [i915#2684]) -> [WARN][65] ([i915#2681] / [i915#2684])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [DMESG-WARN][66] ([i915#1602]) -> [INCOMPLETE][67] ([i915#155])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][68], [FAIL][69]) ([i915#1814] / [i915#2295]) -> ([FAIL][70], [FAIL][71]) ([i915#2295] / [i915#2505] / [i915#2722])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@runner@aborted.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl4/igt@runner@aborted.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@runner@aborted.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@runner@aborted.html
- shard-skl: ([FAIL][72], [FAIL][73]) ([i915#1436] / [i915#2295]) -> ([FAIL][74], [FAIL][75], [FAIL][76], [FAIL][77]) ([i915#1436] / [i915#2295] / [i915#2426])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl5/igt@runner@aborted.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl4/igt@runner@aborted.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl3/igt@runner@aborted.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@runner@aborted.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@runner@aborted.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2895]: https://gitlab.freedesktop.org/drm/intel/issues/2895
[i915#2896]: https://gitlab.freedesktop.org/drm/intel/issues/2896
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9581 -> Patchwork_19317
CI-20190529: 20190529
CI_DRM_9581: 6f3bd6b19cb6cf20481e7c275d04b54ef7539655 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5953: 65c5eea699141e6f942ce0a8fc85db76ce53cd19 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19317: f919d3dd38ae363eb2e89f03660d353e4acf5d9c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/index.html
[-- Attachment #1.2: Type: text/html, Size: 21443 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Use TGL stepping info and add ADLS platform changes (rev2)
2021-01-11 22:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-01-19 18:09 ` Aditya Swarup
0 siblings, 0 replies; 8+ messages in thread
From: Aditya Swarup @ 2021-01-19 18:09 UTC (permalink / raw)
To: intel-gfx
On 1/11/21 2:19 PM, Patchwork wrote:
> == Series Details ==
>
> Series: Use TGL stepping info and add ADLS platform changes (rev2)
> URL : https://patchwork.freedesktop.org/series/85639/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_9581_full -> Patchwork_19317_full
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_19317_full absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_19317_full, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
>
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_19317_full:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@gem_ctx_persistence@close-replace-race:
> - shard-kbl: [PASS][1] -> [TIMEOUT][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@gem_ctx_persistence@close-replace-race.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl4/igt@gem_ctx_persistence@close-replace-race.html
>
> * igt@sysfs_timeslice_duration@timeout@rcs0:
> - shard-skl: [PASS][3] -> [FAIL][4]
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl9/igt@sysfs_timeslice_duration@timeout@rcs0.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl8/igt@sysfs_timeslice_duration@timeout@rcs0.html
>
These regressions are unrelated to the changes from the patch series posted as it only affects TGL and ADLS.
aswarup
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_19317_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@drm_import_export@prime:
> - shard-kbl: [PASS][5] -> [INCOMPLETE][6] ([i915#2895])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl1/igt@drm_import_export@prime.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@drm_import_export@prime.html
>
> * igt@gem_ctx_persistence@engines-hang:
> - shard-hsw: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +3 similar issues
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@gem_ctx_persistence@engines-hang.html
>
> * igt@gem_exec_reloc@basic-wide-active@bcs0:
> - shard-hsw: NOTRUN -> [FAIL][8] ([i915#2389]) +3 similar issues
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw2/igt@gem_exec_reloc@basic-wide-active@bcs0.html
>
> * igt@gem_exec_whisper@basic-fds-forked-all:
> - shard-glk: [PASS][9] -> [DMESG-WARN][10] ([i915#118] / [i915#95])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk9/igt@gem_exec_whisper@basic-fds-forked-all.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk4/igt@gem_exec_whisper@basic-fds-forked-all.html
>
> * igt@kms_color@pipe-c-ctm-red-to-blue:
> - shard-skl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl8/igt@kms_color@pipe-c-ctm-red-to-blue.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_color@pipe-c-ctm-red-to-blue.html
>
> * igt@kms_color_chamelium@pipe-d-ctm-0-75:
> - shard-hsw: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +14 similar issues
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@kms_color_chamelium@pipe-d-ctm-0-75.html
>
> * igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
> - shard-skl: [PASS][14] -> [FAIL][15] ([i915#54]) +4 similar issues
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding.html
>
> * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
> - shard-hsw: [PASS][16] -> [FAIL][17] ([i915#2370])
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
> - shard-skl: [PASS][18] -> [FAIL][19] ([i915#2346])
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
>
> * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
> - shard-glk: [PASS][20] -> [FAIL][21] ([i915#79])
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
>
> * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
> - shard-tglb: [PASS][22] -> [FAIL][23] ([i915#2598])
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
>
> * igt@kms_flip@plain-flip-ts-check@c-edp1:
> - shard-skl: [PASS][24] -> [FAIL][25] ([i915#2122]) +2 similar issues
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl10/igt@kms_flip@plain-flip-ts-check@c-edp1.html
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl1/igt@kms_flip@plain-flip-ts-check@c-edp1.html
>
> * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
> - shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271]) +6 similar issues
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
>
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> - shard-hsw: NOTRUN -> [DMESG-WARN][27] ([i915#2637])
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>
> * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
> - shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108145] / [i915#265]) +2 similar issues
> [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
> [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>
> * igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min:
> - shard-hsw: NOTRUN -> [SKIP][30] ([fdo#109271]) +198 similar issues
> [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw2/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min.html
>
> * igt@kms_plane_lowres@pipe-a-tiling-x:
> - shard-iclb: [PASS][31] -> [DMESG-FAIL][32] ([i915#1226])
> [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
> [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
> - shard-glk: [PASS][33] -> [DMESG-FAIL][34] ([i915#118] / [i915#95])
> [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk2/igt@kms_plane_lowres@pipe-a-tiling-x.html
> [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html
>
> * igt@kms_psr@psr2_sprite_blt:
> - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
> [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
> [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
>
> * igt@perf@polling-parameterized:
> - shard-skl: [PASS][37] -> [FAIL][38] ([i915#1542])
> [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl4/igt@perf@polling-parameterized.html
> [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@perf@polling-parameterized.html
>
> * igt@runner@aborted:
> - shard-hsw: NOTRUN -> [FAIL][39] ([i915#2295] / [i915#2505])
> [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-hsw4/igt@runner@aborted.html
>
>
> #### Possible fixes ####
>
> * igt@gem_ctx_persistence@smoketest:
> - shard-iclb: [FAIL][40] ([i915#2896]) -> [PASS][41]
> [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb3/igt@gem_ctx_persistence@smoketest.html
> [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb5/igt@gem_ctx_persistence@smoketest.html
>
> * {igt@gem_exec_fair@basic-none-share@rcs0}:
> - shard-apl: [SKIP][42] ([fdo#109271]) -> [PASS][43]
> [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
> [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-apl7/igt@gem_exec_fair@basic-none-share@rcs0.html
> - shard-glk: [FAIL][44] ([i915#2842]) -> [PASS][45]
> [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html
> [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk8/igt@gem_exec_fair@basic-none-share@rcs0.html
>
> * {igt@gem_exec_fair@basic-pace@rcs0}:
> - shard-kbl: [FAIL][46] ([i915#2842]) -> [PASS][47]
> [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
> [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
>
> * {igt@gem_vm_create@destroy-race}:
> - shard-tglb: [TIMEOUT][48] ([i915#2795]) -> [PASS][49]
> [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb3/igt@gem_vm_create@destroy-race.html
> [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb2/igt@gem_vm_create@destroy-race.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
> - shard-skl: [FAIL][50] ([i915#54]) -> [PASS][51] +6 similar issues
> [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
> [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
>
> * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
> - shard-glk: [FAIL][52] ([i915#79]) -> [PASS][53] +1 similar issue
> [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
> [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
>
> * igt@kms_flip@plain-flip-fb-recreate@b-edp1:
> - shard-skl: [FAIL][54] ([i915#2122]) -> [PASS][55]
> [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
> [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
>
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> - shard-skl: [INCOMPLETE][56] ([i915#146] / [i915#648]) -> [PASS][57]
> [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
> * igt@kms_psr2_su@page_flip:
> - shard-iclb: [SKIP][58] ([fdo#109642] / [fdo#111068]) -> [PASS][59]
> [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb7/igt@kms_psr2_su@page_flip.html
> [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb2/igt@kms_psr2_su@page_flip.html
>
> * igt@kms_psr@psr2_primary_mmap_cpu:
> - shard-tglb: [SKIP][60] ([i915#668]) -> [PASS][61]
> [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-tglb1/igt@kms_psr@psr2_primary_mmap_cpu.html
> [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-tglb3/igt@kms_psr@psr2_primary_mmap_cpu.html
>
> * {igt@perf@non-zero-reason}:
> - shard-skl: [FAIL][62] -> [PASS][63]
> [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl2/igt@perf@non-zero-reason.html
> [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@perf@non-zero-reason.html
>
>
> #### Warnings ####
>
> * igt@i915_pm_rc6_residency@rc6-idle:
> - shard-iclb: [WARN][64] ([i915#1804] / [i915#2684]) -> [WARN][65] ([i915#2681] / [i915#2684])
> [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
> [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-iclb8/igt@i915_pm_rc6_residency@rc6-idle.html
>
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> - shard-kbl: [DMESG-WARN][66] ([i915#1602]) -> [INCOMPLETE][67] ([i915#155])
> [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>
> * igt@runner@aborted:
> - shard-kbl: ([FAIL][68], [FAIL][69]) ([i915#1814] / [i915#2295]) -> ([FAIL][70], [FAIL][71]) ([i915#2295] / [i915#2505] / [i915#2722])
> [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl2/igt@runner@aborted.html
> [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-kbl4/igt@runner@aborted.html
> [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@runner@aborted.html
> [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-kbl6/igt@runner@aborted.html
> - shard-skl: ([FAIL][72], [FAIL][73]) ([i915#1436] / [i915#2295]) -> ([FAIL][74], [FAIL][75], [FAIL][76], [FAIL][77]) ([i915#1436] / [i915#2295] / [i915#2426])
> [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl5/igt@runner@aborted.html
> [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9581/shard-skl4/igt@runner@aborted.html
> [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl3/igt@runner@aborted.html
> [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl5/igt@runner@aborted.html
> [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl9/igt@runner@aborted.html
> [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/shard-skl3/igt@runner@aborted.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
> [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
> [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
> [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
> [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
> [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
> [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
> [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
> [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
> [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
> [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
> [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
> [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
> [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
> [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
> [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
> [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
> [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
> [i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
> [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
> [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
> [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
> [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
> [i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
> [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
> [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
> [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
> [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
> [i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
> [i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
> [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
> [i915#2895]: https://gitlab.freedesktop.org/drm/intel/issues/2895
> [i915#2896]: https://gitlab.freedesktop.org/drm/intel/issues/2896
> [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
> [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
> [i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
> [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
> [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
> [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
> [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
>
>
> Participating hosts (10 -> 10)
> ------------------------------
>
> No changes in participating hosts
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_9581 -> Patchwork_19317
>
> CI-20190529: 20190529
> CI_DRM_9581: 6f3bd6b19cb6cf20481e7c275d04b54ef7539655 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5953: 65c5eea699141e6f942ce0a8fc85db76ce53cd19 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19317: f919d3dd38ae363eb2e89f03660d353e4acf5d9c @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19317/index.html
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids
2021-01-11 19:30 ` [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids Aditya Swarup
@ 2021-01-19 19:40 ` Lucas De Marchi
0 siblings, 0 replies; 8+ messages in thread
From: Lucas De Marchi @ 2021-01-19 19:40 UTC (permalink / raw)
To: Aditya Swarup; +Cc: Jani Nikula, intel-gfx
On Mon, Jan 11, 2021 at 11:30:00AM -0800, Aditya Swarup wrote:
>From: Caz Yokoyama <caz.yokoyama@intel.com>
>
>- Add the initial platform information for Alderlake-S.
>- Specify ppgtt_size value
>- Add dma_mask_size
>- Add ADLS REVIDs
>- HW tracking(Selective Update Tracking Enable) has been
> removed from ADLS. Disable PSR2 till we enable software/
> manual tracking.
>
>v2:
>- Add support for different ADLS SOC steppings to select
> correct GT/DISP stepping based on Bspec 53655 based on
> feedback from Matt Roper.(aswarup)
>
>v3:
>- Make display/gt steppings info generic for reuse with TGL and ADLS.
>- Modify the macros to reuse tgl_revids_get()
>- Add HTI support to adls device info.(mdroper)
>
>v4:
>- Rebase on TGL patch for applying WAs based on stepping info from
> Matt Roper's feedback.(aswarup)
>
>v5:
>- Replace macros with PCI IDs in revid to stepping table.
>
>Bspec: 53597
>Bspec: 53648
>Bspec: 53655
>Bspec: 48028
>Bspec: 53650
>BSpec: 50422
>
>Cc: José Roberto de Souza <jose.souza@intel.com>
>Cc: Matt Roper <matthew.d.roper@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Cc: Imre Deak <imre.deak@intel.com>
>Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
>Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
>---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++
> drivers/gpu/drm/i915/i915_drv.h | 27 ++++++++++++++++++++-
> drivers/gpu/drm/i915/i915_pci.c | 13 ++++++++++
> drivers/gpu/drm/i915/intel_device_info.c | 1 +
> drivers/gpu/drm/i915/intel_device_info.h | 1 +
> include/drm/i915_pciids.h | 11 +++++++++
> 6 files changed, 60 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>index 111d01e2f81e..cb9220925fe7 100644
>--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>@@ -84,6 +84,14 @@ const struct i915_rev_steppings tgl_revid_step_tbl[] = {
> [1] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_D0 },
> };
>
>+const struct i915_rev_steppings adls_revid_step_tbl[] = {
>+ [0x0] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_A0 },
>+ [0x1] = { .gt_stepping = STEP_A0, .disp_stepping = STEP_A2 },
>+ [0x4] = { .gt_stepping = STEP_B0, .disp_stepping = STEP_B0 },
>+ [0x8] = { .gt_stepping = STEP_C0, .disp_stepping = STEP_B0 },
>+ [0xC] = { .gt_stepping = STEP_D0, .disp_stepping = STEP_C0 },
>+};
>+
> static void wa_init_start(struct i915_wa_list *wal, const char *name, const char *engine_name)
> {
> wal->name = name;
>diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>index 11d6e8abde46..8d8a046a7b0c 100644
>--- a/drivers/gpu/drm/i915/i915_drv.h
>+++ b/drivers/gpu/drm/i915/i915_drv.h
>@@ -1417,6 +1417,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
> #define IS_TIGERLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_TIGERLAKE)
> #define IS_ROCKETLAKE(dev_priv) IS_PLATFORM(dev_priv, INTEL_ROCKETLAKE)
> #define IS_DG1(dev_priv) IS_PLATFORM(dev_priv, INTEL_DG1)
>+#define IS_ALDERLAKE_S(dev_priv) IS_PLATFORM(dev_priv, INTEL_ALDERLAKE_S)
> #define IS_HSW_EARLY_SDV(dev_priv) (IS_HASWELL(dev_priv) && \
> (INTEL_DEVID(dev_priv) & 0xFF00) == 0x0C00)
> #define IS_BDW_ULT(dev_priv) \
>@@ -1560,6 +1561,7 @@ extern const struct i915_rev_steppings kbl_revids[];
>
> enum {
> STEP_A0,
>+ STEP_A2,
> STEP_B0,
> STEP_B1,
> STEP_C0,
>@@ -1568,9 +1570,11 @@ enum {
>
> #define TGL_UY_REVID_STEP_TBL_SIZE 4
> #define TGL_REVID_STEP_TBL_SIZE 2
>+#define ADLS_REVID_STEP_TBL_SIZE 13
>
> extern const struct i915_rev_steppings tgl_uy_revid_step_tbl[TGL_UY_REVID_STEP_TBL_SIZE];
> extern const struct i915_rev_steppings tgl_revid_step_tbl[TGL_REVID_STEP_TBL_SIZE];
>+extern const struct i915_rev_steppings adls_revid_step_tbl[ADLS_REVID_STEP_TBL_SIZE];
>
> static inline const struct i915_rev_steppings *
> tgl_stepping_get(struct drm_i915_private *dev_priv)
>@@ -1579,7 +1583,10 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
> u8 size;
> const struct i915_rev_steppings *revid_step_tbl;
>
>- if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
>+ if (IS_ALDERLAKE_S(dev_priv)) {
>+ revid_step_tbl = adls_revid_step_tbl;
>+ size = ARRAY_SIZE(adls_revid_step_tbl);
>+ } else if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
> revid_step_tbl = tgl_uy_revid_step_tbl;
> size = ARRAY_SIZE(tgl_uy_revid_step_tbl);
> } else {
>@@ -1621,6 +1628,24 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
> #define IS_DG1_REVID(p, since, until) \
> (IS_DG1(p) && IS_REVID(p, since, until))
>
>+#define ADLS_REVID_A0 0x0
>+#define ADLS_REVID_A2 0x1
>+#define ADLS_REVID_B0 0x4
>+#define ADLS_REVID_G0 0x8
>+#define ADLS_REVID_C0 0xC /*Same as H0 ADLS SOC stepping*/
>+
>+extern const struct i915_rev_steppings adls_revids[];
this can be removed now, otherwise lgtm
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-19 19:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 19:29 [Intel-gfx] [PATCH 0/2] Use TGL stepping info and add ADLS platform changes Aditya Swarup
2021-01-11 19:29 ` [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs Aditya Swarup
2021-01-11 19:30 ` [Intel-gfx] [PATCH 2/2] drm/i915/adl_s: Add ADL-S platform info and PCI ids Aditya Swarup
2021-01-19 19:40 ` Lucas De Marchi
2021-01-11 19:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use TGL stepping info and add ADLS platform changes (rev2) Patchwork
2021-01-11 20:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-11 22:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-19 18:09 ` Aditya Swarup
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.