* [PATCH] wireless: realtek: Simplify bool comparison
@ 2021-01-12 8:39 YANG LI
2021-01-12 13:25 ` Pkshih
0 siblings, 1 reply; 2+ messages in thread
From: YANG LI @ 2021-01-12 8:39 UTC (permalink / raw)
To: pkshih; +Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel, YANG LI
Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING:
Comparison to bool
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
---
drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
index f9988225..629c032 100644
--- a/drivers/net/wireless/realtek/rtlwifi/ps.c
+++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
@@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void *data,
ie += 3 + noa_len;
}
- if (find_p2p_ie == true) {
+ if (find_p2p_ie) {
if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
- (find_p2p_ps_ie == false))
+ (!find_p2p_ps_ie))
rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wireless: realtek: Simplify bool comparison
2021-01-12 8:39 [PATCH] wireless: realtek: Simplify bool comparison YANG LI
@ 2021-01-12 13:25 ` Pkshih
0 siblings, 0 replies; 2+ messages in thread
From: Pkshih @ 2021-01-12 13:25 UTC (permalink / raw)
To: abaci-bugfix; +Cc: linux-wireless, kvalo, davem, linux-kernel, kuba, netdev
On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING:
> Comparison to bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c
> b/drivers/net/wireless/realtek/rtlwifi/ps.c
> index f9988225..629c032 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/ps.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
> @@ -798,9 +798,9 @@ static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void
> *data,
> ie += 3 + noa_len;
> }
>
> - if (find_p2p_ie == true) {
> + if (find_p2p_ie) {
> if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
> - (find_p2p_ps_ie == false))
> + (!find_p2p_ps_ie))
> rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
> }
> }
The subject prefix should be "rtlwifi:".
And, I think it's ok to merge this patch with another patch
("rtlwifi: rtl8821ae: style: Simplify bool comparison").
Because both of them are trivial fixes and belong to rtlwifi.
---
Ping-Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-12 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-12 8:39 [PATCH] wireless: realtek: Simplify bool comparison YANG LI
2021-01-12 13:25 ` Pkshih
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.