All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together
Date: Fri, 15 Jan 2021 08:22:12 +0000	[thread overview]
Message-ID: <161069893278.19482.3803444937046587332@build.alporthouse.com> (raw)
In-Reply-To: <7a7348c3-b915-69dc-e9c3-8b8f05db8077@intel.com>

Quoting Nautiyal, Ankit K (2021-01-15 07:24:36)
> 
> On 1/13/2021 5:22 PM, Jani Nikula wrote:
> > On Fri, 08 Jan 2021, Jani Nikula <jani.nikula@intel.com> wrote:
> >> On Thu, 24 Dec 2020, "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com> wrote:
> >>> Thanks Chris to catch this.
> >>>
> >>> This definitely should be bitwise Operator, as mentioned by Jani is
> >>> right thing to do.
> >>>
> >>> The PCON which I had access to, had the F/W which was using 303Ch
> >>> (previously proposed) for color conversion capability, instead of what
> >>> is latest mentioned in the spec ie. 83h.
> >>>
> >>> While testing, I had to skip this line of code, and hardcoded to older
> >>> register ie. 303Ch.
> >>>
> >>> I Will get this patch tested and update.
> >> In the mean time, the topic/dp-hdmi-2.1-pcon branch has been merged to
> >> drm-next and backmerged to drm-intel-next. So drm-intel-next is where
> >> the fixes should now land.
> > Ankit, where are we with this? I'm anxious to merge this.
> 
> Jani, I checked the lastest F/W we had got for source control mode, but 
> its still having support in older DPCD 303Ch and has not updated to use 
> DPCD 83h.
> 
> So this patch cannot be directly tested.
> 
> Since this patch is correctly fixing to use bitwise operator, can we go 
> ahead with the merge?

Pushed. One hopes we can find a way to gain coverage for wacky DPCD,
this sounds like the sort of thing we need an emulator such as chamelium
for.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-01-15  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 10:39 Chris Wilson
2020-12-23 10:51 ` Jani Nikula
2020-12-24  6:04   ` Nautiyal, Ankit K
2021-01-08 13:15     ` Jani Nikula
2021-01-13 11:52       ` Jani Nikula
2021-01-15  7:24         ` Nautiyal, Ankit K
2021-01-15  8:22           ` Chris Wilson [this message]
2020-12-23 13:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-12-23 14:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161069893278.19482.3803444937046587332@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --subject='Re: [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.