From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F151FC433DB for ; Fri, 15 Jan 2021 08:22:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D56222583 for ; Fri, 15 Jan 2021 08:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D56222583 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF20E6E188; Fri, 15 Jan 2021 08:22:17 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 248596E188 for ; Fri, 15 Jan 2021 08:22:16 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23602707-1500050 for multiple; Fri, 15 Jan 2021 08:22:14 +0000 MIME-Version: 1.0 In-Reply-To: <7a7348c3-b915-69dc-e9c3-8b8f05db8077@intel.com> References: <20201223103917.14687-1-chris@chris-wilson.co.uk> <87a6u4okvl.fsf@intel.com> <87wnwny3hb.fsf@intel.com> <87zh1drr3e.fsf@intel.com> <7a7348c3-b915-69dc-e9c3-8b8f05db8077@intel.com> From: Chris Wilson To: "Nautiyal, Ankit K" , Jani Nikula , intel-gfx@lists.freedesktop.org Date: Fri, 15 Jan 2021 08:22:12 +0000 Message-ID: <161069893278.19482.3803444937046587332@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Nautiyal, Ankit K (2021-01-15 07:24:36) > > On 1/13/2021 5:22 PM, Jani Nikula wrote: > > On Fri, 08 Jan 2021, Jani Nikula wrote: > >> On Thu, 24 Dec 2020, "Nautiyal, Ankit K" wrote: > >>> Thanks Chris to catch this. > >>> > >>> This definitely should be bitwise Operator, as mentioned by Jani is > >>> right thing to do. > >>> > >>> The PCON which I had access to, had the F/W which was using 303Ch > >>> (previously proposed) for color conversion capability, instead of what > >>> is latest mentioned in the spec ie. 83h. > >>> > >>> While testing, I had to skip this line of code, and hardcoded to older > >>> register ie. 303Ch. > >>> > >>> I Will get this patch tested and update. > >> In the mean time, the topic/dp-hdmi-2.1-pcon branch has been merged to > >> drm-next and backmerged to drm-intel-next. So drm-intel-next is where > >> the fixes should now land. > > Ankit, where are we with this? I'm anxious to merge this. > > Jani, I checked the lastest F/W we had got for source control mode, but > its still having support in older DPCD 303Ch and has not updated to use > DPCD 83h. > > So this patch cannot be directly tested. > > Since this patch is correctly fixing to use bitwise operator, can we go > ahead with the merge? Pushed. One hopes we can find a way to gain coverage for wacky DPCD, this sounds like the sort of thing we need an emulator such as chamelium for. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx