All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Xiong Zhang <xiong.y.zhang@intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk
Subject: Re: [Intel-gfx] [PATCH v4] drm/i915: Try to guess PCH type even without ISA bridge
Date: Fri, 15 Jan 2021 13:01:49 +0200	[thread overview]
Message-ID: <161070850877.79726.12218329205250979912@jlahtine-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <878s8upj75.fsf@intel.com>

Quoting Jani Nikula (2021-01-15 12:50:54)
> On Thu, 14 Jan 2021, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > On 2021.01.14 08:58:19 +0800, Xiong Zhang wrote:
> >> From: Zhenyu Wang <zhenyuw@linux.intel.com>
> >> 
> >> Some vmm like hyperv and crosvm don't supply any ISA bridge to their guest,
> >> when igd passthrough is equipped on these vmm, guest i915 display may
> >> couldn't work as guest i915 detects PCH_NONE pch type.
> >> 
> >> When i915 runs as guest, this patch guess pch type through gpu type even
> >> without ISA bridge.
> >> 
> >> v2: Fix CI warning
> >> v3: Add HAS_DISPLAY()= true condition beforce guessing virt pch, then
> >>     refactori.
> >> v4: Fix CI warning
> >> 
> >> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> >> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/i915_drv.h  |  7 +++++-
> >>  drivers/gpu/drm/i915/intel_pch.c | 39 ++++++++++++++++++--------------
> >>  2 files changed, 28 insertions(+), 18 deletions(-)
> >>
> >
> > Good to me, thanks! I think this should change author to you. :)
> >
> > Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> 
> Pushed to drm-intel-next, thanks for the patch and review. I ended up
> retaining Zhenyu's authorship, and added
> 
> Co-developed-by: Xiong Zhang <xiong.y.zhang@intel.com>

This only works for the majority of SKUs which happen to use the PCH
that is most common. I NAKed very similar patch some years back asking
for a reliable means to detect the PCH type instead.

Has there been any attempt to introduce such mechanism?

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-01-15 11:01 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14  7:01 [Intel-gfx] [PATCH] drm/i915: Try to guess PCH type even without ISA bridge Xiong Zhang
2020-12-14  7:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-12-14  7:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-18  9:05   ` [Intel-gfx] [PATCH v2] " Xiong Zhang
2020-12-22  5:15     ` Zhenyu Wang
2020-12-23  8:39       ` Zhang, Xiong Y
2020-12-23  8:59     ` Jani Nikula
2020-12-24  2:42       ` Zhang, Xiong Y
2020-12-24  2:54       ` Zhang, Xiong Y
2020-12-24  4:49         ` Zhenyu Wang
2021-01-13  4:53       ` [Intel-gfx] [PATCH v3] " Xiong Zhang
2021-01-14  0:58       ` [Intel-gfx] [PATCH v4] " Xiong Zhang
2021-01-14  5:14         ` Zhenyu Wang
2021-01-15 10:50           ` Jani Nikula
2021-01-15 11:01             ` Joonas Lahtinen [this message]
2021-01-18  6:04               ` Zhenyu Wang
2021-01-18  9:56                 ` Jani Nikula
2020-12-18 10:16   ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Try to guess PCH type even without ISA bridge (rev2) Patchwork
2020-12-18 11:27   ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-13  5:23   ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Try to guess PCH type even without ISA bridge (rev3) Patchwork
2021-01-13  5:52   ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-01-14  2:01   ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Try to guess PCH type even without ISA bridge (rev4) Patchwork
2021-01-14  4:59   ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-14  7:22 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Try to guess PCH type even without ISA bridge Patchwork
2020-12-14  7:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-14  9:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-14 10:10 ` [Intel-gfx] [PATCH] " kernel test robot
2020-12-14 10:10   ` kernel test robot
2020-12-14 10:10 ` [Intel-gfx] [RFC PATCH] drm/i915: intel_detect_pch_virt() can be static kernel test robot
2020-12-14 10:10   ` kernel test robot
2020-12-14 12:50 ` [Intel-gfx] [PATCH] drm/i915: Try to guess PCH type even without ISA bridge kernel test robot
2020-12-14 12:50   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161070850877.79726.12218329205250979912@jlahtine-mobl.ger.corp.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=xiong.y.zhang@intel.com \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.