All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daehwan Jung <dh10.jung@samsung.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Daehwan Jung <dh10.jung@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: dwc3: gadget: skip pullup and set_speed after suspend
Date: Wed, 20 Jan 2021 12:39:28 +0900	[thread overview]
Message-ID: <1611113968-102424-1-git-send-email-dh10.jung@samsung.com> (raw)
In-Reply-To: CGME20210120035123epcas2p2048f6d9896bd21f19d939a56fe0b6610@epcas2p2.samsung.com

Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after
entering suspend. That's why it needs to check whether suspend

1. dwc3 sends disconnect uevent and turn off. (suspend)
2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node)
3. It causes unexpected behavior like ITMON error.

Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
---
 drivers/usb/dwc3/gadget.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index ee44321..d7d4202 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2093,6 +2093,9 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on)
 	unsigned long		flags;
 	int			ret;
 
+	if (pm_runtime_suspended(dwc->dev))
+		return 0;
+
 	is_on = !!is_on;
 
 	/*
@@ -2403,6 +2406,9 @@ static void dwc3_gadget_set_speed(struct usb_gadget *g,
 	unsigned long		flags;
 	u32			reg;
 
+	if (pm_runtime_suspended(dwc->dev))
+		return;
+
 	spin_lock_irqsave(&dwc->lock, flags);
 	reg = dwc3_readl(dwc->regs, DWC3_DCFG);
 	reg &= ~(DWC3_DCFG_SPEED_MASK);
-- 
2.7.4


       reply	other threads:[~2021-01-20  3:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210120035123epcas2p2048f6d9896bd21f19d939a56fe0b6610@epcas2p2.samsung.com>
2021-01-20  3:39 ` Daehwan Jung [this message]
2021-01-21  1:00   ` usb: dwc3: gadget: skip pullup and set_speed after suspend Thinh Nguyen
2021-01-21  6:49     ` Jung Daehwan
2021-01-21  7:44       ` Wesley Cheng
2021-01-21  8:13         ` Jung Daehwan
2021-01-22  3:32           ` Wesley Cheng
2021-01-21  7:11     ` Jung Daehwan
2021-01-24 15:31   ` Felipe Balbi
     [not found]     ` <20210201054539.GA188887@ubuntu>
2021-02-01  6:06       ` Jung Daehwan
     [not found] <CGME20210122065248epcas2p19a972d3a385b91d6e05a16f2ef7b0dd6@epcas2p1.samsung.com>
     [not found] ` <20210122064125.GA121941@ubuntu>
2021-01-22  7:15   ` Jung Daehwan
2021-01-27  3:34     ` Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611113968-102424-1-git-send-email-dh10.jung@samsung.com \
    --to=dh10.jung@samsung.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.