All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pengcheng Yang <yangpc@wangsu.com>
To: ncardwell@google.com, ycheng@google.com
Cc: netdev@vger.kernel.org, yangpc@wangsu.com
Subject: tcp: rearm RTO timer does not comply with RFC6298
Date: Wed, 20 Jan 2021 18:49:54 +0800	[thread overview]
Message-ID: <1611139794-11254-1-git-send-email-yangpc@wangsu.com> (raw)

hi,

I have a doubt about tcp_rearm_rto().

Early TCP always rearm the RTO timer to NOW+RTO when it receives
an ACK that acknowledges new data.

Referring to RFC6298 SECTION 5.3: "When an ACK is received that
acknowledges new data, restart the retransmission timer so that
it will expire after RTO seconds (for the current value of RTO)."

After ER and TLP, we rearm the RTO timer to *tstamp_of_head+RTO*
when switching from ER/TLP/RACK to original RTO in tcp_rearm_rto(),
in this case the RTO timer is triggered earlier than described in 
RFC6298, otherwise the same.

Is this planned? Or can we always rearm the RTO timer to 
tstamp_of_head+RTO?

Thanks.


             reply	other threads:[~2021-01-20 11:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 10:49 Pengcheng Yang [this message]
2021-01-20 14:59 ` tcp: rearm RTO timer does not comply with RFC6298 Neal Cardwell
2021-01-20 18:58   ` Yuchung Cheng
2021-01-21 13:48     ` Pengcheng Yang
2021-01-21 15:50       ` Neal Cardwell
2021-01-22 10:01         ` Pengcheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611139794-11254-1-git-send-email-yangpc@wangsu.com \
    --to=yangpc@wangsu.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.