All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Dave Airlie" <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/i915: refactor ddi translations into a separate file
Date: Thu, 21 Jan 2021 04:57:59 -0000	[thread overview]
Message-ID: <161120507948.14016.5327516027267451861@emeril.freedesktop.org> (raw)
In-Reply-To: <20210121042532.9057-1-airlied@gmail.com>

== Series Details ==

Series: series starting with [1/8] drm/i915: refactor ddi translations into a separate file
URL   : https://patchwork.freedesktop.org/series/86110/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8977ebfa68d5 drm/i915: refactor ddi translations into a separate file
-:1523: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1523: 
new file mode 100644

-:1791: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1791: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:264:
+
+

-:2249: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2249: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:722:
+		return bdw_ddi_translations_edp;
+	} else {

-:2266: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2266: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:739:
+		return skl_u_ddi_translations_dp;
+	} else {

-:2287: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2287: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:760:
+		return kbl_u_ddi_translations_dp;
+	} else {

-:2311: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2311: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:784:
+			return skl_u_ddi_translations_edp;
+		} else {

-:2334: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2334: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:807:
+		return skl_y_ddi_translations_hdmi;
+	} else {

-:2489: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2489: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:962:
+		return cnl_ddi_translations_hdmi_1_05V;
+	} else {

-:2511: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2511: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:984:
+		return cnl_ddi_translations_dp_1_05V;
+	} else {

-:2534: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2534: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1007:
+			return cnl_ddi_translations_edp_1_05V;
+		} else {

-:2628: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2628: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1101:
+		return icl_mg_phy_ddi_translations_hbr2_hbr3;
+	} else {

-:2720: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2720: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1193:
+			return jsl_combo_phy_ddi_translations_edp_hbr2;
+		} else {

-:2762: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2762: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1235:
+			return tgl_uy_combo_phy_ddi_translations_dp_hbr2;
+		} else {

-:2824: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#2824: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1297:
+		return tgl_dkl_phy_dp_ddi_trans_hbr2;
+	} else {

total: 0 errors, 13 warnings, 1 checks, 2944 lines checked
4208556348c8 drm/i915: migrate hsw fdi code to new file.
-:293: WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#293: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:583:
+		       FDI_RX_PWRDN_LANE1_VAL(2) | FDI_RX_PWRDN_LANE0_VAL(2) | FDI_RX_TP1_TO_TP2_48 | FDI_RX_FDI_DELAY_90);

-:301: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#301: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:591:
+	udelay(220);

-:313: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#313: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:603:
+	 * testing each value twice. */

-:325: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#325: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:615:
+		 * port reversal bit */

-:327: WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#327: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:617:
+			       DDI_BUF_CTL_ENABLE | ((crtc_state->fdi_lanes - 1) << 1) | DDI_BUF_TRANS_SELECT(i / 2));

-:330: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#330: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:620:
+		udelay(600);

-:341: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#341: FILE: drivers/gpu/drm/i915/display/intel_fdi.c:631:
+		udelay(30);

total: 0 errors, 4 warnings, 3 checks, 376 lines checked
630ae9723fa6 drm/i915: migrate skl planes code new file (v4)
-:1292: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1292: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1892:
+
+}

-:2828: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#2828: 
new file mode 100644

-:3301: CHECK:LINE_SPACING: Please don't use multiple blank lines
#3301: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:469:
+
+

-:3362: WARNING:TYPO_SPELLING: 'Limted' may be misspelled - perhaps 'Limited'?
#3362: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:530:
+		 * BT.601 Limted range YCbCr -> full range RGB
 		          ^^^^^^

-:3805: CHECK:LINE_SPACING: Please don't use multiple blank lines
#3805: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:973:
+
+

-:3908: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#3908: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:1076:
+				  (plane_state->color_plane[1].y << 16) | plane_state->color_plane[1].x);

-:4214: CHECK:LINE_SPACING: Please don't use multiple blank lines
#4214: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:1382:
+
+

-:4597: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#4597: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:1765:
+		return skl_planar_formats;
+	} else {

-:4610: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#4610: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:1778:
+		return glk_planar_formats;
+	} else {

-:4626: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#4626: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:1794:
+		return icl_sdr_y_plane_formats;
+	} else {

-:4968: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#4968: FILE: drivers/gpu/drm/i915/display/skl_universal_plane.c:2136:
+		drm_plane_create_scaling_filter_property(&plane->base,
+						BIT(DRM_SCALING_FILTER_DEFAULT) |

total: 0 errors, 6 warnings, 5 checks, 5050 lines checked
1f21c6b8bcc4 drm/i915: move pipe update code into crtc.
-:236: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#236: FILE: drivers/gpu/drm/i915/display/intel_crtc.c:533:
+	 * while ... */

total: 0 errors, 1 warnings, 0 checks, 483 lines checked
ceac7e29dced drm/i915: split fb scalable checks into g4x and skl versions
6de2a1874b9d drm/i915: move is_ccs_modifier to an inline
28a3e3bd2878 drm/i915: migrate pll enable/disable code to intel_dpll.[ch]
-:639: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#639: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1399:
+	udelay(150);

-:657: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#657: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1417:
+		udelay(150); /* wait for warmup */

-:698: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#698: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1458:
+	udelay(150);

-:723: CHECK:LINE_SPACING: Please don't use multiple blank lines
#723: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1483:
+
+

-:807: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#807: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1567:
+		       pipe_config->dpll_hw_state.dpll & ~(DPLL_VCO_ENABLE | DPLL_EXT_BUFFER_ENABLE_VLV));

-:860: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#860: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1620:
+		vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW10(pipe),
+				 0x009f0003);

-:863: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#863: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1623:
+		vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW10(pipe),
+				 0x00d0000f);

-:869: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#869: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1629:
+			vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW5(pipe),
+					 0x0df40000);

-:872: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#872: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1632:
+			vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW5(pipe),
+					 0x0df70000);

-:877: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#877: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1637:
+			vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW5(pipe),
+					 0x0df70000);

-:880: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#880: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1640:
+			vlv_dpio_write(dev_priv, pipe, VLV_PLL_DW5(pipe),
+					 0x0df40000);

-:928: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#928: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1688:
+	vlv_dpio_write(dev_priv, pipe, CHV_CMN_DW13(port),
+			5 << DPIO_CHV_S1_DIV_SHIFT |

-:938: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#938: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1698:
+	vlv_dpio_write(dev_priv, pipe, CHV_PLL_DW1(port),
+			DPIO_CHV_M1_DIV_BY_2 |

-:993: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#993: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1753:
+	vlv_dpio_write(dev_priv, pipe, CHV_CMN_DW14(port),
+			vlv_dpio_read(dev_priv, pipe, CHV_CMN_DW14(port)) |

-:1097: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1097: FILE: drivers/gpu/drm/i915/display/intel_dpll.c:1857:
+
+

total: 0 errors, 1 warnings, 14 checks, 1110 lines checked
26c4525e26a4 drm/i915: migrate i9xx plane get config


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-21  4:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  4:25 [Intel-gfx] [rfc v8] remaining intel_display.c refactors Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 1/8] drm/i915: refactor ddi translations into a separate file Dave Airlie
2021-01-21 12:01   ` Jani Nikula
2021-01-21 12:03     ` Jani Nikula
2021-01-21  4:25 ` [Intel-gfx] [PATCH 2/8] drm/i915: migrate hsw fdi code to new file Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 3/8] drm/i915: migrate skl planes code new file (v4) Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 4/8] drm/i915: move pipe update code into crtc Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 5/8] drm/i915: split fb scalable checks into g4x and skl versions Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 6/8] drm/i915: move is_ccs_modifier to an inline Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 7/8] drm/i915: migrate pll enable/disable code to intel_dpll.[ch] Dave Airlie
2021-01-21  4:25 ` [Intel-gfx] [PATCH 8/8] drm/i915: migrate i9xx plane get config Dave Airlie
2021-01-21  4:57 ` Patchwork [this message]
2021-01-21  4:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/8] drm/i915: refactor ddi translations into a separate file Patchwork
2021-01-21  5:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-21  6:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161120507948.14016.5327516027267451861@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=airlied@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.