From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19CE9C433E0 for ; Sun, 24 Jan 2021 04:28:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E3D822C9F for ; Sun, 24 Jan 2021 04:27:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E3D822C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3X0I-00005Y-Rn for qemu-devel@archiver.kernel.org; Sat, 23 Jan 2021 23:27:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Wyl-00071B-1m for qemu-devel@nongnu.org; Sat, 23 Jan 2021 23:26:23 -0500 Received: from indium.canonical.com ([91.189.90.7]:42834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3Wyi-0005gC-UF for qemu-devel@nongnu.org; Sat, 23 Jan 2021 23:26:22 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1l3Wye-0008JW-BP for ; Sun, 24 Jan 2021 04:26:16 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 58A862E81C8 for ; Sun, 24 Jan 2021 04:26:11 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Sun, 24 Jan 2021 04:17:29 -0000 From: Launchpad Bug Tracker <1777786@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Expired; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: janitor th-huth wqlxx X-Launchpad-Bug-Reporter: Qiang Wang (wqlxx) X-Launchpad-Bug-Modifier: Launchpad Janitor (janitor) References: <152947832268.7374.8550233006013647387.malonedeb@wampee.canonical.com> Message-Id: <161146184943.22004.10010286595190894218.malone@loganberry.canonical.com> Subject: [Bug 1777786] Re: virtio-gpu-3d.c: change virtio_gpu_fence_poll timer scale X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="2d1d5e352f0d063d660df2300e31f66bed027fa5"; Instance="production" X-Launchpad-Hash: 44f3effefdcd69c6500d4b3391c2c264350156f0 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1777786 <1777786@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" [Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete =3D> Expired -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1777786 Title: virtio-gpu-3d.c: change virtio_gpu_fence_poll timer scale Status in QEMU: Expired Bug description: We use virtio-gpu to accelerate Unigine Heaven Benchmark in VM. But we ge= t only 5 FPS when we use AMD RX460 in our host. We found that guest os spent a lot of time in waiting for the return of g= lMapBufferRange/glUnmapBuffer commad. We suspected the host GPU was waiting= for fence. So we finally change the timer of fence_poll. Afer change timer= from ms to us=EF=BC=8C Benchmark result raise up to 22 FPS. From a4003af5c4fe92d55353f42767d0c45de95bb78f Mon Sep 17 00:00:00 2001 From: chen wei Date: Fri, 8 Jun 2018 17:34:45 +0800 Subject: [PATCH] virtio-gpu:improve 3d performance greatly opengl function need fence support.when CPU execute opengl function, it= need wait fence for synchronize GPU. so qemu must deal with fence timely as possible. but now the expire time = of the timer to deal with fence is 10 ms. I think it is too long for opengl. So i will change it to 20 ns. Before change, when i play Unigine_Heaven 3d game with virglrenderer, t= he fps is 3. atfer change the fps up to 23. Signed-off-by: chen wei Signed-off-by: wang qiang --- hw/display/virtio-gpu-3d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 3558f38..c0a5d21 100644 --- a/hw/display/virtio-gpu-3d.c +++ b/hw/display/virtio-gpu-3d.c @@ -582,7 +582,7 @@ static void virtio_gpu_fence_poll(void *opaque) virgl_renderer_poll(); virtio_gpu_process_cmdq(g); if (!QTAILQ_EMPTY(&g->cmdq) || !QTAILQ_EMPTY(&g->fenceq)) { - timer_mod(g->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) += 10); + timer_mod(g->fence_poll, qemu_clock_get_us(QEMU_CLOCK_VIRTUAL) += 20); } } = @@ -629,7 +629,7 @@ int virtio_gpu_virgl_init(VirtIOGPU *g) return ret; } = - g->fence_poll =3D timer_new_ms(QEMU_CLOCK_VIRTUAL, + g->fence_poll =3D timer_new_us(QEMU_CLOCK_VIRTUAL, virtio_gpu_fence_poll, g); = if (virtio_gpu_stats_enabled(g->conf)) { -- = 2.7.4 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1777786/+subscriptions