From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC00C433DB for ; Tue, 26 Jan 2021 11:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 500952310E for ; Tue, 26 Jan 2021 11:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405184AbhAZLf0 (ORCPT ); Tue, 26 Jan 2021 06:35:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391841AbhAZKR0 (ORCPT ); Tue, 26 Jan 2021 05:17:26 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FE7C061756 for ; Tue, 26 Jan 2021 02:16:46 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id my11so1131375pjb.1 for ; Tue, 26 Jan 2021 02:16:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=sR1f6/9qxbOzaGUBvKshvPIEd27XjEPY6YY4xmBmtPw=; b=hByZTPn+kC7e4UW2FPK/AIyIGf9W594vufpomYmL3zBVkQjdrkkQGpHS3xs7297uF8 VOZuXvTyW9sl55CPyhKIIMU+riCrnYcmolSmzO7a2ks0VOAD5PMXwyn75ZqZWJt9qd0f fgvVhIgSOjxP+3wo55hLn6DBp6ZeyaybNzl7PQFEyHP/ZCCm93jKAiAbAkNLYGghQIag TqE5huzf5DEhD5ui8CJ2NJPiTNuT1oUOjfl4UoGUE2sZnIoHd8lmUCLKDEPX+0+H/MCW Qi7nLK7V9o/vLa4YcxC1L1QBFwSMvu3lrbd/9irKOurZORXuC/OvuF5VuOJIx4D6xK8Q DINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=sR1f6/9qxbOzaGUBvKshvPIEd27XjEPY6YY4xmBmtPw=; b=aJQnU/43i21QoPInYRSEl2dFEUMG/HuLDSRZc55FygTzGIaHtmYbizPazt3NAjB7dW 5mvLeAKya6+05wBWyxOnND8lwJbmLviQEi00XlmbVHlajGgfnb2ZU2zSCDKH7M55maIT 3vK5ZMDcL3kJ6eQskPpQ8w3/JxgCckHZcvBgdAVvg1+ymZhEnFlT2t6jw81nrPXU3ODf dP3rlWfrgbIpd/CPoVU6Ao+iSNkFxqoKZiCZ1RfFE3lLsW+2+Tf67YRzlQ2vRECOHPtC XbXxWm2Z4QEqbbtyh0jUqu0FdxsPvH3ieWQjRE7v8LLdvuhsb2zShtvgekfsGV63E/rH MivQ== X-Gm-Message-State: AOAM5332CsFzwgKyBn8Uvjg6NmItelvxwHLVQ+sLFKfrwaMVX1M/imUf e+4ECkVcYka3JWdlaULPmOkmjDGlzAY= X-Google-Smtp-Source: ABdhPJwg+JTjblgrrhG9vFEfUG1cblX6qFxLOGQzgNLdQMrgRvDnqGJyI0cCwhxPL54X1bAz2FR0zA== X-Received: by 2002:a17:902:9a4a:b029:dc:435c:70ad with SMTP id x10-20020a1709029a4ab02900dc435c70admr5154709plv.77.1611656206142; Tue, 26 Jan 2021 02:16:46 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id d2sm1840594pjd.29.2021.01.26.02.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 02:16:45 -0800 (PST) Date: Tue, 26 Jan 2021 20:16:39 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 20/23] powerpc/syscall: Do not check unsupported scv vector on PPC32 To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , msuchanek@suse.de, Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: In-Reply-To: MIME-Version: 1.0 Message-Id: <1611656145.efq1cxcpts.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Only PPC64 has scv. No need to check the 0x7ff0 trap on PPC32. >=20 > And ignore the scv parameter in syscall_exit_prepare (Save 14 cycles > 346 =3D> 332 cycles) >=20 > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_32.S | 1 - > arch/powerpc/kernel/syscall.c | 7 +++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_3= 2.S > index 9922a04650f7..6ae9c7bcb06c 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -343,7 +343,6 @@ transfer_to_syscall: > =20 > ret_from_syscall: > addi r4,r1,STACK_FRAME_OVERHEAD > - li r5,0 > bl syscall_exit_prepare > #if defined(CONFIG_4xx) || defined(CONFIG_BOOKE) > /* If the process has its own DBCR0 value, load it up. The internal > diff --git a/arch/powerpc/kernel/syscall.c b/arch/powerpc/kernel/syscall.= c > index 476909b11051..30f8a397a522 100644 > --- a/arch/powerpc/kernel/syscall.c > +++ b/arch/powerpc/kernel/syscall.c > @@ -86,7 +86,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > local_irq_enable(); > =20 > if (unlikely(current_thread_info()->flags & _TIF_SYSCALL_DOTRACE)) { > - if (unlikely(regs->trap =3D=3D 0x7ff0)) { > + if (IS_ENABLED(CONFIG_PPC64) && unlikely(regs->trap =3D=3D 0x7ff0)) { > /* Unsupported scv vector */ > _exception(SIGILL, regs, ILL_ILLOPC, regs->nip); > return regs->gpr[3]; > @@ -109,7 +109,7 @@ notrace long system_call_exception(long r3, long r4, = long r5, > r8 =3D regs->gpr[8]; > =20 > } else if (unlikely(r0 >=3D NR_syscalls)) { > - if (unlikely(regs->trap =3D=3D 0x7ff0)) { > + if (IS_ENABLED(CONFIG_PPC64) && unlikely(regs->trap =3D=3D 0x7ff0)) { Perhaps this could be hidden behind a function like trap_is_scv()? trap_is_unsupported_scv() ? Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2BFC433E6 for ; Tue, 26 Jan 2021 10:19:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2640D22B37 for ; Tue, 26 Jan 2021 10:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2640D22B37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DQ2l83r5VzDqyP for ; Tue, 26 Jan 2021 21:19:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=hByZTPn+; dkim-atps=neutral Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DQ2hd6DthzDr0L for ; Tue, 26 Jan 2021 21:16:49 +1100 (AEDT) Received: by mail-pl1-x62b.google.com with SMTP id 31so9504500plb.10 for ; Tue, 26 Jan 2021 02:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=sR1f6/9qxbOzaGUBvKshvPIEd27XjEPY6YY4xmBmtPw=; b=hByZTPn+kC7e4UW2FPK/AIyIGf9W594vufpomYmL3zBVkQjdrkkQGpHS3xs7297uF8 VOZuXvTyW9sl55CPyhKIIMU+riCrnYcmolSmzO7a2ks0VOAD5PMXwyn75ZqZWJt9qd0f fgvVhIgSOjxP+3wo55hLn6DBp6ZeyaybNzl7PQFEyHP/ZCCm93jKAiAbAkNLYGghQIag TqE5huzf5DEhD5ui8CJ2NJPiTNuT1oUOjfl4UoGUE2sZnIoHd8lmUCLKDEPX+0+H/MCW Qi7nLK7V9o/vLa4YcxC1L1QBFwSMvu3lrbd/9irKOurZORXuC/OvuF5VuOJIx4D6xK8Q DINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=sR1f6/9qxbOzaGUBvKshvPIEd27XjEPY6YY4xmBmtPw=; b=oUU/2fINQI5OV+3Cim1XITwY3X2/vm2EYmu0jqGYaqyiTNMyBCZ9IO2aaZu1RNALM+ GccGJN+9QNpThbL9mWGacG+uQcUNsF28pdGE3MOJh0Ke12EJaQ3d+1l0xOE8RlbmNt5D Ov4psCzUdKKG8KR2MRu10016FTJMMozVr6NOSRBkrxDEVQfGTw762Pv4JUCFUVere+Av AipwLjK8sCvaIAF7ggpDJ6fe8z13fJGhTp40qLeruCu/1qwcMKtoa9ithrwWb7wP9ozi mpuVAWdlkYZRwC1Cak1wJhbDwS1prQRUph9dhZq9s3MUOwOQ2QMINmUYXP3a8b8upPd7 SD7A== X-Gm-Message-State: AOAM530/9HIvQHVhir0vf5dQY0o5v/IYdPYA/gsrjfiP/ydj18x5AvFZ al94OAEkSJQVQz3brnXFUmY= X-Google-Smtp-Source: ABdhPJwg+JTjblgrrhG9vFEfUG1cblX6qFxLOGQzgNLdQMrgRvDnqGJyI0cCwhxPL54X1bAz2FR0zA== X-Received: by 2002:a17:902:9a4a:b029:dc:435c:70ad with SMTP id x10-20020a1709029a4ab02900dc435c70admr5154709plv.77.1611656206142; Tue, 26 Jan 2021 02:16:46 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id d2sm1840594pjd.29.2021.01.26.02.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 02:16:45 -0800 (PST) Date: Tue, 26 Jan 2021 20:16:39 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 20/23] powerpc/syscall: Do not check unsupported scv vector on PPC32 To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , msuchanek@suse.de, Paul Mackerras References: In-Reply-To: MIME-Version: 1.0 Message-Id: <1611656145.efq1cxcpts.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Only PPC64 has scv. No need to check the 0x7ff0 trap on PPC32. >=20 > And ignore the scv parameter in syscall_exit_prepare (Save 14 cycles > 346 =3D> 332 cycles) >=20 > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_32.S | 1 - > arch/powerpc/kernel/syscall.c | 7 +++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_3= 2.S > index 9922a04650f7..6ae9c7bcb06c 100644 > --- a/arch/powerpc/kernel/entry_32.S > +++ b/arch/powerpc/kernel/entry_32.S > @@ -343,7 +343,6 @@ transfer_to_syscall: > =20 > ret_from_syscall: > addi r4,r1,STACK_FRAME_OVERHEAD > - li r5,0 > bl syscall_exit_prepare > #if defined(CONFIG_4xx) || defined(CONFIG_BOOKE) > /* If the process has its own DBCR0 value, load it up. The internal > diff --git a/arch/powerpc/kernel/syscall.c b/arch/powerpc/kernel/syscall.= c > index 476909b11051..30f8a397a522 100644 > --- a/arch/powerpc/kernel/syscall.c > +++ b/arch/powerpc/kernel/syscall.c > @@ -86,7 +86,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > local_irq_enable(); > =20 > if (unlikely(current_thread_info()->flags & _TIF_SYSCALL_DOTRACE)) { > - if (unlikely(regs->trap =3D=3D 0x7ff0)) { > + if (IS_ENABLED(CONFIG_PPC64) && unlikely(regs->trap =3D=3D 0x7ff0)) { > /* Unsupported scv vector */ > _exception(SIGILL, regs, ILL_ILLOPC, regs->nip); > return regs->gpr[3]; > @@ -109,7 +109,7 @@ notrace long system_call_exception(long r3, long r4, = long r5, > r8 =3D regs->gpr[8]; > =20 > } else if (unlikely(r0 >=3D NR_syscalls)) { > - if (unlikely(regs->trap =3D=3D 0x7ff0)) { > + if (IS_ENABLED(CONFIG_PPC64) && unlikely(regs->trap =3D=3D 0x7ff0)) { Perhaps this could be hidden behind a function like trap_is_scv()? trap_is_unsupported_scv() ? Thanks, Nick