From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6DAC433E6 for ; Tue, 26 Jan 2021 12:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D43B52311D for ; Tue, 26 Jan 2021 12:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387448AbhAZMiB (ORCPT ); Tue, 26 Jan 2021 07:38:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391934AbhAZKT2 (ORCPT ); Tue, 26 Jan 2021 05:19:28 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB82CC061573 for ; Tue, 26 Jan 2021 02:18:48 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id n10so11178021pgl.10 for ; Tue, 26 Jan 2021 02:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=bY0+m4945nWumwbU1TQ36SLdrna7sXMlUaFEMn9azHM=; b=otcVSaDkyuN1IFfRVEUqE8c2bayHgbWl4fMLIM9/NfgujwypOXpNCcVfJqbv3XPmZ3 m3T5caX+X2PFVmGS2PuAM3DSxmuqsEC/qtdlFRNyvNLgA2erWkj02+d+0ZXfH7NVvlXC vqRzjdUDLgbJtG4ELaHWDai/2D7gTuh3zm1QMuO71egNZ4GSOIWdHOcUpN6/oFiPSJMF A+60AwwtKXpNmPyHLosablQqAjRgC2NEXvZdVafBbW1JrK1peRmOMIj4xDbwwbTrEpz2 w1GPLMXda9qvRv6Ra5qKFx5sNXiTBCmfFdzV36XhdCsAPC+RV/6TVAJqsyJCq9+mmAvj cawQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=bY0+m4945nWumwbU1TQ36SLdrna7sXMlUaFEMn9azHM=; b=YjHZ5k9dChd4gEU5sBy/IkuIcL0zWcJZ4fDqCxxfON1L0oca4xyhj33vCBo9v48yVt T6SEIYtSprOVsjYsbzPgP1oDQd66B/71Nrxi460BSh+sMKhZKVx7730DxLQOlyHy9FM/ 8IrAwIXfH6yrthAAP+0yYIxCiGSF43p/iqiRd52LxwxcwSDtRgIc1R0uHf1J3RVMAbTq m2/D4lXICpaGbF7fF+rpLI8dq+clITuWHoCkgg+j+wb614PNGUoXbHZPDjbxhrAzUVGx edVf7HqRvCt79/uF4SkLxZoJGpyKd+xeGB4Tpr0lnN9TOi2jJwoV3jdAiZlC7L9T7b/4 JUAw== X-Gm-Message-State: AOAM531tiEwICLo+ZK2cmfCVmTNJBlJcVmgrrGB6hOBxkjLdIvoU6Oqs yNjFDIXAz4qJQeB1pBIoXsE= X-Google-Smtp-Source: ABdhPJxaG61OapcH+qCGgTpLGcWf8cvXcfM4YrAfMSY5mvjCygYR8PMQZXdWfG/BQof6ssxK0ITAqw== X-Received: by 2002:a62:144c:0:b029:1c0:d62d:e16e with SMTP id 73-20020a62144c0000b02901c0d62de16emr4542328pfu.25.1611656328201; Tue, 26 Jan 2021 02:18:48 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id 77sm13765743pfz.100.2021.01.26.02.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 02:18:47 -0800 (PST) Date: Tue, 26 Jan 2021 20:18:42 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 14/23] powerpc/syscall: Save r3 in regs->orig_r3 To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , msuchanek@suse.de, Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <5d375bea8f519924e110842f6b0d05e83cd04470.1611585031.git.christophe.leroy@csgroup.eu> In-Reply-To: <5d375bea8f519924e110842f6b0d05e83cd04470.1611585031.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1611656262.d3l09kg9o2.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Save r3 in regs->orig_r3 in system_call_exception() >=20 > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_64.S | 1 - > arch/powerpc/kernel/syscall.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_6= 4.S > index aa1af139d947..a562a4240aa6 100644 > --- a/arch/powerpc/kernel/entry_64.S > +++ b/arch/powerpc/kernel/entry_64.S > @@ -278,7 +278,6 @@ END_BTB_FLUSH_SECTION > std r10,_LINK(r1) > std r11,_TRAP(r1) > std r12,_CCR(r1) > - std r3,ORIG_GPR3(r1) > addi r10,r1,STACK_FRAME_OVERHEAD > ld r11,exception_marker@toc(r2) > std r11,-16(r10) /* "regshere" marker */ This misses system_call_vectored. Thanks, Nick > diff --git a/arch/powerpc/kernel/syscall.c b/arch/powerpc/kernel/syscall.= c > index cb415170b8f2..b66cfcbcb755 100644 > --- a/arch/powerpc/kernel/syscall.c > +++ b/arch/powerpc/kernel/syscall.c > @@ -29,6 +29,8 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > { > syscall_fn f; > =20 > + regs->orig_gpr3 =3D r3; > + > if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG)) > BUG_ON(irq_soft_mask_return() !=3D IRQS_ALL_DISABLED); > =20 > --=20 > 2.25.0 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCD2C433E0 for ; Tue, 26 Jan 2021 10:21:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE9BD22B37 for ; Tue, 26 Jan 2021 10:21:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE9BD22B37 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DQ2nf0K5wzDqpC for ; Tue, 26 Jan 2021 21:21:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::529; helo=mail-pg1-x529.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=otcVSaDk; dkim-atps=neutral Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DQ2l10cxTzDqyb for ; Tue, 26 Jan 2021 21:18:51 +1100 (AEDT) Received: by mail-pg1-x529.google.com with SMTP id n25so11217000pgb.0 for ; Tue, 26 Jan 2021 02:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=bY0+m4945nWumwbU1TQ36SLdrna7sXMlUaFEMn9azHM=; b=otcVSaDkyuN1IFfRVEUqE8c2bayHgbWl4fMLIM9/NfgujwypOXpNCcVfJqbv3XPmZ3 m3T5caX+X2PFVmGS2PuAM3DSxmuqsEC/qtdlFRNyvNLgA2erWkj02+d+0ZXfH7NVvlXC vqRzjdUDLgbJtG4ELaHWDai/2D7gTuh3zm1QMuO71egNZ4GSOIWdHOcUpN6/oFiPSJMF A+60AwwtKXpNmPyHLosablQqAjRgC2NEXvZdVafBbW1JrK1peRmOMIj4xDbwwbTrEpz2 w1GPLMXda9qvRv6Ra5qKFx5sNXiTBCmfFdzV36XhdCsAPC+RV/6TVAJqsyJCq9+mmAvj cawQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=bY0+m4945nWumwbU1TQ36SLdrna7sXMlUaFEMn9azHM=; b=WF/wWVSxy3xhOzKVZwmAzuI4oprFcG3BzVecSzjgq+3dcGpIE0W9Wg3WXwdW1Xd8+j s42/zS9Fjv7DDV/mgP3EpJ47w0dwv/OCKbGnPWxGaDOF+2N6cBBvPSWjx65oJ1vT6BvP 1npV1KBxhRtgNGX1sh1kZG7k5UqePanOtczBiIxQ1s3b6qS9XgVAUoV9CVxTSFY+Jtj2 yjNYSXnixifw+hstS22GAwJR2DuRrA+YANgV6ROBfcz03TzVFYbTyH8M0BoU72MxMGCn irN0Gb530oUhom0KdZfPuMQ2mLkwe7ogK9vLbCmv8CJUwaa9PKBZ0at+dO/XXObqGb/o JBYQ== X-Gm-Message-State: AOAM532JAUZybYW6BwZiX5xuij+AoBGKFQOP5wf3+uOdbIDSe4ZFZmSA 0vBxlyLxjpiZ7V6bOFIQUGk= X-Google-Smtp-Source: ABdhPJxaG61OapcH+qCGgTpLGcWf8cvXcfM4YrAfMSY5mvjCygYR8PMQZXdWfG/BQof6ssxK0ITAqw== X-Received: by 2002:a62:144c:0:b029:1c0:d62d:e16e with SMTP id 73-20020a62144c0000b02901c0d62de16emr4542328pfu.25.1611656328201; Tue, 26 Jan 2021 02:18:48 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id 77sm13765743pfz.100.2021.01.26.02.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 02:18:47 -0800 (PST) Date: Tue, 26 Jan 2021 20:18:42 +1000 From: Nicholas Piggin Subject: Re: [PATCH v4 14/23] powerpc/syscall: Save r3 in regs->orig_r3 To: Benjamin Herrenschmidt , Christophe Leroy , Michael Ellerman , msuchanek@suse.de, Paul Mackerras References: <5d375bea8f519924e110842f6b0d05e83cd04470.1611585031.git.christophe.leroy@csgroup.eu> In-Reply-To: <5d375bea8f519924e110842f6b0d05e83cd04470.1611585031.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Message-Id: <1611656262.d3l09kg9o2.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: > Save r3 in regs->orig_r3 in system_call_exception() >=20 > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/entry_64.S | 1 - > arch/powerpc/kernel/syscall.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_6= 4.S > index aa1af139d947..a562a4240aa6 100644 > --- a/arch/powerpc/kernel/entry_64.S > +++ b/arch/powerpc/kernel/entry_64.S > @@ -278,7 +278,6 @@ END_BTB_FLUSH_SECTION > std r10,_LINK(r1) > std r11,_TRAP(r1) > std r12,_CCR(r1) > - std r3,ORIG_GPR3(r1) > addi r10,r1,STACK_FRAME_OVERHEAD > ld r11,exception_marker@toc(r2) > std r11,-16(r10) /* "regshere" marker */ This misses system_call_vectored. Thanks, Nick > diff --git a/arch/powerpc/kernel/syscall.c b/arch/powerpc/kernel/syscall.= c > index cb415170b8f2..b66cfcbcb755 100644 > --- a/arch/powerpc/kernel/syscall.c > +++ b/arch/powerpc/kernel/syscall.c > @@ -29,6 +29,8 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > { > syscall_fn f; > =20 > + regs->orig_gpr3 =3D r3; > + > if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG)) > BUG_ON(irq_soft_mask_return() !=3D IRQS_ALL_DISABLED); > =20 > --=20 > 2.25.0 >=20 >=20