From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DF0C433E0 for ; Tue, 26 Jan 2021 15:35:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91FCB22D04 for ; Tue, 26 Jan 2021 15:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91FCB22D04 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E87089D9A; Tue, 26 Jan 2021 15:35:57 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id E59BC89D9A for ; Tue, 26 Jan 2021 15:35:55 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 23705180-1500050 for multiple; Tue, 26 Jan 2021 15:35:49 +0000 MIME-Version: 1.0 In-Reply-To: <20210126151259.253885-4-matthew.auld@intel.com> References: <20210126151259.253885-1-matthew.auld@intel.com> <20210126151259.253885-4-matthew.auld@intel.com> From: Chris Wilson To: Matthew Auld , intel-gfx@lists.freedesktop.org Date: Tue, 26 Jan 2021 15:35:51 +0000 Message-ID: <161167535110.2943.16119545695449363866@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: introduce mem->reserved X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abdiel Janulgue Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Matthew Auld (2021-01-26 15:12:55) > From: Abdiel Janulgue > > In the following patch we need to reserve regions unaccessible to the > driver during initialization, so add mem->reserved for collecting such > regions. > > Cc: Imre Deak > Signed-off-by: Abdiel Janulgue > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/intel_memory_region.c | 2 + > drivers/gpu/drm/i915/intel_memory_region.h | 2 + > .../drm/i915/selftests/intel_memory_region.c | 89 +++++++++++++++++++ > 3 files changed, 93 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c > index b1b610bfff09..803a414c9523 100644 > --- a/drivers/gpu/drm/i915/intel_memory_region.c > +++ b/drivers/gpu/drm/i915/intel_memory_region.c > @@ -156,6 +156,7 @@ int intel_memory_region_init_buddy(struct intel_memory_region *mem) > > void intel_memory_region_release_buddy(struct intel_memory_region *mem) > { > + i915_buddy_free_list(&mem->mm, &mem->reserved); > i915_buddy_fini(&mem->mm); > } > > @@ -185,6 +186,7 @@ intel_memory_region_create(struct drm_i915_private *i915, > mutex_init(&mem->objects.lock); > INIT_LIST_HEAD(&mem->objects.list); > INIT_LIST_HEAD(&mem->objects.purgeable); > + INIT_LIST_HEAD(&mem->reserved); > > mutex_init(&mem->mm_lock); > > diff --git a/drivers/gpu/drm/i915/intel_memory_region.h b/drivers/gpu/drm/i915/intel_memory_region.h > index 6ffc0673f005..8c9947bba3e8 100644 > --- a/drivers/gpu/drm/i915/intel_memory_region.h > +++ b/drivers/gpu/drm/i915/intel_memory_region.h > @@ -89,6 +89,8 @@ struct intel_memory_region { > unsigned int id; > char name[8]; > > + struct list_head reserved; So you added this, but this is not exercised by the selftest either. I think you want to complete the API with intel_memory_region_reserve(mem, start, size/end) And then inspect the mem->reserved rather than the local list. Presumably check the mem->reserved is empty on entry, and then it's safe to call i915_buddy_free_list(&mem->mm, &mem->reserved) directly. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx