All of lore.kernel.org
 help / color / mirror / Atom feed
From: <stefanc@marvell.com>
To: <netdev@vger.kernel.org>
Cc: <thomas.petazzoni@bootlin.com>, <davem@davemloft.net>,
	<nadavh@marvell.com>, <ymarkman@marvell.com>,
	<linux-kernel@vger.kernel.org>, <stefanc@marvell.com>,
	<kuba@kernel.org>, <linux@armlinux.org.uk>, <mw@semihalf.com>,
	<andrew@lunn.ch>, <rmk+kernel@armlinux.org.uk>,
	<atenart@kernel.org>
Subject: [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check
Date: Wed, 27 Jan 2021 13:43:35 +0200	[thread overview]
Message-ID: <1611747815-1934-20-git-send-email-stefanc@marvell.com> (raw)
In-Reply-To: <1611747815-1934-1-git-send-email-stefanc@marvell.com>

From: Stefan Chulski <stefanc@marvell.com>

Patch check that TX FC firmware is running in CM3.
If not, global TX FC would be disabled.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2.h      |  1 +
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 41 ++++++++++++++++----
 2 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
index 0765d6f..47a4b38 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
@@ -829,6 +829,7 @@
 
 #define MSS_THRESHOLD_STOP	768
 #define MSS_THRESHOLD_START	1024
+#define MSS_FC_MAX_TIMEOUT	5000
 
 /* RX buffer constants */
 #define MVPP2_SKB_SHINFO_SIZE \
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index bb7dfed..3aa877b 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -932,6 +932,34 @@ static void mvpp2_bm_pool_update_fc(struct mvpp2_port *port,
 	spin_unlock_irqrestore(&port->priv->mss_spinlock, flags);
 }
 
+static int mvpp2_enable_global_fc(struct mvpp2 *priv)
+{
+	int val, timeout = 0;
+
+	/* Enable global flow control. In this stage global
+	 * flow control enabled, but still disabled per port.
+	 */
+	val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
+	val |= FLOW_CONTROL_ENABLE_BIT;
+	mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
+
+	/* Check if Firmware running and disable FC if not*/
+	val |= FLOW_CONTROL_UPDATE_COMMAND_BIT;
+	mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
+
+	while (timeout < MSS_FC_MAX_TIMEOUT) {
+		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
+
+		if (!(val & FLOW_CONTROL_UPDATE_COMMAND_BIT))
+			return 0;
+		usleep_range(10, 20);
+		timeout++;
+	}
+
+	priv->global_tx_fc = false;
+	return -EOPNOTSUPP;
+}
+
 /* Release buffer to BM */
 static inline void mvpp2_bm_pool_put(struct mvpp2_port *port, int pool,
 				     dma_addr_t buf_dma_addr,
@@ -7283,7 +7311,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 	struct resource *res;
 	void __iomem *base;
 	int i, shared;
-	int err, val;
+	int err;
 
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -7511,13 +7539,12 @@ static int mvpp2_probe(struct platform_device *pdev)
 		goto err_port_probe;
 	}
 
-	/* Enable global flow control. In this stage global
-	 * flow control enabled, but still disabled per port.
-	 */
 	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
-		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
-		val |= FLOW_CONTROL_ENABLE_BIT;
-		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
+		err = mvpp2_enable_global_fc(priv);
+		if (err) {
+			dev_warn(&pdev->dev, "CM3 firmware not running, version should be higher than 18.09\n");
+			dev_warn(&pdev->dev, "Flow control not supported\n");
+		}
 	}
 
 	mvpp2_dbgfs_init(priv, pdev->name);
-- 
1.9.1


  parent reply	other threads:[~2021-01-27 11:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 11:43 [PATCH v4 net-next 00/19] net: mvpp2: Add TX Flow Control support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 01/19] doc: marvell: add cm3-mem device tree bindings description stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 02/19] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 03/19] net: mvpp2: add CM3 SRAM memory map stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 04/19] doc: marvell: add PPv2.3 description to marvell-pp2.txt stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 05/19] net: mvpp2: add PPv23 version definition stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 06/19] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 07/19] net: mvpp2: increase BM pool size to 2048 buffers stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 08/19] net: mvpp2: increase RXQ size to 1024 descriptors stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 09/19] net: mvpp2: add FCA periodic timer configurations stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 10/19] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-01-27 17:36   ` Willem de Bruijn
2021-01-27 18:41     ` [EXT] " Stefan Chulski
2021-01-28 16:40       ` Russell King - ARM Linux admin
2021-01-27 11:43 ` [PATCH v4 net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path stefanc
2021-01-27 17:39   ` Willem de Bruijn
2021-01-27 18:27     ` [EXT] " Stefan Chulski
2021-01-27 11:43 ` [PATCH v4 net-next 12/19] net: mvpp2: enable global flow control stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 13/19] net: mvpp2: add RXQ flow control configurations stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 14/19] net: mvpp2: add ethtool flow control configuration support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 15/19] net: mvpp2: add BM protection underrun feature support stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 16/19] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 17/19] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-01-27 11:43 ` [PATCH v4 net-next 18/19] net: mvpp2: limit minimum ring size to 1024 descriptors stefanc
2021-01-27 11:43 ` stefanc [this message]
2021-01-27 14:05   ` [PATCH v4 net-next 19/19] net: mvpp2: add TX FC firmware check Russell King - ARM Linux admin
2021-01-27 14:37     ` [EXT] " Stefan Chulski
2021-01-27 14:59       ` Russell King - ARM Linux admin
2021-01-27 15:10         ` Stefan Chulski
2021-01-27 15:13           ` Russell King - ARM Linux admin
2021-01-27 15:23             ` Stefan Chulski
2021-01-27 17:55 ` [PATCH v4 net-next 00/19] net: mvpp2: Add TX Flow Control support Willem de Bruijn
2021-01-28 16:43 ` Russell King - ARM Linux admin
2021-01-28 16:47   ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611747815-1934-20-git-send-email-stefanc@marvell.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.