All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keith A. Milner" <maillist@superlative.org>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: fix automatic Roland/Yamaha MIDI detection
Date: Fri, 16 Aug 2013 13:06:03 +0100	[thread overview]
Message-ID: <1611840.QS8IH2v0gO@kamdesktop> (raw)
In-Reply-To: <1662775.3qSRSFOsFp@kamdesktop>

On Monday 12 Aug 2013 23:38:22 Keith A. Milner wrote:
> On Sunday 11 Aug 2013 14:13:13 Clemens Ladisch wrote:
> > Commit aafe77cc45a5 (ALSA: usb-audio: add support for many Roland/Yamaha
> > devices) had several logic errors that prevented create_auto_midi_quirk
> > from enumerating any MIDI ports.
> > 
> > Reported-by: Keith A. Milner <maillist@superlative.org>
> > Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
> > ---
> 
> I tested this with the BR-80. Logfile at the end.
> 

<SNIP>

> I do wonder whether a quirk is still needed for this device. It seems to be
> reporting as a 32-bit interface when it's actually only 16-bit, and I
> suspect this might be upsetting things.

With this in mind, I with a kernel where I had inserted the original BR-80 
quirk back into quirks-table.h.

This still didn't work, so there seems to be some other problem, unrelated to 
this patch.

Cheers,

Keith

  parent reply	other threads:[~2013-08-16 12:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 20:16 [git pull] [PATCH 0/7] add support for many Roland and Yamaha devices Clemens Ladisch
2013-06-27 20:18 ` [PATCH 1/7] ALSA: usb-audio: store protocol version in struct audioformat Clemens Ladisch
2013-07-09 18:34   ` Eldad Zack
2013-06-27 20:18 ` [PATCH 2/7] ALSA: usb-audio: detect implicit feedback on Roland devices Clemens Ladisch
2013-06-27 20:19 ` [PATCH 3/7] ALSA: usb-audio: add support for many Roland/Yamaha devices Clemens Ladisch
2013-06-27 20:19 ` [PATCH 4/7] ALSA: usb-audio: add MIDI port names for some Roland devices Clemens Ladisch
2013-06-27 20:19 ` [PATCH 5/7] ALSA: usb-audio: remove superfluous Roland quirks Clemens Ladisch
2013-06-27 20:20 ` [PATCH 6/7] ALSA: usb-audio: claim autodetected PCM interfaces all at once Clemens Ladisch
2013-06-27 20:20 ` [PATCH 7/7] ALSA: usb-audio: add quirks for Roland QUAD/OCTO-CAPTURE Clemens Ladisch
2013-06-28 10:17 ` [git pull] [PATCH 0/7] add support for many Roland and Yamaha devices Takashi Iwai
2013-08-09 10:52 ` Keith A. Milner
2013-08-09 13:17   ` Clemens Ladisch
2013-08-09 15:02     ` Keith A. Milner
2013-08-09 18:18       ` Clemens Ladisch
2013-08-10 12:35         ` Keith A. Milner
2013-08-11  0:10         ` Keith A. Milner
2013-08-11 12:13           ` [PATCH] ALSA: usb-audio: fix automatic Roland/Yamaha MIDI detection Clemens Ladisch
2013-08-12  9:41             ` Takashi Iwai
2013-08-12 22:00             ` Keith A. Milner
2013-08-12 22:38             ` Keith A. Milner
2013-08-12 22:42               ` Keith A. Milner
2013-08-16 12:06               ` Keith A. Milner [this message]
2013-08-11 12:15           ` [git pull] [PATCH 0/7] add support for many Roland and Yamaha devices Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611840.QS8IH2v0gO@kamdesktop \
    --to=maillist@superlative.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.